ember-cli 5.3.0 → 5.4.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # ember-cli Changelog
 
+## v5.4.0
+
+#### Blueprint Changes
+
+- [`ember new` diff](https://github.com/ember-cli/ember-new-output/compare/v5.3.0...v5.4.0)
+- [`ember addon` diff](https://github.com/ember-cli/ember-addon-output/compare/v5.3.0...v5.4.0)
+
+#### Changelog
+
+- [#10388](https://github.com/ember-cli/ember-cli/pull/10388) [CLEANUP] Drop support for Node v16 [@Shishouille](https://github.com/Shishouille)
+- [#10345](https://github.com/ember-cli/ember-cli/pull/10345) [BUGFIX beta] App blueprint may not have explicit-any in ember-data types [@NullVoxPopuli](https://github.com/NullVoxPopuli)
+- [#10351](https://github.com/ember-cli/ember-cli/pull/10351) [ENHANCEMENT] Remove `ember-lts-4.4` scenario from `addon` blueprint [@bertdeblock](https://github.com/bertdeblock)
+- [#10352](https://github.com/ember-cli/ember-cli/pull/10352) [ENHANCEMENT] Add official support for Node.js v20 [@bertdeblock](https://github.com/bertdeblock)
+- [#10353](https://github.com/ember-cli/ember-cli/pull/10353) [ENHANCEMENT] Remove all telemetry [@bertdeblock](https://github.com/bertdeblock)
+- [#10354](https://github.com/ember-cli/ember-cli/pull/10354) [INTERNAL] Remove `@babel/core` as a dependency [@bertdeblock](https://github.com/bertdeblock)
+- [#10368](https://github.com/ember-cli/ember-cli/pull/10368) [ENHANCEMENT] Streamline package-manager CLI options [@bertdeblock](https://github.com/bertdeblock)
+
+Thank you to all who took the time to contribute!
+
 ## v5.3.0
 
 #### Blueprint Changes

package/RELEASE.md

@@ -173,3 +173,49 @@ git checkout master
 git merge origin/beta
 git push origin master
 ```
+
+## Post-release Automation
+
+There is a GitHub Actions workflow, https://github.com/ember-cli/ember-cli/actions/workflows/sync-output-repos.yml that pushes various invocations of the blueprint generator to "output repos".
+After release, make sure that all the jobs are "green" / succeeded.
+
+<details><summary>What to check afterwards</summary>
+
+- Apps: https://github.com/ember-cli/ember-app-output
+- Addons: https://github.com/ember-cli/ember-addon-output
+
+Both of these have a git-tag per release version
+
+### Online Editors
+
+Multiple editors could be supported, but right now, we only "customize" for stackblitz.
+
+https://github.com/ember-cli/editor-output/
+- [a branch for each scenario + release version](https://github.com/ember-cli/editor-output/branches/active)
+  - `${editorName}-{addon,app}-output{-'typescript'?}{-version}`
+  - and the "latest release" (non beta) will not have a version at the end
+  - This includes [app, addon] X [javascript, typescript]
+
+#### StackBlitz
+
+To make sure StackBlitz runs in their supported browsers (Chrome and FireFox, as of 2023-08-15)
+
+- App + JS: https://stackblitz.com/github/ember-cli/editor-output/tree/stackblitz-app-output
+- App + TS: https://stackblitz.com/github/ember-cli/editor-output/tree/stackblitz-app-output-typescript
+- Addon + JS: https://stackblitz.com/github/ember-cli/editor-output/tree/stackblitz-addon-output
+- Addon + TS: https://stackblitz.com/github/ember-cli/editor-output/tree/stackblitz-addon-output-typescript
+
+The App + JS, and App + TS are linked from Stackblitz's frontend templates UI: https://stackblitz.com/?starters=frontend
+
+</details>
+
+<details><summary>if problems arise</summary>
+
+Script for updating addon/app repos: https://github.com/ember-cli/ember-cli/blob/master/dev/update-output-repos.js
+Script for updating editors: https://github.com/ember-cli/ember-cli/blob/master/dev/update-editor-output-repos.js
+
+Customizations on top of the default blueprint(s) are found here: https://github.com/ember-cli/ember-cli/tree/master/dev/online-editors/stackblitz
+The intent for these customizations is to either be very light, or not needed at all.
+If an online editor breaks with our default blueprint, then it's most likely that _we_ have a bug (or something _very goofy_).
+
+</details>

package/blueprints/addon/additional-package.json

@@ -6,7 +6,7 @@
     "test:ember-compatibility": "ember try:each"
   },
   "devDependencies": {
-    "@embroider/test-setup": "^3.0.1",
+    "@embroider/test-setup": "^3.0.2",
     "ember-source-channel-url": "^3.0.0",
     "ember-try": "^3.0.0"
   },

package/blueprints/addon/files/.github/workflows/ci.yml

@@ -21,11 +21,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16<% } else { %>
+          node-version: 18<% } else { %>
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
@@ -43,11 +43,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16
+          node-version: 18
           no-lockfile: true<% } else { %>
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --no-lockfile' : 'npm install --no-shrinkwrap' %><% } %>
@@ -64,7 +64,6 @@ jobs:
       fail-fast: false
       matrix:
         try-scenario:
-          - ember-lts-4.4
           - ember-lts-4.8
           - ember-lts-4.12
           - ember-release
@@ -77,11 +76,11 @@ jobs:
       - uses: actions/checkout@v3<% if (pnpm) { %>
       - uses: wyvox/action-setup-pnpm@v2
         with:
-          node-version: 16<% } else { %>
+          node-version: 18<% } else { %>
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>

package/blueprints/addon/files/.travis.yml

@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "16"
+  - "18"
 
 dist: xenial
 
@@ -51,7 +51,6 @@ jobs:
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - env: EMBER_TRY_SCENARIO=ember-lts-4.4
     - env: EMBER_TRY_SCENARIO=ember-lts-4.8
     - env: EMBER_TRY_SCENARIO=ember-lts-4.12
     - env: EMBER_TRY_SCENARIO=ember-release

package/blueprints/addon/files/README.md

@@ -5,9 +5,9 @@
 
 ## Compatibility
 
-* Ember.js v4.4 or above
-* Ember CLI v4.4 or above
-* Node.js v16 or above
+* Ember.js v4.8 or above
+* Ember CLI v4.8 or above
+* Node.js v18 or above
 
 
 ## Installation

package/blueprints/addon/files/addon-config/ember-try.js

@@ -8,14 +8,6 @@ module.exports = async function () {
     <% if (pnpm) { %>usePnpm: true,
     <% } else if (yarn) { %>useYarn: true,
     <% } %>scenarios: [
-      {
-        name: 'ember-lts-4.4',
-        npm: {
-          devDependencies: {
-            'ember-source': '~4.4.0',
-          },
-        },
-      },
       {
         name: 'ember-lts-4.8',
         npm: {

package/blueprints/addon/index.js

@@ -151,7 +151,7 @@ module.exports = {
     let addonName = stringUtil.dasherize(addonRawName);
     let addonNamespace = stringUtil.classify(addonRawName);
 
-    let hasOptions = options.welcome || options.yarn || options.pnpm || options.ciProvider;
+    let hasOptions = options.welcome || options.packageManager || options.ciProvider;
     let blueprintOptions = '';
     if (hasOptions) {
       let indent = `\n            `;
@@ -161,8 +161,8 @@ module.exports = {
         indent +
         [
           options.welcome && '"--welcome"',
-          options.yarn && '"--yarn"',
-          options.pnpm && '"--pnpm"',
+          options.packageManager === 'yarn' && '"--yarn"',
+          options.packageManager === 'pnpm' && '"--pnpm"',
           options.ciProvider && `"--ci-provider=${options.ciProvider}"`,
           options.typescript && `"--typescript"`,
         ]
@@ -180,8 +180,8 @@ module.exports = {
       addonNamespace,
       emberCLIVersion: require('../../package').version,
       year: date.getFullYear(),
-      yarn: options.yarn,
-      pnpm: options.pnpm,
+      yarn: options.packageManager === 'yarn',
+      pnpm: options.packageManager === 'pnpm',
       welcome: options.welcome,
       blueprint: 'addon',
       blueprintOptions,
@@ -201,7 +201,7 @@ module.exports = {
 
     let addonFiles = walkSync(addonFilesPath, { ignore: [ignoredCITemplate] });
 
-    if (!options.pnpm) {
+    if (options.packageManager !== 'pnpm') {
       addonFiles = addonFiles.filter((file) => !file.endsWith('.npmrc'));
     }
 

package/blueprints/app/files/.ember-cli

@@ -1,12 +1,4 @@
 {
-  /**
-    Ember CLI sends analytics information by default. The data is completely
-    anonymous, but there are times when you might want to disable this behavior.
-
-    Setting `disableAnalytics` to true will prevent any data from being sent.
-  */
-  "disableAnalytics": false,
-
   /**
     Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
     rather than JavaScript by default, when a TypeScript version of a given blueprint is available.

package/blueprints/app/files/.github/workflows/ci.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>
@@ -41,7 +41,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: <%= yarn ? 'yarn' : 'npm' %>
       - name: Install Dependencies
         run: <%= yarn ? 'yarn install --frozen-lockfile' : 'npm ci' %><% } %>

package/blueprints/app/files/.travis.yml

@@ -1,7 +1,7 @@
 ---
 language: node_js
 node_js:
-  - "16"
+  - "18"
 
 dist: xenial
 

package/blueprints/app/files/package.json

@@ -26,56 +26,56 @@
     "test:ember": "ember test"
   },
   "devDependencies": {
-    "@babel/core": "^7.22.20",
+    "@babel/core": "^7.23.2",
     "<% if (!typescript) { %>@babel/eslint-parser": "^7.22.15",
-    "@babel/plugin-proposal-decorators": "^7.22.15",
+    "@babel/plugin-proposal-decorators": "^7.23.2",
     "<% } %>@ember/optional-features": "^2.0.0",
     "@ember/string": "^3.1.1",
     "@ember/test-helpers": "^3.2.0<% if (embroider) { %>",
-    "@embroider/compat": "^3.2.1",
-    "@embroider/core": "^3.2.1",
-    "@embroider/webpack": "^3.1.5<% } %>",
+    "@embroider/compat": "^3.2.3",
+    "@embroider/core": "^3.3.0",
+    "@embroider/webpack": "^3.2.0<% } %>",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2<% if (typescript) { %>",
-    "@glint/environment-ember-loose": "^1.1.0",
-    "@glint/template": "^1.1.0",
-    "@tsconfig/ember": "^3.0.1",
-    "@types/ember": "^4.0.4",
-    "@types/ember-data": "^4.4.11",
-    "@types/ember-data__adapter": "^4.0.2",
-    "@types/ember-data__model": "^4.0.1",
-    "@types/ember-data__serializer": "^4.0.2",
-    "@types/ember-data__store": "^4.0.3",
-    "@types/ember__application": "^4.0.7",
-    "@types/ember__array": "^4.0.5",
-    "@types/ember__component": "^4.0.16",
-    "@types/ember__controller": "^4.0.6",
-    "@types/ember__debug": "^4.0.4",
-    "@types/ember__destroyable": "^4.0.2",
-    "@types/ember__engine": "^4.0.6",
-    "@types/ember__error": "^4.0.3",
-    "@types/ember__helper": "^4.0.2",
-    "@types/ember__modifier": "^4.0.5",
-    "@types/ember__object": "^4.0.7",
-    "@types/ember__owner": "^4.0.5",
-    "@types/ember__polyfills": "^4.0.2",
-    "@types/ember__routing": "^4.0.14",
-    "@types/ember__runloop": "^4.0.5",
-    "@types/ember__service": "^4.0.3",
-    "@types/ember__string": "^3.0.11",
-    "@types/ember__template": "^4.0.2",
-    "@types/ember__test": "^4.0.2",
-    "@types/ember__utils": "^4.0.3",
-    "@types/qunit": "^2.19.6",
-    "@types/rsvp": "^4.0.4",
-    "@typescript-eslint/eslint-plugin": "^6.7.2",
-    "@typescript-eslint/parser": "^6.7.2<% } %>",
+    "@glint/environment-ember-loose": "^1.2.1",
+    "@glint/template": "^1.2.1",
+    "@tsconfig/ember": "^3.0.2",
+    "@types/ember": "^4.0.8",
+    "@types/ember-data": "^4.4.13",
+    "@types/ember-data__adapter": "^4.0.4",
+    "@types/ember-data__model": "^4.0.3",
+    "@types/ember-data__serializer": "^4.0.4",
+    "@types/ember-data__store": "^4.0.5",
+    "@types/ember__application": "^4.0.9",
+    "@types/ember__array": "^4.0.7",
+    "@types/ember__component": "^4.0.19",
+    "@types/ember__controller": "^4.0.9",
+    "@types/ember__debug": "^4.0.6",
+    "@types/ember__destroyable": "^4.0.3",
+    "@types/ember__engine": "^4.0.8",
+    "@types/ember__error": "^4.0.4",
+    "@types/ember__helper": "^4.0.4",
+    "@types/ember__modifier": "^4.0.7",
+    "@types/ember__object": "^4.0.9",
+    "@types/ember__owner": "^4.0.7",
+    "@types/ember__polyfills": "^4.0.4",
+    "@types/ember__routing": "^4.0.17",
+    "@types/ember__runloop": "^4.0.7",
+    "@types/ember__service": "^4.0.6",
+    "@types/ember__string": "^3.16.3",
+    "@types/ember__template": "^4.0.4",
+    "@types/ember__test": "^4.0.4",
+    "@types/ember__utils": "^4.0.5",
+    "@types/qunit": "^2.19.7",
+    "@types/rsvp": "^4.0.6",
+    "@typescript-eslint/eslint-plugin": "^6.9.1",
+    "@typescript-eslint/parser": "^6.9.1<% } %>",
     "broccoli-asset-rev": "^3.0.0",
-    "concurrently": "^8.2.1",
+    "concurrently": "^8.2.2",
     "ember-auto-import": "^2.6.3",
     "ember-cli": "~<%= emberCLIVersion %>",
     "ember-cli-app-version": "^6.0.1",
-    "ember-cli-babel": "^8.0.0",
+    "ember-cli-babel": "^8.2.0",
     "ember-cli-clean-css": "^3.0.0",
     "ember-cli-dependency-checker": "^3.3.2",
     "ember-cli-htmlbars": "^6.3.0",
@@ -89,28 +89,28 @@
     "ember-page-title": "^8.0.0",
     "ember-qunit": "^8.0.1",
     "ember-resolver": "^11.0.1",
-    "ember-source": "~5.3.0",
+    "ember-source": "~5.4.0",
     "ember-template-lint": "^5.11.2<% if (welcome) { %>",
     "ember-welcome-page": "^7.0.2<% } %>",
-    "eslint": "^8.49.0",
+    "eslint": "^8.52.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-ember": "^11.11.1",
-    "eslint-plugin-n": "^16.1.0",
-    "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-qunit": "^8.0.0",
+    "eslint-plugin-n": "^16.2.0",
+    "eslint-plugin-prettier": "^5.0.1",
+    "eslint-plugin-qunit": "^8.0.1",
     "loader.js": "^4.7.0",
     "prettier": "^3.0.3",
-    "qunit": "^2.19.4",
+    "qunit": "^2.20.0",
     "qunit-dom": "^2.0.0",
-    "stylelint": "^15.10.3",
+    "stylelint": "^15.11.0",
     "stylelint-config-standard": "^34.0.0",
     "stylelint-prettier": "^4.0.2",
-    "tracked-built-ins": "^3.2.0<% if (typescript) { %>",
+    "tracked-built-ins": "^3.3.0<% if (typescript) { %>",
     "typescript": "^5.2.2<% } %>",
-    "webpack": "^5.88.2"
+    "webpack": "^5.89.0"
   },
   "engines": {
-    "node": "16.* || >= 18"
+    "node": ">= 18"
   },
   "ember": {
     "edition": "octane"

package/blueprints/app/index.js

@@ -26,7 +26,7 @@ module.exports = {
     let namespace = stringUtil.classify(rawName);
     let embroider = isExperimentEnabled('EMBROIDER') || options.embroider;
 
-    let hasOptions = !options.welcome || options.yarn || options.pnpm || embroider || options.ciProvider;
+    let hasOptions = !options.welcome || options.packageManager || embroider || options.ciProvider;
     let blueprintOptions = '';
     if (hasOptions) {
       let indent = `\n            `;
@@ -36,8 +36,8 @@ module.exports = {
         indent +
         [
           !options.welcome && '"--no-welcome"',
-          options.yarn && '"--yarn"',
-          options.pnpm && '"--pnpm"',
+          options.packageManager === 'yarn' && '"--yarn"',
+          options.packageManager === 'pnpm' && '"--pnpm"',
           embroider && '"--embroider"',
           options.ciProvider && `"--ci-provider=${options.ciProvider}"`,
           options.typescript && `"--typescript"`,
@@ -53,8 +53,8 @@ module.exports = {
       modulePrefix: name,
       namespace,
       emberCLIVersion: require('../../package').version,
-      yarn: options.yarn,
-      pnpm: options.pnpm,
+      yarn: options.packageManager === 'yarn',
+      pnpm: options.packageManager === 'pnpm',
       welcome: options.welcome,
       blueprint: 'app',
       blueprintOptions,

package/blueprints/http-mock/index.js

@@ -17,7 +17,6 @@ module.exports = {
   beforeInstall(options) {
     let serverBlueprint = Blueprint.lookup('server', {
       ui: this.ui,
-      analytics: this.analytics,
       project: this.project,
     });
 

package/blueprints/http-proxy/index.js

@@ -18,7 +18,6 @@ module.exports = {
   beforeInstall(options) {
     let serverBlueprint = Blueprint.lookup('server', {
       ui: this.ui,
-      analytics: this.analytics,
       project: this.project,
     });