ember-cli 4.12.0 → 4.13.0-beta.0

package/lib/cli/cli.js

@@ -175,15 +175,6 @@ class CLI {
 
       logger.info('command: %s', commandName);
 
-      if (!this.testing) {
-        process.chdir(environment.project.root);
-        let skipInstallationCheck = commandArgs.indexOf('--skip-installation-check') !== -1;
-        if (environment.project.isEmberCLIProject() && !skipInstallationCheck) {
-          const InstallationChecker = require('../models/installation-checker');
-          new InstallationChecker({ project: environment.project }).checkInstallations();
-        }
-      }
-
       let instrumentation = this.instrumentation;
       let onCommandInterrupt;
 

package/lib/commands/addon.js

@@ -12,7 +12,6 @@ module.exports = NewCommand.extend({
     { name: 'verbose', type: Boolean, default: false, aliases: ['v'] },
     { name: 'blueprint', type: String, default: 'addon', aliases: ['b'] },
     { name: 'skip-npm', type: Boolean, default: false, aliases: ['sn'] },
-    { name: 'skip-bower', type: Boolean, default: false, aliases: ['sb'] },
     { name: 'skip-git', type: Boolean, default: false, aliases: ['sg'] },
     { name: 'yarn', type: Boolean }, // no default means use yarn if the blueprint has a yarn.lock
     { name: 'directory', type: String, aliases: ['dir'] },

package/lib/commands/init.js

@@ -20,7 +20,6 @@ module.exports = Command.extend({
     { name: 'verbose', type: Boolean, default: false, aliases: ['v'] },
     { name: 'blueprint', type: String, aliases: ['b'] },
     { name: 'skip-npm', type: Boolean, default: false, aliases: ['sn'] },
-    { name: 'skip-bower', type: Boolean, default: false, aliases: ['sb'] },
     { name: 'lint-fix', type: Boolean, default: true },
     {
       name: 'welcome',
@@ -60,7 +59,6 @@ module.exports = Command.extend({
   async run(commandOptions, rawArgs) {
     if (commandOptions.dryRun) {
       commandOptions.skipNpm = true;
-      commandOptions.skipBower = true;
     }
 
     let project = this.project;
@@ -115,12 +113,6 @@ module.exports = Command.extend({
       });
     }
 
-    if (!commandOptions.skipBower) {
-      await this.runTask('BowerInstall', {
-        verbose: commandOptions.verbose,
-      });
-    }
-
     if (commandOptions.skipGit === false) {
       await this.runTask('GitInit', commandOptions, rawArgs);
     }

package/lib/commands/install.js

@@ -29,8 +29,8 @@ module.exports = Command.extend({
   run(commandOptions, addonNames) {
     if (!addonNames.length) {
       let msg = 'The `install` command must take an argument with the name';
-      msg += ' of an ember-cli addon. For installing all npm and bower ';
-      msg += 'dependencies you can run `npm install && bower install`.';
+      msg += ' of an ember-cli addon. For installing all npm ';
+      msg += 'dependencies you can run `npm install`.';
       return Promise.reject(new SilentError(msg));
     }
 

package/lib/commands/new.js

@@ -18,7 +18,6 @@ module.exports = Command.extend({
     { name: 'verbose', type: Boolean, default: false, aliases: ['v'] },
     { name: 'blueprint', type: String, default: 'app', aliases: ['b'] },
     { name: 'skip-npm', type: Boolean, default: false, aliases: ['sn'] },
-    { name: 'skip-bower', type: Boolean, default: false, aliases: ['sb'] },
     { name: 'skip-git', type: Boolean, default: false, aliases: ['sg'] },
     {
       name: 'welcome',

package/lib/commands/serve.js

@@ -58,7 +58,7 @@ module.exports = Command.extend({
     { name: 'watcher', type: String, default: 'events', aliases: ['w'] },
     { name: 'live-reload', type: Boolean, default: true, aliases: ['lr'] },
     { name: 'live-reload-host', type: String, aliases: ['lrh'], description: 'Defaults to host' },
-    { name: 'live-reload-base-url', type: String, aliases: ['lrbu'], description: 'Defaults to baseURL' },
+    { name: 'live-reload-base-url', type: String, aliases: ['lrbu'], description: 'Defaults to rootURL' },
     { name: 'live-reload-port', type: Number, aliases: ['lrp'], description: 'Defaults to same port as ember app' },
     { name: 'live-reload-prefix', type: String, default: '_lr', aliases: ['lrprefix'], description: 'Default to _lr' },
     {

package/lib/experiments/index.js

@@ -1,9 +1,9 @@
 'use strict';
 
 const chalk = require('chalk');
-const availableExperiments = Object.freeze(['PACKAGER', 'EMBROIDER', 'CLASSIC']);
+const availableExperiments = Object.freeze(['EMBROIDER', 'CLASSIC']);
 
-const deprecatedExperiments = Object.freeze(['PACKAGER']);
+const deprecatedExperiments = Object.freeze([]);
 const enabledExperiments = Object.freeze([]);
 const deprecatedExperimentsDeprecationsIssued = [];
 

package/lib/models/addon.js

@@ -28,17 +28,11 @@ const Funnel = require('broccoli-funnel');
 const walkSync = require('walk-sync');
 const ensurePosixPath = require('ensure-posix-path');
 const { defaultsDeep } = require('ember-cli-lodash-subset');
-const findAddonByName = require('../utilities/find-addon-by-name');
 const heimdall = require('heimdalljs');
 const calculateCacheKeyForTree = require('calculate-cache-key-for-tree');
 const addonProcessTree = require('../utilities/addon-process-tree');
-const emberCLIBabelConfigKey = require('../utilities/ember-cli-babel-config-key');
-const semver = require('semver');
-const processModulesOnly = require('../broccoli/babel-process-modules-only');
 const registryHasPreprocessor = require('../utilities/registry-has-preprocessor');
 
-const BUILD_BABEL_OPTIONS_FOR_PREPROCESSORS = Symbol('BUILD_BABEL_OPTIONS_FOR_PREPROCESSORS');
-
 if (!heimdall.hasMonitor('addon-tree-cache')) {
   heimdall.registerMonitor('addon-tree-cache', function AddonTreeCacheSchema() {
     this.hits = 0;
@@ -125,15 +119,6 @@ function _resetTreeCache() {
   ADDON_TREE_CACHE.clear();
 }
 
-function warn(message) {
-  if (this.ui) {
-    this.ui.writeDeprecateLine(message);
-  } else {
-    const chalk = require('chalk');
-    console.log(chalk.yellow(`DEPRECATION: ${message}`));
-  }
-}
-
 /**
   Root class for an Addon. If your addon module exports an Object this
   will be extended from this base class. If you export a constructor (function),
@@ -323,18 +308,13 @@ let addonProto = {
   },
 
   _initDefaultBabelOptions() {
-    this.__originalOptions = this.options = defaultsDeep(this.options, {
-      babel: this[BUILD_BABEL_OPTIONS_FOR_PREPROCESSORS](),
+    this.options = defaultsDeep(this.options, {
+      babel: {},
     });
 
-    let defaultEmberCLIBabelOptions = {
+    this.options['ember-cli-babel'] = defaultsDeep(this.options['ember-cli-babel'], {
       compileModules: true,
-    };
-    let emberCLIBabelConfigKey = this._emberCLIBabelConfigKey();
-    this.__originalOptions[emberCLIBabelConfigKey] = this.options[emberCLIBabelConfigKey] = defaultsDeep(
-      this.options[emberCLIBabelConfigKey],
-      defaultEmberCLIBabelOptions
-    );
+    });
   },
 
   /**
@@ -409,16 +389,14 @@ let addonProto = {
         return true;
       }
 
-      // Addon names in index.js and package.json should be the same at all times whether they have scope or not.
+      // Addon names in index.js and package.json must be the same at all times whether they have scope or not.
       if (this.root === this.parent.root) {
-        if (parentName !== this.name && !process.env.EMBER_CLI_IGNORE_ADDON_NAME_MISMATCH) {
+        if (parentName !== this.name) {
           let pathToDisplay = process.cwd() === this.root ? process.cwd() : path.relative(process.cwd(), this.root);
 
           throw new SilentError(
-            'ember-cli: Your names in package.json and index.js should match. ' +
-              `The addon in ${pathToDisplay} currently have '${parentName}' in package.json and '${this.name}' in index.js. ` +
-              'Until ember-cli v3.9, this error can be disabled by setting env variable EMBER_CLI_IGNORE_ADDON_NAME_MISMATCH to "true". ' +
-              'For more information about this workaround, see: https://github.com/ember-cli/ember-cli/pull/7950.'
+            'ember-cli: Your names in package.json and index.js must match. ' +
+              `The addon in ${pathToDisplay} currently has '${parentName}' in package.json and '${this.name}' in index.js.`
           );
         }
 
@@ -547,8 +525,8 @@ let addonProto = {
     let tree;
 
     if (!this.project) {
-      this._warn(
-        `Addon: \`${this.name}\` is missing addon.project, this may be the result of an addon forgetting to invoke \`super\` in its init.`
+      throw new SilentError(
+        `Addon \`${this.name}\` is missing \`addon.project\`. This may be the result of an addon forgetting to invoke \`super\` in its init hook.`
       );
     }
     // TODO: fix law of demeter `_watchmanInfo.canNestRoots` is obviously a poor idea
@@ -571,18 +549,6 @@ let addonProto = {
     return ensurePosixPath(normalizedAbsoluteTreePath);
   },
 
-  /**
-   * @private
-   * @method _warn
-   */
-  _warn: warn,
-
-  _emberCLIBabelConfigKey() {
-    let emberCLIBabelInstance = findAddonByName(this.addons, 'ember-cli-babel');
-
-    return emberCLIBabelConfigKey(emberCLIBabelInstance);
-  },
-
   /**
     Returns a given type of tree (if present), merged with the
     application tree. For each of the trees available using this
@@ -836,15 +802,12 @@ let addonProto = {
     @example
     ```js
     treeForAddon() {
-      var tree = this._super.treeForAddon.apply(this, arguments);
-      var checker = new VersionChecker(this);
-      var isOldEmber = checker.for('ember', 'bower').lt('1.13.0');
+      let emberVersion = new VersionChecker(this.project).for('ember-source');
+      let shouldUsePolyfill = emberVersion.lt('4.5.0-alpha.4');
 
-      if (isOldEmber) {
-        tree = new Funnel(tree, { exclude: [ /instance-initializers/ ] });
+      if (shouldUsePolyfill) {
+        return this._super.treeForAddon.apply(this, arguments);
       }
-
-      return tree;
     }
     ```
    */
@@ -946,16 +909,14 @@ let addonProto = {
         registry: this.registry,
         treeType: 'addon-test-support',
       });
-    } else {
-      this._warn(
-        `Addon test support files were detected in \`${this._treePathFor('addon-test-support')}\`, but no JavaScript ` +
-          `preprocessors were found for \`${this.name}\`. Please make sure to add a preprocessor ` +
-          `(most likely \`ember-cli-babel\`) to \`dependencies\` (NOT \`devDependencies\`) in ` +
-          `\`${this.name}\`'s \`package.json\`.`
-      );
-
-      return processModulesOnly(namespacedTree, `Babel Fallback - Addon#treeForAddonTestSupport (${this.name})`);
     }
+
+    throw new SilentError(
+      `Addon test-support files were detected in \`${this._treePathFor('addon-test-support')}\`, but no JavaScript ` +
+        `preprocessor was found for \`${this.name}\`. Please make sure to add a preprocessor ` +
+        `(most likely \`ember-cli-babel\`) to \`dependencies\` (NOT \`devDependencies\`) in ` +
+        `\`${this.name}\`'s \`package.json\`.`
+    );
   },
 
   /**
@@ -1159,37 +1120,27 @@ let addonProto = {
   */
   compileAddon(tree) {
     if (!this.options) {
-      this._warn(
+      throw new SilentError(
         `Ember CLI addons manage their own module transpilation during the \`treeForAddon\` processing. ` +
           `\`${this.name}\` (found at \`${this.root}\`) has removed \`this.options\` ` +
-          `which conflicts with the addons ability to transpile its \`addon/\` files properly. ` +
-          `Falling back to default babel configuration options.`
+          `which conflicts with the addons ability to transpile its \`addon/\` files properly.`
       );
-
-      this.options = {};
     }
 
     if (!this.options.babel) {
-      this._warn(
+      throw new SilentError(
         `Ember CLI addons manage their own module transpilation during the \`treeForAddon\` processing. ` +
-          `\`${this.name}\` (found at \`${this.root}\`) has overridden the \`this.options.babel\` ` +
-          `options which conflicts with the addons ability to transpile its \`addon/\` files properly. ` +
-          `Falling back to default babel configuration options.`
+          `\`${this.name}\` (found at \`${this.root}\`) has overridden the \`this.options.babel\` options ` +
+          `which conflicts with the addons ability to transpile its \`addon/\` files properly.`
       );
-
-      this.options.babel = this.__originalOptions.babel;
     }
 
-    let emberCLIBabelConfigKey = this._emberCLIBabelConfigKey();
-    if (!this.options[emberCLIBabelConfigKey]) {
-      this._warn(
+    if (!this.options['ember-cli-babel']) {
+      throw new SilentError(
         `Ember CLI addons manage their own module transpilation during the \`treeForAddon\` processing. ` +
-          `\`${this.name}\` (found at \`${this.root}\`) has overridden the \`this.options.${emberCLIBabelConfigKey}\` ` +
-          `options which conflicts with the addons ability to transpile its \`addon/\` files properly. ` +
-          `Falling back to default babel configuration options.`
+          `\`${this.name}\` (found at \`${this.root}\`) has overridden the \`this.options['ember-cli-babel']\` options ` +
+          `which conflicts with the addons ability to transpile its \`addon/\` files properly.`
       );
-
-      this.options[emberCLIBabelConfigKey] = this.__originalOptions[emberCLIBabelConfigKey];
     }
 
     let scopedInput = new Funnel(tree, {
@@ -1297,23 +1248,16 @@ let addonProto = {
       treeType: 'addon',
     });
 
-    let postprocessedAddonJs = this._addonPostprocessTree('js', processedAddonJS);
-
-    if (!registryHasPreprocessor(this.registry, 'js')) {
-      this._warn(
-        `Addon files were detected in \`${this._treePathFor('addon')}\`, but no JavaScript ` +
-          `preprocessors were found for \`${this.name}\`. Please make sure to add a preprocessor ` +
-          '(most likely `ember-cli-babel`) to in `dependencies` (NOT `devDependencies`) in ' +
-          `\`${this.name}\`'s \`package.json\`.`
-      );
-
-      postprocessedAddonJs = processModulesOnly(
-        postprocessedAddonJs,
-        `Babel Fallback - Addon#processedAddonJsFiles(${this.name})`
-      );
+    if (registryHasPreprocessor(this.registry, 'js')) {
+      return this._addonPostprocessTree('js', processedAddonJS);
     }
 
-    return postprocessedAddonJs;
+    throw new SilentError(
+      `Addon files were detected in \`${this._treePathFor('addon')}\`, but no JavaScript ` +
+        `preprocessor was found for \`${this.name}\`. Please make sure to add a preprocessor ` +
+        '(most likely `ember-cli-babel`) to `dependencies` (NOT `devDependencies`) in ' +
+        `\`${this.name}\`'s \`package.json\`.`
+    );
   },
 
   /**
@@ -1360,7 +1304,6 @@ let addonProto = {
 
     - Modifying configuration options (see list of defaults [here](https://github.com/ember-cli/ember-cli/blob/v2.4.3/lib/broccoli/ember-app.js#L163))
       - For example
-        - `minifyJS`
         - `storeConfigInMeta`
         - et, al
 
@@ -1732,24 +1675,6 @@ function methodsForTreeType(treeType) {
 
 let Addon = CoreObject.extend(addonProto);
 
-Addon.prototype[BUILD_BABEL_OPTIONS_FOR_PREPROCESSORS] = function () {
-  let emberCLIBabelInstance = findAddonByName(this.addons, 'ember-cli-babel');
-  let version;
-  if (emberCLIBabelInstance) {
-    version = require(path.join(emberCLIBabelInstance.root, 'package')).version;
-  }
-
-  if (version && semver.satisfies(version, '^5')) {
-    return {
-      modules: 'amdStrict',
-      moduleIds: true,
-      resolveModuleSource: require('amd-name-resolver').moduleResolve,
-    };
-  } else {
-    return {};
-  }
-};
-
 module.exports = Addon;
 module.exports._resetTreeCache = _resetTreeCache;
 module.exports._treeCache = ADDON_TREE_CACHE;

package/lib/models/blueprint.js

@@ -20,11 +20,9 @@ const walkSync = require('walk-sync');
 const SilentError = require('silent-error');
 const CoreObject = require('core-object');
 const EOL = require('os').EOL;
-const bowEpParser = require('bower-endpoint-parser');
 const logger = require('heimdalljs-logger')('ember-cli:blueprint');
 const normalizeEntityName = require('ember-cli-normalize-entity-name');
 const isAddon = require('../utilities/is-addon');
-const { deprecate } = require('../debug');
 
 const initialIgnoredFiles = ['.DS_Store'];
 
@@ -1143,119 +1141,6 @@ let Blueprint = CoreObject.extend({
     });
   },
 
-  /**
-    Used to add a Bower package to the projects `bower.json`.
-
-    Bower is a package manager that is no longer recommended
-    for new projects, but you may find this hook used in older
-    addons.
-
-    Generally, this would be done from the `afterInstall` hook, to
-    ensure that a package that is required by a given blueprint is
-    available.
-
-    `localPackageName` and `target` may be thought of as equivalent
-    to the key-value pairs in the `dependency` or `devDepencency`
-    objects contained within a bower.json file.
-    @method addBowerPackageToProject
-    @param {String} localPackageName
-    @param {String} target
-    @param {Object} installOptions
-    @return {Promise}
-
-    @example
-    ```js
-    addBowerPackageToProject('jquery', '~1.11.1');
-    addBowerPackageToProject('old_jquery', 'jquery#~1.9.1');
-    addBowerPackageToProject('bootstrap-3', 'https://twitter.github.io/bootstrap/assets/bootstrap');
-    ```
-  */
-  addBowerPackageToProject(localPackageName, target, installOptions) {
-    deprecate(
-      [
-        `(Blueprint: \`${this.name}\`) \`addBowerPackageToProject\` has been deprecated.`,
-        'If the package is also available on the npm registry, please use `addPackageToProject` instead.',
-        'If not, please install the Bower package manually by running:',
-        `\`bower install ${localPackageName} --save\``,
-      ].join('\n'),
-      false,
-      {
-        for: 'ember-cli',
-        id: 'ember-cli.blueprint.add-bower-package-to-project',
-        since: {
-          available: '4.3.0',
-          enabled: '4.3.0',
-        },
-        until: '5.0.0',
-      }
-    );
-
-    let lpn = localPackageName;
-    let tar = target;
-    let packageObject = bowEpParser.json2decomposed(lpn, tar);
-    return this.addBowerPackagesToProject([packageObject], installOptions, true);
-  },
-
-  /**
-    Used to add an array of packages to the projects `bower.json`.
-
-    Bower is a package manager that is no longer recommended
-    for new projects, but you may find this hook used in older
-    addons.
-
-    Generally, this would be done from the `afterInstall` hook, to
-    ensure that a package that is required by a given blueprint is
-    available.
-
-    Expects each array item to be an object with a `name`.  Each object
-    may optionally have a `target` to specify a specific version, or a
-    `source` to specify a non-local name to be resolved.
-
-    @method addBowerPackagesToProject
-    @param {Array} packages
-    @param {Object} installOptions
-    @return {Promise}
-  */
-  addBowerPackagesToProject(packages, installOptions, _deprecationCondition = false) {
-    let task = this.taskFor('bower-install');
-    let installText = packages.length > 1 ? 'install bower packages' : 'install bower package';
-    let packageNames = [];
-    let packageNamesAndVersions = packages
-      .map((pkg) => {
-        pkg.source = pkg.source || pkg.name;
-        packageNames.push(pkg.name);
-        return pkg;
-      })
-      .map(bowEpParser.compose);
-
-    deprecate(
-      [
-        `(Blueprint: \`${this.name}\`) \`addBowerPackagesToProject\` has been deprecated.`,
-        'If the packages are also available on the npm registry, please use `addPackagesToProject` instead.',
-        'If not, please install the Bower packages manually by running:',
-        `\`bower install ${packageNames.join(' ')} --save\``,
-      ].join('\n'),
-      _deprecationCondition,
-      {
-        for: 'ember-cli',
-        id: 'ember-cli.blueprint.add-bower-packages-to-project',
-        since: {
-          available: '4.3.0',
-          enabled: '4.3.0',
-        },
-        until: '5.0.0',
-      }
-    );
-
-    this._writeStatusToUI(chalk.green, installText, packageNames.join(', '));
-
-    return task.run({
-      verbose: true,
-      packages: packageNamesAndVersions,
-      installOptions: installOptions || { save: true },
-    });
-  },
-
   /**
     Used to add an addon to the project's `package.json` and run it's
     `defaultBlueprint` if it provides one.

package/lib/models/command.js

@@ -127,7 +127,6 @@ let Command = CoreObject.extend({
      *   { name: 'verbose',    type: Boolean, default: false, aliases: ['v'] },
      *   { name: 'blueprint',  type: String,  default: 'app', aliases: ['b'] },
      *   { name: 'skip-npm',   type: Boolean, default: false, aliases: ['sn'] },
-     *   { name: 'skip-bower', type: Boolean, default: false, aliases: ['sb'] },
      *   { name: 'skip-git',   type: Boolean, default: false, aliases: ['sg'] },
      *   { name: 'directory',  type: String ,                 aliases: ['dir'] }
      * ],
@@ -288,12 +287,12 @@ let Command = CoreObject.extend({
             );
           }
 
-          let installInstuction = '`npm install`';
+          let installCommand = 'npm install';
           if (isYarnProject(this.project.root)) {
-            installInstuction = '`yarn install`';
+            installCommand = 'yarn install';
           }
           throw new SilentError(
-            `Required packages are missing, run ${installInstuction} from this directory to install them.`
+            `Required packages are missing, run \`${installCommand}\` from this directory to install them.`
           );
         }
       }

package/lib/models/package-info-cache/package-info.js

@@ -412,11 +412,7 @@ class PackageInfo {
         });
       }
 
-      if (process.env.EMBER_CLI_ERROR_ON_INVALID_ADDON) {
-        throw msg;
-      } else {
-        this.cache.ui.writeWarnLine(msg);
-      }
+      throw msg;
     }
   }
 

package/lib/models/project.js

@@ -12,13 +12,11 @@ const { cloneDeep, merge, forOwn } = require('ember-cli-lodash-subset');
 const logger = require('heimdalljs-logger')('ember-cli:project');
 const versionUtils = require('../utilities/version-utils');
 const emberCLIVersion = versionUtils.emberCLIVersion;
-const findAddonByName = require('../utilities/find-addon-by-name');
 const heimdall = require('heimdalljs');
 const PackageInfoCache = require('./package-info-cache');
 const PerBundleAddonCache = require('./per-bundle-addon-cache');
 const instantiateAddons = require('./instantiate-addons');
 const HostInfoCache = require('./host-info-cache');
-const { deprecate } = require('../debug');
 
 let processCwd = process.cwd();
 
@@ -48,7 +46,6 @@ class Project {
     this.addonPackages = Object.create(null);
     this.addons = [];
     this.liveReloadFilterPatterns = [];
-    this.setupBowerDirectory();
     this.configCache = new Map();
     this.hostInfoCache = new HostInfoCache(this);
 
@@ -57,7 +54,7 @@ class Project {
       so that other areas of the system can be aware that watchman is being used.
 
       For example, this information is used in the broccoli build pipeline to know
-      if we can watch additional directories (like bower_components) "cheaply".
+      if we can watch additional directories "cheaply".
 
       Contains `enabled` and `version`.
 
@@ -105,51 +102,6 @@ class Project {
     }
   }
 
-  /**
-   * Sets the name of the bower directory for this project
-   *
-   * @private
-   * @method setupBowerDirectory
-   */
-  setupBowerDirectory() {
-    let bowerrcPath = path.join(this.root, '.bowerrc');
-
-    logger.info('bowerrc path: %s', bowerrcPath);
-
-    if (fs.existsSync(bowerrcPath)) {
-      try {
-        this._bowerDirectory = fs.readJsonSync(bowerrcPath).directory;
-      } catch (exception) {
-        logger.info('failed to parse bowerc: %s', exception);
-        this._bowerDirectory = null;
-      }
-    }
-
-    this._bowerDirectory = this._bowerDirectory || 'bower_components';
-    logger.info('bowerDirectory: %s', this._bowerDirectory);
-  }
-
-  get bowerDirectory() {
-    deprecate(
-      [
-        '`bowerDirectory` has been deprecated.',
-        "If you still need access to the project's Bower directory, you will have to manually resolve the project's `.bowerrc` file, and read the `directory` property instead.",
-      ].join('\n'),
-      false,
-      {
-        for: 'ember-cli',
-        id: 'ember-cli.project.bower-directory',
-        since: {
-          available: '4.3.0',
-          enabled: '4.3.0',
-        },
-        until: '5.0.0',
-      }
-    );
-
-    return this._bowerDirectory;
-  }
-
   // Checks whether the project's npm dependencies are
   // present. Previously this just looked for a node_modules folder in
   // a fixed place (which is not compatible with node's module
@@ -400,43 +352,6 @@ class Project {
     return Object.assign({}, devDependencies, pkg['dependencies']);
   }
 
-  /**
-    Returns the bower dependencies for this project.
-
-    @private
-    @method bowerDependencies
-    @param  {String} bower Path to bower.json
-    @return {Object}       Bower dependencies
-   */
-  bowerDependencies(bower) {
-    deprecate(
-      [
-        '`bowerDependencies` has been deprecated.',
-        "If you still need access to the project's Bower dependencies, you will have to manually resolve the project's `bower.json` file instead.",
-      ].join('\n'),
-      false,
-      {
-        for: 'ember-cli',
-        id: 'ember-cli.project.bower-dependencies',
-        since: {
-          available: '4.3.0',
-          enabled: '4.3.0',
-        },
-        until: '5.0.0',
-      }
-    );
-
-    return this._bowerDependencies(bower);
-  }
-
-  _bowerDependencies(bower) {
-    if (!bower) {
-      let bowerPath = path.join(this.root, 'bower.json');
-      bower = fs.existsSync(bowerPath) ? require(bowerPath) : {};
-    }
-    return Object.assign({}, bower['devDependencies'], bower['dependencies']);
-  }
-
   /**
     Provides the list of paths to consult for addons that may be provided
     internally to this project. Used for middleware addons with built-in support.
@@ -674,7 +589,7 @@ class Project {
   findAddonByName(name) {
     this.initializeAddons();
 
-    return findAddonByName(this.addons, name);
+    return this.addons.find((addon) => addon.pkg?.name === name);
   }
 
   /**

package/lib/tasks/interactive-new.js

@@ -7,7 +7,7 @@ const DEFAULT_LOCALE = 'en-US';
 
 class InteractiveNewTask extends Task {
   async run(newCommandOptions, _testAnswers) {
-    const inquirer = require('inquirer');
+    const inquirer = await import('inquirer');
 
     let prompt = inquirer.createPromptModule();
     let questions = await this.getQuestions(newCommandOptions);