ember-cli-deploy-s3-index 4.0.2 → 4.0.4

package/.github/workflows/ci.yaml

@@ -10,31 +10,33 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x, 20.x]
+        node-version: [20.x, 22.x, 24.x]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
+    - uses: pnpm/action-setup@v6
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
-        cache: 'yarn'
-    - run: yarn install
-    - run: yarn test
+        cache: 'pnpm'
+    - run: pnpm install --frozen-lockfile
+    - run: pnpm test
 
   test-floating:
     name: Floating Dependencies
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x, 20.x]
+        node-version: [20.x, 22.x, 24.x]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
+    - uses: pnpm/action-setup@v6
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v2
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
-        cache: 'yarn'
+        cache: 'pnpm'
     - name: install dependencies
-      run: yarn install --no-lockfile
+      run: pnpm install --no-lockfile
     - name: test
-      run: yarn test
+      run: pnpm test

package/CHANGELOG.md

@@ -3,6 +3,31 @@
 
 
 
+
+
+## 4.0.4 (2026-10-28)
+
+#### :bug: Bug Fix
+* [#145](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/145) fix: Give endpoint and credentials to the S3 client constructor ([@matthewhartstonge](https://github.com/matthewhartstonge))
+
+#### :house: Internal
+* [#155](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/155) Upgrade release-it to v20 and update RELEASE.md ([@lukemelia](https://github.com/lukemelia))
+* [#151](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/151) Switch from yarn to pnpm ([@lukemelia](https://github.com/lukemelia))
+* [#150](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/150) Remove AppVeyor config and dead CI badges ([@lukemelia](https://github.com/lukemelia))
+* [#146](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/146) Update CI: drop EOL Node versions, bump actions ([@lukemelia](https://github.com/lukemelia))
+
+#### Committers: 2
+- Luke Melia ([@lukemelia](https://github.com/lukemelia))
+- Matthew Hartstonge ([@matthewhartstonge](https://github.com/matthewhartstonge))
+
+## 4.0.3 (2024-05-02)
+
+#### :bug: Bug Fix
+* [#143](https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/pull/143) Handle NotFound S3 Response ([@jrjohnson](https://github.com/jrjohnson))
+
+#### Committers: 1
+- Jon Johnson ([@jrjohnson](https://github.com/jrjohnson))
+
 ## 4.0.2 (2024-04-05)
 
 #### :bug: Bug Fix

package/README.md

@@ -1,4 +1,4 @@
-# ember-cli-deploy-s3-index [![Build Status](https://travis-ci.org/ember-cli-deploy/ember-cli-deploy-s3-index.svg?branch=master)](https://travis-ci.org/ember-cli-deploy/ember-cli-deploy-s3-index) [![Build status](https://ci.appveyor.com/api/projects/status/iogkx02goxx6jsf3/branch/master?svg=true)](https://ci.appveyor.com/project/LevelbossMike/ember-cli-deploy-s3-index/branch/master)
+# ember-cli-deploy-s3-index
 
 
 > An ember-cli-deploy plugin to deploy ember-cli's bootstrap index file to [S3](https://aws.amazon.com/de/s3).
@@ -144,6 +144,8 @@ The underlying S3 library used to upload the files to S3. This allows the user t
 
 The client specified MUST implement functions called `getObject` and `putObject`. See [Using V2 API] (https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/welcome.html#using_v2_commands).
 
+The plugin does not change configuration in a provided client. For example, if you set `endpoint`, you will need to give it to your custom client when you create it.
+
 *Default:* the default S3 library is `@aws-sdk/s3-client` (AWS JS SDK v3). Please use this addon version < 3.0.0 if you want to use AWS JS SDK 2.0 
 
 ### endpoint

package/RELEASE.md

@@ -24,20 +24,29 @@ When reviewing merged PR's the labels to be used are:
 * internal - Used for internal changes that still require a mention in the
   changelog/release notes.
 
+Unlabeled PRs are left out of the changelog.
+
 ## Release
 
 Once the prep work is completed, the actual release is straight forward:
 
-* First, ensure that you have installed your projects dependencies:
+* First, check out an up-to-date `master` and install the project's
+  dependencies:
 
 ```sh
-yarn install
+git checkout master
+git pull
+pnpm install
 ```
 
-* Second, ensure that you have obtained a
+* Second, ensure that you are logged in to npm as a user with publish access
+  to `ember-cli-deploy-s3-index`. `npm whoami` should print your username.
+
+* Third, ensure that you have obtained a
   [GitHub personal access token][generate-token] with the `repo` scope (no
   other permissions are needed). Make sure the token is available as the
-  `GITHUB_AUTH` environment variable.
+  `GITHUB_AUTH` environment variable. Both lerna-changelog and release-it's
+  GitHub release step read it from there.
 
   For instance:
 
@@ -50,11 +59,14 @@ yarn install
 * And last (but not least 😁) do your release.
 
 ```sh
-npx release-it
+pnpm release
 ```
 
 [release-it](https://github.com/release-it/release-it/) manages the actual
-release process. It will prompt you to to choose the version number after which
-you will have the chance to hand tweak the changelog to be used (for the
-`CHANGELOG.md` and GitHub release), then `release-it` continues on to tagging,
-pushing the tag and commits, etc.
+release process. It will prompt you to choose the version number (or pass it
+directly, e.g. `pnpm release minor`) after which you will have the chance to
+hand tweak the changelog to be used (for the `CHANGELOG.md` and GitHub
+release), then `release-it` continues on to committing, tagging, pushing the
+tag and commits, publishing to npm, and creating the GitHub release.
+
+To preview a release without changing anything, run `pnpm release --dry-run`.

package/lib/s3.js

@@ -9,20 +9,15 @@ var readFile        = RSVP.denodeify(fs.readFile);
 var mime            = require('mime-types');
 var joinUriSegments = require('./util/join-uri-segments');
 
-function headObject(client, params) {
-  return new RSVP.Promise(function(resolve, reject) {
-    client.headObject(params, function(err, data) {
-      if (err && err.code === 'NotFound') {
-        return resolve();
-      }
-      else if (err) {
-        return reject(err);
-      }
-      else {
-        return resolve(data);
-      }
-    });
-  });
+async function headObject(client, params) {
+  try {
+    return await client.headObject(params);
+  } catch (err) {
+    if (err.name === 'NotFound') {
+      return;
+    }
+    throw err;
+  }
 }
 
 module.exports = CoreObject.extend({
@@ -32,31 +27,26 @@ module.exports = CoreObject.extend({
     var config = plugin.pluginConfig;
     var profile = plugin.readConfig('profile');
     var endpoint = plugin.readConfig('endpoint');
-    var credentials;
+    // The SDK resolves its options when it creates the client. Do not set them after.
+    var s3Options = Object.assign({}, config);
 
     this._plugin = plugin;
 
     var providedS3Client = plugin.readConfig("s3Client");
-    
+
 
     if (profile && !providedS3Client) {
       this._plugin.log("Using AWS profile from config", { verbose: true });
-      credentials = fromIni({ profile: profile });
+      s3Options.credentials = fromIni({ profile: profile });
     }
 
     if (endpoint) {
-      this._plugin.log('Using endpoint from config', { verbose: true });      
+      this._plugin.log('Using endpoint from config', { verbose: true });
+      s3Options.endpoint = endpoint;
     }
 
-    this._client = providedS3Client || new S3(config);
-  
-    if (endpoint) {
-      this._client.config.endpoint = endpoint;
-    }
-    if (credentials) {
-      this._client.config.credentials = credentials;
-    }
-    
+    this._client = providedS3Client || new S3(s3Options);
+
   },
 
   upload: function(options) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-cli-deploy-s3-index",
-  "version": "4.0.2",
+  "version": "4.0.4",
   "description": "Ember CLI Deploy plugin to deploy ember-cli's bootstrap index file to S3.",
   "keywords": [
     "ember-addon",
@@ -26,14 +26,14 @@
     "rsvp": "^4.8.5"
   },
   "devDependencies": {
+    "@release-it-plugins/lerna-changelog": "^9.0.0",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "ember-cli": "~3.18.0",
     "eslint": "^7.0.0",
     "glob": "^7.1.6",
     "mocha": "^7.1.2",
-    "release-it": "^14.2.1",
-    "release-it-lerna-changelog": "^3.1.0"
+    "release-it": "^20.2.1"
   },
   "engines": {
     "node": "14.* || 16.* || 18.* || >= 20"
@@ -50,10 +50,11 @@
       "tokenRef": "GITHUB_AUTH"
     },
     "plugins": {
-      "release-it-lerna-changelog": {
+      "@release-it-plugins/lerna-changelog": {
         "infile": "CHANGELOG.md",
         "launchEditor": true
       }
     }
-  }
+  },
+  "packageManager": "pnpm@12.15.0+sha512.b3951d6d6ff4a9f13dc7cf56cd28d2b8eb37dbcc9c68e52e1e1191873ea9f82a017287ab50baadc5ccc494f036c67c0e47eb13608c2fa36f47711b61ea128e61"
 }

package/pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+allowBuilds:
+  core-js: false

package/appveyor.yml

@@ -1,33 +0,0 @@
-# http://www.appveyor.com/docs/appveyor-yml
-
-# Fix line endings in Windows. (runs before repo cloning)
-init:
-  - git config --global core.autorclf true
-
-# Test against these versions of Node.js.
-environment:
-  matrix:
-    - nodejs_version: "4.5"
-    - nodejs_version: "6.10"
-
-cache:
- - "%LOCALAPPDATA%\\Yarn"
-
-# Install scripts. (runs after repo cloning)
-install:
-  # Get the latest stable version of Node.js or io.js
-  - ps: Install-Product node $env:nodejs_version
-  # install modules
-  - md C:\nc
-  - yarn install
-
-# Post-install test scripts.
-test_script:
-  # Output useful info for debugging.
-  - node --version
-  - yarn --version
-  # run tests
-  - yarn test
-
-# Don't actually build.
-build: off