ember-attacher 3.0.0 → 3.1.0

package/CHANGELOG.md

@@ -1,9 +1,14 @@
 
 
 
-## v3.0.0 (2024-03-06)
+
+## v3.1.0 (2024-03-07)
+
+#### :boom: Breaking Change
+* [#843](https://github.com/tylerturdenpants/ember-attacher/pull/843) Drop ember-in-element-polyfill from dependencies ([@pzubar](https://github.com/pzubar))
 
 #### :rocket: Enhancement
+* [#887](https://github.com/tylerturdenpants/ember-attacher/pull/887) [chore]: Bump ember-cli-babel from 7.26.11 to 8.2.0 ([@dependabot[bot]](https://github.com/apps/dependabot))
 * [#820](https://github.com/tylerturdenpants/ember-attacher/pull/820) Fix the "cancelAnimationFrame is not defined" error in fastboot ([@pzubar](https://github.com/pzubar))
 * [#790](https://github.com/tylerturdenpants/ember-attacher/pull/790) Bump ember-maybe-in-element to supress build-time warning ([@pzubar](https://github.com/pzubar))
 * [#784](https://github.com/tylerturdenpants/ember-attacher/pull/784) Prevent overflow by default ([@pzubar](https://github.com/pzubar))
@@ -15,6 +20,8 @@
 * [#784](https://github.com/tylerturdenpants/ember-attacher/pull/784) Prevent overflow by default ([@pzubar](https://github.com/pzubar))
 
 #### :house: Internal
+* [#867](https://github.com/tylerturdenpants/ember-attacher/pull/867) [chore]: Bump ember-truth-helpers from 3.1.1 to 4.0.3 ([@dependabot[bot]](https://github.com/apps/dependabot))
+* [#928](https://github.com/tylerturdenpants/ember-attacher/pull/928) [chore]: Bump ip from 1.1.8 to 1.1.9 ([@dependabot[bot]](https://github.com/apps/dependabot))
 * [#827](https://github.com/tylerturdenpants/ember-attacher/pull/827) [chore]: Bump @ember/test-helpers from 2.9.3 to 2.9.4 ([@dependabot[bot]](https://github.com/apps/dependabot))
 * [#786](https://github.com/tylerturdenpants/ember-attacher/pull/786) [chore]: Bump @ember/string from 3.0.1 to 3.1.1 ([@dependabot[bot]](https://github.com/apps/dependabot))
 * [#833](https://github.com/tylerturdenpants/ember-attacher/pull/833) [chore]: Bump ember-source from 4.12.0 to 4.12.3 ([@dependabot[bot]](https://github.com/apps/dependabot))
@@ -27,6 +34,14 @@
 #### Committers: 1
 - Petro Zubar ([@pzubar](https://github.com/pzubar))
 
+## v3.0.0 (2024-03-06)
+
+#### :boom: Breaking Change
+* [#843](https://github.com/tylerturdenpants/ember-attacher/pull/843) Drop ember-in-element-polyfill from dependencies ([@pzubar](https://github.com/pzubar))
+
+#### Committers: 1
+- Petro Zubar ([@pzubar](https://github.com/pzubar))
+
 ## v2.0.8 (2024-01-16)
 
 #### :rocket: Enhancement
@@ -696,4 +711,4 @@
 
 
 
-\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

package/addon/components/attach-popover.js

@@ -1,6 +1,6 @@
 import { action } from '@ember/object';
 import Component from '@glimmer/component';
-import { cancel, debounce, later, next, run } from '@ember/runloop';
+import { cancel, debounce, later, next, run, once } from '@ember/runloop';
 import { getOwner } from '@ember/application';
 import { guidFor } from '@ember/object/internals';
 import { htmlSafe, isHTMLSafe } from '@ember/template';
@@ -10,6 +10,7 @@ import { isEmpty, typeOf } from '@ember/utils';
 import { autoUpdate, computePosition, arrow, flip, limitShift, shift } from '@floating-ui/dom';
 import { buildWaiter } from '@ember/test-waiters';
 import { tracked } from '@glimmer/tracking';
+import { modifier } from 'ember-modifier';
 import DEFAULTS from '../defaults';
 
 const animationTestWaiter = buildWaiter('attach-popover');
@@ -293,20 +294,18 @@ export default class AttachPopover extends Component {
     this._hide();
   }
 
-  @action
-  onParentFinderInsert(element) {
+  onParentFinderInsert = modifier((element) => {
     this.parentElement = element.parentElement;
-    this._initializeAttacher();
-  }
+    once(this, '_initializeAttacher')
+  });
 
-  @action
-  _ensureArgumentsAreValid() {
+  _ensureArgumentsAreValid([arrow, useCapture]) {
     stripInProduction(() => {
-      if (this.arrow && this.isFillAnimation) {
+      if (arrow && this.isFillAnimation) {
         warn('Animation: \'fill\' is not compatible with arrow: true', { id: 70015 });
       }
 
-      if (this.useCapture !== this._lastUseCaptureArgumentValue) {
+      if (useCapture !== this._lastUseCaptureArgumentValue) {
         warn(
           'The value of the useCapture argument was mutated',
           { id: 'ember-attacher.use-capture-mutated' }
@@ -403,15 +402,11 @@ export default class AttachPopover extends Component {
       });
   }
 
-  @action
-  onTargetOrTriggerChange() {
-    this._initializeAttacher();
-  }
-
-  @action
-  onIsShownChange() {
-    const isShown = this.isShown;
+  onTargetOrTriggerChange = modifier((_, _positional) => {
+    once(this, '_initializeAttacher', ..._positional);
+  });
 
+  onIsShownChange = modifier((_, [isShown]) => {
     if (isShown === true && this._isHidden) {
       this._show();
 
@@ -421,7 +416,18 @@ export default class AttachPopover extends Component {
     } else if (isShown === false && !this._isHidden) {
       this._hide();
     }
-  }
+  });
+
+  initializeAttacher = modifier((floatingElement) => {
+    this._floatingElement = floatingElement;
+
+    if (this.renderInPlace) {
+      this.parentElement = floatingElement.parentElement;
+      once(this, '_initializeAttacher');
+    }
+
+    return () => this._cleanup?.();
+  });
 
   /**
    * ================== SHOW ATTACHMENT LOGIC ==================
@@ -768,31 +774,14 @@ export default class AttachPopover extends Component {
     });
   }
 
-  @action
-  didInsertFloatingElement(floatingElement) {
-    this._floatingElement = floatingElement;
-
-    if (this.renderInPlace) {
-      this.parentElement = floatingElement.parentElement;
-      this._initializeAttacher();
-    }
-  }
-
-  @action
-  didInsertArrow(element) {
+  didInsertArrow = modifier((element) => {
     this._arrowElement = element;
-  }
-
-  @action
-  onOptionsChange() {
-    this._ensureArgumentsAreValid();
-    this._update();
-  }
+  })
 
-  @action
-  willDestroyFloatingElement() {
-    this._cleanup?.();
-  }
+  onOptionsChange = modifier((_, positional) => {
+    this._ensureArgumentsAreValid(positional);
+    once(this, '_update')
+  })
 
   _update() {
     this._cleanup?.();

package/addon/templates/components/attach-popover.hbs

@@ -1,5 +1,5 @@
 {{~#unless this.renderFloatingElement}}
-  <meta hidden {{did-insert this.onParentFinderInsert}} {{did-update this.onIsShownChange this.isShown}}/>
+  <meta hidden {{this.onParentFinderInsert}} {{this.onIsShownChange this.isShown}}/>
 {{~/unless~}}
 
 {{~#if this.renderFloatingElement~}}
@@ -8,17 +8,16 @@
       class="ember-attacher"
       id={{this.id}}
       role={{this.ariaRole}}
-      {{did-insert this.didInsertFloatingElement}}
-      {{did-update this.onIsShownChange this.isShown}}
-      {{did-update this.onTargetOrTriggerChange this.hideOn this.showOn @explicitTarget}}
-      {{did-update this.onOptionsChange this.autoUpdate this.animation this.arrow this.useCapture this.placement this._renderInPlace this._currentTarget this._middleware}}
-      {{will-destroy this.willDestroyFloatingElement}}
+      {{this.onIsShownChange this.isShown}}
+      {{this.onTargetOrTriggerChange this.hideOn this.showOn @explicitTarget}}
+      {{this.onOptionsChange this.arrow this.useCapture this.autoUpdate this.animation this.placement this._renderInPlace this._currentTarget this._middleware}}
+      {{this.initializeAttacher}}
       ...attributes
     >
       <div class={{this._class}} style={{this._style}}>
-        {{yield (hash hide=(action 'hide'))}}
+        {{yield (hash hide=this.hide)}}
         {{#if this.arrow}}
-          <div x-arrow {{did-insert this.didInsertArrow}}></div>
+          <div x-arrow {{this.didInsertArrow}}></div>
         {{/if}}
         {{#if this.isFillAnimation}}
           <div x-circle style="{{this._circleTransitionDuration}}"></div>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-attacher",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "Tooltips and popovers for Ember.js apps",
   "keywords": [
     "ember-addon",
@@ -32,11 +32,12 @@
     "@floating-ui/dom": "^1.6.3",
     "babel-plugin-filter-imports": "^4.0.0",
     "broccoli-funnel": "~3.0.8",
-    "ember-auto-import": "^2.7.0",
-    "ember-cli-babel": "^7.26.11",
+    "ember-auto-import": "^2.7.2",
+    "ember-cli-babel": "^8.2.0",
     "ember-cli-htmlbars": "^6.3.0",
     "ember-cli-sass": "^11.0.1",
     "ember-maybe-in-element": "^2.1.0",
+    "ember-modifier": "^4.1.0",
     "sass": "^1.71.1"
   },
   "devDependencies": {
@@ -45,15 +46,14 @@
     "@babel/helper-get-function-arity": "^7.16.7",
     "@babel/plugin-proposal-private-property-in-object": "^7.21.11",
     "@ember/optional-features": "^2.0.0",
-    "@ember/render-modifiers": "^2.0.5",
     "@ember/string": "^3.1.1",
     "@ember/test-helpers": "~2.9.4",
     "@ember/test-waiters": "^3.1.0",
-    "@embroider/test-setup": "^2.1.1",
+    "@embroider/test-setup": "^3.0.0",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
     "@html-next/flexi-default-styles": "^2.2.0",
-    "@release-it-plugins/lerna-changelog": "^5.0.0",
+    "@release-it-plugins/lerna-changelog": "^6.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "broccoli-asset-rev": "^3.0.0",
     "ember-cli": "~4.12.1",
@@ -68,7 +68,7 @@
     "ember-source": "~4.12.3",
     "ember-source-channel-url": "^3.0.0",
     "ember-svg-jar": "~2.4.7",
-    "ember-truth-helpers": "^3.1.1",
+    "ember-truth-helpers": "^4.0.3",
     "ember-try": "~3.0.0",
     "eslint": "~8.55.0",
     "eslint-plugin-decorator-position": "^5.0.2",