ember-attacher 2.0.1 → 2.0.2

package/.idea/ember-attacher.iml

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="WEB_MODULE" version="4">
+  <component name="NewModuleRootManager">
+    <content url="file://$MODULE_DIR$">
+      <sourceFolder url="file://$MODULE_DIR$/addon" isTestSource="false" />
+      <sourceFolder url="file://$MODULE_DIR$/app" isTestSource="false" />
+      <sourceFolder url="file://$MODULE_DIR$/public" isTestSource="false" />
+      <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" />
+      <sourceFolder url="file://$MODULE_DIR$/test-app" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/test-app/app" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/test-app/tests/acceptance" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/test-app/tests/integration" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/test-app/tests/unit" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/tests" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/tests/acceptance" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/tests/dummy/app" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/tests/integration" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/tests/unit" isTestSource="true" />
+      <excludeFolder url="file://$MODULE_DIR$/.bower_components.ember-try" />
+      <excludeFolder url="file://$MODULE_DIR$/.node_modules.ember-try" />
+      <excludeFolder url="file://$MODULE_DIR$/.tmp" />
+      <excludeFolder url="file://$MODULE_DIR$/dist" />
+      <excludeFolder url="file://$MODULE_DIR$/temp" />
+      <excludeFolder url="file://$MODULE_DIR$/tmp" />
+    </content>
+    <orderEntry type="inheritedJdk" />
+    <orderEntry type="sourceFolder" forTests="false" />
+  </component>
+</module>

package/.idea/inspectionProfiles/Project_Default.xml

@@ -0,0 +1,6 @@
+<component name="InspectionProjectProfileManager">
+  <profile version="1.0">
+    <option name="myName" value="Project Default" />
+    <inspection_tool class="Eslint" enabled="true" level="WARNING" enabled_by_default="true" />
+  </profile>
+</component>

package/.idea/modules.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="ProjectModuleManager">
+    <modules>
+      <module fileurl="file://$PROJECT_DIR$/.idea/ember-attacher.iml" filepath="$PROJECT_DIR$/.idea/ember-attacher.iml" />
+    </modules>
+  </component>
+</project>

package/.idea/vcs.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="VcsDirectoryMappings">
+    <mapping directory="" vcs="Git" />
+  </component>
+</project>

package/CHANGELOG.md

@@ -1,4 +1,20 @@
 
+
+## v2.0.2 (2023-05-18)
+
+#### :rocket: Enhancement
+* [#790](https://github.com/tylerturdenpants/ember-attacher/pull/790) Bump ember-maybe-in-element to supress build-time warning ([@pzubar](https://github.com/pzubar))
+* [#784](https://github.com/tylerturdenpants/ember-attacher/pull/784) Prevent overflow by default ([@pzubar](https://github.com/pzubar))
+
+#### :bug: Bug Fix
+* [#784](https://github.com/tylerturdenpants/ember-attacher/pull/784) Prevent overflow by default ([@pzubar](https://github.com/pzubar))
+
+#### :house: Internal
+* [#783](https://github.com/tylerturdenpants/ember-attacher/pull/783) Upgrade Ember to v4 ([@pzubar](https://github.com/pzubar))
+
+#### Committers: 1
+- Petro Zubar ([@pzubar](https://github.com/pzubar))
+
 ## v2.0.1 (2023-05-15)
 
 #### :boom: Breaking Change

package/README.md

@@ -4,7 +4,7 @@
 [![Download count all time](https://img.shields.io/npm/dt/ember-attacher.svg)](https://www.npmjs.com/package/ember-attacher)
 [![npm](https://img.shields.io/npm/dm/ember-attacher.svg)](https://www.npmjs.com/package/ember-attacher)
 [![Ember Observer Score](http://emberobserver.com/badges/ember-attacher.svg)](http://emberobserver.com/addons/ember-attacher)
-[![Build Status](https://travis-ci.org/kybishop/ember-attacher.svg?branch=master)](https://travis-ci.org/kybishop/ember-attacher)
+[![GitHub CI](https://github.com/tylerturdenpants/ember-attacher/actions/workflows/ci.yml/badge.svg)](https://github.com/tylerturdenpants/ember-attacher/actions/workflows/ci.yml)
 
 ## Compatibility
 
@@ -178,7 +178,10 @@ Below is a list of all available options, along with their defaults.
   // than the bubbling phase. This should be set to true when there are elements on the page that
   // are stopping event propagation in the bubbling phase, and as a result preventing correct
   // showing and hiding of popovers and tooltips.
-  useCapture: false
+  useCapture: false,
+
+  // The default padding if collision happens. Set "false" if no collision prevention needed 
+  overflowPadding: 5 
 }
 ```
 

package/addon/components/attach-popover.js

@@ -7,7 +7,7 @@ import { htmlSafe, isHTMLSafe } from '@ember/template';
 import { stripInProduction } from 'ember-attacher/-debug/helpers';
 import { warn, assert } from '@ember/debug';
 import { isEmpty, typeOf } from '@ember/utils';
-import { autoUpdate, computePosition, arrow, flip } from '@floating-ui/dom';
+import { autoUpdate, computePosition, arrow, flip, limitShift, shift } from '@floating-ui/dom';
 import { buildWaiter } from '@ember/test-waiters';
 import { tracked } from '@glimmer/tracking';
 import DEFAULTS from '../defaults';
@@ -62,7 +62,7 @@ export default class AttachPopover extends Component {
   }
 
   get isOffset() {
-    return this.args.isOffset ?? this._config.isOffset ?? DEFAULTS.interactive;
+    return this.args.isOffset ?? this._config.isOffset ?? DEFAULTS.isOffset;
   }
 
   get isShown() {
@@ -129,6 +129,10 @@ export default class AttachPopover extends Component {
     return this.args.id || `${guidFor(this)}-floating`;
   }
 
+  get overflowPadding() {
+    return this.args.overflowPadding ?? this._config.overflowPadding ?? DEFAULTS.overflowPadding;
+  }
+
   // The circle element needs a special duration that is slightly faster than the floating element's
   // transition, this prevents text from appearing outside the circle as it fills the background
   get _circleTransitionDuration() {
@@ -180,12 +184,7 @@ export default class AttachPopover extends Component {
 
   get _middleware() {
     // Copy the middleware since we might write to the provided array
-    const middleware
-      = this.args.middleware ? [...this.args.middleware] : [];
-
-    if (this.arrow && this._arrowElement && !middleware.find(name => name === 'arrow')) {
-      middleware.push(arrow({ element: this._arrowElement }));
-    }
+    const middleware = this.args.middleware ? [...this.args.middleware] : [];
 
     const flipString = this.flip;
     if (flipString) {
@@ -196,6 +195,16 @@ export default class AttachPopover extends Component {
       } else if (!flipMiddleware.fallbackPlacements) {
         Object.assign({}, flipMiddleware, flipOptions);
       }
+    } else if (this.overflowPadding !== false) {
+      middleware.push(flip());
+    }
+
+    if (this.overflowPadding !== false && !middleware.find(name => name === 'shift')) {
+      middleware.push(shift({ limiter: limitShift(), padding: this.overflowPadding }))
+    }
+
+    if (this.arrow && this._arrowElement && !middleware.find(name => name === 'arrow')) {
+      middleware.push(arrow({ element: this._arrowElement }));
     }
 
     return middleware;

package/addon/defaults.js

@@ -20,5 +20,6 @@ export default {
   showOn: 'mouseenter focus',
   style: null,
   tooltipClass: 'ember-attacher-floating ember-attacher-tooltip',
-  useCapture: false
+  useCapture: false,
+  overflowPadding: 5
 };

package/addon/templates/components/attach-popover.hbs

@@ -2,8 +2,8 @@
   <meta hidden {{did-insert this.onParentFinderInsert}} {{did-update this.onIsShownChange this.isShown}}/>
 {{~/unless~}}
 
-{{~#if this.renderFloatingElement}}
-  {{~#maybe-in-element destinationElement=this._floatingElementContainer renderInPlace=@renderInPlace}}
+{{~#if this.renderFloatingElement~}}
+  <MaybeInElement @destinationElement={{this._floatingElementContainer}} @renderInPlace={{@renderInPlace}}>
     <div
       class="ember-attacher"
       id={{this.id}}
@@ -25,5 +25,5 @@
         {{/if}}
       </div>
     </div>
-  {{~/maybe-in-element}}
+  </MaybeInElement>
 {{~/if~}}

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "ember-attacher",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Tooltips and popovers for Ember.js apps",
   "keywords": [
     "ember-addon",
     "tooltips",
     "popovers"
   ],
-  "repository": "https://github.com/kybishop/ember-attacher",
+  "repository": "https://github.com/tylerturdenpants/ember-attacher",
   "license": "MIT",
   "author": {
     "name": "Kyle Bishop",
@@ -33,10 +33,11 @@
     "babel-plugin-filter-imports": "^4.0.0",
     "broccoli-funnel": "~3.0.8",
     "ember-auto-import": "~2.6.3",
-    "ember-cli-babel": "^7.26.10",
+    "ember-cli-babel": "^7.26.11",
     "ember-cli-htmlbars": "~6.2.0",
     "ember-cli-sass": "~11.0.1",
     "ember-in-element-polyfill": "~1.0.1",
+    "ember-maybe-in-element": "2.0.3",
     "sass": "^1.62.1"
   },
   "devDependencies": {
@@ -47,25 +48,22 @@
     "@ember/string": "^3.0.1",
     "@ember/test-helpers": "~2.9.3",
     "@ember/test-waiters": "^3.0.2",
-    "@glimmer/component": "^1.0.0",
-    "@glimmer/tracking": "^1.0.0",
+    "@embroider/test-setup": "^2.1.1",
+    "@glimmer/component": "^1.1.2",
+    "@glimmer/tracking": "^1.1.2",
     "@html-next/flexi-default-styles": "^2.2.0",
     "@release-it-plugins/lerna-changelog": "^5.0.0",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-cli": "~3.28.5",
+    "ember-cli": "~4.12.1",
     "ember-cli-dependency-checker": "~3.3.1",
     "ember-cli-github-pages": "^0.2.2",
-    "ember-cli-inject-live-reload": "^2.0.2",
+    "ember-cli-inject-live-reload": "~2.1.0",
     "ember-cli-sri": "^2.1.1",
     "ember-cli-terser": "^4.0.2",
-    "ember-disable-prototype-extensions": "^1.1.3",
-    "ember-export-application-global": "^2.0.1",
     "ember-load-initializers": "^2.1.2",
-    "ember-maybe-import-regenerator": "^1.0.0",
-    "ember-maybe-in-element": "^2.1.0",
     "ember-qunit": "^6.2.0",
     "ember-resolver": "~10.0.0",
-    "ember-source": "~3.28.11",
+    "ember-source": "~4.12.0",
     "ember-source-channel-url": "^3.0.0",
     "ember-svg-jar": "~2.4.2",
     "ember-truth-helpers": "^3.1.1",
@@ -73,7 +71,7 @@
     "eslint": "~8.40.0",
     "eslint-plugin-decorator-position": "^5.0.2",
     "eslint-plugin-ember": "~11.5.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "flexi": "^2.1.0",
     "loader.js": "^4.7.0",
     "qunit": "~2.19.4",
@@ -85,7 +83,7 @@
     "ember-in-element-polyfill": "^1.0.1"
   },
   "engines": {
-    "node": ">= 12.*"
+    "node": "14.* || 16.* || >= 18"
   },
   "ember": {
     "edition": "octane"

package/.github/ISSUE_TEMPLATE.md

@@ -1,3 +0,0 @@
-Thank you for taking the time to open an issue!
-
-For non-obvious bugs, please alter [this twiddle](https://ember-twiddle.com/26aef5ea692f75105cfda90949dd3f7d?openFiles=templates.application.hbs%2C) to reproduce the issue, then include a link.

package/.github/dependabot.yml

@@ -1,71 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: npm
-  directory: "/"
-  schedule:
-    interval: daily
-    time: "10:00"
-  open-pull-requests-limit: 10
-  versioning-strategy: increase
-  ignore:
-  - dependency-name: sass
-    versions:
-    - 1.32.10
-    - 1.32.11
-    - 1.32.7
-    - 1.32.8
-  - dependency-name: eslint-plugin-ember
-    versions:
-    - 10.1.2
-    - 10.2.0
-    - 10.3.0
-    - 10.4.1
-  - dependency-name: ember-cli
-    versions:
-    - 3.25.0
-    - 3.25.1
-    - 3.25.2
-    - 3.25.3
-    - 3.26.0
-  - dependency-name: eslint
-    versions:
-    - 7.20.0
-    - 7.21.0
-    - 7.22.0
-    - 7.23.0
-    - 7.24.0
-  - dependency-name: release-it
-    versions:
-    - 14.4.0
-    - 14.4.1
-    - 14.5.0
-    - 14.5.1
-    - 14.6.0
-  - dependency-name: y18n
-    versions:
-    - 4.0.1
-    - 4.0.2
-  - dependency-name: ember-cli-babel
-    versions:
-    - 7.25.0
-    - 7.26.1
-    - 7.26.2
-    - 7.26.3
-  - dependency-name: ember-source
-    versions:
-    - 3.25.0
-    - 3.25.1
-    - 3.25.3
-    - 3.26.0
-  - dependency-name: ember-cli-htmlbars
-    versions:
-    - 5.3.2
-    - 5.4.0
-    - 5.6.0
-    - 5.6.2
-    - 5.6.3
-    - 5.6.4
-    - 5.6.5
-    - 5.7.0
-  commit-message:
-    prefix: "[chore]"

package/.github/workflows/ci.yml

@@ -1,221 +0,0 @@
-# This file was autogenerated by create-github-actions-setup-for-ember-addons.
-#
-# You can upgrade the GitHub Actions workflow to the latest blueprints used
-# by Create GitHub Actions setup for Ember Addons by running it again:
-#
-# - `yarn create github-actions-setup-for-ember-addons` if using yarn and
-# - `npm init github-actions-setup-for-ember-addons` if using NPM.
-#
-# See https://github.com/jelhan/create-github-actions-setup-for-ember-addon for
-# details.
-#
-# The following lines contain the configuration used in the last run. Please do
-# not change them. Doing so could break upgrade flow.
-#
-#$ browsers:
-#$   - Chrome
-#$ emberTryScenarios:
-#$   - scenario: ember-lts-3.12
-#$   - scenario: ember-lts-3.16
-#$   - scenario: ember-lts-3.20
-#$   - scenario: ember-release
-#$   - scenario: ember-beta
-#$   - scenario: ember-canary
-#$     allowedToFail: true
-#$   - scenario: ember-default
-#$   - scenario: ember-default-with-jquery
-#$ nodeVersion: '10'
-#$ packageManager: yarn
-#
-
-name: CI
-
-on:
-  push:
-    branches:
-      - master
-  pull_request:
-
-env:
-  NODE_VERSION: '14'
-
-jobs:
-  lint:
-    name: Lint
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-      with:
-        fetch-depth: 1
-
-    - uses: actions/setup-node@v2-beta
-      with:
-        node-version: '${{ env.NODE_VERSION }}'
-
-    - name: Get package manager's global cache path
-      id: global-cache-dir-path
-      run: echo "::set-output name=dir::$(yarn cache dir)"
-
-    - name: Cache package manager's global cache and node_modules
-      id: cache-dependencies
-      uses: actions/cache@v2
-      with:
-        path: |
-          ${{ steps.global-cache-dir-path.outputs.dir }}
-          node_modules
-        key: ${{ runner.os }}-${{ matrix.node-version }}-${{
-          hashFiles('**/yarn.lock'
-          ) }}
-        restore-keys: |
-          ${{ runner.os }}-${{ matrix.node-version }}-
-
-    - name: Install Dependencies
-      run: yarn install --frozen-lockfile
-      if: |
-        steps.cache-dependencies.outputs.cache-hit != 'true'
-
-    - name: Lint
-      run: yarn lint
-
-
-  test:
-    name: Tests
-    runs-on: ${{ matrix.os }}
-    needs: lint
-
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-        browser: [Chrome]
-
-    steps:
-    - uses: actions/checkout@v2
-      with:
-        fetch-depth: 1
-
-    - uses: actions/setup-node@v2-beta
-      with:
-        node-version: '${{ env.NODE_VERSION }}'
-
-    - name: Get package manager's global cache path
-      id: global-cache-dir-path
-      run: echo "::set-output name=dir::$(yarn cache dir)"
-
-    - name: Cache package manager's global cache and node_modules
-      id: cache-dependencies
-      uses: actions/cache@v2
-      with:
-        path: |
-          ${{ steps.global-cache-dir-path.outputs.dir }}
-          node_modules
-        key: ${{ runner.os }}-${{ matrix.node-version }}-${{
-          hashFiles('**/yarn.lock'
-          ) }}
-        restore-keys: |
-          ${{ runner.os }}-${{ matrix.node-version }}-
-
-    - name: Install Dependencies
-      run: yarn install --frozen-lockfile
-      if: |
-        steps.cache-dependencies.outputs.cache-hit != 'true'
-
-    - name: Test
-      run: yarn test --launch ${{ matrix.browser }}
-      timeout-minutes: 5
-
-
-  floating-dependencies:
-    name: Floating Dependencies
-    runs-on: ${{ matrix.os }}
-    needs: lint
-
-    strategy:
-      matrix:
-        os: [ubuntu-latest]
-        browser: [Chrome]
-
-    steps:
-    - uses: actions/checkout@v2
-      with:
-        fetch-depth: 1
-
-    - uses: actions/setup-node@v2-beta
-      with:
-        node-version: '${{ env.NODE_VERSION }}'
-
-    - name: Get package manager's global cache path
-      id: global-cache-dir-path
-      run: echo "::set-output name=dir::$(yarn cache dir)"
-
-    - name: Cache package manager's global cache and node_modules
-      id: cache-dependencies
-      uses: actions/cache@v2
-      with:
-        path: |
-          ${{ steps.global-cache-dir-path.outputs.dir }}
-          node_modules
-        key: ${{ runner.os }}-${{ matrix.node-version }}-floating-deps
-        restore-keys: |
-          ${{ runner.os }}-${{ matrix.node-version }}-
-
-    - name: Install Dependencies
-      run: yarn install --no-lockfile --non-interactive
-
-    - name: Test
-      run: yarn test --launch ${{ matrix.browser }}
-      timeout-minutes: 5
-
-
-  try-scenarios:
-    name: Tests - ${{ matrix.ember-try-scenario }}
-    runs-on: ubuntu-latest
-    continue-on-error: true
-    needs: test
-
-    strategy:
-      fail-fast: true
-      matrix:
-        ember-try-scenario: [
-          ember-lts-3.16,
-          ember-lts-3.20,
-          ember-lts-3.26,
-          ember-release,
-          ember-default,
-          ember-default-with-jquery
-        ]
-
-    steps:
-    - uses: actions/checkout@v2
-      with:
-        fetch-depth: 1
-
-    - uses: actions/setup-node@v2-beta
-      with:
-        node-version: '${{ env.NODE_VERSION }}'
-
-    - name: Get package manager's global cache path
-      id: global-cache-dir-path
-      run: echo "::set-output name=dir::$(yarn cache dir)"
-
-    - name: Cache package manager's global cache and node_modules
-      id: cache-dependencies
-      uses: actions/cache@v2
-      with:
-        path: |
-          ${{ steps.global-cache-dir-path.outputs.dir }}
-          node_modules
-        key: ${{ runner.os }}-${{ matrix.node-version }}-${{
-          hashFiles('**/yarn.lock'
-          ) }}
-        restore-keys: |
-          ${{ runner.os }}-${{ matrix.node-version }}-
-
-    - name: Install Dependencies
-      run: yarn install --frozen-lockfile
-      if: |
-        steps.cache-dependencies.outputs.cache-hit != 'true'
-
-    - name: Test
-      env:
-        EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
-      run: node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

package/config/dependency-lint.js

@@ -1,5 +0,0 @@
-'use strict';
-
-module.exports = {
-
-};

package/config/environment.js

@@ -1,6 +0,0 @@
-/* eslint-env node */
-'use strict';
-
-module.exports = function(/* environment, appConfig */) {
-  return { };
-};