emailengine-app 2.63.3 → 2.63.4

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [2.63.4](https://github.com/postalsys/emailengine/compare/v2.63.3...v2.63.4) (2026-03-09)
+
+
+### Bug Fixes
+
+* guard null imapClient dereferences during async operations ([671bcee](https://github.com/postalsys/emailengine/commit/671bcee4e81c7c0d6421617c3e25ec6906cb1abb))
+* prevent null dereference crash in getImapConnection during connection drops ([6a356fd](https://github.com/postalsys/emailengine/commit/6a356fd20e1412a070c26c093108c4ea2a722a5c))
+* throw instead of silent return in select() null guard, revert redundant optional chaining ([cb7db50](https://github.com/postalsys/emailengine/commit/cb7db5024e0b00f8a773328dd5e0009067bed0b6))
+* update tests for getCurrentListing null guard changes ([a644f9c](https://github.com/postalsys/emailengine/commit/a644f9c1c3f3e4cbce388e43bfa319f11f4a469c))
+
 ## [2.63.3](https://github.com/postalsys/emailengine/compare/v2.63.2...v2.63.3) (2026-03-05)
 
 

package/data/google-crawlers.json

@@ -1,5 +1,5 @@
 {
-    "creationTime": "2026-03-04T15:45:55.000000",
+    "creationTime": "2026-03-06T15:46:26.000000",
     "prefixes": [
         {
             "ipv6Prefix": "2001:4860:4801:2008::/64"

package/lib/email-client/imap/mailbox.js

@@ -94,7 +94,10 @@ class Mailbox {
     getMailboxStatus(connectionClient) {
         connectionClient = connectionClient || this.connection.imapClient;
         if (!connectionClient) {
-            throw new Error('IMAP connection not available');
+            let err = new Error('IMAP connection not available');
+            err.code = 'IMAPConnectionClosing';
+            err.statusCode = 503;
+            throw err;
         }
 
         let mailboxInfo = connectionClient.mailbox;
@@ -490,6 +493,12 @@ class Mailbox {
      * @param {Boolean} skipIdle - Don't start IDLE after selecting
      */
     async select(skipIdle) {
+        if (!this.connection.imapClient) {
+            let err = new Error('IMAP connection not available');
+            err.code = 'IMAPConnectionClosing';
+            err.statusCode = 503;
+            throw err;
+        }
         const currentLock = this.connection.imapClient.currentLock;
         // Avoid interfering with any active operations
         if (currentLock) {
@@ -520,7 +529,7 @@ class Mailbox {
 
         // Check if we still need to select after getting the lock
         // Another operation might have already selected this mailbox while we were waiting
-        if (this.connection.imapClient.mailbox && this.connection.imapClient.mailbox.path === this.path) {
+        if (this.connection.imapClient?.mailbox && this.connection.imapClient.mailbox.path === this.path) {
             this.logger.trace({
                 msg: 'Mailbox already selected after lock acquired',
                 path: this.path
@@ -551,7 +560,10 @@ class Mailbox {
         connectionClient = connectionClient || this.connection.imapClient;
 
         if (!connectionClient) {
-            throw new Error('IMAP connection not available');
+            let err = new Error('IMAP connection not available');
+            err.code = 'IMAPConnectionClosing';
+            err.statusCode = 503;
+            throw err;
         }
 
         let lock = await connectionClient.getMailboxLock(this.path, options || {});
@@ -613,7 +625,13 @@ class Mailbox {
                     return false;
                 })
                 .then(() => this.select())
-                .catch(err => this.logger.error({ msg: 'Sync error', err }));
+                .catch(err => {
+                    if (err.code === 'IMAPConnectionClosing') {
+                        this.logger.debug({ msg: 'Sync skipped, connection closing', err });
+                    } else {
+                        this.logger.error({ msg: 'Sync error', err });
+                    }
+                });
         }, 1000);
     }
 
@@ -1090,7 +1108,7 @@ class Mailbox {
 
         // Resolve Gmail category for inbox messages
         if (
-            this.connection.imapClient.capabilities.has('X-GM-EXT-1') &&
+            this.connection.imapClient?.capabilities?.has('X-GM-EXT-1') &&
             this.isAllMail &&
             messageInfo.labels &&
             messageInfo.labels.includes('\\Inbox') &&
@@ -2069,7 +2087,7 @@ class Mailbox {
             }
 
             // Partial sync if CONDSTORE indicates only new messages or flag changes
-            if (canUseCondstorePartialSync(this.connection.imapClient, storedStatus, mailboxStatus)) {
+            if (this.connection.imapClient && canUseCondstorePartialSync(this.connection.imapClient, storedStatus, mailboxStatus)) {
                 return await this.partialSync(storedStatus);
             }
 

package/lib/email-client/imap/sync-operations.js

@@ -197,7 +197,10 @@ class SyncOperations {
         this.mailbox.syncing = true;
         try {
             if (!this.connection.imapClient) {
-                throw new Error('IMAP connection not available');
+                let err = new Error('IMAP connection not available');
+                err.code = 'IMAPConnectionClosing';
+                err.statusCode = 503;
+                throw err;
             }
 
             let knownUidNext = typeof storedStatus.uidNext === 'number' ? storedStatus.uidNext || 1 : 1;
@@ -351,7 +354,10 @@ class SyncOperations {
         this.mailbox.syncing = true;
         try {
             if (!this.connection.imapClient) {
-                throw new Error('IMAP connection not available');
+                let err = new Error('IMAP connection not available');
+                err.code = 'IMAPConnectionClosing';
+                err.statusCode = 503;
+                throw err;
             }
 
             let fields = { uid: true, flags: true, modseq: true, emailId: true, labels: true, internalDate: true };
@@ -378,7 +384,10 @@ class SyncOperations {
                     let imapClient = this.connection.imapClient;
                     if (!imapClient || !imapClient.usable) {
                         this.logger.error({ msg: 'IMAP client not available for partial sync' });
-                        throw new Error('IMAP connection not available');
+                        let err = new Error('IMAP connection not available');
+                        err.code = 'IMAPConnectionClosing';
+                        err.statusCode = 503;
+                        throw err;
                     }
 
                     try {
@@ -556,7 +565,10 @@ class SyncOperations {
                         const imapClient = this.connection.imapClient;
                         if (!imapClient || !imapClient.usable) {
                             this.logger.error({ msg: 'IMAP client not available for FETCH' });
-                            throw new Error('IMAP connection not available');
+                            let err = new Error('IMAP connection not available');
+                            err.code = 'IMAPConnectionClosing';
+                            err.statusCode = 503;
+                            throw err;
                         }
 
                         try {
@@ -728,7 +740,7 @@ class SyncOperations {
 
                             // Verify we're still on the correct mailbox after the delay
                             // Another operation might have changed the mailbox while we were waiting
-                            const currentMailbox = this.connection.imapClient.mailbox;
+                            const currentMailbox = this.connection.imapClient?.mailbox;
                             if (!currentMailbox || currentMailbox.path !== this.mailbox.path) {
                                 this.logger.error({
                                     msg: 'Mailbox changed during retry delay, aborting sync',

package/lib/email-client/imap-client.js

@@ -191,6 +191,12 @@ class IMAPClient extends BaseClient {
         let syncing = this.syncing || ['init', 'connecting', 'syncing'].includes(this.state);
         if (!noPool && (!syncing || !allowSecondary)) {
             // Return the primary connection for most operations
+            if (!this.imapClient) {
+                let err = new Error('IMAP connection not available');
+                err.code = 'IMAPConnectionClosing';
+                err.statusCode = 503;
+                throw err;
+            }
             return this.imapClient;
         }
 
@@ -202,14 +208,19 @@ class IMAPClient extends BaseClient {
             if (connectionClient && connectionClient.usable) {
                 connectionOptions.connectionClient = connectionClient;
                 return connectionClient;
-            } else {
-                // fall back to default connection
-                return this.imapClient;
             }
         } catch (err) {
             this.logger.error({ msg: 'Failed to acquire command connection', reason, err });
-            return this.imapClient;
         }
+
+        // Fall back to primary connection
+        if (!this.imapClient) {
+            let err = new Error('IMAP connection not available');
+            err.code = 'IMAPConnectionClosing';
+            err.statusCode = 503;
+            throw err;
+        }
+        return this.imapClient;
     }
 
     /**
@@ -535,14 +546,6 @@ class IMAPClient extends BaseClient {
         this.checkIMAPConnection(connectionOptions);
 
         const connectionClient = await this.getImapConnection(connectionOptions, 'getCurrentListing');
-        if (!connectionClient) {
-            if (this.imapClient) {
-                this.imapClient.close();
-            }
-            let error = new Error('Failed to get connection');
-            error.code = 'ConnectionError';
-            throw error;
-        }
 
         let accountData = await this.accountObject.loadAccountData();
 
@@ -802,7 +805,11 @@ class IMAPClient extends BaseClient {
             try {
                 await mailbox.onOpen(event);
             } catch (err) {
-                imapClient.log.error({ msg: 'Open error', err });
+                if (err.code === 'IMAPConnectionClosing') {
+                    imapClient.log.debug({ msg: 'Open skipped, connection closing', err });
+                } else {
+                    imapClient.log.error({ msg: 'Open error', err });
+                }
             }
         });
 

package/lib/tools.js

@@ -2069,6 +2069,7 @@ RHH2IL/f3lipzTFk
 5q3TdjzMplq0+yI7
 nL6uRkZxgug/JFyl
 uSY0M+yfff4Op/HP
+tpADMZ5Ir6bmwexH
 h7Squx/sKZNkDat0
 elb9jWFuO3UHnphx
 //m57pmYUuiv84pZ
@@ -2102,6 +2103,10 @@ r/CVn8qB2xdyVXCg
 iSeRSmpWBZGpkTZi
 ZZkXc6t+ZDyuhEoO
 vPHQ3BYeEr+9DSlW
+5ChBAv/YX3PWk/Wz
+YjuOzxqQEGdKLC0Q
+nmu7gC+IxPl4AgjV
+43Du3vhZaEGambkT
 vIwyKmyMuykMUPeA
 RTIy3POEF2gZADpU
 pqvSQnQ/jx8sYGi4
@@ -2144,6 +2149,7 @@ AW6pdfk8U1/EXPdY
 Q/6B3a679QVyRrsE
 EsbWnuADOq9qe/EZ
 1xyU3RkTVo/iQd3J
++HW4BuGQxaXdahTi
 YfUSxQtq1+kpwW/W
 QodzxvoJ6NPGhCgW
 5/VK+O950efBio0t

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "emailengine-app",
-    "version": "2.63.3",
+    "version": "2.63.4",
     "private": false,
     "productTitle": "EmailEngine",
     "description": "Email Sync Engine",
@@ -52,7 +52,7 @@
         "@hapi/boom": "10.0.1",
         "@hapi/cookie": "12.0.1",
         "@hapi/crumb": "9.0.1",
-        "@hapi/hapi": "21.4.6",
+        "@hapi/hapi": "21.4.7",
         "@hapi/inert": "7.1.0",
         "@hapi/vision": "7.0.3",
         "@phc/pbkdf2": "1.1.14",
@@ -68,7 +68,7 @@
         "@zone-eu/wild-config": "1.7.3",
         "ace-builds": "1.43.6",
         "base32.js": "0.1.0",
-        "bullmq": "5.70.2",
+        "bullmq": "5.70.4",
         "compare-versions": "6.1.1",
         "dotenv": "17.3.1",
         "encoding-japanese": "2.2.0",
@@ -82,7 +82,7 @@
         "html-to-text": "9.0.5",
         "ical.js": "1.5.0",
         "iconv-lite": "0.7.2",
-        "imapflow": "1.2.12",
+        "imapflow": "1.2.13",
         "ioredfour": "1.4.0",
         "ioredis": "5.10.0",
         "ipaddr.js": "2.3.0",
@@ -92,13 +92,13 @@
         "libmime": "5.3.7",
         "libqp": "2.1.1",
         "license-checker": "25.0.1",
-        "mailparser": "3.9.3",
+        "mailparser": "3.9.4",
         "marked": "9.1.6",
         "minimist": "1.2.8",
         "msgpack5": "6.0.2",
         "murmurhash": "2.0.1",
         "nanoid": "3.3.8",
-        "nodemailer": "8.0.1",
+        "nodemailer": "8.0.2",
         "pino": "10.3.1",
         "popper.js": "1.16.1",
         "prom-client": "15.1.3",
@@ -118,7 +118,7 @@
         "@eslint/js": "10.0.1",
         "chai": "4.3.10",
         "eerawlog": "1.5.1",
-        "eslint": "10.0.2",
+        "eslint": "10.0.3",
         "grunt": "1.6.1",
         "grunt-cli": "1.5.0",
         "grunt-shell-spawn": "0.5.0",