elsabro 7.4.0 → 7.5.0

package/README.md

@@ -1,4 +1,4 @@
-# ELSABRO v7.4.0
+# ELSABRO v7.5.0
 
 **Tu asistente AI para crear apps increibles** — Orquestacion de agentes con flow engine, checkpointing, ejecucion paralela y skill auto-discovery.
 
@@ -338,6 +338,7 @@ rm -rf .elsabro .planning
 
 | Version | Milestone | Cambio Principal |
 |---------|-----------|-----------------|
+| 7.5.0 | M7+ | Skill gate enforcement, 5-layer enforcement, Agent Teams review, plan verification gate |
 | 7.4.0 | M7+ | Skill invocation protocol, review gate enforcement, auto-sync hook, 47 nodos, 399 tests |
 | 7.3.2 | M7 | Validation errors/warnings separation, case-insensitive hasCriticalIssues |
 | 7.3.1 | M7 | PR #1: 23 critical fixes, skill auto-install hooks, deprecated teams bypass |

package/bin/install.js

@@ -422,6 +422,77 @@ async function install() {
     }
   }
 
+  // Install review-gate hooks in settings.json
+  // These hooks enforce code review before git commit/push
+  if (!settings.hooks) {
+    settings.hooks = {};
+  }
+
+  // PostToolUse: Set review-pending flag when code is modified
+  const reviewGateSetHook = {
+    type: 'command',
+    command: 'input=$(cat); file=$(echo "$input" | jq -r \'.tool_input.file_path // "unknown"\' 2>/dev/null); if [ -f "$CLAUDE_PROJECT_DIR/hooks/review-gate.sh" ]; then bash "$CLAUDE_PROJECT_DIR/hooks/review-gate.sh" set "$file" 2>/dev/null; fi; exit 0'
+  };
+
+  // PreToolUse: Block git commit/push if review is pending
+  const reviewGateCheckHook = {
+    type: 'command',
+    command: 'input=$(cat); cmd=$(echo "$input" | jq -r \'.tool_input.command // ""\' 2>/dev/null); if echo "$cmd" | grep -qE \'git commit|git push\'; then if [ -f "$CLAUDE_PROJECT_DIR/hooks/review-gate.sh" ]; then bash "$CLAUDE_PROJECT_DIR/hooks/review-gate.sh" check; exit $?; fi; fi; exit 0'
+  };
+
+  // Merge PostToolUse hooks: remove any stale review-gate entries, then add correct one
+  if (!settings.hooks.PostToolUse || !Array.isArray(settings.hooks.PostToolUse)) {
+    settings.hooks.PostToolUse = [];
+  }
+  // Remove existing review-gate entries (any matcher) to avoid duplicates
+  const prevPostCount = settings.hooks.PostToolUse.length;
+  settings.hooks.PostToolUse = settings.hooks.PostToolUse.filter(entry =>
+    !(entry.hooks && entry.hooks.some(h => h.command && h.command.includes('review-gate.sh')))
+  );
+  // Add canonical review-gate entry with correct matcher
+  settings.hooks.PostToolUse.push({
+    matcher: 'Write|Edit',
+    hooks: [reviewGateSetHook]
+  });
+  const verb1 = prevPostCount > settings.hooks.PostToolUse.length ? 'actualizado' : 'instalado';
+  console.log(`  ${green}✓${reset} Review gate (PostToolUse) ${verb1}`);
+
+  // Merge PreToolUse hooks: remove any stale review-gate entries, then add correct one
+  if (!settings.hooks.PreToolUse || !Array.isArray(settings.hooks.PreToolUse)) {
+    settings.hooks.PreToolUse = [];
+  }
+  // Remove existing review-gate entries (any matcher) to avoid duplicates
+  const prevPreCount = settings.hooks.PreToolUse.length;
+  settings.hooks.PreToolUse = settings.hooks.PreToolUse.filter(entry =>
+    !(entry.hooks && entry.hooks.some(h => h.command && h.command.includes('review-gate.sh')))
+  );
+  // Add canonical review-gate entry with correct matcher and exit $? fix
+  settings.hooks.PreToolUse.push({
+    matcher: 'Bash',
+    hooks: [reviewGateCheckHook]
+  });
+  const verb2 = prevPreCount > settings.hooks.PreToolUse.length ? 'actualizado' : 'instalado';
+  console.log(`  ${green}✓${reset} Review gate (PreToolUse) ${verb2}`);
+
+  // Install skill-gate hooks in settings.json
+  // These hooks enforce skill discovery before code changes (only when ELSABRO mode is active)
+  const skillGateCheckHook = {
+    type: 'command',
+    command: 'if [ -f "$CLAUDE_PROJECT_DIR/hooks/skill-gate.sh" ]; then bash "$CLAUDE_PROJECT_DIR/hooks/skill-gate.sh" check; exit $?; fi; exit 0'
+  };
+
+  // Merge PreToolUse hooks for skill-gate: remove stale entries, then add correct one
+  const prevSkillGateCount = settings.hooks.PreToolUse.length;
+  settings.hooks.PreToolUse = settings.hooks.PreToolUse.filter(entry =>
+    !(entry.hooks && entry.hooks.some(h => h.command && h.command.includes('skill-gate.sh')))
+  );
+  settings.hooks.PreToolUse.push({
+    matcher: 'Write|Edit',
+    hooks: [skillGateCheckHook]
+  });
+  const verb3 = prevSkillGateCount > settings.hooks.PreToolUse.length ? 'actualizado' : 'instalado';
+  console.log(`  ${green}✓${reset} Skill gate (PreToolUse) ${verb3}`);
+
   // Add version tracking
   settings.elsabro = {
     version: pkg.version,

package/commands/elsabro/debug.md

@@ -10,6 +10,9 @@ allowed-tools:
   - Grep
   - WebSearch
   - Task
+  - TeamCreate
+  - TeamDelete
+  - SendMessage
   - AskUserQuestion
   - mcp__plugin_context7_context7__*
 argument-hint: "[descripción del problema]"
@@ -133,25 +136,51 @@ El debugger actualizará el archivo de sesión con:
 - Fix implementado
 - Verificación realizada
 
-## Paso 5: Code Review (OBLIGATORIO)
+## Paso 5: Code Review (OBLIGATORIO - Agent Teams LITE)
 
-**REGLA:** Después de implementar cualquier fix, SIEMPRE ejecutar code review antes de reportar al usuario.
-
-```
-Task(pr-review-toolkit:code-reviewer):
-  Revisa los cambios del fix aplicado.
-  Busca bugs, code smells, seguridad.
-  Archivos modificados: [lista de archivos cambiados]
-```
-
-Si el review encuentra issues, corregir ANTES de reportar al usuario.
+**REGLA:** Después de implementar cualquier fix, SIEMPRE ejecutar code review con Agent Teams antes de reportar al usuario.
 
 ```javascript
+// Crear team de review LITE (3 agentes esenciales)
+TeamCreate({ team_name: "elsabro-review-lite", description: "Quick review - 3 agentes especializados" })
+
+// Lanzar 3 teammates en paralelo (UN SOLO MENSAJE)
+Task({
+  subagent_type: "pr-review-toolkit:code-reviewer",
+  team_name: "elsabro-review-lite",
+  name: "quality-reviewer",
+  model: "sonnet",
+  prompt: "Review code quality of the fix: bugs, code smells, naming, patterns. Focus on modified files. DO NOT ask questions."
+})
+Task({
+  subagent_type: "pr-review-toolkit:silent-failure-hunter",
+  team_name: "elsabro-review-lite",
+  name: "failure-hunter",
+  model: "sonnet",
+  prompt: "Review fix for silent failures, error handling gaps, dangerous fallbacks. Focus on modified files. DO NOT ask questions."
+})
+Task({
+  subagent_type: "pr-review-toolkit:pr-test-analyzer",
+  team_name: "elsabro-review-lite",
+  name: "test-analyzer",
+  model: "sonnet",
+  prompt: "Analyze test coverage for the fix: edge cases, regression tests needed. Focus on modified files. DO NOT ask questions."
+})
+
+// Consolidar hallazgos. Si issues criticos > 0: fix y re-review
+// Shutdown team
+for (const name of ["quality-reviewer", "failure-hunter", "test-analyzer"]) {
+  SendMessage({ type: "shutdown_request", recipient: name, content: "Review complete" })
+}
+TeamDelete()
+
 // MARCAR: code review pasó (para code_review_gate en siguiente_paso)
 state.current_flow.code_review_passed = true;
 Write(".elsabro/state.json", JSON.stringify(state, null, 2));
 ```
 
+Si alguno de los 3 reviewers encuentra issues criticos, corregir y re-review ANTES de reportar al usuario.
+
 ## Paso 6: Verificar con Usuario
 
 Una vez el debugger reporta fix:
@@ -177,18 +206,27 @@ Para verificar:
 ```
 ¿Se implementó un fix (modo find_and_fix)?
 │
-├─ SÍ → ¿Se ejecutó code review (Paso 5)?
+├─ SÍ → ¿Se ejecutó code review con Agent Teams LITE (Paso 5)?
 │    │
 │    ├─ NO → EJECUTAR AHORA:
-│    │   Task(pr-review-toolkit:code-reviewer)
-│    │   Si issues > 0: fix y re-review
-│    │   Solo cuando issues == 0: continuar
+│    │   TeamCreate("elsabro-review-lite")
+│    │   + 3 teammates: quality-reviewer, failure-hunter, test-analyzer
+│    │   Consolidar hallazgos
+│    │   Si issues criticos > 0: fix y re-review
+│    │   Solo cuando issues == 0: shutdown + TeamDelete + continuar
 │    │
-│    └─ SÍ, issues == 0 → Continuar
+│    └─ SÍ, issues == 0, team deleted → Continuar
 │
 └─ NO (solo find_root_cause_only) → Continuar (no aplica)
 ```
 
+**Agent Teams LITE — 3 Reviewers:**
+| Teammate | Plugin | Foco |
+|----------|--------|------|
+| quality-reviewer | pr-review-toolkit:code-reviewer | bugs, patterns, naming |
+| failure-hunter | pr-review-toolkit:silent-failure-hunter | error handling, fallbacks |
+| test-analyzer | pr-review-toolkit:pr-test-analyzer | coverage, edge cases |
+
 **VIOLACIÓN CRÍTICA**: Reportar fix sin code review = ABORTAR OPERACIÓN
 </code_review_gate>
 

package/commands/elsabro/execute.md

@@ -34,6 +34,78 @@ vive en el engine y en `flows/development-flow.json`. Este archivo solo define e
 Leer `.elsabro/state.json` siguiendo el protocolo de @references/state-sync.md.
 Verificar flujo en progreso. Actualizar phase a "stepping".
 
+### Skill Discovery Gate (OBLIGATORIO)
+
+Antes de cualquier otra accion, verificar que skill discovery fue ejecutado:
+
+```javascript
+// GATE: Verificar skill discovery antes de ejecutar
+const skillGateResult = Bash('bash hooks/skill-gate.sh status');
+const skillGate = JSON.parse(skillGateResult);
+
+if (skillGate.elsabro_active && !skillGate.done) {
+  // Skill discovery no ejecutado — ejecutar ahora
+  output("Ejecutando skill discovery antes de continuar...");
+  state.context = state.context || {};
+  try {
+    const discoveryResult = Bash(`bash ./hooks/skill-discovery.sh "${inputs.task || args}" "medium"`, { timeout: 30000 });
+    try {
+      state.context.available_skills = JSON.parse(discoveryResult).recommended || [];
+    } catch (e) {
+      output("Warning: skill-discovery devolvio JSON invalido, continuando sin skills");
+      state.context.available_skills = [];
+    }
+  } catch (e) {
+    output("Warning: skill-discovery fallo, continuando sin skills");
+    state.context.available_skills = [];
+  }
+  Write(".elsabro/state.json", JSON.stringify(state, null, 2));
+  Bash('bash hooks/skill-gate.sh set "execute"');
+}
+```
+
+### Plan Verification (OBLIGATORIO)
+
+Antes de ejecutar CUALQUIER codigo, verificar que existe un plan aprobado:
+
+```javascript
+// GATE: No ejecutar sin plan previo
+state.context = state.context || {};
+const planFile = state.context.plan_file;
+const hasPlan = planFile && fs.existsSync(planFile);
+const hasPlanInPlanning = fs.readdirSync('.planning/').some(f => f.endsWith('-PLAN.md'));
+
+if (!hasPlan && !hasPlanInPlanning) {
+  // No hay plan — forzar planificacion primero
+  output("⚠ No se encontro plan de implementacion.");
+  output("→ Ejecuta /elsabro:plan primero, o usa EnterPlanMode para crear un plan.");
+  output("→ ELSABRO requiere un plan aprobado antes de ejecutar codigo.");
+
+  // Ofrecer opciones al usuario
+  const answer = AskUserQuestion({
+    questions: [{
+      question: "No hay plan de implementacion. ¿Que deseas hacer?",
+      header: "Plan Check",
+      options: [
+        { label: "Crear plan ahora (Recomendado)", description: "Entra a plan mode para disenar la implementacion" },
+        { label: "Continuar sin plan", description: "Solo para tareas triviales - se registra como excepcion" }
+      ],
+      multiSelect: false
+    }]
+  });
+
+  if (answer.includes("Crear plan")) {
+    EnterPlanMode();
+    return; // Exit execute — se reanuda despues de aprobar plan
+  }
+
+  // Usuario eligio continuar sin plan — registrar excepcion
+  state.context.plan_skipped = true;
+  state.context.plan_skip_reason = "user_override";
+  Write(".elsabro/state.json", JSON.stringify(state, null, 2));
+}
+```
+
 ```bash
 FLOW="flows/development-flow.json"
 TASK="[descripcion de la tarea del usuario]"
@@ -548,15 +620,166 @@ Cuando el loop retorna `{ finished: true }`:
    - Establecer `suggested_next: "verify-work"`
 2. Actualizar `.elsabro/context.md` con resumen legible
 
+<code_review_gate>
+## 5.1. Code Review Gate (OBLIGATORIO - NO NEGOCIABLE)
+
+**ANTES de mostrar resultado o ofrecer commit, VERIFICAR:**
+
+```
+¿Se escribió/modificó código durante la ejecución?
+│
+├─ SÍ → ¿Se ejecutó code review (parallel_review node)?
+│    │
+│    ├─ NO → EJECUTAR AHORA con Agent Teams FULL (5 agentes):
+│    │   1. bash hooks/review-gate.sh set (si no esta activo)
+│    │   2. TeamCreate("elsabro-review") + 5 teammates especializados
+│    │   3. Consolidar hallazgos de los 5 reviewers
+│    │   4. Si issues criticos > 0: fix y re-review (max 3 iteraciones)
+│    │   5. Solo cuando issues criticos == 0: bash hooks/review-gate.sh clear
+│    │   6. SendMessage(shutdown_request) x5 + TeamDelete()
+│    │   7. Continuar
+│    │
+│    └─ SÍ, issues == 0, gate cleared → Continuar
+│
+└─ NO → Continuar (no aplica)
+```
+
+```javascript
+// Verificacion programatica del review gate
+const gateStatus = Bash("bash hooks/review-gate.sh status");
+const gate = JSON.parse(gateStatus);
+
+state.current_flow = state.current_flow || {};
+
+if (gate.pending) {
+  // Hay codigo modificado sin review — EJECUTAR REVIEW con Agent Teams FULL
+  state.current_flow.code_written = true;
+  output("⚠ Review gate activo: " + gate.count + " archivo(s) sin revisar");
+  output("→ Lanzando Agent Teams FULL review (5 agentes especializados)...");
+
+  // 1. Crear team de review
+  TeamCreate({ team_name: "elsabro-review", description: "Code review team - 5 agentes especializados" })
+
+  // 2. Lanzar 5 teammates en paralelo (UN SOLO MENSAJE con multiples Task calls)
+  Task({
+    subagent_type: "pr-review-toolkit:code-reviewer",
+    team_name: "elsabro-review",
+    name: "quality-reviewer",
+    model: "sonnet",
+    prompt: "Review code quality: naming conventions, design patterns, DRY, SOLID principles. Focus on recently modified files. DO NOT ask questions. Report only high-confidence issues."
+  })
+  Task({
+    subagent_type: "feature-dev:code-reviewer",
+    team_name: "elsabro-review",
+    name: "security-reviewer",
+    model: "sonnet",
+    prompt: "Review security: OWASP top 10, injection vulnerabilities, XSS, secrets exposure, token handling, input validation. Focus on recently modified files. DO NOT ask questions. Report only high-confidence issues."
+  })
+  Task({
+    subagent_type: "pr-review-toolkit:pr-test-analyzer",
+    team_name: "elsabro-review",
+    name: "test-analyzer",
+    model: "sonnet",
+    prompt: "Analyze test coverage: missing tests, edge cases, happy/error paths, test quality. Focus on recently modified files. DO NOT ask questions. Report only critical gaps."
+  })
+  Task({
+    subagent_type: "pr-review-toolkit:silent-failure-hunter",
+    team_name: "elsabro-review",
+    name: "performance-reviewer",
+    model: "sonnet",
+    prompt: "Review for silent failures, N+1 queries, memory leaks, inadequate error handling, dangerous fallback behavior. Focus on recently modified files. DO NOT ask questions. Report only high-confidence issues."
+  })
+  Task({
+    subagent_type: "pr-review-toolkit:type-design-analyzer",
+    team_name: "elsabro-review",
+    name: "type-analyzer",
+    model: "sonnet",
+    prompt: "Analyze type design: encapsulation, invariant expression, null safety, interface correctness. Focus on recently modified files. DO NOT ask questions. Report only high-confidence issues."
+  })
+
+  // 3. Consolidar resultados — esperar que todos terminen
+  // Agregar hallazgos de cada reviewer al reporte consolidado
+  // Si ANY reviewer reporta issues criticos: fix y re-review (max 3 iteraciones)
+
+  // 4. Shutdown team
+  for (const name of ["quality-reviewer", "security-reviewer", "test-analyzer", "performance-reviewer", "type-analyzer"]) {
+    SendMessage({ type: "shutdown_request", recipient: name, content: "Review complete" })
+  }
+  TeamDelete()
+
+  // 5. Si review pasa sin issues criticos, limpiar gate y setear flag
+  Bash("bash hooks/review-gate.sh clear");
+  state.current_flow.code_review_passed = true;
+  Write(".elsabro/state.json", JSON.stringify(state, null, 2));
+}
+```
+
+**Donde se setean los flags:**
+- `state.current_flow.code_written = true` — se setea aqui (5.1) cuando review-gate.sh detecta archivos pendientes, y tambien por el PostToolUse hook al hacer Write/Edit
+- `state.current_flow.code_review_passed = true` — se setea aqui (5.1) despues de que los 5 reviewers pasan sin issues criticos y el gate se limpia
+
+**Agent Teams FULL — 5 Reviewers:**
+| Teammate | Plugin | Foco |
+|----------|--------|------|
+| quality-reviewer | pr-review-toolkit:code-reviewer | naming, patterns, DRY, SOLID |
+| security-reviewer | feature-dev:code-reviewer | OWASP, injection, secrets |
+| test-analyzer | pr-review-toolkit:pr-test-analyzer | coverage, edge cases |
+| performance-reviewer | pr-review-toolkit:silent-failure-hunter | silent failures, N+1, memory |
+| type-analyzer | pr-review-toolkit:type-design-analyzer | types, encapsulation, null safety |
+
+**VIOLACIÓN CRÍTICA**: Reportar resultado o ofrecer commit sin code review = ABORTAR OPERACIÓN
+</code_review_gate>
+
+<siguiente_paso>
 ## 6. Siguiente Paso
 
-**Gate checks** (por referencia a @references/enforcement-rules.md):
-- Rule 7: Si se escribio codigo -> code review debe haber pasado (el flow lo garantiza via parallel_review)
-- Rule 8: Si se usaron 2+ agentes -> Agent Teams debe haberse usado (callbacks.js lo garantiza)
+Al completar la ejecucion, verificar gates programaticamente antes de sugerir siguiente paso:
+
+```javascript
+// GATE CHECK: Enforcement estricto antes de cerrar
+state.current_flow = state.current_flow || {};
+
+// Cross-check: review-gate.sh es la fuente de verdad para codigo pendiente
+const gateStatus = Bash("bash hooks/review-gate.sh status");
+const gate = JSON.parse(gateStatus);
+
+// Si review-gate tiene archivos pendientes, code_written DEBE estar seteado
+if (gate.pending && !state.current_flow.code_written) {
+  state.current_flow.code_written = true; // Auto-fix inconsistencia
+}
+
+// Flags verificados
+const codeWritten = state.current_flow.code_written === true;
+const codeReviewPassed = state.current_flow.code_review_passed === true;
+
+// Rule 7: Si se escribio codigo, code review DEBE haber pasado
+if (codeWritten && !codeReviewPassed) {
+  // VIOLACIÓN CRÍTICA — NO proceder. Volver a code_review_gate.
+  output("⛔ CRITICAL: Code written without review. Execute section 5.1 first.");
+  output("→ Volver a Code Review Gate (seccion 5.1) antes de continuar.");
+  return; // Bloquea — no se puede llegar a suggested_next sin review
+}
+
+// Rule 7b: Double-check con review-gate.sh (fuente de verdad del sistema)
+if (gate.pending) {
+  output("⛔ REVIEW GATE PENDING: " + gate.count + " file(s) sin revisar.");
+  output("→ Ejecutar code review y bash hooks/review-gate.sh clear primero.");
+  return; // Bloquea — gate aun activo
+}
+
+// Rule 8: Si se usaron 2+ agentes, Agent Teams debe haberse usado
+// (callbacks.js lo garantiza, pero verificamos por seguridad)
+
+// Todo limpio — establecer siguiente paso
+state.suggested_next = "verify-work";
+Write(".elsabro/state.json", JSON.stringify(state, null, 2));
+```
 
+Mostrar al usuario:
 ```
 Siguiente Paso
 
--> /elsabro:verify-work -- verificar el trabajo completado
--> /elsabro:progress -- ver el progreso general del proyecto
+→ /elsabro:verify-work — verificar el trabajo completado
+→ /elsabro:progress — ver el progreso general del proyecto
 ```
+</siguiente_paso>

package/commands/elsabro/quick.md

@@ -1,6 +1,18 @@
 ---
 name: quick
 description: Modo de ejecución rápida para tareas simples - mínima ceremonia, máxima velocidad
+allowed-tools:
+  - Read
+  - Write
+  - Edit
+  - Bash
+  - Glob
+  - Grep
+  - Task
+  - TeamCreate
+  - TeamDelete
+  - SendMessage
+  - AskUserQuestion
 sync:
   reads: [".elsabro/state.json"]
   writes: [".elsabro/state.json", ".elsabro/context.md"]
@@ -126,9 +138,11 @@ ELSABRO: [Ejecuta en <30 segundos]
 4. Verify (10 seg)
    └─ Correr tests afectados
 
-5. Code Review (OBLIGATORIO)
-   └─ Task(pr-review-toolkit:code-reviewer) sobre archivos modificados
-   └─ Si hay issues: fix antes de reportar
+5. Code Review (OBLIGATORIO - Agent Teams LITE)
+   └─ TeamCreate("elsabro-review-lite") + 3 teammates especializados
+   └─ quality-reviewer + failure-hunter + test-analyzer (en paralelo)
+   └─ Consolidar hallazgos. Si issues criticos: fix y re-review
+   └─ SendMessage(shutdown_request) x3 + TeamDelete()
    └─ Si issues == 0: state.current_flow.code_review_passed = true ← MARCAR
 
 6. Report
@@ -141,7 +155,7 @@ ELSABRO: [Ejecuta en <30 segundos]
 1. **Max 2 preguntas** - Si necesitas más info, usa `/elsabro:plan`
 2. **Max 3 archivos** - Si afecta más, usa flujo normal
 3. **Auto-test** - Siempre corre tests relacionados
-4. **Auto-review** - SIEMPRE ejecutar code review con `Task(pr-review-toolkit:code-reviewer)` después de escribir código
+4. **Auto-review** - SIEMPRE ejecutar code review con Agent Teams LITE (3 agentes) después de escribir código
 5. **No docs** - Skip documentación para velocidad
 6. **Offer commit** - Siempre pregunta si commitear
 
@@ -177,18 +191,27 @@ Task({
 ```
 ¿Se escribió/modificó código?
 │
-├─ SÍ → ¿Se ejecutó code review (Paso 5)?
+├─ SÍ → ¿Se ejecutó code review con Agent Teams LITE (Paso 5)?
 │    │
 │    ├─ NO → EJECUTAR AHORA:
-│    │   Task(pr-review-toolkit:code-reviewer)
-│    │   Si issues > 0: fix y re-review
-│    │   Solo cuando issues == 0: continuar
+│    │   TeamCreate("elsabro-review-lite")
+│    │   + 3 teammates: quality-reviewer, failure-hunter, test-analyzer
+│    │   Consolidar hallazgos
+│    │   Si issues criticos > 0: fix y re-review
+│    │   Solo cuando issues == 0: shutdown + TeamDelete + continuar
 │    │
-│    └─ SÍ, issues == 0 → Continuar
+│    └─ SÍ, issues == 0, team deleted → Continuar
 │
 └─ NO → Continuar (no aplica)
 ```
 
+**Agent Teams LITE — 3 Reviewers:**
+| Teammate | Plugin | Foco |
+|----------|--------|------|
+| quality-reviewer | pr-review-toolkit:code-reviewer | bugs, patterns, naming |
+| failure-hunter | pr-review-toolkit:silent-failure-hunter | error handling, fallbacks |
+| test-analyzer | pr-review-toolkit:pr-test-analyzer | coverage, edge cases |
+
 **VIOLACIÓN CRÍTICA**: Reportar resultado sin code review = ABORTAR OPERACIÓN
 </code_review_gate>
 

package/hooks/hooks-config-updated.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "description": "ELSABRO Hooks Configuration v3.3 (hook config version) for ELSABRO v7.3.2 - Agent Teams + Blocking Review + Skill Discovery + Persistent Mode + Auto-Sync",
-  "version": "3.3.0",
+  "description": "ELSABRO Hooks Configuration v3.5 (hook config version) for ELSABRO v7.4.0 - Agent Teams + Blocking Review + Skill Discovery + Skill Gate + Persistent Mode + Auto-Sync + Review Gate Enforcement",
+  "version": "3.5.0",
 
   "hooks": {
     "PreFlow": [
@@ -40,10 +40,34 @@
         "command": "./hooks/lint-check.sh",
         "timeout": 10000,
         "enabled": true
+      },
+      {
+        "id": "review-gate-set",
+        "name": "review-gate-set",
+        "description": "Activa review-pending flag cuando se modifica codigo. Bloquea git commit hasta que pase code review.",
+        "matcher": "Write|Edit",
+        "command": "input=$(cat); file=$(echo \"$input\" | jq -r '.tool_input.file_path // \"unknown\"' 2>/dev/null); if [ -f \"$CLAUDE_PROJECT_DIR/hooks/review-gate.sh\" ]; then bash \"$CLAUDE_PROJECT_DIR/hooks/review-gate.sh\" set \"$file\" 2>/dev/null; fi; exit 0",
+        "timeout": 5000,
+        "enabled": true,
+        "errorPolicy": "continue",
+        "settingsJsonHook": true,
+        "settingsJsonNote": "Este hook se instala en ~/.claude/settings.json via install.js"
       }
     ],
 
     "PreToolUse": [
+      {
+        "id": "skill-gate-check",
+        "name": "skill-gate-check",
+        "description": "Bloquea Write/Edit si skill discovery no se ejecuto. Solo activo cuando ELSABRO mode esta on.",
+        "matcher": "Write|Edit",
+        "command": "if [ -f \"$CLAUDE_PROJECT_DIR/hooks/skill-gate.sh\" ]; then bash \"$CLAUDE_PROJECT_DIR/hooks/skill-gate.sh\" check; exit $?; fi; exit 0",
+        "timeout": 5000,
+        "enabled": true,
+        "errorPolicy": "block",
+        "settingsJsonHook": true,
+        "settingsJsonNote": "Este hook se instala en ~/.claude/settings.json via install.js. Solo bloquea cuando elsabro_mode=true en state.json."
+      },
       {
         "id": "confirm-destructive",
         "name": "confirm-destructive",
@@ -53,6 +77,19 @@
         "command": "./hooks/confirm-destructive.sh",
         "timeout": 60000,
         "enabled": true
+      },
+      {
+        "id": "review-gate-check",
+        "name": "review-gate-check",
+        "description": "Bloquea git commit/push si hay review pendiente. Propaga exit code de review-gate.sh check.",
+        "matcher": "Bash",
+        "pattern": "git commit|git push",
+        "command": "input=$(cat); cmd=$(echo \"$input\" | jq -r '.tool_input.command // \"\"' 2>/dev/null); if echo \"$cmd\" | grep -qE 'git commit|git push'; then if [ -f \"$CLAUDE_PROJECT_DIR/hooks/review-gate.sh\" ]; then bash \"$CLAUDE_PROJECT_DIR/hooks/review-gate.sh\" check; exit $?; fi; fi; exit 0",
+        "timeout": 5000,
+        "enabled": true,
+        "errorPolicy": "block",
+        "settingsJsonHook": true,
+        "settingsJsonNote": "Este hook se instala en ~/.claude/settings.json via install.js. CRITICO: exit $? propaga el exit code de review-gate.sh"
       }
     ],
 

package/hooks/skill-gate.sh

@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+# skill-gate.sh - ELSABRO Skill Discovery Gate Hook
+#
+# Enforces that skill discovery runs before any code changes.
+# Only active when ELSABRO mode is on (elsabro_mode: true in state.json).
+#
+# Usage:
+#   After skill discovery:    bash ./hooks/skill-gate.sh set
+#   PreToolUse (Write/Edit):  bash ./hooks/skill-gate.sh check
+#   New session start:        bash ./hooks/skill-gate.sh clear
+#   Query status:             bash ./hooks/skill-gate.sh status
+#
+# Flag file: .elsabro/.skill-discovery-done
+# This file tracks whether skill discovery was executed in the current session.
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
+ELSABRO_DIR="${PROJECT_ROOT}/.elsabro"
+FLAG_FILE="${ELSABRO_DIR}/.skill-discovery-done"
+STATE_FILE="${ELSABRO_DIR}/state.json"
+
+# Colors for stderr
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m'
+PREFIX="[ELSABRO:skill-gate]"
+
+ensure_dir() {
+    mkdir -p "$ELSABRO_DIR" 2>/dev/null || true
+}
+
+# Check if ELSABRO mode is active
+is_elsabro_active() {
+    if [[ ! -f "$STATE_FILE" ]]; then
+        return 1
+    fi
+    local mode
+    mode=$(grep -o '"elsabro_mode"[[:space:]]*:[[:space:]]*true' "$STATE_FILE" 2>/dev/null || true)
+    [[ -n "$mode" ]]
+}
+
+cmd_set() {
+    ensure_dir
+    local timestamp
+    timestamp=$(date -u +%Y-%m-%dT%H:%M:%SZ)
+    local task_desc
+    task_desc=$(printf '%s' "${2:-session}" | tr -cd '[:alnum:]/._ -')
+    echo "$timestamp|$task_desc" > "$FLAG_FILE"
+    echo -e "${GREEN}${PREFIX}${NC} Skill discovery completed ($task_desc)" >&2
+}
+
+cmd_check() {
+    # Only enforce if ELSABRO is active
+    if ! is_elsabro_active; then
+        exit 0
+    fi
+
+    if [[ -f "$FLAG_FILE" ]]; then
+        echo -e "${GREEN}${PREFIX}${NC} OK: Skill discovery done" >&2
+        exit 0
+    fi
+
+    echo -e "${YELLOW}${PREFIX}${NC} WARNING: Skill discovery not executed yet" >&2
+    echo -e "${YELLOW}${PREFIX}${NC} Run: bash hooks/skill-discovery.sh \"[task]\" \"medium\"" >&2
+    echo -e "${YELLOW}${PREFIX}${NC} Then: bash hooks/skill-gate.sh set" >&2
+    # Exit 1 to block the operation
+    exit 1
+}
+
+cmd_clear() {
+    if [[ -f "$FLAG_FILE" ]]; then
+        rm -f "$FLAG_FILE"
+        echo -e "${GREEN}${PREFIX}${NC} Skill gate cleared (new session)" >&2
+    else
+        echo -e "${GREEN}${PREFIX}${NC} No skill discovery flag to clear" >&2
+    fi
+}
+
+cmd_status() {
+    local elsabro_active="false"
+    if is_elsabro_active; then
+        elsabro_active="true"
+    fi
+
+    if [[ -f "$FLAG_FILE" ]]; then
+        local content
+        content=$(cat "$FLAG_FILE" 2>/dev/null || echo "unknown")
+        echo "{\"done\":true,\"elsabro_active\":$elsabro_active,\"last_run\":\"$content\"}"
+    else
+        echo "{\"done\":false,\"elsabro_active\":$elsabro_active}"
+    fi
+}
+
+# Main
+case "${1:-status}" in
+    set)    cmd_set "$@" ;;
+    check)  cmd_check ;;
+    clear)  cmd_clear ;;
+    status) cmd_status ;;
+    *)
+        echo "Usage: skill-gate.sh {set|check|clear|status}" >&2
+        exit 1
+        ;;
+esac

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "elsabro",
-  "version": "7.4.0",
+  "version": "7.5.0",
   "description": "Sistema de desarrollo AI-powered para Claude Code - BMAD Method Integration, Spec-Driven Development, Party Mode, Next Step Suggestions, Stitch UI Design, Agent Teams, blocking code review, orquestación avanzada con flows declarativos",
   "bin": {
     "elsabro": "bin/install.js",

package/references/enforcement-rules.md

@@ -151,41 +151,68 @@ fs.appendFile('.planning/TODOS.md', '- [ ] Fix validation bug');
 
 ---
 
-### 7. Code Review OBLIGATORIO Después de Escribir Código
+### 7. Code Review con Agent Teams OBLIGATORIO Después de Escribir Código
 
-**PROHIBIDO**: Completar un comando que escribe/modifica código sin ejecutar code review.
+**PROHIBIDO**: Completar un comando que escribe/modifica código sin ejecutar code review con Agent Teams.
 
-**OBLIGATORIO**: Después de cualquier operación que crea o modifica archivos de código, ejecutar `Task(pr-review-toolkit:code-reviewer)` sobre los archivos cambiados.
+**OBLIGATORIO**: Después de cualquier operación que crea o modifica archivos de código, ejecutar code review usando Agent Teams con agentes especializados en paralelo.
 
 **Aplica a**: `execute`, `quick`, `debug` (modo find_and_fix), `new` (cuando genera código)
 
+**Dos Tiers de Review:**
+
+| Tier | Comandos | Agentes | Team Name |
+|------|----------|---------|-----------|
+| FULL | execute | 5 (quality, security, tests, performance, types) | elsabro-review |
+| LITE | quick, debug, new | 3 (quality, failures, tests) | elsabro-review-lite |
+
 **Secuencia:**
 ```
 1. Escribir/modificar código
 2. Correr tests
-3. Task(pr-review-toolkit:code-reviewer) sobre archivos cambiados ← OBLIGATORIO
-4. Si hay issues: corregir y re-review
-5. Solo entonces: reportar al usuario / ofrecer commit
+3. TeamCreate + N teammates especializados en paralelo ← OBLIGATORIO
+4. Consolidar hallazgos de todos los reviewers
+5. Si hay issues criticos: corregir y re-review (max 3 iteraciones)
+6. SendMessage(shutdown_request) xN + TeamDelete()
+7. Solo entonces: reportar al usuario / ofrecer commit
 ```
 
-**Ejemplo correcto:**
+**Ejemplo correcto (FULL — execute):**
+```javascript
+// Después de implementar feature
+TeamCreate({ team_name: "elsabro-review", description: "5-agent review team" })
+
+// 5 teammates en paralelo (UN SOLO MENSAJE)
+Task({ subagent_type: "pr-review-toolkit:code-reviewer", team_name: "elsabro-review", name: "quality-reviewer", model: "sonnet", prompt: "..." })
+Task({ subagent_type: "feature-dev:code-reviewer", team_name: "elsabro-review", name: "security-reviewer", model: "sonnet", prompt: "..." })
+Task({ subagent_type: "pr-review-toolkit:pr-test-analyzer", team_name: "elsabro-review", name: "test-analyzer", model: "sonnet", prompt: "..." })
+Task({ subagent_type: "pr-review-toolkit:silent-failure-hunter", team_name: "elsabro-review", name: "performance-reviewer", model: "sonnet", prompt: "..." })
+Task({ subagent_type: "pr-review-toolkit:type-design-analyzer", team_name: "elsabro-review", name: "type-analyzer", model: "sonnet", prompt: "..." })
+
+// Consolidar → fix si criticos → shutdown → TeamDelete
+```
+
+**Ejemplo correcto (LITE — quick/debug):**
 ```javascript
-// Después de implementar fix
-Task({
-  subagent_type: "pr-review-toolkit:code-reviewer",
-  description: "Code review de cambios",
-  prompt: "Revisa los cambios en [archivos]. Busca bugs, code smells, seguridad."
-})
-// Si clean → continuar
-// Si issues → fix → re-review
+TeamCreate({ team_name: "elsabro-review-lite", description: "3-agent review team" })
+
+Task({ subagent_type: "pr-review-toolkit:code-reviewer", team_name: "elsabro-review-lite", name: "quality-reviewer", ... })
+Task({ subagent_type: "pr-review-toolkit:silent-failure-hunter", team_name: "elsabro-review-lite", name: "failure-hunter", ... })
+Task({ subagent_type: "pr-review-toolkit:pr-test-analyzer", team_name: "elsabro-review-lite", name: "test-analyzer", ... })
+
+// Consolidar → fix si criticos → shutdown → TeamDelete
 ```
 
 **Ejemplo INCORRECTO:**
 ```
-# VIOLACIÓN: Ofrecer commit sin code review
+# VIOLACIÓN 1: Ofrecer commit sin code review
 Edit(file...)
 Bash("npm test")
 "¿Commit? (y/n)"  # ← Falta code review
+
+# VIOLACIÓN 2: Code review sin Agent Teams (single agent)
+Task({ subagent_type: "pr-review-toolkit:code-reviewer", prompt: "..." })
+# ← Viola Rule 8: 1 solo agente, sin TeamCreate
 ```
 
 ---