elsabro 7.1.0 → 7.3.0

package/hooks/skill-install.sh

@@ -0,0 +1,224 @@
+#!/bin/bash
+# skill-install.sh - ELSABRO Skill Install Bridge (v1.0.0)
+#
+# Instala skills del vercel-labs/skills registry y valida archivos instalados.
+# Companion de skill-discovery.sh — este script ejecuta lo que discovery recomienda.
+#
+# Comandos:
+#   check              - Valida accesibilidad del registry (npx skills check)
+#   install "<cmd>"    - Ejecuta install command con pre-checks y timeout (e.g. npx skills add ...)
+#   validate "<name>"  - Verifica que skill instalado existe y tiene YAML frontmatter
+#
+# Output: JSON en stdout, logs en stderr
+# Errores: Siempre exit 0, errores comunicados via JSON {"status":"error","message":"..."}
+#
+# Requiere: bash 4+, node/npm (para npx)
+
+set -euo pipefail
+
+# ============================================================================
+# CONFIGURACION
+# ============================================================================
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
+GLOBAL_SKILLS_DIR="${HOME}/.claude/skills"
+CACHE_FILE="${PROJECT_ROOT}/.cache/skill-discovery-cache.json"
+
+NPX_TIMEOUT=30    # segundos para install
+CHECK_TIMEOUT=15  # segundos para check
+
+# Portable timeout: use gtimeout (macOS/brew) > timeout (Linux) > no timeout
+if command -v gtimeout >/dev/null 2>&1; then
+    TIMEOUT_CMD="gtimeout"
+elif command -v timeout >/dev/null 2>&1; then
+    TIMEOUT_CMD="timeout"
+else
+    TIMEOUT_CMD=""
+fi
+
+run_with_timeout() {
+    local secs="$1"; shift
+    if [[ -n "$TIMEOUT_CMD" ]]; then
+        "$TIMEOUT_CMD" "$secs" "$@"
+    else
+        "$@"
+    fi
+}
+
+# Colores para stderr
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m'
+PREFIX="[ELSABRO:install]"
+
+# ============================================================================
+# LOGGING (stderr only)
+# ============================================================================
+
+log_info()  { echo -e "${GREEN}${PREFIX}${NC} $*" >&2; }
+log_warn()  { echo -e "${YELLOW}${PREFIX}${NC} $*" >&2; }
+log_error() { echo -e "${RED}${PREFIX}${NC} $*" >&2; }
+
+# ============================================================================
+# JSON OUTPUT (stdout only)
+# ============================================================================
+
+json_ok() {
+    local extra="${1:-}"
+    if [[ -n "$extra" ]]; then
+        echo "{\"status\":\"ok\",$extra}"
+    else
+        echo '{"status":"ok"}'
+    fi
+}
+
+json_error() {
+    local msg="$1"
+    echo "{\"status\":\"error\",\"message\":\"$msg\"}"
+}
+
+# ============================================================================
+# COMMAND: check
+# Validates registry accessibility via npx skills check
+# ============================================================================
+
+cmd_check() {
+    log_info "Checking registry accessibility..."
+
+    command -v npx >/dev/null 2>&1 || { json_error "npx not found"; exit 0; }
+
+    local output
+    if output=$(run_with_timeout "$CHECK_TIMEOUT" npx -y skills check 2>&1); then
+        log_info "Registry accessible"
+        json_ok
+    else
+        log_error "Registry check failed: $output"
+        json_error "registry check failed"
+    fi
+}
+
+# ============================================================================
+# COMMAND: install <install_cmd>
+# Executes the given install command with pre-checks and timeout
+# ============================================================================
+
+cmd_install() {
+    local install_cmd="${1:-}"
+
+    if [[ -z "$install_cmd" ]]; then
+        json_error "install command required"
+        exit 0
+    fi
+
+    log_info "Installing skill: $install_cmd"
+
+    # Pre-check: command format (defense-in-depth — only allow npx skills add ...)
+    if [[ ! "$install_cmd" =~ ^npx[[:space:]]+((-y|skills|add|--skill|--yes|-g|-a|claude-code|[a-zA-Z0-9/_-]+)[[:space:]]*)+$ ]]; then
+        json_error "install command failed format validation"
+        exit 0
+    fi
+
+    # Pre-check: npx available
+    command -v npx >/dev/null 2>&1 || { json_error "npx not found"; exit 0; }
+
+    # Pre-check: skills dir exists and is writable
+    if [[ ! -d "$GLOBAL_SKILLS_DIR" ]]; then
+        mkdir -p "$GLOBAL_SKILLS_DIR" 2>/dev/null || { json_error "$GLOBAL_SKILLS_DIR cannot be created"; exit 0; }
+    fi
+    test -w "$GLOBAL_SKILLS_DIR" || { json_error "$GLOBAL_SKILLS_DIR not writable"; exit 0; }
+
+    # Execute install command with timeout
+    local output
+    if output=$(run_with_timeout "$NPX_TIMEOUT" bash -c "$install_cmd" 2>&1); then
+        log_info "Install succeeded"
+
+        # Extract skill name from command (--skill <name>)
+        local skill_name
+        skill_name=$(echo "$install_cmd" | sed -n 's/.*--skill \([a-zA-Z0-9_-]*\).*/\1/p')
+
+        # Invalidate discovery cache (so next run sees skill as installed)
+        if [[ -f "$CACHE_FILE" ]]; then
+            rm -f "$CACHE_FILE"
+            log_info "Discovery cache invalidated"
+        fi
+
+        json_ok "\"skill\":\"$skill_name\""
+    else
+        local exit_code=$?
+        if [[ $exit_code -eq 124 ]]; then
+            log_error "Install timed out after ${NPX_TIMEOUT}s"
+            json_error "install timed out after ${NPX_TIMEOUT}s"
+        else
+            log_error "Install failed (exit $exit_code): $output"
+            json_error "install failed: $(echo "$output" | tail -1 | tr '"' "'")"
+        fi
+    fi
+}
+
+# ============================================================================
+# COMMAND: validate <skill_name>
+# Checks installed file exists and has YAML frontmatter
+# ============================================================================
+
+cmd_validate() {
+    local skill_name="${1:-}"
+
+    if [[ -z "$skill_name" ]]; then
+        json_error "skill name required"
+        exit 0
+    fi
+
+    log_info "Validating skill: $skill_name"
+
+    # Check flat file first: ~/.claude/skills/<name>.md
+    local flat_path="${GLOBAL_SKILLS_DIR}/${skill_name}.md"
+    if [[ -f "$flat_path" ]]; then
+        local first_line
+        first_line=$(head -1 "$flat_path")
+        if [[ "$first_line" == "---" ]]; then
+            log_info "Valid skill at $flat_path (YAML frontmatter)"
+            json_ok "\"path\":\"$flat_path\",\"has_frontmatter\":true"
+        else
+            log_warn "File exists but no YAML frontmatter: $flat_path"
+            json_ok "\"path\":\"$flat_path\",\"has_frontmatter\":false"
+        fi
+        return
+    fi
+
+    # Check subdirectory fallback: ~/.claude/skills/<name>/SKILL.md
+    local subdir_path="${GLOBAL_SKILLS_DIR}/${skill_name}/SKILL.md"
+    if [[ -f "$subdir_path" ]]; then
+        local first_line
+        first_line=$(head -1 "$subdir_path")
+        if [[ "$first_line" == "---" ]]; then
+            log_info "Valid skill at $subdir_path (YAML frontmatter)"
+            json_ok "\"path\":\"$subdir_path\",\"has_frontmatter\":true"
+        else
+            log_warn "File exists but no YAML frontmatter: $subdir_path"
+            json_ok "\"path\":\"$subdir_path\",\"has_frontmatter\":false"
+        fi
+        return
+    fi
+
+    log_error "Skill not found: checked $flat_path and $subdir_path"
+    json_error "skill file not found after install"
+}
+
+# ============================================================================
+# MAIN
+# ============================================================================
+
+cmd="${1:-}"
+shift || true
+
+case "$cmd" in
+    check)    cmd_check ;;
+    install)  cmd_install "$@" ;;
+    validate) cmd_validate "$@" ;;
+    *)
+        json_error "unknown command: $cmd (use: check, install, validate)"
+        exit 0
+        ;;
+esac

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "elsabro",
-  "version": "7.1.0",
+  "version": "7.3.0",
   "description": "Sistema de desarrollo AI-powered para Claude Code - BMAD Method Integration, Spec-Driven Development, Party Mode, Next Step Suggestions, Stitch UI Design, Agent Teams, blocking code review, orquestación avanzada con flows declarativos",
   "bin": {
     "elsabro": "bin/install.js",

package/references/SYSTEM_INDEX.md

@@ -501,7 +501,7 @@ Para verificar que el sistema está correctamente configurado:
 ### Comandos Core
 - [ ] `start.md` tiene sección `<enforcement>` y `<state_sync>`
 - [ ] `plan.md` tiene sección `<state_sync>` y `dispatcher` en frontmatter
-- [ ] `execute.md` tiene sección `<state_sync>` y `dispatcher` en frontmatter
+- [ ] `execute.md` tiene sync config en frontmatter y referencia a @references/state-sync.md
 - [ ] `verify-work.md` tiene sección `<state_sync>` y `dispatcher` en frontmatter
 
 ### Referencias

package/references/agent-teams-integration.md

@@ -336,21 +336,13 @@ New "teams" profile added:
 }
 ```
 
-### execute.md Dispatcher
-
-New fields in dispatcher config:
-
-```yaml
-dispatcher:
-  implementation:
-    method: "agent-team"  # v4.2.0: always agent-team for 2+ agents (Rule 8)
-    agent_team_config:
-      team_members: [elsabro-executor, elsabro-qa, elsabro-planner]
-      when: "always"  # v4.2.0: mandatory, no longer conditional
-  verification:
-    blocking: true
-    max_review_iterations: 5
-```
+### execute.md Dispatch (v7.3.0+)
+
+execute.md is a thin CLI wrapper. Agent Teams dispatch is in section `#3-dispatch (type: parallel)`.
+The CLI flow engine + `callbacks.js` (`requiresTeam()` / `composeTeam()`) decide automatically
+whether to use Agent Teams (2+ non-haiku branches) or loose subagents (all-haiku).
+
+See: `commands/elsabro/execute.md#3-dispatch`
 
 ## Changelog (v4.0.0)