elsabro 3.8.2 → 4.0.0

package/flows/development-flow.json

@@ -1,7 +1,7 @@
 {
   "id": "development_flow",
   "name": "Standard Development Flow",
-  "version": "3.0.0",
+  "version": "4.0.0",
   "description": "Workflow completo para desarrollar features con quality gates",
 
   "config": {
@@ -15,7 +15,7 @@
   "inputs": {
     "task": { "type": "string", "required": true, "description": "Descripción de la tarea" },
     "complexity": { "type": "enum", "values": ["low", "medium", "high"], "default": "medium" },
-    "profile": { "type": "enum", "values": ["default", "yolo", "careful"], "default": "default" }
+    "profile": { "type": "enum", "values": ["default", "yolo", "careful", "teams"], "default": "default" }
   },
 
   "outputs": {
@@ -31,6 +31,28 @@
     {
       "id": "start",
       "type": "entry",
+      "next": "skill_discovery"
+    },
+
+    {
+      "id": "skill_discovery",
+      "type": "sequence",
+      "description": "Descubrir skills necesarios antes de cargar contexto",
+      "errorPolicy": "continue",
+      "steps": [
+        {
+          "action": "bash",
+          "command": "bash ./hooks/skill-discovery.sh \"{{inputs.task}}\" \"{{inputs.complexity}}\"",
+          "as": "discovery",
+          "timeout": 45000,
+          "captureExitCode": true
+        }
+      ],
+      "outputs": {
+        "discoveryResult": "{{steps.discovery.output}}",
+        "skillRecommendations": "{{steps.discovery.output.recommended.skills || []}}",
+        "installCommands": "{{steps.discovery.output.recommended.install_commands || []}}"
+      },
       "next": "load_context"
     },
 
@@ -47,6 +69,14 @@
         {
           "action": "load_memory",
           "types": ["longTerm", "entity"]
+        },
+        {
+          "action": "inject_state",
+          "data": {
+            "availableSkills": "{{nodes.skill_discovery.outputs.discoveryResult}}",
+            "skillRecommendations": "{{nodes.skill_discovery.outputs.skillRecommendations || []}}"
+          },
+          "optional": true
         }
       ],
       "next": "profile_router"
@@ -60,6 +90,7 @@
       "routes": {
         "yolo": "yolo_execute",
         "careful": "careful_analyze",
+        "teams": "teams_spawn",
         "default": "standard_analyze"
       },
       "default": "standard_analyze"
@@ -119,6 +150,92 @@
       }
     },
 
+    {
+      "id": "teams_spawn",
+      "type": "team",
+      "description": "Crear Agent Team para coordinación peer-to-peer",
+      "config": {
+        "team_name": "elsabro-{{inputs.task | slugify}}",
+        "description": "Agent Teams para: {{inputs.task}}"
+      },
+      "members": [
+        {
+          "name": "analyst",
+          "agent": "elsabro-analyst",
+          "role": "Analizar requisitos y diseñar solución",
+          "model": "opus"
+        },
+        {
+          "name": "planner",
+          "agent": "elsabro-planner",
+          "role": "Planificar implementación con waves",
+          "model": "opus"
+        },
+        {
+          "name": "executor",
+          "agent": "elsabro-executor",
+          "role": "Implementar código con TDD",
+          "model": "opus"
+        },
+        {
+          "name": "qa",
+          "agent": "elsabro-qa",
+          "role": "Testing y quality assurance",
+          "model": "opus"
+        },
+        {
+          "name": "verifier",
+          "agent": "elsabro-verifier",
+          "role": "Verificación final y code review",
+          "model": "opus"
+        }
+      ],
+      "phases": [
+        {
+          "id": "team_analyze",
+          "name": "Analysis",
+          "active_members": ["analyst", "planner"],
+          "tasks": "Analizar y planificar: {{inputs.task}}"
+        },
+        {
+          "id": "team_implement",
+          "name": "Implementation",
+          "active_members": ["executor", "qa"],
+          "tasks": "Implementar con TDD según plan del analyst"
+        },
+        {
+          "id": "team_review",
+          "name": "Review",
+          "active_members": ["verifier"],
+          "tasks": "Code review bloqueante - 0 issues para pasar"
+        }
+      ],
+      "cleanup": true,
+      "onError": "interrupt_teams_failed",
+      "next": "quality_gate"
+    },
+
+    {
+      "id": "interrupt_teams_failed",
+      "type": "interrupt",
+      "reason": "Agent Team creation or execution failed",
+      "display": {
+        "title": "⚠️ Agent Team Falló",
+        "content": "El equipo de agentes no pudo completar la tarea. Esto puede deberse a un agente que no respondió, un timeout, o un error de configuración.",
+        "errors": "{{state.lastError}}",
+        "options": [
+          { "id": "retry", "label": "🔄 Reintentar con Agent Teams" },
+          { "id": "fallback", "label": "📋 Usar subagents en su lugar" },
+          { "id": "abort", "label": "❌ Abortar ejecución" }
+        ]
+      },
+      "routes": {
+        "retry": "teams_spawn",
+        "fallback": "standard_analyze",
+        "abort": "end_cancelled"
+      }
+    },
+
     {
       "id": "standard_analyze",
       "type": "parallel",
@@ -205,24 +322,28 @@
       "id": "quality_gate",
       "type": "sequence",
       "description": "Quality gate: tests, types, lint",
+      "captureExitCode": true,
       "steps": [
         {
           "action": "bash",
-          "command": "npm test 2>&1 || true",
+          "command": "npm test 2>&1; echo \"EXIT_CODE=$?\"",
           "as": "tests",
-          "timeout": 120000
+          "timeout": 120000,
+          "captureExitCode": true
         },
         {
           "action": "bash",
-          "command": "npx tsc --noEmit 2>&1 || true",
+          "command": "npx tsc --noEmit 2>&1; echo \"EXIT_CODE=$?\"",
           "as": "typescript",
-          "timeout": 60000
+          "timeout": 60000,
+          "captureExitCode": true
         },
         {
           "action": "bash",
-          "command": "npm run lint 2>&1 || true",
+          "command": "npm run lint 2>&1; echo \"EXIT_CODE=$?\"",
           "as": "lint",
-          "timeout": 60000
+          "timeout": 60000,
+          "captureExitCode": true
         }
       ],
       "next": "quality_check"
@@ -231,8 +352,8 @@
     {
       "id": "quality_check",
       "type": "condition",
-      "description": "Verificar si pasó quality gate",
-      "condition": "{{nodes.quality_gate.outputs.tests.exitCode === 0 && nodes.quality_gate.outputs.typescript.exitCode === 0}}",
+      "description": "Verificar si pasó quality gate (tests + typescript + lint)",
+      "condition": "{{nodes.quality_gate.outputs.tests.exitCode === 0 && nodes.quality_gate.outputs.typescript.exitCode === 0 && nodes.quality_gate.outputs.lint.exitCode === 0}}",
       "true": "parallel_review",
       "false": "fix_issues"
     },
@@ -277,13 +398,11 @@
         "attempts": "3",
         "options": [
           { "id": "retry", "label": "Reintentar auto-fix" },
-          { "id": "skip", "label": "Continuar sin fix" },
           { "id": "manual", "label": "Corregiré manualmente" }
         ]
       },
       "routes": {
         "retry": "fix_issues",
-        "skip": "parallel_review",
         "manual": "wait_manual_fix"
       }
     },
@@ -354,16 +473,57 @@
     {
       "id": "fix_review_issues",
       "type": "agent",
-      "description": "Corregir issues del code review",
+      "description": "Corregir issues del code review - BLOCKING: no avanza hasta 0 errores",
       "agent": "elsabro-executor",
       "config": { "model": "opus" },
       "inputs": {
-        "task": "Corregir issues del code review",
-        "issues": "{{nodes.parallel_review.outputs}}"
+        "task": "Corregir TODOS los issues del code review. No dejar ninguno pendiente.",
+        "issues": "{{nodes.parallel_review.outputs}}",
+        "iteration": "{{state.reviewIteration || 1}}",
+        "maxIterations": 5
       },
       "next": "parallel_review",
-      "maxIterations": 2,
-      "onMaxIterations": "verify_final"
+      "maxIterations": 5,
+      "onMaxIterations": "interrupt_blocked"
+    },
+
+    {
+      "id": "interrupt_blocked",
+      "type": "interrupt",
+      "reason": "Code review still has issues after 5 fix iterations - BLOCKED",
+      "display": {
+        "title": "🚫 BLOQUEADO: Code Review con Errores Pendientes",
+        "content": "Se han agotado 5 iteraciones de auto-fix y aún hay issues sin resolver.",
+        "errors": "{{nodes.parallel_review.outputs}}",
+        "iterations_used": 5,
+        "options": [
+          { "id": "retry", "label": "🔄 Reintentar auto-fix (5 intentos más)" },
+          { "id": "manual", "label": "👤 Corregiré manualmente" },
+          { "id": "abort", "label": "❌ Abortar ejecución" }
+        ]
+      },
+      "routes": {
+        "retry": "fix_review_issues",
+        "manual": "wait_manual_review_fix",
+        "abort": "end_cancelled"
+      }
+    },
+
+    {
+      "id": "wait_manual_review_fix",
+      "type": "interrupt",
+      "reason": "Waiting for manual fix of review issues",
+      "display": {
+        "title": "👤 Esperando Corrección Manual de Review Issues",
+        "content": "Corrige los issues listados y avísame cuando estés listo. El proceso NO avanzará hasta que todos los issues estén resueltos.",
+        "errors": "{{nodes.parallel_review.outputs}}",
+        "options": [
+          { "id": "done", "label": "✓ Ya corregí todos los issues" }
+        ]
+      },
+      "routes": {
+        "done": "parallel_review"
+      }
     },
 
     {
@@ -391,14 +551,14 @@
         "title": "❌ Verificación Final Fallida",
         "errors": "{{nodes.verify_final.outputs.errors}}",
         "options": [
-          { "id": "retry", "label": "Reintentar desde implementación" },
-          { "id": "accept", "label": "Aceptar con errores" },
-          { "id": "cancel", "label": "Cancelar" }
+          { "id": "retry", "label": "🔄 Reintentar desde implementación" },
+          { "id": "manual", "label": "👤 Corregiré manualmente" },
+          { "id": "cancel", "label": "❌ Cancelar" }
         ]
       },
       "routes": {
         "retry": "parallel_implementation",
-        "accept": "post_mortem",
+        "manual": "wait_manual_fix",
         "cancel": "end_cancelled"
       }
     },
@@ -432,8 +592,8 @@
         "filesCreated": "{{collectOutputs('filesCreated')}}",
         "filesModified": "{{collectOutputs('filesModified')}}",
         "testsCreated": "{{collectOutputs('testsCreated')}}",
-        "testsPassed": true,
-        "reviewApproved": true,
+        "testsPassed": "{{nodes.quality_gate.outputs.tests.exitCode === 0}}",
+        "reviewApproved": "{{!hasCriticalIssues(nodes.parallel_review.outputs)}}",
         "success": true,
         "summary": "{{generateSummary()}}"
       }

package/hooks/hooks-config-updated.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "description": "ELSABRO Hooks Configuration v2.0 - Con integración de Skill Discovery",
-  "version": "2.0.0",
+  "description": "ELSABRO Hooks Configuration v3.1 - Agent Teams + Blocking Review + Skill Discovery (npx skills)",
+  "version": "3.1.0",
 
   "hooks": {
     "PreFlow": [
@@ -109,6 +109,17 @@
       "auto-test-on-edit": false,
       "lint-on-save": false,
       "confirm-destructive": false
+    },
+
+    "teams": {
+      "description": "Perfil para Agent Teams - coordinación peer-to-peer con Teammate/SendMessage",
+      "auto-test-on-edit": true,
+      "lint-on-save": true,
+      "confirm-destructive": true,
+      "skill-discovery": true,
+      "agent-teams": true,
+      "blocking-review": true,
+      "max-review-iterations": 5
     }
   },
 
@@ -129,128 +140,78 @@
   },
 
   "skillDiscoveryConfig": {
-    "description": "Configuración específica para skill discovery",
-    "keywords": {
-      "categories": [
-        {
-          "id": "api",
-          "keywords": ["api", "backend", "endpoint", "rest", "graphql", "http", "server"]
-        },
-        {
-          "id": "auth",
-          "keywords": ["auth", "login", "signin", "oauth", "jwt", "session", "password"]
-        },
-        {
-          "id": "db",
-          "keywords": ["database", "db", "postgres", "mysql", "mongodb", "firebase"]
-        },
-        {
-          "id": "payments",
-          "keywords": ["payment", "stripe", "paypal", "billing", "checkout", "commerce"]
-        },
-        {
-          "id": "mobile",
-          "keywords": ["mobile", "expo", "react-native", "ios", "android", "app"]
-        },
-        {
-          "id": "web",
-          "keywords": ["website", "web", "nextjs", "react", "vue", "angular", "frontend"]
-        },
-        {
-          "id": "devops",
-          "keywords": ["devops", "docker", "kubernetes", "ci", "cd", "github", "deploy"]
-        },
-        {
-          "id": "testing",
-          "keywords": ["test", "jest", "vitest", "mocha", "pytest", "coverage"]
-        },
-        {
-          "id": "security",
-          "keywords": ["security", "encrypt", "https", "cors", "ssl", "auth"]
-        },
-        {
-          "id": "monitoring",
-          "keywords": ["monitor", "sentry", "logging", "error", "analytics"]
-        }
-      ]
-    },
-    "ranking": {
-      "algorithm": "weighted_score",
-      "weights": {
-        "match_score": 100,
-        "difficulty_beginner": 50,
-        "difficulty_intermediate": 30,
-        "difficulty_advanced": 10,
-        "source_elsabro": 20,
-        "source_external": 5,
-        "requires_installation": -10
-      },
-      "maxSkills": 10,
-      "minScore": 0
+    "description": "Configuración de skill discovery usando vercel-labs/skills (npx skills)",
+    "method": "npx-skills",
+    "commands": {
+      "find": "npx skills find <query>",
+      "add": "npx skills add -g <name>",
+      "list": "npx skills list",
+      "check": "npx skills check",
+      "update": "npx skills update"
     },
     "sources": {
-      "elsabro": {
+      "installed": {
         "enabled": true,
-        "path": "./skills",
-        "filePattern": "*.md",
-        "metadataFormat": "yaml_frontmatter",
+        "path": "~/.claude/skills",
+        "description": "Skills globales instalados",
         "priority": 1
       },
-      "external": {
+      "elsabro": {
         "enabled": true,
-        "api_url": "https://api.skills.sh/v1/discover",
-        "api_timeout": 15000,
-        "priority": 2,
-        "fallback_to_cache": true
+        "path": "./skills",
+        "filePattern": "*.md",
+        "description": "Skills bundled con ELSABRO",
+        "priority": 2
       },
-      "cache": {
+      "registry": {
         "enabled": true,
-        "path": "./.cache/skills-discovery-cache.json",
-        "ttl": 3600
+        "command": "npx skills find",
+        "description": "vercel-labs/skills registry",
+        "timeout": 30000,
+        "priority": 3
       }
     },
+    "ranking": {
+      "algorithm": "weighted_score",
+      "weights": {
+        "match_score": 100,
+        "source_elsabro": 20,
+        "source_registry": 10
+      },
+      "maxSkills": 10
+    },
+    "cache": {
+      "enabled": true,
+      "path": "./.cache/skill-discovery-cache.json",
+      "ttl": 3600
+    },
     "output": {
       "format": "json",
-      "includeMetadata": true,
-      "includeTags": true,
-      "includeRanking": true,
-      "maxRecommendations": 5
+      "includeInstallCommands": true,
+      "includeUpdateStatus": true,
+      "maxRecommendations": 10
     }
   },
 
   "flowEngineIntegration": {
-    "description": "Configuración de integración con Flow Engine",
+    "description": "Integración con Flow Engine - nodo skill_discovery antes de load_context",
     "enabled": true,
-    "nodePosition": "before:load_context",
     "nodeId": "skill_discovery",
+    "nodePosition": "between:start:load_context",
     "injectInto": [
       {
         "node": "load_context",
-        "field": "context.availableSkills"
+        "field": "state.availableSkills",
+        "source": "nodes.skill_discovery.outputs.discoveredSkills"
       },
       {
         "node": "load_context",
-        "field": "context.skillContext"
-      },
-      {
-        "branches": ["standard_analyze", "careful_analyze"],
-        "inputs": {
-          "available_skills": "state.skillContext",
-          "skill_recommendations": "state.discoveredSkills[*].id"
-        }
+        "field": "state.skillRecommendations",
+        "source": "nodes.skill_discovery.outputs.skillRecommendations"
       }
     ],
-    "displayResults": true,
-    "displayNode": {
-      "id": "display_skill_discovery",
-      "type": "display",
-      "position": "after:skill_discovery",
-      "title": "🎯 Skills Descubiertos",
-      "showKeywords": true,
-      "showCount": true,
-      "showRecommendations": true,
-      "showSources": true
-    }
+    "errorPolicy": "continue",
+    "displayResults": true
   },
 
   "installation": {
@@ -258,15 +219,16 @@
       "1. Copiar este archivo a ~/.claude/hooks/hooks-config.json",
       "2. O referenciar desde settings.json: \"hooks\": {\"configPath\": \".planning/hooks/hooks-config-updated.json\"}",
       "3. Otorgar permisos al hook: chmod +x ./hooks/skill-discovery.sh",
-      "4. Verificar instalación: bash ./hooks/skill-discovery.sh 'test api' 'medium'"
+      "4. Instalar find-skills meta-skill: npx skills add -g https://github.com/vercel-labs/skills --skill find-skills",
+      "5. Verificar instalación: bash ./hooks/skill-discovery.sh 'crear api con auth' 'medium'"
     ],
     "settingsPath": "~/.claude/settings.json",
     "elsabroPath": ".planning/hooks/",
     "requirements": {
       "bash": "4.0+",
       "jq": "latest (para JSON processing)",
-      "curl": "latest (para API calls)",
-      "md5": "para hash de caché"
+      "node": "18+ (para npx skills)",
+      "npm": "latest (para npx)"
     }
   },