elm-pages 3.0.25 → 3.0.27

package/generator/dead-code-review/src/Pages/Review/DeadCodeEliminateData.elm

@@ -145,7 +145,7 @@ declarationVisitor node context =
                                             (\recordSetter ->
                                                 case Node.value recordSetter of
                                                     ( keyNode, valueNode ) ->
-                                                        if Node.value keyNode == "data" || Node.value keyNode == "action" then
+                                                        if Node.value keyNode == "data" || Node.value keyNode == "action" || Node.value keyNode == "pages" then
                                                             if isAlreadyApplied context.lookupTable (Node.value valueNode) then
                                                                 Nothing
 
@@ -203,7 +203,7 @@ expressionVisitor node context =
                                     (\recordSetter ->
                                         case Node.value recordSetter of
                                             ( keyNode, valueNode ) ->
-                                                if Node.value keyNode == "data" || Node.value keyNode == "action" then
+                                                if Node.value keyNode == "data" || Node.value keyNode == "action" || Node.value keyNode == "pages" then
                                                     if isAlreadyApplied context.lookupTable (Node.value valueNode) then
                                                         Nothing
 
@@ -234,16 +234,28 @@ expressionVisitor node context =
                                             ++ " = "
                                             ++ (case pageBuilderName of
                                                     "preRender" ->
-                                                        "\\_ -> "
-                                                            ++ referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
-                                                            ++ " "
-                                                            ++ exceptionFromString
+                                                        if key == "pages" then
+                                                            referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
+                                                                ++ " "
+                                                                ++ exceptionFromString
+
+                                                        else
+                                                            "\\_ -> "
+                                                                ++ referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
+                                                                ++ " "
+                                                                ++ exceptionFromString
 
                                                     "preRenderWithFallback" ->
-                                                        "\\_ -> "
-                                                            ++ referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
-                                                            ++ " "
-                                                            ++ exceptionFromString
+                                                        if key == "pages" then
+                                                            referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
+                                                                ++ " "
+                                                                ++ exceptionFromString
+
+                                                        else
+                                                            "\\_ -> "
+                                                                ++ referenceFunction context.importContext ( [ "BackendTask" ], "fail" )
+                                                                ++ " "
+                                                                ++ exceptionFromString
 
                                                     "serverRender" ->
                                                         "\\_ _ -> "

package/generator/dead-code-review/tests/Pages/Review/DeadCodeEliminateDataTest.elm

@@ -311,7 +311,7 @@ route =
     RouteBuilder.preRender
         { data = data
         , head = head
-        , pages = pages
+        , pages = BackendTask.fail (FatalError.fromString "")
         }
         |> RouteBuilder.buildNoState { view = view }
 
@@ -366,7 +366,7 @@ route =
     RouteBuilder.preRender
         { data = \\_ -> BackendTask.fail (FatalError.fromString "")
         , head = head
-        , pages = pages
+        , pages = BackendTask.fail (FatalError.fromString "")
         }
         |> RouteBuilder.buildNoState { view = view }
 
@@ -374,6 +374,109 @@ route =
 data : BackendTask Data
 data =
     BackendTask.succeed ()
+"""
+                        ]
+        , test "replaces pages record setter in preRender" <|
+            \() ->
+                """module Route.Blog.Slug_ exposing (Data, Model, Msg, route)
+
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
+import RouteBuilder exposing (Page, App)
+import Pages.PageUrl exposing (PageUrl)
+import Pages.Url
+import UrlPath
+import Route exposing (Route)
+import Shared
+import View exposing (View)
+
+
+type alias Model =
+   {}
+
+
+type alias Msg =
+   ()
+
+
+type alias RouteParams =
+    { slug : String }
+
+
+type alias Data =
+   ()
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+    RouteBuilder.preRender
+        { data = \\_ -> BackendTask.fail (FatalError.fromString "")
+        , head = head
+        , pages = pages
+        }
+        |> RouteBuilder.buildNoState { view = view }
+
+
+pages : BackendTask (List RouteParams)
+pages =
+    BackendTask.succeed [ { slug = "hello" } ]
+"""
+                    |> Review.Test.run rule
+                    |> Review.Test.expectErrors
+                        [ Review.Test.error
+                            { message = "Codemod"
+                            , details =
+                                [ "" ]
+                            , under =
+                                """pages = pages
+        }"""
+                            }
+                            |> Review.Test.whenFixed
+                                """module Route.Blog.Slug_ exposing (Data, Model, Msg, route)
+
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
+import RouteBuilder exposing (Page, App)
+import Pages.PageUrl exposing (PageUrl)
+import Pages.Url
+import UrlPath
+import Route exposing (Route)
+import Shared
+import View exposing (View)
+
+
+type alias Model =
+   {}
+
+
+type alias Msg =
+   ()
+
+
+type alias RouteParams =
+    { slug : String }
+
+
+type alias Data =
+   ()
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+    RouteBuilder.preRender
+        { data = \\_ -> BackendTask.fail (FatalError.fromString "")
+        , head = head
+        , pages = BackendTask.fail (FatalError.fromString "")}
+        |> RouteBuilder.buildNoState { view = view }
+
+
+pages : BackendTask (List RouteParams)
+pages =
+    BackendTask.succeed [ { slug = "hello" } ]
 """
                         ]
         , test "replaces data record setter with RouteBuilder.serverRendered" <|

package/generator/src/compatibility-key.js

@@ -1,3 +1,3 @@
 export const compatibilityKey = 22;
 
-export const packageVersion = "3.0.25";
+export const packageVersion = "3.0.27";

package/generator/src/compile-elm.js

@@ -133,6 +133,12 @@ async function compileElm(options, elmEntrypointPath, outputPath, cwd) {
 
 function spawnElmMake(options, elmEntrypointPath, outputPath, cwd) {
   return new Promise(async (resolve, reject) => {
+    try {
+      await fsPromises.unlink(outputPath);
+    } catch (e) {
+      /* File may not exist, so ignore errors */
+    }
+
     const subprocess = spawnCallback(
       `lamdera`,
       [
@@ -152,13 +158,6 @@ function spawnElmMake(options, elmEntrypointPath, outputPath, cwd) {
         cwd: cwd,
       }
     );
-    if (await fsHelpers.fileExists(outputPath)) {
-      try {
-        await fsPromises.unlink(outputPath, {
-          force: true /* ignore errors if file doesn't exist */,
-        });
-      } catch (e) {}
-    }
     let commandOutput = "";
 
     subprocess.stderr.on("data", function (data) {

package/generator/src/render.js

@@ -412,12 +412,7 @@ async function outputString(
 
 /** @typedef { { head: any[]; errors: any[]; contentJson: any[]; html: string; route: string; title: string; } } Arg */
 
-async function runHttpJob(
-  requestHash,
-  portsFile,
-  mode,
-  requestToPerform,
-) {
+async function runHttpJob(requestHash, portsFile, mode, requestToPerform) {
   try {
     const lookupResponse = await lookupOrPerform(
       portsFile,
@@ -490,18 +485,13 @@ async function runInternalJob(
   portsFile
 ) {
   try {
-    const cwd = path.resolve(...requestToPerform.dir);
-    const quiet = requestToPerform.quiet;
-    const env = { ...process.env, ...requestToPerform.env };
-
-    const context = { cwd, quiet, env };
     switch (requestToPerform.url) {
       case "elm-pages-internal://log":
         return [requestHash, await runLogJob(requestToPerform)];
       case "elm-pages-internal://read-file":
         return [
           requestHash,
-          await readFileJobNew(requestToPerform, patternsToWatch, context),
+          await readFileJobNew(requestToPerform, patternsToWatch),
         ];
       case "elm-pages-internal://read-file-binary":
         return [
@@ -539,7 +529,7 @@ async function runInternalJob(
           await runDecryptJob(requestToPerform, patternsToWatch),
         ];
       case "elm-pages-internal://write-file":
-        return [requestHash, await runWriteFileJob(requestToPerform, context)];
+        return [requestHash, await runWriteFileJob(requestToPerform)];
       case "elm-pages-internal://sleep":
         return [requestHash, await runSleep(requestToPerform)];
       case "elm-pages-internal://which":
@@ -549,10 +539,7 @@ async function runInternalJob(
       case "elm-pages-internal://shell":
         return [requestHash, await runShell(requestToPerform)];
       case "elm-pages-internal://stream":
-        return [
-          requestHash,
-          await runStream(requestToPerform, portsFile, context),
-        ];
+        return [requestHash, await runStream(requestToPerform, portsFile)];
       case "elm-pages-internal://start-spinner":
         return [requestHash, runStartSpinner(requestToPerform)];
       case "elm-pages-internal://stop-spinner":
@@ -567,7 +554,19 @@ async function runInternalJob(
   }
 }
 
-async function readFileJobNew(req, patternsToWatch, { cwd }) {
+/**
+ * @param {{ dir: string[]; quiet: boolean; env: { [key:string]: string; }; }} requestToPerform
+ */
+function getContext(requestToPerform) {
+  const cwd = path.resolve(...requestToPerform.dir);
+  const quiet = requestToPerform.quiet;
+  const env = { ...process.env, ...requestToPerform.env };
+
+  return { cwd, quiet, env };
+}
+
+async function readFileJobNew(req, patternsToWatch) {
+  const { cwd } = getContext(req);
   // TODO use cwd
   const filePath = path.resolve(cwd, req.body.args[1]);
   try {
@@ -639,8 +638,9 @@ async function runQuestion(req) {
   return jsonResponse(req, await question(req.body.args[0]));
 }
 
-function runStream(req, portsFile, context) {
+function runStream(req, portsFile) {
   return new Promise(async (resolve) => {
+    const context = getContext(req);
     let metadataResponse = null;
     let lastStream = null;
     try {
@@ -1153,7 +1153,8 @@ export async function question({ prompt }) {
   });
 }
 
-async function runWriteFileJob(req, { cwd }) {
+async function runWriteFileJob(req) {
+  const { cwd } = getContext(req);
   const data = req.body.args[0];
   const filePath = path.resolve(cwd, data.path);
   try {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "elm-pages",
   "type": "module",
-  "version": "3.0.25",
+  "version": "3.0.27",
   "homepage": "https://elm-pages.com",
   "moduleResolution": "node",
   "description": "Hybrid Elm framework with full-stack and static routes.",
@@ -28,47 +28,50 @@
   "dependencies": {
     "@sindresorhus/merge-streams": "^4.0.0",
     "busboy": "^1.6.0",
-    "chokidar": "^4.0.3",
+    "chokidar": "^5.0.0",
     "cli-cursor": "^5.0.0",
-    "commander": "^13.1.0",
+    "commander": "^14.0.2",
     "connect": "^3.7.0",
     "cookie-signature": "^1.2.2",
     "cross-spawn": "7.0.6",
     "devcert": "^1.2.2",
     "elm-doc-preview": "^6.0.1",
     "elm-hot": "^1.1.6",
-    "esbuild": "^0.25.0",
-    "fs-extra": "^11.3.0",
-    "globby": "14.1.0",
+    "esbuild": "^0.27.2",
+    "fs-extra": "^11.3.3",
+    "globby": "16.1.0",
     "gray-matter": "^4.0.3",
     "jsesc": "^3.1.0",
     "kleur": "^4.1.5",
-    "make-fetch-happen": "^14.0.3",
-    "memfs": "^4.17.0",
+    "make-fetch-happen": "^15.0.3",
+    "memfs": "^4.51.1",
     "micromatch": "^4.0.8",
-    "serve-static": "^1.16.2",
-    "terser": "^5.39.0",
-    "vite": "^6.2.0",
-    "which": "^5.0.0"
+    "serve-static": "^2.2.1",
+    "terser": "^5.44.1",
+    "vite": "^7.3.1",
+    "which": "^6.0.0"
+  },
+  "optionalDependencies": {
+    "@rollup/rollup-linux-x64-gnu": "4.55.1"
   },
   "devDependencies": {
     "@types/cross-spawn": "^6.0.6",
     "@types/fs-extra": "^11.0.4",
     "@types/make-fetch-happen": "^10.0.4",
-    "@types/micromatch": "^4.0.9",
-    "@types/node": "^22.13.9",
-    "@types/serve-static": "^1.15.7",
-    "cypress": "^14.1.0",
+    "@types/micromatch": "^4.0.10",
+    "@types/node": "^25.0.3",
+    "@types/serve-static": "^2.2.0",
+    "cypress": "^15.8.2",
     "elm-codegen": "^0.6.1",
     "elm-optimize-level-2": "^0.3.5",
-    "elm-review": "^2.13.2",
-    "elm-test": "^0.19.1-revision15",
-    "elm-tooling": "^1.15.1",
+    "elm-review": "^2.13.5",
+    "elm-test": "^0.19.1-revision17",
+    "elm-tooling": "^1.17.0",
     "elm-verify-examples": "^6.0.3",
-    "lamdera": "^0.19.1-1.3.2",
-    "prettier": "^3.5.3",
-    "typescript": "^5.8.2",
-    "vitest": "^3.0.7"
+    "lamdera": "^0.19.1-1.4.0",
+    "prettier": "^3.7.4",
+    "typescript": "^5.9.3",
+    "vitest": "^4.0.16"
   },
   "files": [
     "adapter/",