elm-pages 3.0.0-beta.2 → 3.0.0-beta.20

package/generator/dead-code-review/tests/Pages/Review/DeadCodeEliminateDataTest.elm

@@ -12,7 +12,111 @@ all =
             \() ->
                 """module Route.Index exposing (Data, Model, Msg, route)
 
-import DataSource exposing (DataSource)
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
+import RouteBuilder exposing (Page, StaticPayload, single)
+import Pages.PageUrl exposing (PageUrl)
+import Pages.Url
+import Path
+import Route exposing (Route)
+import Shared
+import View exposing (View)
+
+
+type alias Model =
+   {}
+
+
+type alias Msg =
+   ()
+
+
+type alias RouteParams =
+   {}
+
+
+type alias Data =
+   ()
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+   single
+       { head = head
+       , data = data
+       }
+       |> RouteBuilder.buildNoState { view = view }
+
+
+data : BackendTask Data
+data =
+    BackendTask.succeed ()
+"""
+                    |> Review.Test.run rule
+                    |> Review.Test.expectErrors
+                        [ Review.Test.error
+                            { message = "Codemod"
+                            , details =
+                                [ "" ]
+                            , under =
+                                """data = data
+       }"""
+                            }
+                            |> Review.Test.whenFixed
+                                """module Route.Index exposing (Data, Model, Msg, route)
+
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
+import RouteBuilder exposing (Page, StaticPayload, single)
+import Pages.PageUrl exposing (PageUrl)
+import Pages.Url
+import Path
+import Route exposing (Route)
+import Shared
+import View exposing (View)
+
+
+type alias Model =
+   {}
+
+
+type alias Msg =
+   ()
+
+
+type alias RouteParams =
+   {}
+
+
+type alias Data =
+   ()
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+   single
+       { head = head
+       , data = BackendTask.fail (FatalError.fromString "")
+       }
+       |> RouteBuilder.buildNoState { view = view }
+
+
+data : BackendTask Data
+data =
+    BackendTask.succeed ()
+"""
+                        ]
+        , test "supports aliased BackendTask module import" <|
+            \() ->
+                """module Route.Index exposing (Data, Model, Msg, route)
+
+import Server.Request as Request
+import FatalError
+import BackendTask as DS
 import RouteBuilder exposing (Page, StaticPayload, single)
 import Pages.PageUrl exposing (PageUrl)
 import Pages.Url
@@ -47,9 +151,9 @@ route =
        |> RouteBuilder.buildNoState { view = view }
 
 
-data : DataSource Data
+data : BackendTask Data
 data =
-    DataSource.succeed ()
+    BackendTask.succeed ()
 """
                     |> Review.Test.run rule
                     |> Review.Test.expectErrors
@@ -64,7 +168,9 @@ data =
                             |> Review.Test.whenFixed
                                 """module Route.Index exposing (Data, Model, Msg, route)
 
-import DataSource exposing (DataSource)
+import Server.Request as Request
+import FatalError
+import BackendTask as DS
 import RouteBuilder exposing (Page, StaticPayload, single)
 import Pages.PageUrl exposing (PageUrl)
 import Pages.Url
@@ -94,21 +200,24 @@ route : StatelessRoute RouteParams Data ActionData
 route =
    single
        { head = head
-       , data = DataSource.fail ""
+       , data = DS.fail (FatalError.fromString "")
        }
        |> RouteBuilder.buildNoState { view = view }
 
 
-data : DataSource Data
+data : BackendTask Data
 data =
-    DataSource.succeed ()
+    BackendTask.succeed ()
 """
                         ]
         , test "replaces data record setter with non-empty RouteParams" <|
             \() ->
                 """module Route.Blog.Slug_ exposing (Data, Model, Msg, route)
 
-import DataSource exposing (DataSource)
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
 import RouteBuilder exposing (Page, StaticPayload)
 import Pages.PageUrl exposing (PageUrl)
 import Pages.Url
@@ -144,9 +253,9 @@ route =
         |> RouteBuilder.buildNoState { view = view }
 
 
-data : DataSource Data
+data : BackendTask Data
 data =
-    DataSource.succeed ()
+    BackendTask.succeed ()
 """
                     |> Review.Test.run rule
                     |> Review.Test.expectErrors
@@ -160,7 +269,10 @@ data =
                             |> Review.Test.whenFixed
                                 """module Route.Blog.Slug_ exposing (Data, Model, Msg, route)
 
-import DataSource exposing (DataSource)
+import Server.Request as Request
+
+import BackendTask exposing (BackendTask)
+import FatalError
 import RouteBuilder exposing (Page, StaticPayload)
 import Pages.PageUrl exposing (PageUrl)
 import Pages.Url
@@ -189,22 +301,25 @@ type alias Data =
 route : StatelessRoute RouteParams Data ActionData
 route =
     RouteBuilder.preRender
-        { data = \\_ -> DataSource.fail ""
+        { data = \\_ -> BackendTask.fail (FatalError.fromString "")
         , head = head
         , pages = pages
         }
         |> RouteBuilder.buildNoState { view = view }
 
 
-data : DataSource Data
+data : BackendTask Data
 data =
-    DataSource.succeed ()
+    BackendTask.succeed ()
 """
                         ]
         , test "replaces data record setter with RouteBuilder.serverRendered" <|
             \() ->
                 """module Route.Login exposing (Data, Model, Msg, route)
 
+import Server.Request as Request
+import FatalError
+
 type alias Model =
     {}
 
@@ -239,6 +354,9 @@ route =
                             |> Review.Test.whenFixed
                                 """module Route.Login exposing (Data, Model, Msg, route)
 
+import Server.Request as Request
+import FatalError
+
 type alias Model =
     {}
 
@@ -271,6 +389,9 @@ route =
                             |> Review.Test.whenFixed
                                 """module Route.Login exposing (Data, Model, Msg, route)
 
+import Server.Request as Request
+import FatalError
+
 type alias Model =
     {}
 
@@ -291,12 +412,116 @@ route =
         , action = \\_ -> Request.oneOf []
         }
         |> RouteBuilder.buildNoState { view = view }
+"""
+                        ]
+        , test "uses appropriate import alias for Server.Request module" <|
+            \() ->
+                """module Route.Login exposing (Data, Model, Msg, route)
+
+import Server.Request
+import FatalError
+
+type alias Model =
+    {}
+
+
+type alias Msg =
+    ()
+
+
+type alias RouteParams =
+    {}
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+    RouteBuilder.serverRender
+        { head = head
+        , data = data
+        , action = action
+        }
+        |> RouteBuilder.buildNoState { view = view }
+"""
+                    |> Review.Test.run rule
+                    |> Review.Test.expectErrors
+                        [ Review.Test.error
+                            { message = "Codemod"
+                            , details =
+                                [ "" ]
+                            , under =
+                                """data = data
+        ,"""
+                            }
+                            |> Review.Test.whenFixed
+                                """module Route.Login exposing (Data, Model, Msg, route)
+
+import Server.Request
+import FatalError
+
+type alias Model =
+    {}
+
+
+type alias Msg =
+    ()
+
+
+type alias RouteParams =
+    {}
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+    RouteBuilder.serverRender
+        { head = head
+        , data = \\_ -> Server.Request.oneOf []
+        , action = action
+        }
+        |> RouteBuilder.buildNoState { view = view }
+"""
+                        , Review.Test.error
+                            { message = "Codemod"
+                            , details =
+                                [ "" ]
+                            , under =
+                                """action = action
+        }"""
+                            }
+                            |> Review.Test.whenFixed
+                                """module Route.Login exposing (Data, Model, Msg, route)
+
+import Server.Request
+import FatalError
+
+type alias Model =
+    {}
+
+
+type alias Msg =
+    ()
+
+
+type alias RouteParams =
+    {}
+
+
+route : StatelessRoute RouteParams Data ActionData
+route =
+    RouteBuilder.serverRender
+        { head = head
+        , data = data
+        , action = \\_ -> Server.Request.oneOf []
+        }
+        |> RouteBuilder.buildNoState { view = view }
 """
                         ]
         , test "no Request.oneOf fix after replacement is made" <|
             \() ->
                 """module Route.Login exposing (Data, Model, Msg, route)
 
+import Server.Request as Request
+import FatalError
+
 type alias Model =
     {}
 
@@ -323,7 +548,10 @@ route =
             \() ->
                 """module Route.Index exposing (Data, Model, Msg, route)
 
-import DataSource exposing (DataSource)
+import Server.Request as Request
+import FatalError
+
+import BackendTask exposing (BackendTask)
 import RouteBuilder exposing (Page, StaticPayload)
 import Pages.PageUrl exposing (PageUrl)
 import Pages.Url
@@ -353,14 +581,14 @@ route : StatelessRoute RouteParams Data ActionData
 route =
    RouteBuilder.single
        { head = head
-       , data = DataSource.fail ""
+       , data = BackendTask.fail (FatalError.fromString "")
        }
        |> RouteBuilder.buildNoState { view = view }
 
 
-data : DataSource Data
+data : BackendTask Data
 data =
-    DataSource.succeed ()
+    BackendTask.succeed ()
 """
                     |> Review.Test.run rule
                     |> Review.Test.expectNoErrors
@@ -368,8 +596,11 @@ data =
             \() ->
                 """module Shared exposing (Data, Model, Msg, template)
 
+import Server.Request as Request
+import FatalError
+
 import Browser.Navigation
-import DataSource
+import BackendTask
 import Html exposing (Html)
 import Html.Styled
 import Pages.Flags
@@ -416,8 +647,11 @@ type alias Model =
                             |> Review.Test.whenFixed
                                 """module Shared exposing (Data, Model, Msg, template)
 
+import Server.Request as Request
+import FatalError
+
 import Browser.Navigation
-import DataSource
+import BackendTask
 import Html exposing (Html)
 import Html.Styled
 import Pages.Flags
@@ -435,7 +669,7 @@ template =
     { init = init
     , update = update
     , view = view
-    , data = DataSource.fail ""
+    , data = BackendTask.fail (FatalError.fromString "")
     , subscriptions = subscriptions
     , onPageChange = Just OnPageChange
     }

package/generator/review/elm-stuff/tests-0.19.1/elm.json

@@ -1 +1 @@
-{"type":"application","source-directories":["../../src","../../tests","../../../../src","src"],"elm-version":"0.19.1","dependencies":{"direct":{"elm/core":"1.0.5","elm/html":"1.0.0","elm/json":"1.1.3","elm/regex":"1.0.0","elm-community/result-extra":"2.4.0","elm-explorations/test":"1.2.2","jfmengels/elm-review":"2.4.2","mdgriffith/elm-codegen":"2.0.0","mpizenberg/elm-test-runner":"5.0.0","stil4m/elm-syntax":"7.2.5","the-sett/elm-syntax-dsl":"6.0.2"},"indirect":{"Chadtech/elm-bool-extra":"2.4.2","elm/parser":"1.1.0","elm/project-metadata-utils":"1.0.2","elm/random":"1.0.0","elm/time":"1.0.0","elm/virtual-dom":"1.0.3","elm-community/basics-extra":"4.1.0","elm-community/list-extra":"8.6.0","elm-community/maybe-extra":"5.3.0","miniBill/elm-unicode":"1.0.2","rtfeldman/elm-hex":"1.0.0","stil4m/structured-writer":"1.0.3","the-sett/elm-pretty-printer":"3.0.0"}},"test-dependencies":{"direct":{},"indirect":{}}}
+{"type":"application","source-directories":["../../src","../../tests","../../../../src","src"],"elm-version":"0.19.1","dependencies":{"direct":{"elm/core":"1.0.5","elm/html":"1.0.0","elm/json":"1.1.3","elm/regex":"1.0.0","elm-explorations/test":"2.1.0","jfmengels/elm-review":"2.10.0","mdgriffith/elm-codegen":"2.0.0","mpizenberg/elm-test-runner":"6.0.0","stil4m/elm-syntax":"7.2.9","the-sett/elm-syntax-dsl":"6.0.2"},"indirect":{"Chadtech/elm-bool-extra":"2.4.2","elm/bytes":"1.0.8","elm/parser":"1.1.0","elm/project-metadata-utils":"1.0.2","elm/random":"1.0.0","elm/time":"1.0.0","elm/virtual-dom":"1.0.3","elm-community/basics-extra":"4.1.0","elm-community/list-extra":"8.7.0","elm-community/maybe-extra":"5.3.0","miniBill/elm-unicode":"1.0.3","rtfeldman/elm-hex":"1.0.0","stil4m/structured-writer":"1.0.3","the-sett/elm-pretty-printer":"3.0.0"}},"test-dependencies":{"direct":{},"indirect":{}}}