elektron-lfo 1.0.8 → 1.0.9

package/dist/index.js

@@ -66,7 +66,7 @@ function generateSquare(phase) {
   return phase < 0.5 ? 1 : -1;
 }
 function generateSawtooth(phase) {
-  return 1 - phase * 2;
+  return phase * 2 - 1;
 }
 function generateExponential(phase) {
   const k = 3;
@@ -122,7 +122,7 @@ function generateWaveform(waveform, phase, state) {
   }
 }
 function isUnipolar(waveform) {
-  return waveform === "EXP" || waveform === "RMP";
+  return waveform === "RMP" || waveform === "EXP";
 }
 function getWaveformRange(waveform) {
   if (isUnipolar(waveform)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "elektron-lfo",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "Elektron LFO engine simulator implementation with CLI visualization",
   "main": "dist/index.js",
   "module": "src/index.ts",

package/src/engine/lfo.ts

@@ -289,7 +289,7 @@ export class LFO {
   }
 
   /**
-   * Stop the LFO
+   * Stop the LFO (pause, keeps current position)
    */
   stop(): void {
     this.state.isRunning = false;

package/src/engine/waveforms.ts

@@ -1,9 +1,8 @@
 /**
  * Waveform generators for Elektron Digitakt II LFO
  *
- * Waveform types:
- * - Bipolar (-1 to +1): TRI, SIN, SQR, SAW, RND
- * - Unipolar (0 to +1): EXP, RMP
+ * Most waveforms are bipolar (-1 to +1).
+ * RMP and EXP are unipolar (0 to +1) - depth parameter handles negative modulation.
  */
 
 import type { Waveform, LFOState } from './types';
@@ -40,29 +39,27 @@ export function generateSquare(phase: number): number {
 
 /**
  * Sawtooth waveform - Bipolar
- * Linear fall from +1 to -1 (with positive depth)
+ * Linear rise from -1 to +1 (matches Digitakt II behavior)
  */
 export function generateSawtooth(phase: number): number {
-  return 1 - phase * 2;
+  return phase * 2 - 1;
 }
 
 /**
  * Exponential waveform - Unipolar (0 to +1)
- * Decaying curve from 1 to 0 (matches Digitakt II behavior)
+ * Decaying curve from +1 to 0 (matches Digitakt II behavior)
  * Fast initial decay, slowing toward the end (true exponential decay shape)
  */
 export function generateExponential(phase: number): number {
   const k = 3; // Decay rate - controls steepness of decay
-  // True exponential decay: starts at 1, decays rapidly then slows
-  // Formula: (exp(-phase * k) - exp(-k)) / (1 - exp(-k))
-  // This normalizes to exactly [1, 0] range
+  // True exponential decay normalized to [1, 0]
   const expK = Math.exp(-k);
   return (Math.exp(-phase * k) - expK) / (1 - expK);
 }
 
 /**
  * Ramp waveform - Unipolar (0 to +1)
- * Linear rise from 0 to +1
+ * Linear rise from 0 to +1 (matches Digitakt II behavior)
  */
 export function generateRamp(phase: number): number {
   return phase;
@@ -141,9 +138,10 @@ export function generateWaveform(
 
 /**
  * Check if a waveform is unipolar (0 to +1) vs bipolar (-1 to +1)
+ * RMP and EXP are unipolar - depth parameter handles negative modulation
  */
 export function isUnipolar(waveform: Waveform): boolean {
-  return waveform === 'EXP' || waveform === 'RMP';
+  return waveform === 'RMP' || waveform === 'EXP';
 }
 
 /**

package/tests/waveforms.test.ts

@@ -123,22 +123,22 @@ describe('Square Waveform', () => {
 });
 
 describe('Sawtooth Waveform', () => {
-  test('starts at +1 at phase 0', () => {
-    expect(generateSawtooth(0)).toBe(1);
+  test('starts at -1 at phase 0', () => {
+    expect(generateSawtooth(0)).toBe(-1);
   });
 
   test('is 0 at phase 0.5', () => {
     expect(generateSawtooth(0.5)).toBe(0);
   });
 
-  test('approaches -1 at phase ~1', () => {
-    expect(generateSawtooth(1)).toBe(-1);
-    expect(generateSawtooth(0.999)).toBeCloseTo(-1, 2);
+  test('approaches +1 at phase ~1', () => {
+    expect(generateSawtooth(1)).toBe(1);
+    expect(generateSawtooth(0.999)).toBeCloseTo(1, 2);
   });
 
-  test('is bipolar and linear (falling)', () => {
-    expect(generateSawtooth(0.25)).toBeCloseTo(0.5, 5);
-    expect(generateSawtooth(0.75)).toBeCloseTo(-0.5, 5);
+  test('is bipolar and linear (rising)', () => {
+    expect(generateSawtooth(0.25)).toBeCloseTo(-0.5, 5);
+    expect(generateSawtooth(0.75)).toBeCloseTo(0.5, 5);
   });
 });