elektron-lfo 1.0.2 → 1.0.4

package/dist/index.js

@@ -66,14 +66,14 @@ function generateSquare(phase) {
   return phase < 0.5 ? 1 : -1;
 }
 function generateSawtooth(phase) {
-  return phase * 2 - 1;
+  return 1 - phase * 2;
 }
 function generateExponential(phase) {
   const k = 4;
   return (Math.exp(phase * k) - 1) / (Math.exp(k) - 1);
 }
 function generateRamp(phase) {
-  return 1 - phase;
+  return phase;
 }
 function generateRandom(phase, state) {
   const stepsPerCycle = 16;
@@ -283,7 +283,15 @@ function checkModeStop(config, state, previousPhase, currentPhase) {
   const isForward = config.speed >= 0;
   if (config.mode === "ONE") {
     if (state.cycleCount >= 1) {
-      return { shouldStop: true, cycleCompleted: true };
+      if (isForward) {
+        if (startPhase === 0 || currentPhase >= startPhase) {
+          return { shouldStop: true, cycleCompleted: true };
+        }
+      } else {
+        if (startPhase === 0 || currentPhase <= startPhase) {
+          return { shouldStop: true, cycleCompleted: true };
+        }
+      }
     }
   } else if (config.mode === "HLF") {
     const halfPhase = (startPhase + 0.5) % 1;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "elektron-lfo",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Elektron LFO engine simulator implementation with CLI visualization",
   "main": "dist/index.js",
   "module": "src/index.ts",

package/src/engine/waveforms.ts

@@ -40,10 +40,10 @@ export function generateSquare(phase: number): number {
 
 /**
  * Sawtooth waveform - Bipolar
- * Linear rise from -1 to +1
+ * Linear fall from +1 to -1 (with positive depth)
  */
 export function generateSawtooth(phase: number): number {
-  return phase * 2 - 1;
+  return 1 - phase * 2;
 }
 
 /**
@@ -57,10 +57,10 @@ export function generateExponential(phase: number): number {
 
 /**
  * Ramp waveform - Unipolar (0 to +1)
- * Linear fall from +1 to 0
+ * Linear rise from 0 to +1
  */
 export function generateRamp(phase: number): number {
-  return 1 - phase;
+  return phase;
 }
 
 /**

package/tests/waveforms.test.ts

@@ -123,22 +123,22 @@ describe('Square Waveform', () => {
 });
 
 describe('Sawtooth Waveform', () => {
-  test('starts at -1 at phase 0', () => {
-    expect(generateSawtooth(0)).toBe(-1);
+  test('starts at +1 at phase 0', () => {
+    expect(generateSawtooth(0)).toBe(1);
   });
 
   test('is 0 at phase 0.5', () => {
     expect(generateSawtooth(0.5)).toBe(0);
   });
 
-  test('approaches +1 at phase ~1', () => {
-    expect(generateSawtooth(1)).toBe(1);
-    expect(generateSawtooth(0.999)).toBeCloseTo(1, 2);
+  test('approaches -1 at phase ~1', () => {
+    expect(generateSawtooth(1)).toBe(-1);
+    expect(generateSawtooth(0.999)).toBeCloseTo(-1, 2);
   });
 
-  test('is bipolar and linear', () => {
-    expect(generateSawtooth(0.25)).toBeCloseTo(-0.5, 5);
-    expect(generateSawtooth(0.75)).toBeCloseTo(0.5, 5);
+  test('is bipolar and linear (falling)', () => {
+    expect(generateSawtooth(0.25)).toBeCloseTo(0.5, 5);
+    expect(generateSawtooth(0.75)).toBeCloseTo(-0.5, 5);
   });
 });
 
@@ -165,12 +165,12 @@ describe('Exponential Waveform', () => {
 });
 
 describe('Ramp Waveform', () => {
-  test('starts at 1 at phase 0', () => {
-    expect(generateRamp(0)).toBe(1);
+  test('starts at 0 at phase 0', () => {
+    expect(generateRamp(0)).toBe(0);
   });
 
-  test('ends at 0 at phase 1', () => {
-    expect(generateRamp(1)).toBe(0);
+  test('ends at 1 at phase 1', () => {
+    expect(generateRamp(1)).toBe(1);
   });
 
   test('is 0.5 at phase 0.5', () => {
@@ -183,9 +183,9 @@ describe('Ramp Waveform', () => {
     expect(Math.max(...samples)).toBeLessThanOrEqual(1);
   });
 
-  test('is linear', () => {
-    expect(generateRamp(0.25)).toBe(0.75);
-    expect(generateRamp(0.75)).toBe(0.25);
+  test('is linear (rising)', () => {
+    expect(generateRamp(0.25)).toBe(0.25);
+    expect(generateRamp(0.75)).toBe(0.75);
   });
 });
 
@@ -238,7 +238,7 @@ describe('generateWaveform', () => {
     expect(generateWaveform('SQR', 0.25, state).value).toBe(1);
     expect(generateWaveform('SAW', 0.5, state).value).toBe(0);
     expect(generateWaveform('EXP', 1, state).value).toBeCloseTo(1, 5);
-    expect(generateWaveform('RMP', 0, state).value).toBe(1);
+    expect(generateWaveform('RMP', 0, state).value).toBe(0);
   });
 });