electron-findbar 3.0.0 → 3.1.0

package/README.md

@@ -327,6 +327,49 @@ FindbarRemote.open()
 FindbarRemote.inputChange('findIt')
 ```
 
+## Changing the Parent Window
+
+There are scenarios where you might need to change the parent window.
+
+### Using updateParentWindow
+
+The `updateParentWindow` method allows you to change the parent window while preserving the findbar instance and its state:
+
+```javascript
+// Create a findbar for the initial window
+const findbar = Findbar.from(oldWindow, webContents)
+
+// Later, when you need to change the parent:
+findbar.updateParentWindow(newWindow)
+```
+
+This approach keeps the same findbar instance connected to the same webContents, but changes which window it's attached to. The findbar will close immediately.
+
+### Using detach
+
+Alternatively, the `detach` method disconnects a findbar instance from its webContents, allowing you to create a new instance in the next `Findbar.from` call:
+
+```javascript
+// Get the existing findbar
+const oldFindbar = Findbar.fromIfExists(webContents)
+
+// Detach it to free the association
+if (oldFindbar) {
+  oldFindbar.detach()
+}
+
+// Now create a new findbar with a different parent
+const newFindbar = Findbar.from([newWindow, ]webContents)
+```
+
+This approach is useful when you want to completely reset the findbar's configuration or when moving between very different window configurations.
+
+### Important Considerations
+
+- If the findbar is currently open when you change the parent window, it will automatically close.
+- Window options and handlers will be preserved when using `updateParentWindow`.
+- After calling `detach`, the old findbar instance can no longer be used.
+
 ## Author
 
 Created by [Emerson Capuchi Romaneli](https://github.com/ECRomaneli) (@ECRomaneli).

package/index.js

@@ -74,6 +74,8 @@ class Findbar {
         }
 
         this.#findableContents._findbar = this
+
+        this.#findableContents.once('destroyed', () => { this.detach() })
     }
 
     /**
@@ -116,10 +118,15 @@ class Findbar {
         if (this.#window) { this.#window.webContents._findbar = void 0 }
     }
 
-    setTheme(theme) {
-        if (this.#window && !this.#window.isDestroyed()) {
-            this.#window.webContents.send('electron-findbar/set-theme', theme)
-        }
+    /**
+     * Update the parent window of the findbar.
+     * @param {BaseWindow} [newParent] - The new parent window. If not provided, the parent will be set to the window containing the web contents.
+     * @returns {void}
+     */
+    updateParentWindow(newParent) {
+        if (this.#parent === newParent) { return }
+        this.close()
+        this.#parent = newParent ?? Findbar.#getBaseWindowFromWebContents(this.#findableContents)
     }
 
     /**
@@ -310,7 +317,7 @@ class Findbar {
             this.#parent.prependListener('move', boundsHandler)
         }
 
-        this.#window.once('close', () => {
+        this.#window.once('closed', () => {
             if (this.#parent && !this.#parent.isDestroyed()) {
                 this.#parent.off('show', showCascade)
                 this.#parent.off('hide', hideCascade)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "electron-findbar",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "Chrome-like findbar for your Electron app.",
   "main": "index.js",
   "files": [