electron-cli 0.3.0-alpha.10 → 0.3.0-alpha.11

package/src/commands/publish.rs

@@ -1,15 +1,16 @@
 use std::{
     fs,
+    fs::File,
     path::{Path, PathBuf},
-    time::{SystemTime, UNIX_EPOCH},
+    time::{Duration, SystemTime, UNIX_EPOCH},
 };
 
 use anyhow::{bail, Context, Result};
 use camino::Utf8PathBuf;
-use serde::Serialize;
+use serde::{de::DeserializeOwned, Deserialize, Serialize};
 
 use crate::{
-    cli::{MakeArgs, PublishArgs},
+    cli::{MakeArgs, PublishArgs, PublishTarget},
     commands::make::{self, MakeReport},
     output,
 };
@@ -19,9 +20,8 @@ struct PublishReport {
     make: MakeReport,
     publisher: String,
     channel: String,
-    destination_dir: Utf8PathBuf,
-    destination_artifact: Utf8PathBuf,
-    manifest: Utf8PathBuf,
+    local: Option<LocalPublishPlan>,
+    github: Option<GithubPublishPlan>,
     skip_make: bool,
     dry_run: bool,
     status: PublishStatus,
@@ -29,6 +29,26 @@ struct PublishReport {
     warnings: Vec<String>,
 }
 
+#[derive(Debug, Serialize)]
+struct LocalPublishPlan {
+    destination_dir: Utf8PathBuf,
+    destination_artifact: Utf8PathBuf,
+    manifest: Utf8PathBuf,
+}
+
+#[derive(Debug, Serialize)]
+struct GithubPublishPlan {
+    repo: String,
+    tag: String,
+    release_name: String,
+    draft: bool,
+    prerelease: bool,
+    api_url: String,
+    artifact_name: String,
+    release_url: Option<String>,
+    asset_url: Option<String>,
+}
+
 #[derive(Debug, Serialize)]
 #[serde(rename_all = "kebab-case")]
 enum PublishStatus {
@@ -86,17 +106,11 @@ fn build_report(args: &PublishArgs) -> Result<PublishReport> {
     };
     let make = make::build_report(&make_args)?;
     let root = Path::new(make.package().project().root.as_str());
-    let publish_root = resolve_destination(root, &args.to);
-    let destination_dir = publish_root
-        .join(&args.channel)
-        .join(make.package().platform())
-        .join(make.package().arch());
     let artifact_name = make
         .artifact()
         .file_name()
-        .context("Make artifact path has no file name")?;
-    let destination_artifact = destination_dir.join(artifact_name);
-    let manifest = destination_dir.join("manifest.json");
+        .context("Make artifact path has no UTF-8 file name")?
+        .to_string();
 
     let mut warnings = make.warnings().to_vec();
     if args.skip_make && !Path::new(make.artifact().as_str()).exists() {
@@ -105,26 +119,35 @@ fn build_report(args: &PublishArgs) -> Result<PublishReport> {
             make.artifact()
         ));
     }
-    if destination_artifact.exists() && !args.force {
-        warnings.push(format!(
-            "Publish artifact already exists: {}. Use --force to overwrite it.",
-            destination_artifact.display()
-        ));
-    }
-    if manifest.exists() && !args.force {
-        warnings.push(format!(
-            "Publish manifest already exists: {}. Use --force to overwrite it.",
-            manifest.display()
-        ));
-    }
+    let (local, github) = match args.publisher {
+        PublishTarget::Local => {
+            let local = build_local_plan(root, args, &make, &artifact_name)?;
+            if Path::new(local.destination_artifact.as_str()).exists() && !args.force {
+                warnings.push(format!(
+                    "Publish artifact already exists: {}. Use --force to overwrite it.",
+                    local.destination_artifact
+                ));
+            }
+            if Path::new(local.manifest.as_str()).exists() && !args.force {
+                warnings.push(format!(
+                    "Publish manifest already exists: {}. Use --force to overwrite it.",
+                    local.manifest
+                ));
+            }
+            (Some(local), None)
+        }
+        PublishTarget::Github => {
+            let github = build_github_plan(args, &make, &artifact_name, &mut warnings)?;
+            (None, Some(github))
+        }
+    };
 
     Ok(PublishReport {
         make,
         publisher: args.publisher.as_str().to_string(),
         channel: args.channel.clone(),
-        destination_dir: utf8_path(destination_dir)?,
-        destination_artifact: utf8_path(destination_artifact)?,
-        manifest: utf8_path(manifest)?,
+        local,
+        github,
         skip_make: args.skip_make,
         dry_run: args.dry_run,
         status: PublishStatus::Planned,
@@ -133,6 +156,77 @@ fn build_report(args: &PublishArgs) -> Result<PublishReport> {
     })
 }
 
+fn build_local_plan(
+    root: &Path,
+    args: &PublishArgs,
+    make: &MakeReport,
+    artifact_name: &str,
+) -> Result<LocalPublishPlan> {
+    let publish_root = resolve_destination(root, &args.to);
+    let destination_dir = publish_root
+        .join(&args.channel)
+        .join(make.package().platform())
+        .join(make.package().arch());
+    let destination_artifact = destination_dir.join(artifact_name);
+    let manifest = destination_dir.join("manifest.json");
+
+    Ok(LocalPublishPlan {
+        destination_dir: utf8_path(destination_dir)?,
+        destination_artifact: utf8_path(destination_artifact)?,
+        manifest: utf8_path(manifest)?,
+    })
+}
+
+fn build_github_plan(
+    args: &PublishArgs,
+    make: &MakeReport,
+    artifact_name: &str,
+    warnings: &mut Vec<String>,
+) -> Result<GithubPublishPlan> {
+    let repo = args
+        .github_repo
+        .clone()
+        .or_else(|| {
+            make.package()
+                .project()
+                .repository
+                .as_deref()
+                .and_then(github_repo_from_repository)
+        })
+        .unwrap_or_default();
+    if repo.is_empty() {
+        warnings.push(
+            "GitHub repository is not configured. Pass --github-repo OWNER/REPO or set package.json repository.".to_string(),
+        );
+    } else if !valid_github_repo(&repo) {
+        warnings.push(format!(
+            "GitHub repository should use OWNER/REPO form: {repo}."
+        ));
+    }
+
+    let tag = args
+        .github_tag
+        .clone()
+        .unwrap_or_else(|| default_github_tag(make, &args.channel));
+    let release_name = args
+        .github_release_name
+        .clone()
+        .unwrap_or_else(|| tag.clone());
+    let prerelease = args.github_prerelease || tag.contains('-');
+
+    Ok(GithubPublishPlan {
+        repo,
+        tag,
+        release_name,
+        draft: args.github_draft,
+        prerelease,
+        api_url: args.github_api_url.trim_end_matches('/').to_string(),
+        artifact_name: artifact_name.to_string(),
+        release_url: None,
+        asset_url: None,
+    })
+}
+
 fn execute_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()> {
     if !args.skip_make {
         let make_args = MakeArgs {
@@ -156,8 +250,26 @@ fn execute_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()>
         );
     }
 
-    let destination_artifact = Path::new(report.destination_artifact.as_str());
-    let manifest = Path::new(report.manifest.as_str());
+    let published_at_unix_seconds = now_unix_seconds()?;
+    report.published_at_unix_seconds = Some(published_at_unix_seconds);
+
+    match args.publisher {
+        PublishTarget::Local => execute_local_publish(report, args, published_at_unix_seconds),
+        PublishTarget::Github => execute_github_publish(report, args),
+    }
+}
+
+fn execute_local_publish(
+    report: &PublishReport,
+    args: &PublishArgs,
+    published_at_unix_seconds: u64,
+) -> Result<()> {
+    let local = report
+        .local
+        .as_ref()
+        .context("Local publish plan was not built")?;
+    let destination_artifact = Path::new(local.destination_artifact.as_str());
+    let manifest = Path::new(local.manifest.as_str());
 
     for path in [destination_artifact, manifest] {
         if path.exists() {
@@ -173,8 +285,8 @@ fn execute_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()>
         }
     }
 
-    fs::create_dir_all(report.destination_dir.as_str())
-        .with_context(|| format!("Could not create {}", report.destination_dir))?;
+    fs::create_dir_all(local.destination_dir.as_str())
+        .with_context(|| format!("Could not create {}", local.destination_dir))?;
     fs::copy(report.make.artifact().as_str(), destination_artifact).with_context(|| {
         format!(
             "Could not publish {} to {}",
@@ -183,8 +295,6 @@ fn execute_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()>
         )
     })?;
 
-    let published_at_unix_seconds = now_unix_seconds()?;
-    report.published_at_unix_seconds = Some(published_at_unix_seconds);
     let manifest_json =
         serde_json::to_string_pretty(&build_manifest(report, published_at_unix_seconds)?)?;
     fs::write(manifest, format!("{manifest_json}\n"))
@@ -193,11 +303,229 @@ fn execute_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()>
     Ok(())
 }
 
+fn execute_github_publish(report: &mut PublishReport, args: &PublishArgs) -> Result<()> {
+    let token = github_token()?;
+    let agent = github_agent();
+    publish_to_github(report, args, &token, &agent)
+}
+
+#[derive(Debug, Serialize)]
+struct CreateGithubRelease<'a> {
+    tag_name: &'a str,
+    name: &'a str,
+    body: &'a str,
+    draft: bool,
+    prerelease: bool,
+}
+
+#[derive(Debug, Deserialize)]
+struct GithubRelease {
+    html_url: String,
+    upload_url: String,
+    #[serde(default)]
+    assets: Vec<GithubAsset>,
+}
+
+#[derive(Debug, Deserialize)]
+struct GithubAsset {
+    id: u64,
+    name: String,
+    browser_download_url: String,
+}
+
+#[derive(Debug, Deserialize)]
+struct GithubErrorBody {
+    message: Option<String>,
+}
+
+fn publish_to_github(
+    report: &mut PublishReport,
+    args: &PublishArgs,
+    token: &str,
+    agent: &ureq::Agent,
+) -> Result<()> {
+    let artifact_path = Path::new(report.make.artifact().as_str());
+    let github = report
+        .github
+        .as_mut()
+        .context("GitHub publish plan was not built")?;
+    if github.repo.is_empty() || !valid_github_repo(&github.repo) {
+        bail!("GitHub repository must be configured as OWNER/REPO.");
+    }
+
+    let release = get_or_create_github_release(agent, token, github)?;
+    if let Some(asset) = release
+        .assets
+        .iter()
+        .find(|asset| asset.name == github.artifact_name)
+    {
+        if args.force {
+            delete_github_asset(agent, token, github, asset.id)?;
+        } else {
+            bail!(
+                "GitHub release asset already exists: {}. Use --force to replace it.",
+                github.artifact_name
+            );
+        }
+    }
+
+    let asset = upload_github_asset(agent, token, github, &release.upload_url, artifact_path)?;
+    github.release_url = Some(release.html_url);
+    github.asset_url = Some(asset.browser_download_url);
+
+    Ok(())
+}
+
+fn get_or_create_github_release(
+    agent: &ureq::Agent,
+    token: &str,
+    github: &GithubPublishPlan,
+) -> Result<GithubRelease> {
+    let get_url = format!(
+        "{}/repos/{}/releases/tags/{}",
+        github.api_url,
+        github.repo,
+        encode_url_component(&github.tag)
+    );
+    let response = github_request(agent.get(&get_url), token)
+        .call()
+        .with_context(|| format!("Could not query GitHub release {}", github.tag))?;
+    match response.status().as_u16() {
+        200 => parse_github_response(response, "Could not parse GitHub release"),
+        404 => create_github_release(agent, token, github),
+        status => github_status_error(response, status, "Could not query GitHub release"),
+    }
+}
+
+fn create_github_release(
+    agent: &ureq::Agent,
+    token: &str,
+    github: &GithubPublishPlan,
+) -> Result<GithubRelease> {
+    let url = format!("{}/repos/{}/releases", github.api_url, github.repo);
+    let body = format!(
+        "{} {} {} artifact published by electron-cli.",
+        github.artifact_name, github.tag, github.repo
+    );
+    let request = CreateGithubRelease {
+        tag_name: &github.tag,
+        name: &github.release_name,
+        body: &body,
+        draft: github.draft,
+        prerelease: github.prerelease,
+    };
+    let response = github_request(agent.post(&url), token)
+        .content_type("application/json")
+        .send_json(&request)
+        .with_context(|| format!("Could not create GitHub release {}", github.tag))?;
+    let status = response.status().as_u16();
+    if status == 201 {
+        parse_github_response(response, "Could not parse created GitHub release")
+    } else {
+        github_status_error(response, status, "Could not create GitHub release")
+    }
+}
+
+fn delete_github_asset(
+    agent: &ureq::Agent,
+    token: &str,
+    github: &GithubPublishPlan,
+    asset_id: u64,
+) -> Result<()> {
+    let url = format!(
+        "{}/repos/{}/releases/assets/{}",
+        github.api_url, github.repo, asset_id
+    );
+    let response = github_request(agent.delete(&url), token)
+        .call()
+        .with_context(|| format!("Could not delete GitHub release asset {asset_id}"))?;
+    let status = response.status().as_u16();
+    if status == 204 {
+        Ok(())
+    } else {
+        github_status_error(response, status, "Could not delete GitHub release asset")
+    }
+}
+
+fn upload_github_asset(
+    agent: &ureq::Agent,
+    token: &str,
+    github: &GithubPublishPlan,
+    upload_url: &str,
+    artifact_path: &Path,
+) -> Result<GithubAsset> {
+    let url = github_asset_upload_url(upload_url, &github.artifact_name);
+    let file = File::open(artifact_path)
+        .with_context(|| format!("Could not open {}", artifact_path.display()))?;
+    let response = github_request(agent.post(&url), token)
+        .content_type("application/octet-stream")
+        .send(file)
+        .with_context(|| format!("Could not upload {}", artifact_path.display()))?;
+    let status = response.status().as_u16();
+    if status == 201 {
+        parse_github_response(response, "Could not parse uploaded GitHub asset")
+    } else {
+        github_status_error(response, status, "Could not upload GitHub release asset")
+    }
+}
+
+fn github_request<T>(request: ureq::RequestBuilder<T>, token: &str) -> ureq::RequestBuilder<T> {
+    request
+        .header("Accept", "application/vnd.github+json")
+        .header("Authorization", format!("Bearer {token}"))
+        .header(
+            "User-Agent",
+            format!("electron-cli/{}", env!("CARGO_PKG_VERSION")),
+        )
+}
+
+fn parse_github_response<T: DeserializeOwned>(
+    mut response: ureq::http::Response<ureq::Body>,
+    context: &str,
+) -> Result<T> {
+    response
+        .body_mut()
+        .read_json::<T>()
+        .with_context(|| context.to_string())
+}
+
+fn github_status_error<T>(
+    mut response: ureq::http::Response<ureq::Body>,
+    status: u16,
+    context: &str,
+) -> Result<T> {
+    let body = response.body_mut().read_to_string().unwrap_or_default();
+    let message = serde_json::from_str::<GithubErrorBody>(&body)
+        .ok()
+        .and_then(|body| body.message)
+        .filter(|message| !message.trim().is_empty())
+        .unwrap_or(body);
+    bail!("{context}: HTTP {status}: {message}")
+}
+
+fn github_agent() -> ureq::Agent {
+    ureq::Agent::config_builder()
+        .http_status_as_error(false)
+        .timeout_global(Some(Duration::from_secs(300)))
+        .build()
+        .into()
+}
+
+fn github_token() -> Result<String> {
+    std::env::var("GITHUB_TOKEN")
+        .or_else(|_| std::env::var("GH_TOKEN"))
+        .context("GitHub publisher requires GITHUB_TOKEN or GH_TOKEN")
+}
+
 fn build_manifest(
     report: &PublishReport,
     published_at_unix_seconds: u64,
 ) -> Result<PublishManifest> {
-    let destination_artifact = Path::new(report.destination_artifact.as_str());
+    let local = report
+        .local
+        .as_ref()
+        .context("Local publish manifest requires a local publish plan")?;
+    let destination_artifact = Path::new(local.destination_artifact.as_str());
     let artifact_size = fs::metadata(destination_artifact)
         .with_context(|| format!("Could not stat {}", destination_artifact.display()))?
         .len();
@@ -220,7 +548,7 @@ fn build_manifest(
         published_at_unix_seconds,
         artifacts: vec![PublishedArtifact {
             file: artifact_file,
-            path: report.destination_artifact.clone(),
+            path: local.destination_artifact.clone(),
             size: artifact_size,
         }],
     })
@@ -252,8 +580,22 @@ fn print_report(report: &PublishReport, json: bool) -> Result<()> {
 
     println!();
     println!("Publish");
-    println!("  artifact: {}", report.destination_artifact);
-    println!("  manifest: {}", report.manifest);
+    if let Some(local) = &report.local {
+        println!("  artifact: {}", local.destination_artifact);
+        println!("  manifest: {}", local.manifest);
+    }
+    if let Some(github) = &report.github {
+        println!("  repository: {}", github.repo);
+        println!("  tag: {}", github.tag);
+        println!("  release: {}", github.release_name);
+        println!("  artifact: {}", github.artifact_name);
+        if let Some(url) = &github.release_url {
+            println!("  release url: {url}");
+        }
+        if let Some(url) = &github.asset_url {
+            println!("  asset url: {url}");
+        }
+    }
 
     if !report.warnings.is_empty() {
         println!();
@@ -274,6 +616,80 @@ fn resolve_destination(root: &Path, destination: &Path) -> PathBuf {
     }
 }
 
+fn default_github_tag(make: &MakeReport, channel: &str) -> String {
+    make.package()
+        .project()
+        .version
+        .as_deref()
+        .map(|version| {
+            if version.starts_with('v') {
+                version.to_string()
+            } else {
+                format!("v{version}")
+            }
+        })
+        .unwrap_or_else(|| channel.to_string())
+}
+
+fn valid_github_repo(repo: &str) -> bool {
+    let mut parts = repo.split('/');
+    let Some(owner) = parts.next() else {
+        return false;
+    };
+    let Some(name) = parts.next() else {
+        return false;
+    };
+    parts.next().is_none() && valid_github_path_part(owner) && valid_github_path_part(name)
+}
+
+fn valid_github_path_part(part: &str) -> bool {
+    !part.is_empty()
+        && part
+            .chars()
+            .all(|char| char.is_ascii_alphanumeric() || matches!(char, '-' | '_' | '.'))
+}
+
+fn github_repo_from_repository(repository: &str) -> Option<String> {
+    let mut value = repository.trim().trim_start_matches("git+").to_string();
+    if let Some(fragment) = value.find('#') {
+        value.truncate(fragment);
+    }
+    let value = value.trim_end_matches(".git");
+    let path = value
+        .split_once("github.com:")
+        .map(|(_, path)| path)
+        .or_else(|| value.split_once("github.com/").map(|(_, path)| path))?;
+    let mut parts = path.trim_matches('/').split('/');
+    let owner = parts.next()?.trim();
+    let repo = parts.next()?.trim();
+    if owner.is_empty() || repo.is_empty() {
+        None
+    } else {
+        Some(format!("{owner}/{repo}"))
+    }
+}
+
+fn github_asset_upload_url(upload_url: &str, artifact_name: &str) -> String {
+    let base = upload_url.split('{').next().unwrap_or(upload_url);
+    let separator = if base.contains('?') { '&' } else { '?' };
+    format!(
+        "{base}{separator}name={}",
+        encode_url_component(artifact_name)
+    )
+}
+
+fn encode_url_component(value: &str) -> String {
+    let mut encoded = String::new();
+    for byte in value.bytes() {
+        if byte.is_ascii_alphanumeric() || matches!(byte, b'-' | b'.' | b'_' | b'~') {
+            encoded.push(byte as char);
+        } else {
+            encoded.push_str(&format!("%{byte:02X}"));
+        }
+    }
+    encoded
+}
+
 fn now_unix_seconds() -> Result<u64> {
     Ok(SystemTime::now()
         .duration_since(UNIX_EPOCH)
@@ -302,6 +718,12 @@ impl PublishStatus {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use std::{
+        io::{Read, Write},
+        net::{TcpListener, TcpStream},
+        sync::{Arc, Mutex},
+        thread,
+    };
 
     #[test]
     fn builds_local_publish_report() {
@@ -315,7 +737,8 @@ mod tests {
 
         assert_eq!(report.publisher, "local");
         assert_eq!(report.channel, "default");
-        assert!(Path::new(report.destination_artifact.as_str()).ends_with(
+        let local = report.local.as_ref().expect("local plan should exist");
+        assert!(Path::new(local.destination_artifact.as_str()).ends_with(
             PathBuf::from("out")
                 .join("publish")
                 .join("local")
@@ -344,16 +767,103 @@ mod tests {
 
         execute_publish(&mut report, &args).expect("publish should succeed");
 
-        assert!(Path::new(report.destination_artifact.as_str()).exists());
-        assert!(Path::new(report.manifest.as_str()).exists());
-        let manifest =
-            fs::read_to_string(report.manifest.as_str()).expect("manifest should be readable");
+        let local = report.local.as_ref().expect("local plan should exist");
+        assert!(Path::new(local.destination_artifact.as_str()).exists());
+        assert!(Path::new(local.manifest.as_str()).exists());
+        let manifest = fs::read_to_string(local.manifest.as_str()).expect("manifest should read");
         assert!(manifest.contains("\"publisher\": \"local\""));
         assert!(manifest.contains("\"app_name\": \"starter-app\""));
 
         let _ = fs::remove_dir_all(root);
     }
 
+    #[test]
+    fn builds_github_publish_report_from_package_repository() {
+        let root = unique_temp_dir("github-plan");
+        write_github_package_json(&root);
+        write_app_file(&root);
+        write_fake_electron_dist(&root);
+
+        let args = github_publish_args(root.clone(), true, "http://127.0.0.1:9");
+        let report = build_report(&args).expect("report should build");
+
+        assert_eq!(report.publisher, "github");
+        assert!(report.local.is_none());
+        let github = report.github.as_ref().expect("github plan should exist");
+        assert_eq!(github.repo, "Ikana/electron-cli");
+        assert_eq!(github.tag, "v0.1.0");
+        assert_eq!(github.release_name, "v0.1.0");
+        assert!(!github.draft);
+        assert!(!github.prerelease);
+        assert_eq!(
+            github.artifact_name,
+            format!(
+                "starter-app-{}-{}.zip",
+                report.make.package().platform(),
+                report.make.package().arch()
+            )
+        );
+
+        let _ = fs::remove_dir_all(root);
+    }
+
+    #[test]
+    fn publishes_make_artifact_to_github_release() {
+        let server = MockGithubServer::new(3);
+        let root = unique_temp_dir("github-execute");
+        write_github_package_json(&root);
+        write_app_file(&root);
+        write_fake_electron_dist(&root);
+
+        let mut args = github_publish_args(root.clone(), false, &server.api_url);
+        args.skip_make = true;
+        let mut report = build_report(&args).expect("report should build");
+        let artifact = Path::new(report.make.artifact().as_str());
+        fs::create_dir_all(artifact.parent().expect("artifact parent should exist"))
+            .expect("artifact parent should be created");
+        fs::write(artifact, b"artifact bytes").expect("artifact should be written");
+
+        let agent = github_agent();
+        publish_to_github(&mut report, &args, "test-token", &agent)
+            .expect("github publish should succeed");
+
+        let github = report.github.as_ref().expect("github plan should exist");
+        let artifact_name = github.artifact_name.clone();
+        assert_eq!(
+            github.release_url.as_deref(),
+            Some("https://github.com/Ikana/electron-cli/releases/tag/v0.1.0")
+        );
+        assert_eq!(
+            github.asset_url.as_deref(),
+            Some("https://github.com/Ikana/electron-cli/releases/download/v0.1.0/starter-app.zip")
+        );
+
+        let requests = server.finish();
+        assert_eq!(requests.len(), 3);
+        assert_eq!(requests[0].method, "GET");
+        assert_eq!(
+            requests[0].path,
+            "/repos/Ikana/electron-cli/releases/tags/v0.1.0"
+        );
+        assert_eq!(
+            requests[0].header("authorization").as_deref(),
+            Some("Bearer test-token")
+        );
+        assert_eq!(requests[1].method, "POST");
+        assert_eq!(requests[1].path, "/repos/Ikana/electron-cli/releases");
+        let release_body =
+            String::from_utf8(requests[1].body.clone()).expect("release body should be utf-8");
+        assert!(release_body.contains("\"tag_name\": \"v0.1.0\""));
+        assert_eq!(requests[2].method, "POST");
+        assert_eq!(
+            requests[2].path,
+            format!("/uploads/1?name={}", encode_url_component(&artifact_name))
+        );
+        assert_eq!(requests[2].body, b"artifact bytes");
+
+        let _ = fs::remove_dir_all(root);
+    }
+
     #[test]
     fn skip_make_requires_existing_artifact() {
         let root = unique_temp_dir("skip-make");
@@ -370,6 +880,22 @@ mod tests {
         let _ = fs::remove_dir_all(root);
     }
 
+    #[test]
+    fn parses_github_repository_urls() {
+        assert_eq!(
+            github_repo_from_repository("git+https://github.com/Ikana/electron-cli.git"),
+            Some("Ikana/electron-cli".to_string())
+        );
+        assert_eq!(
+            github_repo_from_repository("git@github.com:Ikana/electron-cli.git"),
+            Some("Ikana/electron-cli".to_string())
+        );
+        assert_eq!(
+            github_repo_from_repository("https://example.com/Ikana/electron-cli.git"),
+            None
+        );
+    }
+
     fn publish_args(root: PathBuf, dry_run: bool) -> PublishArgs {
         PublishArgs {
             cwd: root,
@@ -380,6 +906,12 @@ mod tests {
             target: crate::cli::MakeTarget::Zip,
             publisher: crate::cli::PublishTarget::Local,
             to: PathBuf::from("out/publish/local"),
+            github_repo: None,
+            github_tag: None,
+            github_release_name: None,
+            github_draft: false,
+            github_prerelease: false,
+            github_api_url: "https://api.github.com".to_string(),
             channel: "default".to_string(),
             skip_make: false,
             force: false,
@@ -388,6 +920,13 @@ mod tests {
         }
     }
 
+    fn github_publish_args(root: PathBuf, dry_run: bool, api_url: &str) -> PublishArgs {
+        let mut args = publish_args(root, dry_run);
+        args.publisher = crate::cli::PublishTarget::Github;
+        args.github_api_url = api_url.to_string();
+        args
+    }
+
     fn write_package_json(root: &Path) {
         fs::write(
             root.join("package.json"),
@@ -396,6 +935,14 @@ mod tests {
         .expect("package.json should be written");
     }
 
+    fn write_github_package_json(root: &Path) {
+        fs::write(
+            root.join("package.json"),
+            r#"{"name":"starter-app","version":"0.1.0","repository":{"type":"git","url":"git+https://github.com/Ikana/electron-cli.git"},"main":"src/main.js","devDependencies":{"electron":"30.0.0"}}"#,
+        )
+        .expect("package.json should be written");
+    }
+
     fn write_app_file(root: &Path) {
         fs::create_dir_all(root.join("src")).expect("src should be created");
         fs::write(root.join("src/main.js"), "console.log('hello');")
@@ -429,4 +976,151 @@ mod tests {
         fs::create_dir_all(&path).expect("temp dir should be created");
         path
     }
+
+    #[derive(Debug, Clone)]
+    struct RecordedRequest {
+        method: String,
+        path: String,
+        headers: Vec<(String, String)>,
+        body: Vec<u8>,
+    }
+
+    impl RecordedRequest {
+        fn header(&self, name: &str) -> Option<String> {
+            self.headers
+                .iter()
+                .find(|(key, _)| key.eq_ignore_ascii_case(name))
+                .map(|(_, value)| value.clone())
+        }
+    }
+
+    struct MockGithubServer {
+        api_url: String,
+        requests: Arc<Mutex<Vec<RecordedRequest>>>,
+        handle: Option<thread::JoinHandle<()>>,
+    }
+
+    impl MockGithubServer {
+        fn new(request_count: usize) -> Self {
+            let listener = TcpListener::bind("127.0.0.1:0").expect("server should bind");
+            let address = listener.local_addr().expect("server address should read");
+            let api_url = format!("http://{address}");
+            let requests = Arc::new(Mutex::new(Vec::new()));
+            let thread_requests = Arc::clone(&requests);
+            let thread_api_url = api_url.clone();
+            let handle = thread::spawn(move || {
+                for index in 0..request_count {
+                    let (mut stream, _) = listener.accept().expect("request should connect");
+                    let request = read_http_request(&mut stream);
+                    thread_requests
+                        .lock()
+                        .expect("requests should lock")
+                        .push(request);
+
+                    match index {
+                        0 => write_http_response(&mut stream, 404, r#"{"message":"Not Found"}"#),
+                        1 => write_http_response(
+                            &mut stream,
+                            201,
+                            &format!(
+                                r#"{{
+                                    "html_url":"https://github.com/Ikana/electron-cli/releases/tag/v0.1.0",
+                                    "upload_url":"{}/uploads/1{{?name,label}}",
+                                    "assets":[]
+                                }}"#,
+                                thread_api_url
+                            ),
+                        ),
+                        _ => write_http_response(
+                            &mut stream,
+                            201,
+                            r#"{
+                                "id":42,
+                                "name":"starter-app",
+                                "browser_download_url":"https://github.com/Ikana/electron-cli/releases/download/v0.1.0/starter-app.zip"
+                            }"#,
+                        ),
+                    }
+                }
+            });
+
+            Self {
+                api_url,
+                requests,
+                handle: Some(handle),
+            }
+        }
+
+        fn finish(mut self) -> Vec<RecordedRequest> {
+            if let Some(handle) = self.handle.take() {
+                handle.join().expect("server thread should finish");
+            }
+            self.requests.lock().expect("requests should lock").clone()
+        }
+    }
+
+    fn read_http_request(stream: &mut TcpStream) -> RecordedRequest {
+        let mut bytes = Vec::new();
+        let header_end = loop {
+            let mut buffer = [0; 1024];
+            let read = stream.read(&mut buffer).expect("request should read");
+            assert!(read > 0, "connection closed before request headers");
+            bytes.extend_from_slice(&buffer[..read]);
+            if let Some(position) = bytes.windows(4).position(|window| window == b"\r\n\r\n") {
+                break position + 4;
+            }
+        };
+
+        let headers_text =
+            String::from_utf8(bytes[..header_end].to_vec()).expect("headers should be utf-8");
+        let mut lines = headers_text.split("\r\n");
+        let request_line = lines.next().expect("request line should exist");
+        let mut request_parts = request_line.split_whitespace();
+        let method = request_parts
+            .next()
+            .expect("request method should exist")
+            .to_string();
+        let path = request_parts
+            .next()
+            .expect("request path should exist")
+            .to_string();
+        let headers = lines
+            .filter_map(|line| line.split_once(':'))
+            .map(|(key, value)| (key.trim().to_string(), value.trim().to_string()))
+            .collect::<Vec<_>>();
+        let content_length = headers
+            .iter()
+            .find(|(key, _)| key.eq_ignore_ascii_case("content-length"))
+            .and_then(|(_, value)| value.parse::<usize>().ok())
+            .unwrap_or(0);
+        while bytes.len() < header_end + content_length {
+            let mut buffer = [0; 1024];
+            let read = stream.read(&mut buffer).expect("request body should read");
+            assert!(read > 0, "connection closed before request body");
+            bytes.extend_from_slice(&buffer[..read]);
+        }
+        let body = bytes[header_end..header_end + content_length].to_vec();
+
+        RecordedRequest {
+            method,
+            path,
+            headers,
+            body,
+        }
+    }
+
+    fn write_http_response(stream: &mut TcpStream, status: u16, body: &str) {
+        let reason = match status {
+            201 => "Created",
+            404 => "Not Found",
+            _ => "OK",
+        };
+        write!(
+            stream,
+            "HTTP/1.1 {status} {reason}\r\nContent-Type: application/json\r\nContent-Length: {}\r\nConnection: close\r\n\r\n{}",
+            body.len(),
+            body
+        )
+        .expect("response should write");
+    }
 }