electrobun 0.1.2 → 0.1.3

package/dist/api/browser/webviewtag.ts

@@ -111,7 +111,7 @@ const ConfigureWebviewTags = (
         // todo: wire up to a param and a method to update them
         navigationRules: null,        
       });
-
+      console.log('electrobun webviewid: ', webviewId)
       this.webviewId = webviewId;
       this.id = `electrobun-webview-${webviewId}`;
       // todo: replace bun -> webviewtag communication with a global instead of
@@ -252,8 +252,10 @@ const ConfigureWebviewTags = (
 
       if (width === 0 && height === 0) {
         if (this.wasZeroRect === false) {
+          console.log('WAS NOT ZERO RECT', this.webviewId)
           this.wasZeroRect = true;
-          this.toggleHidden(true, true);
+          this.toggleTransparent(true, true);
+          this.togglePassthrough(true, true);
         }
         return;
       }
@@ -312,7 +314,9 @@ const ConfigureWebviewTags = (
 
       if (this.wasZeroRect) {
         this.wasZeroRect = false;
-        this.toggleHidden(false, true);
+        console.log('WAS ZERO RECT', this.webviewId)
+        this.toggleTransparent(false, true);
+        this.togglePassthrough(false, true);
       }
     }
 
@@ -492,17 +496,20 @@ const ConfigureWebviewTags = (
         return;
       }
 
-      if (!bypassState) {
-        if (typeof transparent === "undefined") {
-          this.transparent = !this.transparent;
-        } else {
-          this.transparent = transparent;
-        }
+      let newValue;
+      if (typeof transparent === "undefined") {
+        newValue = !this.transparent;
+      } else {
+        newValue = Boolean(transparent);
       }
 
+      if (!bypassState) {
+        this.transparent = newValue;
+      }               
+
       this.internalRpc.send.webviewTagSetTransparent({
         id: this.webviewId,
-        transparent: this.transparent || Boolean(transparent),
+        transparent: newValue,
       });
     }
     togglePassthrough(enablePassthrough?: boolean, bypassState?: boolean) {
@@ -511,12 +518,15 @@ const ConfigureWebviewTags = (
         return;
       }
 
-      if (!bypassState) {
-        if (typeof enablePassthrough === "undefined") {
-          this.passthroughEnabled = !this.passthroughEnabled;
-        } else {
-          this.passthroughEnabled = enablePassthrough;
-        }
+      let newValue;
+      if (typeof enablePassthrough === "undefined") {
+        newValue = !this.passthroughEnabled;
+      } else {
+        newValue = Boolean(enablePassthrough);
+      }
+
+      if (!bypassState) {        
+        this.passthroughEnabled = newValue;        
       }
 
       this.internalRpc.send.webviewTagSetPassthrough({
@@ -532,17 +542,21 @@ const ConfigureWebviewTags = (
         return;
       }
 
-      if (!bypassState) {
-        if (typeof hidden === "undefined") {
-          this.hidden = !this.hidden;
-        } else {
-          this.hidden = hidden;
-        }
+      let newValue;
+      if (typeof hidden === "undefined") {
+        newValue = !this.hidden;
+      } else {
+        newValue = Boolean(hidden);
+      }
+
+      if (!bypassState) {       
+        this.hidden = newValue;        
       }
 
+      console.trace('electrobun toggle hidden: ', this.hidden, this.webviewId)
       this.internalRpc.send.webviewTagSetHidden({
         id: this.webviewId,
-        hidden: this.hidden || Boolean(hidden),
+        hidden: this.hidden|| Boolean(hidden),
       });
     }   
   }

package/dist/api/bun/core/BrowserView.ts

@@ -124,12 +124,9 @@ export class BrowserView<T> {
     this.ptr = this.init();
   }
 
-  init() {
-    console.log('browserView init', this.id, this.windowId, this.renderer);
+  init() {    
     this.createStreams();
-
-    
-   console.log('ffi createWEbview')
+       
     // TODO: add a then to this that fires an onReady event
     return ffi.request.createWebview({
       id: this.id,

package/dist/api/bun/core/BrowserWindow.ts

@@ -162,8 +162,7 @@ export class BrowserWindow<T> {
     
   }
 
-  get webview() {
-    console.log('getting webview for window: ', this.webviewId)
+  get webview() {    
     // todo (yoav): we don't want this to be undefined, so maybe we should just
     // link directly to the browserview object instead of a getter
     return BrowserView.getById(this.webviewId) as BrowserView<T>;

package/dist/api/bun/core/Tray.ts

@@ -25,9 +25,7 @@ export class Tray {
     template = true,
     width = 16,
     height = 16,
-  }: ConstructorOptions = {}) {
-    console.log("img", image);
-    console.log("img", this.resolveImagePath(image));
+  }: ConstructorOptions = {}) {    
     this.ptr = ffi.request.createTray({
       id: this.id,
       title,

package/dist/api/bun/core/Utils.ts

@@ -1,4 +1,4 @@
-import { ffi } from "../proc/native";
+import { ffi, native } from "../proc/native";
 
 // TODO: move this to a more appropriate namespace
 export const moveToTrash = (path: string) => {
@@ -9,6 +9,11 @@ export const showItemInFolder = (path: string) => {
   return ffi.request.showItemInFolder({ path });
 };
 
+export const quit = () => {
+  // Use native killApp for graceful shutdown
+  native.symbols.killApp();
+};
+
 export const openFileDialog = async (
   opts: {
     startingFolder?: string;

package/dist/api/bun/proc/native.ts

@@ -526,8 +526,7 @@ export const ffi = {
            // init (like views://myview/index.html) so fast while the Bun FFI to load a url is still executing
            // or something where the JSCallback that this postMessage fires is not available or busy or
            // its memory is allocated to something else or something and the handler receives garbage data in Bun.
-           setTimeout(() => {
-              console.log('emitWebviewEvent', eventName, detail)             
+           setTimeout(() => {              
               window.__electrobunInternalBridge?.postMessage(JSON.stringify({id: 'webviewEvent', type: 'message', payload: {id: window.__electrobunWebviewId, eventName, detail}}));
           });
          };                 
@@ -683,7 +682,7 @@ export const ffi = {
         } = params;
 
         const tray = Tray.getById(id);
-        console.log('native.symbols.setTrayMenu', tray.ptr, menuConfig)
+        
         native.symbols.setTrayMenu(
           tray.ptr,
           toCString(menuConfig)
@@ -691,18 +690,14 @@ export const ffi = {
       },
 
       removeTray: (params: { id: number }): void => {
-        const { id } = params;
-        console.log('removeTray called with id:', id);
-        const tray = Tray.getById(id);
-        console.log('Found tray:', tray);
+        const { id } = params;        
+        const tray = Tray.getById(id);        
         
         if (!tray) {
           throw `Can't remove tray. Tray no longer exists`;
         }
-        
-        console.log('Calling native.symbols.removeTray with ptr:', tray.ptr);
-        native.symbols.removeTray(tray.ptr);
-        console.log('Native removeTray called successfully');
+                
+        native.symbols.removeTray(tray.ptr);        
         // The Tray class will handle removing from TrayMap
       },
       setApplicationMenu: (params: {menuConfig: string}): void => {
@@ -900,7 +895,7 @@ native.symbols.setJSUtils(getMimeType, getHTMLForWebviewSync);
 
 // TODO XX: revisit this as integrated into the will-navigate handler
 const webviewDecideNavigation = new JSCallback((webviewId, url) => {
-  console.log('webviewDecideNavigation', webviewId, new CString(url))
+  console.log('TODO: webviewDecideNavigation', webviewId, new CString(url))
   return true;
 }, {
   args: [FFIType.u32, FFIType.cstring],
@@ -1056,10 +1051,13 @@ const internalBridgeHandler = new JSCallback((id, msg) => {
   threadsafe: true
 });
 
-const trayItemHandler = new JSCallback((id, action) => {      
+const trayItemHandler = new JSCallback((id, action) => {
+  // Note: Some invisible character that doesn't appear in .length
+  // is causing issues      
+  const actionString = (new CString(action).toString() || "").trim();
   const event = electrobunEventEmitter.events.tray.trayClicked({
     id,
-    action: new CString(action),
+    action: actionString,
   });
 
   let result;
@@ -1171,7 +1169,7 @@ export const internalRpcHandlers = {
       return native.symbols.webviewCanGoForward(webviewPtr);  
     },  
     webviewTagCallAsyncJavaScript: (params) => {
-      console.log('-----------+ request: ', 'webviewTagCallAsyncJavaScript', params)
+      console.log('TODO: webviewTagCallAsyncJavaScript NOT YET IMPLEMENTED', params)
       // Not implemented - users can use RPC for JavaScript execution if needed
     }
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "electrobun",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Build ultra fast, tiny, and cross-platform desktop apps with Typescript.",
   "license": "MIT",
   "author": "Blackboard Technologies Inc.",