electerm 3.3.3 → 3.3.5

package/README.md

@@ -90,9 +90,6 @@ Check [https://electerm-repos.html5beta.com/deb](https://electerm-repos.html5bet
 ```bash
 npm i -g electerm
 
-# After installation, it will immediately open for windows and linux,
-# For macOS, it will open the drag to install panel
-
 ```
 
 ## Upgrade

package/npm/electerm

@@ -34,6 +34,21 @@ function getElectermExePath () {
   return path.join(packageRoot, 'electerm', 'electerm')
 }
 
+function isSandboxReady () {
+  // chrome-sandbox must be owned by root (uid 0) and have setuid bit set (mode 4755)
+  // This requires root during install, which npm global install does not provide.
+  try {
+    const sandboxPath = path.join(packageRoot, 'electerm', 'chrome-sandbox')
+    if (!fs.existsSync(sandboxPath)) return false
+    const stat = fs.statSync(sandboxPath)
+    const hasSetuid = (stat.mode & 0o4000) !== 0
+    const ownedByRoot = stat.uid === 0
+    return hasSetuid && ownedByRoot
+  } catch (e) {
+    return false
+  }
+}
+
 function launchElecterm () {
   const exePath = getElectermExePath()
 
@@ -46,7 +61,12 @@ function launchElecterm () {
     process.exit(1)
   }
 
-  const child = spawn(exePath, process.argv.slice(2), {
+  const extraArgs = []
+  if (plat === 'linux' && !isSandboxReady()) {
+    extraArgs.push('--no-sandbox')
+  }
+
+  const child = spawn(exePath, [...extraArgs, ...process.argv.slice(2)], {
     stdio: 'inherit',
     detached: plat !== 'win32',
     windowsHide: false

package/npm/install.js

@@ -192,11 +192,15 @@ async function runLinux (folderName, filePattern) {
   mv(join(tmpDir, extractedFolder), extractDir)
 
   // Fix chrome-sandbox permissions on Linux (Electron requires specific permissions)
+  // Note: setting the setuid bit requires root ownership, which npm install cannot provide.
+  // The launcher handles this by passing --no-sandbox when the sandbox is not root-owned.
   if (plat === 'linux') {
     const chromeSandboxPath = join(extractDir, 'chrome-sandbox')
     if (fs.existsSync(chromeSandboxPath)) {
-      console.log('  Fixing chrome-sandbox permissions...')
-      fs.chmodSync(chromeSandboxPath, 0o4755)
+      console.log('  Note: To enable the Electron sandbox, run:')
+      console.log(`    sudo chown root:root "${chromeSandboxPath}"`)
+      console.log(`    sudo chmod 4755 "${chromeSandboxPath}"`)
+      console.log('  Otherwise, electerm will launch with --no-sandbox automatically.')
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "electerm",
-  "version": "3.3.3",
+  "version": "3.3.5",
   "description": "Terminal/ssh/telnet/serialport/sftp client(linux, mac, win)",
   "main": "app.js",
   "bin": "npm/electerm",