elanous 0.2.42 → 0.2.43

package/src/dashboard/classic-sidetab-mission.ts

@@ -1,10 +1,24 @@
 import type { LLMToolSpec } from '../llm.js';
+import { debug } from '../debug/log.js';
 import { isClassicMissionId, redactMissionResultPath } from './mission-cli-consumer.js';
 
 export const CLASSIC_SIDETAB_MISSION_TOOL_NAME = 'RunSidetabMission';
 export const CLASSIC_SIDETAB_MISSION_CANCEL_TOOL_NAME = 'CancelSidetabMission';
+export const CLASSIC_SIDETAB_HAND_REPLY_TOOL_NAME = 'HandReply';
 const AGENT_TOOL_NAME = 'Agent';
 
+export interface ClassicSidetabHandReplyInput {
+  missionId: string;
+  kind: 'answer' | 'correct';
+  text: string;
+  actor: 'agent' | 'human';
+  replyTo: number;
+  runId?: string;
+  scope?: string;
+  stop?: boolean;
+  priority?: string;
+}
+
 export interface ClassicSidetabMissionResult {
   ok: boolean;
   status?: 'running' | 'completed' | 'cancelled' | 'failed';
@@ -12,6 +26,10 @@ export interface ClassicSidetabMissionResult {
   content?: string;
   error?: string;
   interactionId?: string;
+  /** Final raw child PTY screen, retained in the parent comparison recording. */
+  finalScreen?: string;
+  /** First child PTY frame, retained to explain startup menus and input interception. */
+  initialScreen?: string;
 }
 export interface ClassicSidetabMissionToolResult {
   status: 'running' | 'done' | 'error' | 'aborted';
@@ -25,6 +43,51 @@ export interface ClassicSidetabMissionTool {
   dispatch(args: unknown, context?: ClassicSidetabMissionDispatchContext): Promise<ClassicSidetabMissionToolResult>;
 }
 
+export interface ClassicSidetabMissionPairResult {
+  pairId: string;
+  codex: ClassicSidetabMissionResult;
+  claude: ClassicSidetabMissionResult;
+}
+
+export type ClassicSidetabMissionAgent = 'codex' | 'claude' | 'grok';
+export interface ClassicSidetabMissionTrioResult {
+  trioId: string;
+  members: Record<ClassicSidetabMissionAgent, ClassicSidetabMissionResult>;
+  grokFallback?: string;
+}
+
+export interface ClassicSidetabMissionPairSessionRegistry {
+  register(missionIds: readonly string[], sessionIds: readonly string[]): void;
+  cancel(missionId: string, hasSession: (sessionId: string) => boolean, killSession: (sessionId: string) => void): boolean | undefined;
+  clear(missionIds: readonly string[]): void;
+}
+
+/** Map either public mission ID to the full visible PTY pair until completion/cancellation. */
+export function createClassicSidetabMissionPairSessionRegistry(): ClassicSidetabMissionPairSessionRegistry {
+  const pairs = new Map<string, readonly string[]>();
+  return {
+    register(missionIds, sessionIds) {
+      const pair = [...sessionIds];
+      for (const missionId of missionIds) pairs.set(missionId, pair);
+    },
+    cancel(missionId, hasSession, killSession) {
+      const pair = pairs.get(missionId);
+      if (!pair) return undefined;
+      let cancelled = false;
+      for (const sessionId of pair) {
+        if (!hasSession(sessionId)) continue;
+        killSession(sessionId);
+        cancelled = true;
+      }
+      for (const [id, mappedPair] of pairs) if (mappedPair === pair) pairs.delete(id);
+      return cancelled;
+    },
+    clear(missionIds) {
+      for (const missionId of missionIds) pairs.delete(missionId);
+    },
+  };
+}
+
 export interface ClassicSidetabMissionIntegration {
   getTools(tools: readonly LLMToolSpec[]): LLMToolSpec[];
   dispatchTool(name: string, args: unknown, context?: ClassicSidetabMissionDispatchContext): Promise<ClassicSidetabMissionToolResult> | undefined;
@@ -32,21 +95,30 @@ export interface ClassicSidetabMissionIntegration {
 
 export interface ClassicSidetabMissionDispatchContext {
   callId?: string;
+  parentSessionId?: string;
+  linearIssueId?: string;
 }
 
 /** A classic ACP-only tool. Result paths remain internal; the final mission text returns to chat. */
 export function createClassicSidetabMissionTool(
   runMission: (agent: 'codex' | 'claude', mission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionResult>,
+  runMissionPair?: (agent: 'codex' | 'claude', mission: string, parallelMission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionPairResult>,
+  runMissionTrio?: (mission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionTrioResult>,
 ): ClassicSidetabMissionTool {
   return {
     spec: {
       name: CLASSIC_SIDETAB_MISSION_TOOL_NAME,
-      description: 'Run a stateless coding mission with the selected sidetab agent. Return a structured result with status, body, artifacts, and id; the parent chat uses it to continue the original task. Parent-turn cancellation does not cancel the mission; explicit mission-ID cancellation or the one-hour safety timeout can stop it.',
+      description: 'Run a stateless coding mission with the selected sidetab agent. Optionally set parallelMission for a two-hand Codex/Claude pair. Set withGrok=true to send the exact same mission to Codex, Claude Code, and Grok concurrently; omit both parallelMission and linearIssueId in this mode. For any parallel mission, omit linearIssueId because Linear progress sync only supports one sidetab mission. After one combined result notification, compare candidates, adopt the strongest answer, and explain the choice. If Grok login or startup is unavailable, continue with Codex and Claude and disclose the fallback. For parallel runs, either listed mission ID cancels all members. Return a structured result with status, body, artifacts, and id. Parent-turn cancellation does not cancel missions; explicit mission-ID cancellation or the one-hour safety timeout can stop them.',
       parameters: {
         type: 'object',
         properties: {
           agent: { type: 'string', enum: ['codex', 'claude'], description: 'Visible coding agent to run.' },
           mission: { type: 'string', minLength: 1, description: 'The work to perform.' },
+          // Keep optional strings schema-valid when model output includes an empty placeholder.
+          // Dispatch treats empty Linear IDs as omitted and validates empty pair prompts itself.
+          linearIssueId: { type: 'string', minLength: 1, description: 'Optional non-empty Linear child issue ID for a single sidetab mission only; omit when parallelMission or withGrok is used.' },
+          parallelMission: { type: 'string', description: 'Optional second prompt for a two-hand Codex/Claude pair only; omit linearIssueId and do not combine with withGrok.' },
+          withGrok: { type: 'boolean', description: 'Run this exact mission concurrently with Codex, Claude Code, and Grok, then compare and adopt the strongest result; omit parallelMission and linearIssueId. Grok login failure degrades to Codex + Claude.' },
         },
         required: ['agent', 'mission'],
         additionalProperties: false,
@@ -61,16 +133,79 @@ export function createClassicSidetabMissionTool(
       });
       if (!args || typeof args !== 'object' || Array.isArray(args)) return output('error', 'arguments must be an object');
       const input = args as Record<string, unknown>;
-      if (Object.keys(input).some(key => key !== 'agent' && key !== 'mission')) {
+      if (Object.keys(input).some(key => key !== 'agent' && key !== 'mission' && key !== 'parallelMission' && key !== 'withGrok' && key !== 'linearIssueId')) {
         return output('error', 'arguments contain unsupported fields');
       }
       const agent = input.agent;
       const mission = typeof input.mission === 'string' ? input.mission.trim() : '';
+      const parallelMission = typeof input.parallelMission === 'string' ? input.parallelMission.trim() : '';
+      const linearIssueId = typeof input.linearIssueId === 'string' ? input.linearIssueId.trim() : '';
+      const withGrok = input.withGrok === true;
       if (agent !== 'codex' && agent !== 'claude') return output('error', 'agent must be codex or claude');
       if (!mission) return output('error', 'mission text is required');
+      if (!withGrok && input.parallelMission !== undefined && !parallelMission) return output('error', 'parallelMission must contain prompt text');
+      if (input.withGrok !== undefined && typeof input.withGrok !== 'boolean') return output('error', 'withGrok must be a boolean');
+      if (input.linearIssueId !== undefined && typeof input.linearIssueId !== 'string') return output('error', 'linearIssueId must be omitted or contain a non-empty ID');
+      // Some tool callers emit an empty optional string despite the schema's
+      // minLength. In three-hand mode it means "no linked issue" (there is no
+      // progress-sync behavior there); keep explicit empty IDs invalid for the
+      // single-agent path where the ID is actionable.
+      if (input.linearIssueId !== undefined && !linearIssueId && !withGrok) return output('error', 'linearIssueId must be omitted or contain a non-empty ID');
+      debug.log('agent-mission.sidetab', 'guard-input', {
+        hasLinearIssueId: Boolean(linearIssueId),
+        parallelMission: Boolean(parallelMission),
+        source: input.linearIssueId !== undefined
+          ? (context?.linearIssueId ? 'tool-input+linear-dispatch-context' : 'tool-input')
+          : context?.linearIssueId ? 'dispatch-context' : 'none',
+      });
+      const parallelHasLinearIssueId = Boolean(parallelMission && (linearIssueId || context?.linearIssueId));
+      if (parallelHasLinearIssueId) {
+        debug.log('agent-mission.sidetab', 'linear-sync-skipped-for-parallel', {
+          source: linearIssueId && context?.linearIssueId ? 'tool-input+dispatch-context' : linearIssueId ? 'tool-input' : 'dispatch-context',
+          reason: 'Linear progress sync is only supported for a single sidetab mission',
+        }, { level: 'warn' });
+      }
+      if (withGrok && parallelMission) return output('error', 'withGrok compares the same mission; omit parallelMission');
+      if (withGrok && !runMissionTrio) return output('error', 'Codex + Claude + Grok comparison is unavailable in this runtime');
+      if (withGrok && runMissionTrio) {
+        try {
+          const trio = await runMissionTrio(mission, linearIssueId ? { ...context, linearIssueId } : context);
+          const ids = Object.values(trio.members).map((member) => member.interactionId).filter((id): id is string => Boolean(id));
+          const grok = trio.members.grok;
+          const disclosure = trio.grokFallback ?? (!grok.ok ? grok.error : undefined);
+          return output('running', `Three-hand comparison started (${trio.trioId}; mission IDs: ${ids.join(', ') || 'unavailable'})${disclosure ? ` · Grok fallback: ${disclosure}` : ''}${linearIssueId ? ' · Linked Linear progress is not synchronized by three-hand missions.' : ''}. One combined completion notification will compare the results and show the adopted answer.`, trio.members.codex.interactionId ?? trio.members.claude.interactionId ?? trio.trioId);
+        } catch {
+          return output('error', 'Codex + Claude + Grok missions failed before the comparison could start');
+        }
+      }
+      if (parallelMission && !runMissionPair) return output('error', 'parallel Codex/Claude missions are unavailable in this runtime');
+      if (parallelMission && runMissionPair) {
+        try {
+          const pairContext = context?.linearIssueId
+            ? { callId: context.callId, parentSessionId: context.parentSessionId }
+            : context;
+          const pair = await runMissionPair(agent, mission, parallelMission, pairContext);
+          const codex = pair.codex;
+          const claude = pair.claude;
+          const format = (name: string, result: ClassicSidetabMissionResult): string => {
+            if (result.status === 'running') return `${name}: still running (${result.interactionId ?? 'no mission ID'})`;
+            if (!result.ok) return `${name}: ${result.status ?? 'failed'}; no answer returned`;
+            const content = result.content?.trim();
+            return content ? `${name} answer:\n${redactMissionResultPath(content, result.path)}` : `${name}: completed without an answer`;
+          };
+          const bothDone = codex.status !== 'running' && claude.status !== 'running';
+          const bothOk = codex.ok && claude.ok && Boolean(codex.content?.trim()) && Boolean(claude.content?.trim());
+          const ids = [codex.interactionId, claude.interactionId].filter((id): id is string => Boolean(id));
+          return output(bothDone && bothOk ? 'done' : bothDone ? 'error' : 'running',
+            `Concurrent Codex + Claude mission pair (${pair.pairId}; mission IDs: ${ids.join(', ') || 'unavailable'})\n\n${format('Codex', codex)}\n\n${format('Claude', claude)}`,
+            codex.interactionId ?? claude.interactionId ?? null);
+        } catch {
+          return output('error', 'Concurrent Codex/Claude missions failed before both results were available');
+        }
+      }
       let result: ClassicSidetabMissionResult;
       try {
-        result = await runMission(agent, mission, context);
+        result = await runMission(agent, mission, linearIssueId ? { ...context, linearIssueId } : context);
       } catch {
         return output('error', 'Sidetab mission failed before a result was available');
       }
@@ -97,8 +232,11 @@ export function createClassicSidetabMissionTool(
 export function createClassicSidetabMissionIntegration(
   runMission: (agent: 'codex' | 'claude', mission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionResult>,
   cancelMission?: (interactionId: string) => Promise<boolean>,
+  runMissionPair?: (agent: 'codex' | 'claude', mission: string, parallelMission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionPairResult>,
+  handReply?: (input: ClassicSidetabHandReplyInput) => Promise<{ ok: boolean; body: string }>,
+  runMissionTrio?: (mission: string, context?: ClassicSidetabMissionDispatchContext) => Promise<ClassicSidetabMissionTrioResult>,
 ): ClassicSidetabMissionIntegration {
-  const tool = createClassicSidetabMissionTool(runMission);
+  const tool = createClassicSidetabMissionTool(runMission, runMissionPair, runMissionTrio);
   const dispatchAgentHand = async (args: unknown, context?: ClassicSidetabMissionDispatchContext): Promise<ClassicSidetabMissionToolResult> => {
     const output = (status: ClassicSidetabMissionToolResult['status'], body: string, id: string | null = null): ClassicSidetabMissionToolResult => ({
       status,
@@ -146,7 +284,19 @@ export function createClassicSidetabMissionIntegration(
     };
   };
   return {
-    getTools: (tools) => [...tools.map(spec => spec.name === AGENT_TOOL_NAME ? withHandOption(spec) : spec), tool.spec, ...(cancelMission ? [{
+    getTools: (tools) => [...tools.map(spec => spec.name === AGENT_TOOL_NAME ? withHandOption(spec) : spec), tool.spec, ...(handReply ? [{
+      name: CLASSIC_SIDETAB_HAND_REPLY_TOOL_NAME,
+      description: 'Answer or correct a question from a running visible sidetab mission. Answers are recorded in the mission ledger for the matching ask waiter. Corrections require child runId, actor=agent, scope, stop, and priority, then are delivered to the mapped PTY through the input arbiter.',
+      parameters: {
+        type: 'object',
+        properties: {
+          missionId: { type: 'string', format: 'uuid' }, kind: { type: 'string', enum: ['answer', 'correct'] },
+          text: { type: 'string', minLength: 1 }, actor: { type: 'string', enum: ['agent', 'human'] },
+          replyTo: { type: 'integer', minimum: 1 }, runId: { type: 'string', description: 'Required for kind=correct; omitted for kind=answer.' }, scope: { type: 'string' }, stop: { type: 'boolean' }, priority: { type: 'string' },
+        },
+        required: ['missionId', 'kind', 'text', 'actor', 'replyTo'], additionalProperties: false,
+      },
+    } satisfies LLMToolSpec] : []), ...(cancelMission ? [{
       name: CLASSIC_SIDETAB_MISSION_CANCEL_TOOL_NAME,
       description: 'Explicitly cancel a running sidetab mission. Cancelling the parent conversation turn does not cancel its detached mission.',
       parameters: {
@@ -158,6 +308,18 @@ export function createClassicSidetabMissionIntegration(
     } satisfies LLMToolSpec] : [])],
     dispatchTool: (name, args, context) => {
       if (name === CLASSIC_SIDETAB_MISSION_TOOL_NAME) return tool.dispatch(args, context);
+      if (name === CLASSIC_SIDETAB_HAND_REPLY_TOOL_NAME && handReply) {
+        return (async () => {
+          if (!args || typeof args !== 'object' || Array.isArray(args)) return { status: 'error', body: 'arguments must be an object', artifacts: [], id: null };
+          const input = args as Record<string, unknown>;
+          if (Object.keys(input).some((key) => !['missionId', 'kind', 'text', 'actor', 'replyTo', 'runId', 'scope', 'stop', 'priority'].includes(key))) return { status: 'error', body: 'arguments contain unsupported fields', artifacts: [], id: null };
+          if (typeof input.missionId !== 'string' || !isClassicMissionId(input.missionId) || (input.kind !== 'answer' && input.kind !== 'correct') || typeof input.text !== 'string' || !input.text.trim() || (input.actor !== 'agent' && input.actor !== 'human') || typeof input.replyTo !== 'number' || !Number.isInteger(input.replyTo) || input.replyTo < 1) return { status: 'error', body: 'missionId, kind, text, actor, or replyTo is invalid', artifacts: [], id: null };
+          if (input.runId !== undefined && typeof input.runId !== 'string') return { status: 'error', body: 'runId must be a string', artifacts: [], id: input.missionId };
+          if (input.kind === 'correct' && (typeof input.scope !== 'string' || typeof input.stop !== 'boolean' || typeof input.priority !== 'string')) return { status: 'error', body: 'correct requires scope, stop, and priority', artifacts: [], id: input.missionId };
+          const result = await handReply({ missionId: input.missionId, kind: input.kind, text: input.text, actor: input.actor, replyTo: input.replyTo, ...(typeof input.runId === 'string' ? { runId: input.runId } : {}), ...(typeof input.scope === 'string' ? { scope: input.scope } : {}), ...(typeof input.stop === 'boolean' ? { stop: input.stop } : {}), ...(typeof input.priority === 'string' ? { priority: input.priority } : {}) });
+          return { status: result.ok ? 'done' : 'error', body: result.body, artifacts: [], id: input.missionId };
+        })();
+      }
       if (name === AGENT_TOOL_NAME) {
         if (!args || typeof args !== 'object' || Array.isArray(args)) return dispatchAgentHand(args, context);
         const hand = (args as Record<string, unknown>).hand;