ei-tui 0.3.7 → 0.3.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ei-tui",
-  "version": "0.3.7",
+  "version": "0.3.8",
   "author": "Flare576",
   "repository": {
     "type": "git",

package/src/core/handlers/persona-generation.ts

@@ -150,16 +150,44 @@ export function handlePersonaTraitExtraction(response: LLMResponse, state: State
     return;
   }
 
+  if (result.length === 0) {
+    return;
+  }
+
+  const persona = state.persona_getById(personaId);
+  if (!persona) {
+    console.error(`[handlePersonaTraitExtraction] Persona ${personaId} not found`);
+    return;
+  }
+
   const now = new Date().toISOString();
-  const traits: PersonaTrait[] = result.map(t => ({
-    id: crypto.randomUUID(),
-    name: t.name,
-    description: t.description,
-    sentiment: t.sentiment,
-    strength: t.strength,
-    last_updated: now,
-  }));
+  const updatedIds = new Set<string>();
+  const patchedTraits: PersonaTrait[] = result.map(delta => {
+    if (delta.id === "new") {
+      return {
+        id: crypto.randomUUID(),
+        name: delta.name,
+        description: delta.description,
+        sentiment: delta.sentiment,
+        strength: delta.strength,
+        last_updated: now,
+      };
+    }
+    updatedIds.add(delta.id);
+    return {
+      id: delta.id,
+      name: delta.name,
+      description: delta.description,
+      sentiment: delta.sentiment,
+      strength: delta.strength,
+      last_updated: now,
+    };
+  });
+
+  const preservedTraits = persona.traits.filter(t => !updatedIds.has(t.id));
+
+  const traits: PersonaTrait[] = [...preservedTraits, ...patchedTraits];
 
   state.persona_update(personaId, { traits, last_updated: now });
-  console.log(`[handlePersonaTraitExtraction] Updated ${traits.length} traits for ${personaDisplayName}`);
+  console.log(`[handlePersonaTraitExtraction] Applied ${result.length} delta(s) to ${personaDisplayName}, total traits: ${traits.length}`);
 }

package/src/prompts/persona/traits.ts

@@ -6,6 +6,7 @@ function formatTraitsForPrompt(traits: PersonaTrait[]): string {
   if (traits.length === 0) return "(No traits yet)";
   
   return JSON.stringify(traits.map(t => ({
+    id: t.id,
     name: t.name,
     description: t.description,
     sentiment: t.sentiment,
@@ -44,7 +45,8 @@ You are analyzing a conversation to detect EXPLICIT requests for ${personaName}
 - Add traits the user didn't explicitly request
 - Infer traits from general conversation
 - Remove traits without explicit feedback
-- Confuse topics/interests with communication traits`;
+- Confuse topics/interests with communication traits
+- Return traits that don't need to change`;
 
   const fieldsFragment = `# Fields
 
@@ -70,16 +72,28 @@ ${formatTraitsForPrompt(data.current_traits)}
 
 1. ONLY analyze "Most Recent Messages" - earlier messages are context only
 2. ONLY detect EXPLICIT behavior change requests
-3. Return the COMPLETE trait list (existing + any additions/modifications)
+3. Return ONLY traits that need to change or be added — omit unchanged traits
+4. If nothing changed, return an empty array \`[]\`
+
+**To update an existing trait:** use its \`id\` from the Current TRAITS list above.
+**To add a new trait:** use \`"id": "new"\`.
 
 **Return JSON:**
 \`\`\`json
 [
   {
-    "name": "A one- or two-word Title for the trait",
-    "description": "A brief instruction on how the trait is exhibited",
+    "id": "existing-guid-from-current-traits",
+    "name": "Existing Trait Name",
+    "description": "Updated instruction",
     "sentiment": 0.3,
     "strength": 0.7
+  },
+  {
+    "id": "new",
+    "name": "Brand New Trait",
+    "description": "A brief instruction on how the trait is exhibited",
+    "sentiment": 0.0,
+    "strength": 0.5
   }
 ]
 \`\`\``;
@@ -111,7 +125,7 @@ ${earlierSection}${recentSection}
 
 Analyze the "Most Recent Messages" for EXPLICIT requests to change ${personaName}'s communication style.
 
-Return the complete trait list as JSON.`;
+Return ONLY the traits that need to change or be added. Return \`[]\` if nothing changed.`;
 
   return { system, user };
 }

package/src/prompts/persona/types.ts

@@ -13,6 +13,7 @@ export interface PersonaTraitExtractionPromptData {
 }
 
 export interface TraitResult {
+  id: string;       // Existing trait GUID to update, or "new" to create
   name: string;
   description: string;
   sentiment: number;

package/tui/src/util/yaml-serializers.ts

@@ -76,6 +76,7 @@ const PLACEHOLDER_LONG_DESC = "Detailed description of this persona's personalit
 interface YAMLTrait {
   name: string;
   description: string;
+  sentiment: number;
   strength: number;
 }
 
@@ -91,6 +92,7 @@ interface YAMLPersonaTopic {
 const PLACEHOLDER_TRAIT: YAMLTrait = {
   name: "Example Trait",
   description: "Delete this placeholder or modify it to define a real trait",
+  sentiment: 0,
   strength: 0.5,
 };
 const PLACEHOLDER_TOPIC: YAMLPersonaTopic = {
@@ -196,8 +198,8 @@ export function newPersonaFromYAML(yamlContent: string, allTools?: ToolDefinitio
       id: crypto.randomUUID(),
       name: t.name,
       description: t.description,
+      sentiment: t.sentiment ?? 0,
       strength: t.strength,
-      sentiment: 0,
       last_updated: new Date().toISOString(),
     });
   }
@@ -275,7 +277,7 @@ export function personaToYAML(persona: PersonaEntity, allGroups?: string[], allT
     groups_visible: groupsForYAML,
     traits: useTraitPlaceholder 
       ? [PLACEHOLDER_TRAIT]
-      : persona.traits.map(({ name, description, strength }) => ({ name, description, strength: strength ?? 0.5 })),
+      : persona.traits.map(({ name, description, sentiment, strength }) => ({ name, description, sentiment: sentiment ?? 0, strength: strength ?? 0.5 })),
     topics: useTopicPlaceholder
       ? [PLACEHOLDER_TOPIC]
       : persona.topics.map(({ name, perspective, approach, personal_stake, exposure_current, exposure_desired }) => ({ 
@@ -320,8 +322,8 @@ export function personaFromYAML(yamlContent: string, original: PersonaEntity, al
       id: existing?.id ?? crypto.randomUUID(),
       name: t.name,
       description: t.description,
+      sentiment: t.sentiment ?? existing?.sentiment ?? 0,
       strength: t.strength,
-      sentiment: existing?.sentiment ?? 0,
       last_updated: new Date().toISOString(),
     });
   }