ei-tui 0.1.25 → 0.3.1

package/src/integrations/cursor/reader.ts

@@ -0,0 +1,209 @@
+import type {
+  ICursorReader,
+  CursorSession,
+  CursorMessage,
+  CursorComposerMeta,
+  CursorBubbleRaw,
+  CursorBubbleHeader,
+} from "./types.js";
+
+const isBrowser = typeof document !== "undefined";
+
+let _join: typeof import("path").join;
+let _readFile: typeof import("fs/promises").readFile;
+let _readdir: typeof import("fs/promises").readdir;
+let _nodeModulesLoaded = false;
+
+async function ensureNodeModules(): Promise<boolean> {
+  if (isBrowser) return false;
+  if (_nodeModulesLoaded) return true;
+
+  const PATH_MODULE = "path";
+  const FS_MODULE = "fs/promises";
+
+  const pathMod = await import(/* @vite-ignore */ PATH_MODULE);
+  const fsMod = await import(/* @vite-ignore */ FS_MODULE);
+
+  _join = pathMod.join;
+  _readFile = fsMod.readFile;
+  _readdir = fsMod.readdir;
+  _nodeModulesLoaded = true;
+  return true;
+}
+
+function getPlatformBasePath(): string {
+  if (!_join) return "";
+  const home = process.env.HOME || process.env.USERPROFILE || "~";
+  const platform = process.platform;
+
+  if (platform === "darwin") {
+    return _join(home, "Library", "Application Support", "Cursor", "User");
+  }
+  if (platform === "win32") {
+    return _join(process.env.APPDATA || home, "Cursor", "User");
+  }
+  return _join(home, ".config", "Cursor", "User");
+}
+
+function titleFromPath(workspacePath: string): string {
+  if (!workspacePath) return "Unknown";
+  const parts = workspacePath.replace(/\\/g, "/").split("/").filter(Boolean);
+  return parts[parts.length - 1] ?? workspacePath;
+}
+
+export class CursorReader implements ICursorReader {
+  private readonly basePath?: string;
+
+  constructor(basePath?: string) {
+    this.basePath = basePath;
+  }
+
+  async isAvailable(): Promise<boolean> {
+    if (!(await ensureNodeModules())) return false;
+    const base = this.basePath ?? getPlatformBasePath();
+    const globalDb = _join(base, "globalStorage", "state.vscdb");
+    try {
+      await _readFile(globalDb);
+      return true;
+    } catch {
+      return false;
+    }
+  }
+
+  async getSessions(): Promise<CursorSession[]> {
+    if (!(await ensureNodeModules())) return [];
+
+    const base = this.basePath ?? getPlatformBasePath();
+    const globalDbPath = _join(base, "globalStorage", "state.vscdb");
+    const workspaceStoragePath = _join(base, "workspaceStorage");
+
+    let globalDb: import("bun:sqlite").Database;
+    try {
+      const { Database } = await import(/* @vite-ignore */ "bun:sqlite");
+      globalDb = new Database(globalDbPath, { readonly: true });
+    } catch (err) {
+      console.warn("[CursorReader] failed to open global DB:", err);
+      return [];
+    }
+
+    const hashToFolder = await this.buildHashToFolderMap(workspaceStoragePath);
+    const sessions: CursorSession[] = [];
+
+    for (const [hash, workspacePath] of hashToFolder.entries()) {
+      const workspaceDbPath = _join(workspaceStoragePath, hash, "state.vscdb");
+      let workspaceDb: import("bun:sqlite").Database | null = null;
+
+      try {
+        const { Database } = await import(/* @vite-ignore */ "bun:sqlite");
+        workspaceDb = new Database(workspaceDbPath, { readonly: true });
+
+        const row = workspaceDb
+          .query(`SELECT value FROM ItemTable WHERE key = 'composer.composerData'`)
+          .get() as { value: string } | null;
+
+        if (!row) continue;
+
+        const composerData = JSON.parse(row.value) as { allComposers?: CursorComposerMeta[] };
+        const allComposers: CursorComposerMeta[] = composerData.allComposers ?? [];
+
+        for (const meta of allComposers) {
+          if (meta.lastUpdatedAt == null) continue;
+          if (meta.isDraft === true) continue;
+
+          const composerId = meta.composerId;
+
+          const headerRow = globalDb
+            .query(`SELECT value FROM cursorDiskKV WHERE key = ?`)
+            .get(`composerData:${composerId}`) as { value: string } | null;
+
+          if (!headerRow) continue;
+
+          const composerGlobal = JSON.parse(headerRow.value) as {
+            fullConversationHeadersOnly?: CursorBubbleHeader[];
+          };
+          const headers: CursorBubbleHeader[] = composerGlobal.fullConversationHeadersOnly ?? [];
+          if (headers.length === 0) continue;
+
+          const messages: CursorMessage[] = [];
+
+          for (const header of headers) {
+            const bubbleKey = `bubbleId:${composerId}:${header.bubbleId}`;
+            const bubbleRow = globalDb
+              .query(`SELECT value FROM cursorDiskKV WHERE key = ?`)
+              .get(bubbleKey) as { value: string } | null;
+
+            if (!bubbleRow) continue;
+
+            const bubble = JSON.parse(bubbleRow.value) as CursorBubbleRaw;
+            if (!bubble.text || bubble.text.trim() === "") continue;
+
+            messages.push({
+              id: bubble.bubbleId,
+              type: bubble.type,
+              text: bubble.text,
+              timestamp: bubble.createdAt,
+            });
+          }
+
+          if (messages.length === 0) continue;
+
+          messages.sort(
+            (a, b) => new Date(a.timestamp).getTime() - new Date(b.timestamp).getTime()
+          );
+
+          const lastMsg = messages[messages.length - 1];
+          const sessionName = meta.name?.trim()
+            ? meta.name.trim()
+            : `${meta.unifiedMode ?? "chat"} — ${titleFromPath(workspacePath)}`;
+
+          sessions.push({
+            id: composerId,
+            name: sessionName,
+            workspacePath,
+            unifiedMode: meta.unifiedMode ?? "chat",
+            createdAt: new Date(meta.createdAt).toISOString(),
+            lastMessageAt: lastMsg.timestamp,
+            messages,
+          });
+        }
+      } catch (err) {
+        console.warn(`[CursorReader] skipping workspace ${hash.slice(0, 8)}:`, err);
+      } finally {
+        workspaceDb?.close();
+      }
+    }
+
+    globalDb.close();
+
+    return sessions.sort(
+      (a, b) => new Date(a.lastMessageAt).getTime() - new Date(b.lastMessageAt).getTime()
+    );
+  }
+
+  private async buildHashToFolderMap(workspaceStoragePath: string): Promise<Map<string, string>> {
+    const map = new Map<string, string>();
+
+    let hashes: string[];
+    try {
+      hashes = await _readdir(workspaceStoragePath);
+    } catch {
+      return map;
+    }
+
+    for (const hash of hashes) {
+      if (hash.startsWith(".")) continue;
+      const wsJsonPath = _join(workspaceStoragePath, hash, "workspace.json");
+      try {
+        const text = await _readFile(wsJsonPath, "utf-8");
+        const wsData = JSON.parse(text) as { folder?: string };
+        if (wsData.folder) {
+          const folderPath = wsData.folder.replace(/^file:\/\//, "");
+          map.set(hash, folderPath);
+        }
+      } catch {
+      }
+    }
+
+    return map;
+  }
+}

package/src/integrations/cursor/types.ts

@@ -0,0 +1,140 @@
+/**
+ * Cursor IDE Integration Types
+ *
+ * Cursor stores sessions across two SQLite DBs:
+ *
+ * Workspace DBs:
+ *   ~/Library/Application Support/Cursor/User/workspaceStorage/<hash>/state.vscdb
+ *   ItemTable key "composer.composerData" → { allComposers: CursorComposerMeta[] }
+ *
+ * Global DB:
+ *   ~/Library/Application Support/Cursor/User/globalStorage/state.vscdb
+ *   cursorDiskKV key "composerData:<id>" → header list
+ *   cursorDiskKV key "bubbleId:<id>:<bubbleId>" → bubble blob
+ */
+
+// ============================================================================
+// Reader Interface
+// ============================================================================
+
+export interface ICursorReader {
+  getSessions(): Promise<CursorSession[]>;
+  isAvailable(): Promise<boolean>;
+}
+
+// ============================================================================
+// Raw DB Schema Types (internal to reader)
+// ============================================================================
+
+/**
+ * Raw entry from workspace DB's allComposers array.
+ */
+export interface CursorComposerMeta {
+  composerId: string;
+  name?: string;
+  createdAt: number;            // epoch ms
+  lastUpdatedAt?: number | null; // epoch ms, null for never-used sessions
+  unifiedMode?: string;         // "agent" | "chat" | "plan" | "debug"
+  isArchived?: boolean;
+  isDraft?: boolean;
+  filesChangedCount?: number;
+  totalLinesAdded?: number;
+  totalLinesRemoved?: number;
+}
+
+/**
+ * Raw bubble from global DB bubbleId:<composerId>:<bubbleId>.
+ */
+export interface CursorBubbleRaw {
+  _v?: number;
+  type: 1 | 2;          // 1 = user, 2 = assistant
+  bubbleId: string;
+  text: string;
+  richText?: string;    // Lexical JSON, same content as text — ignored
+  createdAt: string;    // ISO timestamp
+  modelInfo?: { modelName: string };
+  requestId?: string;
+}
+
+/**
+ * Header entry from composerData:<id>.fullConversationHeadersOnly.
+ */
+export interface CursorBubbleHeader {
+  bubbleId: string;
+  type: 1 | 2;
+}
+
+// ============================================================================
+// Cleaned Session / Message Types (for Ei consumption)
+// ============================================================================
+
+/**
+ * A single message in a Cursor session, cleaned for Ei.
+ */
+export interface CursorMessage {
+  /** bubbleId from the raw bubble */
+  id: string;
+  /** 1 = user, 2 = assistant */
+  type: 1 | 2;
+  /** Plain text content */
+  text: string;
+  /** ISO timestamp */
+  timestamp: string;
+}
+
+/**
+ * A Cursor composer session, cleaned for Ei.
+ */
+export interface CursorSession {
+  /** composerId — the stable identifier */
+  id: string;
+  /** User-assigned name, or a generated fallback */
+  name: string;
+  /** Absolute path to the workspace folder, e.g. /Users/foo/Projects/myapp */
+  workspacePath: string;
+  /** "agent" | "chat" | "plan" | "debug" */
+  unifiedMode: string;
+  /** ISO timestamp of creation */
+  createdAt: string;
+  /** ISO timestamp of last message */
+  lastMessageAt: string;
+  /** All non-empty messages, sorted oldest-first */
+  messages: CursorMessage[];
+}
+
+// ============================================================================
+// Constants
+// ============================================================================
+
+/** The single persona name for all Cursor sessions */
+export const CURSOR_PERSONA_NAME = "Cursor";
+
+/** Topic groups assigned to Cursor session topics */
+export const CURSOR_TOPIC_GROUPS = ["General", "Coding", "Cursor"];
+
+/**
+ * Minimum session age before we import it.
+ * Mirrors ClaudeCode's 20-minute rule — gives the session time to "settle."
+ */
+export const MIN_SESSION_AGE_MS = 20 * 60 * 1000;
+
+// ============================================================================
+// Human Settings Shape
+// ============================================================================
+
+/**
+ * Stored under human.settings.cursor
+ *
+ * ⚠️  ADDING A NEW FIELD HERE?
+ * If it's runtime-managed (not user-editable), you MUST also add it to the
+ * cursor reconstruction block in settingsFromYAML() in:
+ *   tui/src/util/yaml-serializers.ts
+ * Otherwise it will be silently wiped every time the user saves /settings.
+ */
+export interface CursorSettings {
+  integration?: boolean;
+  polling_interval_ms?: number;   // Default: 1800000 (30 min)
+  last_sync?: string;             // ISO timestamp
+  extraction_point?: string;      // ISO timestamp — floor for session filtering
+  processed_sessions?: Record<string, string>; // sessionId → ISO timestamp of last import
+}

package/src/integrations/opencode/importer.ts

@@ -57,9 +57,9 @@ function convertToPreMarkedEiMessage(ocMsg: OpenCodeMessage): Message {
   return {
     ...convertToEiMessage(ocMsg),
     f: true,
-    r: true,
+    t: true,
     p: true,
-    o: true,
+    e: true,
   };
 }
 
@@ -79,12 +79,18 @@ function filterRelevantMessages(messages: OpenCodeMessage[]): OpenCodeMessage[]
  * Import one OpenCode session per call.
  *
  * Flow:
- * 1. Find the next unprocessed session after extraction_point.
+ * 1. Find the next unprocessed or updated session (oldest-first).
  * 2. Write all messages for that session to their persona(s) — archived,
  *    messages cleared first. Messages before last_imported are pre-marked
  *    [p,r,o,f]=true; newer messages are unmarked and queued for extraction.
  * 3. Advance extraction_point to session.time.updated.
  *
+ * NOTE: extraction_point is a progress indicator for user visibility only.
+ * It does NOT gate which sessions are imported. processed_sessions (per-session
+ * timestamps) is the sole source of truth for "have we seen this session and
+ * is it up to date." Sessions absent from processed_sessions are always
+ * candidates regardless of their timestamp vs extraction_point.
+ *
  * The processor gate (queue_length() === 0) ensures we never pile onto a
  * backed-up queue.
  *
@@ -229,7 +235,11 @@ export async function importOpenCodeSessions(
       };
 
       if (!signal?.aborted) {
-        queueAllScans(context, stateManager);
+        const openCodeSettings = stateManager.getHuman().settings?.opencode;
+        queueAllScans(context, stateManager, {
+          extraction_model: openCodeSettings?.extraction_model,
+          extraction_token_limit: openCodeSettings?.extraction_token_limit,
+        });
         result.extractionScansQueued += 4;
       }
     }

package/src/prompts/AGENTS.md

@@ -29,7 +29,7 @@ interface PromptBuilder<T> {
 
 **Rules**:
 1. **Synchronous** - No async, no fetching
-2. **Pure** - Same input → same output
+2. **Pure** - Same input → same output. No state reads, no side effects.
 3. **Pre-processed data** - Processor fetches/filters before calling
 4. **Minimal logic** - String interpolation, not computation
 
@@ -60,3 +60,75 @@ interface PromptBuilder<T> {
 **Prompt engineering lives here. Code logic lives in Processor.**
 
 When modifying persona behavior, check prompts first—the "personality" is in the English, not the TypeScript.
+
+---
+
+## VIOLATIONS
+
+These are wrong. If you see them, fix them.
+
+### Prompt strings defined outside `src/prompts/`
+
+**Violation:**
+```typescript
+// ❌ In src/core/handlers/something.ts
+const system = `You are an expert at JSON. Return only valid JSON with no commentary.`;
+const user = `Fix this broken JSON: ${badJson}`;
+const response = await llmClient.call({ system, user });
+```
+
+**Correct:** Move the prompt to `src/prompts/[purpose]/index.ts`. The handler calls the builder with pre-fetched data; the builder returns `{ system, user }`.
+
+### Exception: JSON recovery prompt in `queue-processor.ts`
+
+There is one deliberate exception to the "all prompts live in `src/prompts/`" rule: the JSON repair retry prompt in `queue-processor.ts`.
+
+**Why it's an exception**: This is a *repair heuristic* — it fires after a JSON parse failure to ask the LLM to fix its own malformed output. It has no domain knowledge, no persona data, and no human data. It's infrastructure-level error recovery, not a domain prompt. Moving it to `src/prompts/` would create a degenerate prompt builder with a one-line body and no meaningful data contract.
+
+**Criteria for a legitimate exception** (all must be true):
+1. The prompt contains zero domain knowledge (no persona names, no human data, no Ei concepts)
+2. It's error recovery or infrastructure glue, not business logic
+3. Moving it to `src/prompts/` would produce a builder with no real `types.ts` (no input data shape worth naming)
+
+If your use case doesn't meet all three criteria, it belongs in `src/prompts/`.
+
+### Prompt builders that do computation
+
+**Violation:**
+```typescript
+// ❌ Prompt builder filtering its own data
+function buildResponsePrompt(data: ResponsePromptData) {
+  const relevantFacts = data.facts.filter(f => f.sentiment > 0.5);  // ← WRONG
+  const recentTopics = data.topics.slice(-5);                        // ← WRONG
+  return { system: `...${relevantFacts}...`, user: `...` };
+}
+```
+
+**Correct:** The Processor filters and slices before calling the builder. The builder receives already-filtered data and does string interpolation only.
+
+> If you're writing a loop, a `.filter()`, or a `.map()` inside a prompt builder for anything other than formatting a string — stop. That logic belongs in the Processor or a pre-processing utility.
+
+### Async prompt builders
+
+**Violation:**
+```typescript
+// ❌ Async prompt builder
+async function buildHeartbeatPrompt(personaId: string) {
+  const persona = await stateManager.getPersona(personaId);  // ← WRONG
+  return { system: `...`, user: `...` };
+}
+```
+
+**Correct:** Processor calls `stateManager.getPersona()` first, then passes the result to the synchronous builder.
+
+---
+
+## Prompt Creep Warning
+
+Prompt builders are the most-edited files in the codebase. Watch for these failure modes:
+
+- **Logic creep**: A builder that started as pure string interpolation slowly accumulates conditionals, date math, or data filtering. Each addition seems small. After six changes it's a 200-line function that requires mocking to test. If you're adding branching logic to a prompt builder — reconsider. Move it to the Processor.
+
+- **Data shape expansion**: A builder's input type grows to include things it doesn't actually use in the prompt string. This means the Processor is fetching data the prompt doesn't need. Audit `types.ts` when the data shape grows.
+
+- **Responsibility leakage**: A prompt builder that calls another prompt builder, or calls a utility that reads from state, or has a side effect on logging that depends on runtime context. Builders must be standalone: same input, same output, every time, in any order.

package/src/prompts/ceremony/dedup.ts

@@ -121,8 +121,6 @@ function buildRecordFormatExamples(itemType: string): string {
   // When merging: HIGHER strength/confidence, AVERAGE sentiment, MAX exposure_desired.
   
   switch (itemType) {
-    case "fact":
-      return buildFactExamples();
     case "trait":
       return buildTraitExamples();
     case "topic":
@@ -134,37 +132,6 @@ function buildRecordFormatExamples(itemType: string): string {
   }
 }
 
-function buildFactExamples(): string {
-  return `EXISTING FACT (being updated/merged):
-{
-  "id": "uuid-of-canonical-record",  // REQUIRED for updates
-  "type": "fact",                     // REQUIRED
-  "name": "Owns a 2019 Toyota Camry", // REQUIRED - descriptive, concise
-  "description": "Silver sedan, purchased in March 2019. Primary commute vehicle. Has 45k miles as of Jan 2024.", // REQUIRED - ALL unique details from duplicates
-  "sentiment": 0.2,                    // -1.0 to 1.0, emotional valence (average when merging)
-  "validated": "by_human",            // "unknown" | "by_ei" | "by_human" | "ai_generated" (keep highest trust level)
-  "validated_date": "2024-01-15T10:30:00Z", // ISO timestamp (most recent)
-  "last_updated": "2024-03-11T12:00:00Z",   // ISO timestamp (set to now)
-  "learned_by": "persona-uuid-123",  // OPTIONAL - UUID of persona that learned this (preserve from source)
-  "last_changed_by": "persona-uuid-456", // OPTIONAL - UUID of persona that last updated (your current context)
-  "persona_groups": ["group1", "group2"] // OPTIONAL - visibility groups (union of all sources)
-}
-
-NEW FACT (creating missing concept):
-{
-  "type": "fact",                     // REQUIRED (NO "id" field for new records)
-  "name": "Lives in Seattle",         // REQUIRED
-  "description": "Resides in the Capitol Hill neighborhood. Has lived there since 2018.", // REQUIRED - concise (<300 chars ideal)
-  "sentiment": 0.0,                    // -1.0 to 1.0 (neutral default for facts)
-  "validated": "unknown",             // Default for new records
-  "validated_date": ""                // Empty string for unvalidated
-}
-
-GOOD vs BAD descriptions:
-✅ GOOD: "Works as a Senior Software Engineer at Microsoft. Started in 2020. Team focuses on Azure infrastructure."
-❌ BAD: "The user has indicated through various conversations that they are employed..." (too verbose, meta-commentary)`;
-}
-
 function buildTraitExamples(): string {
   return `EXISTING TRAIT (being updated/merged):
 {

package/src/prompts/ceremony/rewrite.ts

@@ -19,7 +19,7 @@ Rules:
 
 Return a raw JSON array of strings. No markdown fencing, no commentary, no explanation. Just the array.
 
-Example — a Fact named "Job" whose description also discusses vim keybindings, git conventions, and AI tooling:
+Example — a Topic named "Software Engineering" whose description also discusses vim keybindings, git conventions, and AI tooling:
 ["vim keybindings and editor configuration", "git and GitHub workflow conventions", "AI coding assistant preferences"]`;
 
   const user = JSON.stringify(stripEmbedding(data.item), null, 2);
@@ -59,10 +59,9 @@ Rules:
 - The original record (id: "${data.item.id}") MUST appear in "existing", slimmed down.
 - Descriptions should be concise — ideally under 300 characters, never over 500.
 - Preserve sentiment, strength, confidence, and other numeric values from the source record where applicable.
-- "type" must be one of: "fact", "trait", "topic", "person".
-- Topics MUST include "category" — one of: Interest, Goal, Dream, Conflict, Concern, Fear, Hope, Plan, Project.
+- "type" must be one of: "topic", "person".
+- Topics MUST include "category" — one of: Interest, Goal, Dream, Conflict, Concern, Fear, Hope, Plan, Project, Event. For Event topics, the description should be a narrative account of a specific moment, not a general summary.
 - People MUST include "relationship" — a short label like "coworker", "friend", "mentor", etc.
-- Traits MUST include "strength" (0.0-1.0).
 - Do NOT invent information. Only redistribute what exists in the original record.`;
 
   const subjects = data.subjects.map(s => ({
@@ -92,24 +91,7 @@ function stripEmbedding<T extends { embedding?: unknown }>(item: T): Omit<T, "em
 }
 
 function buildExistingExamples(): string {
-  return `Fact:
-{
-  "id": "existing-uuid",
-  "type": "fact",
-  "name": "Record Name",
-  "description": "Updated description with incorporated data"
-}
-
-Trait:
-{
-  "id": "existing-uuid",
-  "type": "trait",
-  "name": "Trait Name",
-  "description": "Updated trait description",
-  "strength": 0.7
-}
-
-Topic:
+  return `Topic:
 {
   "id": "existing-uuid",
   "type": "topic",
@@ -129,30 +111,13 @@ Person:
 }
 
 function buildNewExamples(): string {
-  return `Fact:
-{
-  "type": "fact",
-  "name": "New Subject Name",
-  "description": "Concise description of this subject",
-  "sentiment": 0.0
-}
-
-Trait:
-{
-  "type": "trait",
-  "name": "New Trait Name",
-  "description": "Concise trait description",
-  "sentiment": 0.0,
-  "strength": 0.5
-}
-
-Topic:
+  return `Topic:
 {
   "type": "topic",
   "name": "New Topic Name",
   "description": "Concise topic description",
   "sentiment": 0.0,
-  "category": "Interest"
+  "category": "Interest|Goal|Dream|Conflict|Concern|Fear|Hope|Plan|Project|Event"
 }
 
 Person:

package/src/prompts/ceremony/types.ts

@@ -1,4 +1,4 @@
-import type { Trait, PersonaTopic, DataItemBase } from "../../core/types.js";
+import type { PersonaTrait, PersonaTopic, DataItemBase } from "../../core/types.js";
 
 export interface PersonaExpirePromptData {
   persona_name: string;
@@ -11,7 +11,7 @@ export interface PersonaExpireResult {
 
 export interface PersonaExplorePromptData {
   persona_name: string;
-  traits: Trait[];
+  traits: PersonaTrait[];
   remaining_topics: PersonaTopic[];
   recent_conversation_themes: string[];
 }
@@ -32,7 +32,7 @@ export interface DescriptionCheckPromptData {
   persona_name: string;
   current_short_description?: string;
   current_long_description?: string;
-  traits: Trait[];
+  traits: PersonaTrait[];
   topics: PersonaTopic[];
 }
 
@@ -45,7 +45,7 @@ export interface DescriptionCheckResult {
 // REWRITE (Item Reorganization)
 // =============================================================================
 
-export type RewriteItemType = "fact" | "trait" | "topic" | "person";
+export type RewriteItemType = "trait" | "topic" | "person";
 
 /** Phase 1 input: the bloated item to scan for extra subjects. */
 export interface RewriteScanPromptData {

package/src/prompts/generation/descriptions.ts

@@ -1,7 +1,7 @@
 import type { PersonaDescriptionsPromptData, PromptOutput } from "./types.js";
-import type { Trait, PersonaTopic } from "../../core/types.js";
+import type { PersonaTrait, PersonaTopic } from "../../core/types.js";
 
-function formatTraitsForPrompt(traits: Trait[]): string {
+function formatTraitsForPrompt(traits: PersonaTrait[]): string {
   if (traits.length === 0) return "(No traits defined)";
   
   return traits.map(t => {

package/src/prompts/generation/types.ts

@@ -1,4 +1,4 @@
-import type { Trait, PersonaTopic } from "../../core/types.js";
+import type { PersonaTrait, PersonaTopic } from "../../core/types.js";
 
 export interface PromptOutput {
   system: string;
@@ -36,7 +36,7 @@ export interface PersonaGenerationResult {
 export interface PersonaDescriptionsPromptData {
   name: string;
   aliases: string[];
-  traits: Trait[];
+  traits: PersonaTrait[];
   topics: PersonaTopic[];
 }
 

package/src/prompts/heartbeat/types.ts

@@ -3,7 +3,7 @@
  * Based on CONTRACTS.md specifications
  */
 
-import type { Trait, Topic, Person, Message, PersonaTopic } from "../../core/types.js";
+import type { PersonaTrait, Topic, Person, Message, PersonaTopic } from "../../core/types.js";
 
 /**
  * Common prompt output structure
@@ -19,7 +19,7 @@ export interface PromptOutput {
 export interface HeartbeatCheckPromptData {
   persona: {
     name: string;
-    traits: Trait[];
+    traits: PersonaTrait[];
     topics: PersonaTopic[];
   };
   human: {