effect 4.0.0-beta.106 → 4.0.0-beta.107

package/src/unstable/http/MultipartParser/internal/headers.ts

@@ -12,394 +12,23 @@ type State = (typeof State)[keyof typeof State]
 
 const constContinue: Continue = { _tag: "Continue" }
 
-const constNameChars = [
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  1,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  0,
-  0,
-  1,
-  1,
-  0,
-  1,
-  1,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  0,
-  0,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  0,
-  1,
-  0,
-  1
-]
+// RFC 7230 token characters, allowed in header names
+// The previous table stopped at byte 126; zero-filled entries for bytes 127-255
+// preserve its rejection behavior because callers accept only entries equal to 1.
+const constNameChars = new Uint8Array(256)
+for (const char of "!#$%&'*+-.^_`|~0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ") {
+  constNameChars[char.charCodeAt(0)] = 1
+}
 
-const constValueChars = [
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  1,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  0,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1,
-  1
-]
+// HTAB, visible ASCII and obs-text, allowed in header values
+const constValueChars = new Uint8Array(256)
+constValueChars[9] = 1
+for (let i = 32; i <= 126; i++) {
+  constValueChars[i] = 1
+}
+for (let i = 128; i <= 255; i++) {
+  constValueChars[i] = 1
+}
 
 export function make() {
   const decoder = new TextDecoder()

package/src/unstable/http/MultipartParser/internal/multipart.ts

@@ -84,6 +84,14 @@ export function make({
     state.onChunk = noopOnChunk
   }
 
+  function stop(error: MultipartError) {
+    state.stopped = true
+    if (state.state === State.body && state.isFile) {
+      state.onChunk(null)
+    }
+    onError(error)
+  }
+
   const headerParser = HP.make()
 
   const split = Search.make(
@@ -132,14 +140,12 @@ export function make({
 
         state.parts++
         if (state.parts > maxParts) {
-          state.stopped = true
-          return onError(errMaxParts)
+          return stop(errMaxParts)
         }
       }
 
       if ((state.partSize += chunk.length) > maxPartSize) {
-        state.stopped = true
-        return onError(errMaxPartSize)
+        return stop(errMaxPartSize)
       }
 
       if (state.state === State.headers) {
@@ -206,8 +212,7 @@ export function make({
           } else {
             const buf = chunk.subarray(result.endPosition)
             if ((state.fieldSize += buf.length) > maxFieldSize) {
-              state.stopped = true
-              return onError(errMaxFieldSize)
+              return stop(errMaxFieldSize)
             }
             state.fieldChunks.push(buf)
           }
@@ -216,8 +221,7 @@ export function make({
         state.onChunk(chunk)
       } else {
         if ((state.fieldSize += chunk.length) > maxFieldSize) {
-          state.stopped = true
-          return onError(errMaxFieldSize)
+          return stop(errMaxFieldSize)
         }
         state.fieldChunks.push(chunk)
       }
@@ -232,14 +236,14 @@ export function make({
         return
       }
       if ((state.totalSize += chunk.length) > maxTotalSize) {
-        return onError(errMaxTotalSize)
+        return stop(errMaxTotalSize)
       }
       return split.write(chunk)
     },
     end() {
       split.end()
       if (!state.done && !state.stopped) {
-        onError(errEndNotReached)
+        stop(errEndNotReached)
       }
 
       state.state = State.headers

package/src/unstable/process/ChildProcess.ts

@@ -432,6 +432,14 @@ export interface CommandOptions extends KillOptions {
    * Defaults to `true` on non-Windows platforms and `false` on Windows platforms.
    */
   readonly detached?: boolean | undefined
+  /**
+   * If set to `true`, prevents the child process's console or GUI window from
+   * becoming visible on Windows.
+   *
+   * Defaults to `true` unless `detached` is set to `true`. This option has no
+   * effect on non-Windows platforms.
+   */
+  readonly windowsHide?: boolean | undefined
   /**
    * Configuration options for the standard input stream for the child process.
    */

package/src/unstable/sql/Migrator.ts

@@ -15,6 +15,7 @@ import { FileSystem } from "../../FileSystem.ts"
 import { pipe } from "../../Function.ts"
 import * as Option from "../../Option.ts"
 import * as Order from "../../Order.ts"
+import { Path } from "../../Path.ts"
 import * as Client from "./SqlClient.ts"
 import type { SqlError } from "./SqlError.ts"
 
@@ -400,11 +401,19 @@ export const fromRecord = (migrations: Record<string, Effect.Effect<void, unknow
  * files named `<id>_<name>.js`, `<id>_<name>.ts`,
  * `<id>_<name>.mjs`, or `<id>_<name>.mts`, and sorts migrations by id.
  *
+ * **Details**
+ *
+ * Requires a `Path` service appropriate for the migration directory's path
+ * syntax. On Windows, prefer a platform-aware implementation such as
+ * `NodePath.layer`; the core `Path.layer` uses POSIX semantics and does not
+ * preserve Windows drive-letter paths.
+ *
  * @category loaders
  * @since 4.0.0
  */
-export const fromFileSystem: (directory: string) => Loader<FileSystem> = Effect.fnUntraced(function*(directory) {
+export const fromFileSystem: (directory: string) => Loader<FileSystem | Path> = Effect.fnUntraced(function*(directory) {
   const Fs = yield* FileSystem
+  const path = yield* Path
   const files = yield* Effect.mapError(
     Fs.readDirectory(directory),
     (cause) =>
@@ -424,14 +433,18 @@ export const fromFileSystem: (directory: string) => Loader<FileSystem> = Effect.
             [
               Number(id),
               name,
-              Effect.promise(
-                () =>
-                  import(
-                    /* @vite-ignore */
-                    /* webpackIgnore: true */
-                    `${directory}/${basename}`
-                  )
-              )
+              // `import` needs a file URL: on Windows an absolute path such as
+              // `D:\migrations\1_init.ts` is rejected by the ESM loader. `orDie` keeps the
+              // failure a defect so `loadMigration` reports it as an import error.
+              Effect.flatMap(Effect.orDie(path.toFileUrl(path.join(directory, basename))), (url) =>
+                Effect.promise(
+                  () =>
+                    import(
+                      /* @vite-ignore */
+                      /* webpackIgnore: true */
+                      url.href
+                    )
+                ))
             ]
           ] as const
       })