effect-cf 0.47.0 → 0.48.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # effect-cf
 
+## 0.48.0
+
+### Minor Changes
+
+- [#192](https://github.com/danieljvdm/effect-cf/pull/192) [`761c4f4`](https://github.com/danieljvdm/effect-cf/commit/761c4f411e11ae0491f61c6fe7c7697faf68e7f0) Thanks [@danieljvdm](https://github.com/danieljvdm)! - Report absent Artifacts commits as `ArtifactsOperationError` with `NOT_FOUND` instead of succeeding with `null`. Correct the raw `ArtifactsRepoBinding.readCommit` return type to include `null`; the Effect client continues to return a commit or a typed failure.
+
 ## 0.47.0
 
 ### Minor Changes

package/dist/Artifacts.d.mts

@@ -145,7 +145,7 @@ interface ArtifactsRepoBinding extends Partial<ArtifactsRepoInfo> {
   readonly revokeToken: (tokenOrId: string) => Promise<boolean>;
   readonly fork: (name: RepoName, options?: ArtifactsForkOptions) => Promise<ArtifactsCreateRepoResult>;
   readonly log: (options?: ArtifactsLogOptions) => Promise<ArtifactsLogResult>;
-  readonly readCommit: (hash: string) => Promise<ArtifactsCommit>;
+  readonly readCommit: (hash: string) => Promise<ArtifactsCommit | null>;
   readonly readTree: (hash: string) => Promise<ArtifactsTree>;
 }
 interface ArtifactsBinding {

package/dist/Artifacts.mjs

@@ -105,7 +105,17 @@ const wrapRepo = (binding, repo, info) => ({
 	revokeToken: Effect.fn("Artifacts.revokeToken", spanOptions(binding, "revokeToken"))((tokenOrId) => tryArtifactsPromise(binding, "revokeToken", () => repo.revokeToken(tokenOrId))),
 	fork: Effect.fn("Artifacts.fork", spanOptions(binding, "fork"))((name, options) => tryArtifactsPromise(binding, "fork", () => repo.fork(name, options))),
 	log: Effect.fn("Artifacts.log", spanOptions(binding, "log"))((options) => tryArtifactsPromise(binding, "log", () => repo.log(options))),
-	readCommit: Effect.fn("Artifacts.readCommit", spanOptions(binding, "readCommit"))((hash) => tryArtifactsPromise(binding, "readCommit", () => repo.readCommit(hash))),
+	readCommit: Effect.fn("Artifacts.readCommit", spanOptions(binding, "readCommit"))(function* (hash) {
+		const commit = yield* tryArtifactsPromise(binding, "readCommit", () => repo.readCommit(hash));
+		if (commit === null) return yield* new ArtifactsOperationError({
+			binding,
+			operation: "readCommit",
+			code: "NOT_FOUND",
+			numericCode: artifactsErrorNumericCodes.NOT_FOUND,
+			cause: /* @__PURE__ */ new Error("Commit not found")
+		});
+		return commit;
+	}),
 	readTree: Effect.fn("Artifacts.readTree", spanOptions(binding, "readTree"))((hash) => tryArtifactsPromise(binding, "readTree", () => repo.readTree(hash))),
 	raw: repo
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "effect-cf",
-  "version": "0.47.0",
+  "version": "0.48.0",
   "description": "Effect-native primitives for Cloudflare Workers and bindings.",
   "license": "MIT",
   "repository": {

package/src/Artifacts.ts

@@ -222,7 +222,7 @@ export interface ArtifactsRepoBinding extends Partial<ArtifactsRepoInfo> {
     options?: ArtifactsForkOptions,
   ) => Promise<ArtifactsCreateRepoResult>;
   readonly log: (options?: ArtifactsLogOptions) => Promise<ArtifactsLogResult>;
-  readonly readCommit: (hash: string) => Promise<ArtifactsCommit>;
+  readonly readCommit: (hash: string) => Promise<ArtifactsCommit | null>;
   readonly readTree: (hash: string) => Promise<ArtifactsTree>;
 }
 
@@ -451,7 +451,20 @@ const wrapRepo = (
   readCommit: Effect.fn(
     "Artifacts.readCommit",
     spanOptions(binding, "readCommit"),
-  )((hash: string) => tryArtifactsPromise(binding, "readCommit", () => repo.readCommit(hash))),
+  )(function* (hash: string) {
+    const commit = yield* tryArtifactsPromise(binding, "readCommit", () => repo.readCommit(hash));
+
+    if (commit === null)
+      return yield* new ArtifactsOperationError({
+        binding,
+        operation: "readCommit",
+        code: "NOT_FOUND",
+        numericCode: artifactsErrorNumericCodes.NOT_FOUND,
+        cause: new Error("Commit not found"),
+      });
+
+    return commit;
+  }),
   readTree: Effect.fn(
     "Artifacts.readTree",
     spanOptions(binding, "readTree"),