ef-keycloak-connect 1.2.1 → 1.2.3

package/README.md

@@ -1,10 +1,16 @@
-# Node JS module for keycloak
+# Node JS adapter for keycloak
 Keycloak is an Open Source Identity and Access Management solution for modern Applications and Services.
 
 This repository contains the source code for the Keycloak Node.js adapter. This module makes it simple to implement a Node.js Connect-friendly application that uses Keycloak for its authentication and authorization needs.
 
 [Documentation](https://www.keycloak.org/documentation.html)
 
+# EF Keycloak Connect
+
+**ef-keycloak-connect** extends on the functionality of Keycloak Node JS adapter by using Keycloak APIs to simplify its functionality. This package provides functions to Authencticate a user, get access token with introspect, create and delete resource, create users, roles and assign role to users. 
+
+**ef-keycloak-connect** also includes the functions to authenticate users from Cisco Finesse for both SSO and Non SSO instances.
+
 ## Getting started
 
 ### Installation 
@@ -193,7 +199,7 @@ This function performs 3 functionalities based on arguments/parameters provided.
 ***Finesse User Auth and Sync with keycloak (SSO)***
  For Finesse User Auth (Non SSO) we use the function as follows
    ```
-   authenticateFinesse('johndoe', '', `https://${finesse_server_url}:${port}`, ['agent','supervisor'], 'eyJhbGciOiJkaXIiLCJjdHkiOiJKV1QiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2In0..oPk0ttAA')
+   authenticateUserViaKeycloak('johndoe', '', `https://${finesse_server_url}:${port}`, ['agent','supervisor'], 'eyJhbGciOiJkaXIiLCJjdHkiOiJKV1QiLCJlbmMiOiJBMTI4Q0JDLUhTMjU2In0..oPk0ttAA')
    ```
   Difference between *Finesse User Auth(SSO)* and *Finesse User Auth(Non SSO)* is that SSO uses finesse_token field while Password field remains ' ', while in Non SSO a Password is sent by user and finesse_token field remains ' '
   

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ef-keycloak-connect",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "Node JS keycloak adapter for authentication and authorization.",
   "main": "index.js",
   "scripts": {

package/services/keycloakService.js

@@ -584,39 +584,50 @@ class KeycloakService extends Keycloak{
                     let count = 0;
                     let flag = true;
                     let obj = [];  // final object to be returned
-                    let rolesCount = 0;
+
                     for (let i = 0; i < keycloak_roles.length; i++) {
                         try {
-                            config.url = keycloakConfig["auth-server-url"] + 'admin/realms/' + keycloakConfig.realm + '/roles/' + keycloak_roles[i] + '/users'
+
+                            config.url = keycloakConfig["auth-server-url"] + 'admin/realms/' + keycloakConfig.realm + '/roles/' + keycloak_roles[i] + '/users?max=100000'
                             let getUsersfromRoles = await requestController.httpRequest(config, true);
                             userObject = getUsersfromRoles.data;
-                            for (let check = 0; check < userObject.length; check++) {
-                                let tobecheckedID = userObject[check].id;
-                                for (let org = 0; org < count; org++) {
-                                    if (tobecheckedID === obj[org].id) {
-                                        obj[org].roles[++rolesCount] = keycloak_roles[i];
+
+                            userObject.forEach((user) => {
+
+                                if(count > 0){
+
+                                   let userIndex = obj.findIndex(usr => {
+                                        return usr.username == user.username;
+                                   });
+
+                                   if(userIndex != -1){
+                                        obj[userIndex].roles.push(keycloak_roles[i]);
                                         flag = false;
-                                    }
+                                   }
                                 }
-                                if (flag == true) {
-                                    obj[count] = {
-                                        'id': userObject[check].id,
-                                        'username': userObject[check].username,
-                                        'firstName': userObject[check].firstName,
-                                        'lastName': userObject[check].lastName,
+                                
+                                if(flag == true){
+
+                                    obj.push({
+                                        'id': user.id,
+                                        'username': user.username,
+                                        'firstName': ((user.firstName == undefined)? "" : user.firstName),
+                                        'lastName': ((user.lastName == undefined)? "" : user.lastName),
                                         'roles': [keycloak_roles[i]]
-                                    }
-                                    if (obj[count].firstName == undefined) {
-                                        obj[count].firstName = "";
-                                        obj[count].lastName = "";
-                                    }
-                                    count = count + 1;
+                                    }) 
+
                                 }
-                            }
+    
+                                flag = true;
+
+                            });
+
                         }
                         catch (er) {
                             reject(er);
                         }
+
+                        count++;
                     }
                     resolve(obj);
                 }