edsger 0.77.0 → 0.78.0

package/dist/phases/code-implementation-verification/prompts.d.ts

@@ -1,10 +0,0 @@
-export declare const createCodeImplementationVerificationSystemPrompt: (projectDir?: string) => Promise<string>;
-export interface CodeImplVerificationPromptOptions {
-    issueId: string;
-    branchName: string;
-    baseBranch: string;
-    issueName: string;
-    issueDescription: string;
-    checklistContext: string;
-}
-export declare const createCodeImplementationVerificationPrompt: (opts: CodeImplVerificationPromptOptions) => string;

package/dist/phases/code-implementation-verification/prompts.js

@@ -1,90 +0,0 @@
-import { resolveSkill } from '../../services/skill-resolver.js';
-import { OUTPUT_CONTRACTS } from '../output-contracts.js';
-export const createCodeImplementationVerificationSystemPrompt = async (projectDir) => {
-    const skill = await resolveSkill('phase/code-implementation-verification', {
-        projectDir,
-    });
-    if (!skill) {
-        throw new Error('Failed to load skill: phase/code-implementation-verification');
-    }
-    return `${skill.prompt}
-
-${OUTPUT_CONTRACTS['code-implementation-verification']}`;
-};
-export const createCodeImplementationVerificationPrompt = (opts) => {
-    const { issueId, branchName, baseBranch, issueName, issueDescription, checklistContext, } = opts;
-    return `# Code Implementation Verification Task
-
-You are verifying the code implementation for issue: **${issueName}**
-
-## Issue Information
-- **Issue ID**: ${issueId}
-- **Description**: ${issueDescription}
-- **Implementation Branch**: ${branchName}
-- **Base Branch**: ${baseBranch}
-
-## Checklist Requirements to Verify
-${checklistContext}
-
----
-
-## Your Verification Process
-
-Follow these steps systematically:
-
-### Step 1: Switch to Issue Branch
-\`\`\`bash
-git checkout ${branchName}
-\`\`\`
-
-### Step 2: Review Code Changes
-Compare the issue branch with the base branch to see what was changed:
-\`\`\`bash
-git diff ${baseBranch}...${branchName}
-\`\`\`
-
-Also review the commit history:
-\`\`\`bash
-git log ${baseBranch}..${branchName} --oneline
-\`\`\`
-
-### Step 3: Read Modified Files
-Use the Read tool to examine the actual code implementation in detail. Look at:
-- New files created
-- Modified files
-- Implementation logic
-- Error handling
-- Test coverage
-
-### Step 4: Verify Against Checklist
-For each checklist item, evaluate the implementation:
-- Is the requirement implemented?
-- Is the implementation complete and correct?
-- Does it follow best practices?
-- Are there quality concerns?
-
-### Step 5: Assign Verification Status
-For each checklist item:
-- ✅ **CONFIRMED**: Code clearly satisfies the requirement with good quality
-- ❌ **REJECTED**: Requirement not implemented or implementation inadequate
-- ⚠️ **UNCERTAIN**: Partial implementation or quality concerns
-
-### Step 6: Provide Improvement Suggestions
-For rejected or uncertain items, provide specific, actionable suggestions on how to improve the implementation.
-
----
-
-## Important Notes
-
-- **Review ACTUAL CODE**: Base your verification on the actual code changes in git diff, not on summaries
-- **Be Thorough**: Read the modified files to understand the implementation
-- **Be Objective**: Provide fair, evidence-based assessments
-- **Be Specific**: Give concrete examples and actionable suggestions
-- **Focus on Quality**: Consider code quality, security, performance, and maintainability
-
-## Output Format
-
-Return your verification results in the required JSON format. Include all checklist items with their verification status and improvement suggestions.
-
-Begin your systematic code review now.`;
-};

package/dist/phases/code-refine/context.d.ts

@@ -1,99 +0,0 @@
-/**
- * Context fetcher for code refine phase
- * Fetches GitHub PR review comments and reviews using GraphQL API
- */
-import { Octokit } from '@octokit/rest';
-export interface PRReviewComment {
-    id: number;
-    body: string;
-    path: string | null;
-    line: number | null;
-    user: {
-        login: string;
-    };
-    created_at: string;
-    position: number | null;
-    original_position: number | null;
-    diff_hunk: string | null;
-    in_reply_to_id?: number;
-    url?: string;
-}
-export interface PRReview {
-    id: number;
-    node_id: string;
-    user: {
-        login: string;
-    };
-    body: string | null;
-    state: string;
-    submitted_at: string | null;
-}
-export interface PRReviewThread {
-    id: string;
-    isResolved: boolean;
-    isOutdated: boolean;
-    line: number | null;
-    originalLine: number | null;
-    startLine: number | null;
-    originalStartLine: number | null;
-    diffSide: string;
-    comments: PRReviewComment[];
-}
-export interface CodeRefineContext {
-    issueId: string;
-    issueName: string;
-    issueDescription: string | null;
-    pullRequestUrl: string;
-    pullRequestNumber: number;
-    owner: string;
-    repo: string;
-    reviews: PRReview[];
-    reviewComments: PRReviewComment[];
-    reviewThreads?: PRReviewThread[];
-    technicalDesign?: string;
-    userStories?: any[];
-    testCases?: any[];
-}
-/**
- * Extract owner, repo, and PR number from GitHub PR URL
- */
-export declare function parsePullRequestUrl(pullRequestUrl: string): {
-    owner: string;
-    repo: string;
-    prNumber: number;
-} | null;
-/**
- * Fetch PR reviews that request changes
- */
-export declare function fetchPRReviews(octokit: Octokit, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<PRReview[]>;
-/**
- * Fetch PR review comments
- */
-export declare function fetchPRReviewComments(octokit: Octokit, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<PRReviewComment[]>;
-/**
- * Fetch PR data using GraphQL API including review threads and reviews
- */
-export declare function fetchPRDataGraphQL(octokit: Octokit, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<{
-    reviewThreads: PRReviewThread[];
-    reviews: PRReview[];
-}>;
-/**
- * Fetch user stories via MCP
- */
-export declare function fetchUserStories(issueId: string, verbose?: boolean): Promise<any[]>;
-/**
- * Fetch test cases via MCP
- */
-export declare function fetchTestCases(issueId: string, verbose?: boolean): Promise<any[]>;
-/**
- * Fetch complete code refine context
- * @param issueId - The issue ID
- * @param githubToken - GitHub token for API access
- * @param verbose - Enable verbose logging
- * @param pullRequestUrl - Optional PR URL (for multi-branch issues, use branch's PR URL)
- */
-export declare function fetchCodeRefineContext(issueId: string, githubToken: string, verbose?: boolean, pullRequestUrl?: string): Promise<CodeRefineContext>;
-/**
- * Format code refine context for prompt
- */
-export declare function formatContextForPrompt(context: CodeRefineContext): string;

package/dist/phases/code-refine/context.js

@@ -1,457 +0,0 @@
-/**
- * Context fetcher for code refine phase
- * Fetches GitHub PR review comments and reviews using GraphQL API
- */
-import { Octokit } from '@octokit/rest';
-import { getIssue } from '../../api/issues/get-issue.js';
-import { getMcpServerUrl, getMcpToken } from '../../auth/auth-store.js';
-import { downloadImagesForClaudeCode } from '../../utils/image-downloader.js';
-import { logDebug } from '../../utils/logger.js';
-/**
- * Extract owner, repo, and PR number from GitHub PR URL
- */
-export function parsePullRequestUrl(pullRequestUrl) {
-    const match = pullRequestUrl.match(/github\.com\/([^\/]+)\/([^\/]+)\/pull\/(\d+)/);
-    if (!match) {
-        return null;
-    }
-    return {
-        owner: match[1],
-        repo: match[2],
-        prNumber: parseInt(match[3], 10),
-    };
-}
-/**
- * Fetch PR reviews that request changes
- */
-export async function fetchPRReviews(octokit, owner, repo, prNumber, verbose) {
-    logDebug(`Fetching PR reviews for ${owner}/${repo}#${prNumber}...`, verbose);
-    const { data: reviews } = await octokit.pulls.listReviews({
-        owner,
-        repo,
-        pull_number: prNumber,
-    });
-    // Filter for reviews that request changes and map to our interface
-    const requestChangesReviews = reviews
-        .filter((review) => review.state === 'CHANGES_REQUESTED')
-        .map((review) => ({
-        id: review.id,
-        node_id: review.node_id, // REST API also returns node_id
-        user: {
-            login: review.user?.login || 'unknown',
-        },
-        body: review.body ?? null,
-        state: review.state,
-        submitted_at: review.submitted_at ?? null,
-    }));
-    logDebug(`Found ${requestChangesReviews.length} reviews requesting changes`, verbose);
-    return requestChangesReviews;
-}
-/**
- * Fetch PR review comments
- */
-export async function fetchPRReviewComments(octokit, owner, repo, prNumber, verbose) {
-    logDebug(`Fetching PR review comments for ${owner}/${repo}#${prNumber}...`, verbose);
-    const { data: comments } = await octokit.pulls.listReviewComments({
-        owner,
-        repo,
-        pull_number: prNumber,
-    });
-    logDebug(`Found ${comments.length} review comments`, verbose);
-    return comments;
-}
-/**
- * Fetch PR data using GraphQL API including review threads and reviews
- */
-export async function fetchPRDataGraphQL(octokit, owner, repo, prNumber, verbose) {
-    logDebug(`Fetching PR data via GraphQL for ${owner}/${repo}#${prNumber}...`, verbose);
-    const query = `
-    query($owner: String!, $repo: String!, $prNumber: Int!) {
-      repository(owner: $owner, name: $repo) {
-        pullRequest(number: $prNumber) {
-          reviews(first: 100) {
-            nodes {
-              id
-              databaseId
-              author {
-                login
-              }
-              body
-              state
-              submittedAt
-            }
-          }
-          reviewThreads(first: 100) {
-            nodes {
-              id
-              isResolved
-              isOutdated
-              line
-              originalLine
-              startLine
-              originalStartLine
-              diffSide
-              comments(first: 100) {
-                nodes {
-                  id
-                  databaseId
-                  body
-                  path
-                  originalPosition
-                  diffHunk
-                  createdAt
-                  url
-                  author {
-                    login
-                  }
-                }
-              }
-            }
-          }
-        }
-      }
-    }
-  `;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const result = await octokit.graphql(query, {
-        owner,
-        repo,
-        prNumber,
-    });
-    const { pullRequest } = result.repository;
-    // Transform GraphQL reviews to our interface
-    const reviews = (pullRequest.reviews.nodes || []).map(
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (review) => ({
-        id: review.databaseId,
-        node_id: review.id, // GraphQL Node ID for mutations
-        user: {
-            login: review.author?.login || 'unknown',
-        },
-        body: review.body,
-        state: review.state,
-        submitted_at: review.submittedAt,
-    }));
-    // Transform GraphQL review threads to our interface
-    const reviewThreads = (pullRequest.reviewThreads.nodes || [])
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        .map((thread) => ({
-        id: thread.id,
-        isResolved: thread.isResolved,
-        isOutdated: thread.isOutdated,
-        line: thread.line,
-        originalLine: thread.originalLine,
-        startLine: thread.startLine,
-        originalStartLine: thread.originalStartLine,
-        diffSide: thread.diffSide,
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        comments: (thread.comments.nodes || []).map((comment) => ({
-            id: comment.databaseId,
-            body: comment.body,
-            path: comment.path,
-            line: thread.line, // Use thread's line for consistency
-            user: {
-                login: comment.author?.login || 'unknown',
-            },
-            created_at: comment.createdAt,
-            position: comment.originalPosition,
-            original_position: comment.originalPosition,
-            diff_hunk: comment.diffHunk,
-            url: comment.url,
-        })),
-    }));
-    // Filter for reviews requesting changes
-    const changesRequestedReviews = reviews.filter((review) => review.state === 'CHANGES_REQUESTED');
-    // Filter for unresolved threads
-    const unresolvedThreads = reviewThreads.filter((thread) => !thread.isResolved);
-    logDebug(`Found ${changesRequestedReviews.length} reviews requesting changes`, verbose);
-    logDebug(`Found ${unresolvedThreads.length} unresolved review threads`, verbose);
-    return {
-        reviewThreads: unresolvedThreads,
-        reviews: changesRequestedReviews,
-    };
-}
-/**
- * Fetch user stories via MCP
- */
-export async function fetchUserStories(issueId, verbose
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-) {
-    try {
-        logDebug(`Fetching user stories for ${issueId}...`, verbose);
-        const mcpServerUrl = getMcpServerUrl();
-        const mcpToken = getMcpToken();
-        const response = await fetch(`${mcpServerUrl}/mcp`, {
-            method: 'POST',
-            headers: {
-                'Content-Type': 'application/json',
-                Authorization: `Bearer ${mcpToken}`,
-            },
-            body: JSON.stringify({
-                jsonrpc: '2.0',
-                id: 1,
-                method: 'user_stories/list',
-                params: {
-                    issue_id: issueId,
-                },
-            }),
-        });
-        if (!response.ok) {
-            logDebug(`Could not fetch user stories: ${response.status}`, verbose);
-            return [];
-        }
-        const data = await response.json();
-        if (data.error || !data.result) {
-            logDebug('User stories not available', verbose);
-            return [];
-        }
-        return data.result.user_stories || [];
-    }
-    catch (error) {
-        logDebug(`Error fetching user stories: ${error}`, verbose);
-        return [];
-    }
-}
-/**
- * Fetch test cases via MCP
- */
-export async function fetchTestCases(issueId, verbose
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-) {
-    try {
-        logDebug(`Fetching test cases for ${issueId}...`, verbose);
-        const mcpServerUrl = getMcpServerUrl();
-        const mcpToken = getMcpToken();
-        const response = await fetch(`${mcpServerUrl}/mcp`, {
-            method: 'POST',
-            headers: {
-                'Content-Type': 'application/json',
-                Authorization: `Bearer ${mcpToken}`,
-            },
-            body: JSON.stringify({
-                jsonrpc: '2.0',
-                id: 1,
-                method: 'test_cases/list',
-                params: {
-                    issue_id: issueId,
-                },
-            }),
-        });
-        if (!response.ok) {
-            logDebug(`Could not fetch test cases: ${response.status}`, verbose);
-            return [];
-        }
-        const data = await response.json();
-        if (data.error || !data.result) {
-            logDebug('Test cases not available', verbose);
-            return [];
-        }
-        return data.result.test_cases || [];
-    }
-    catch (error) {
-        logDebug(`Error fetching test cases: ${error}`, verbose);
-        return [];
-    }
-}
-/**
- * Process images in GitHub PR reviews and comments
- * Downloads images from markdown content and replaces URLs with local paths
- */
-async function processGitHubContentImages(reviews, reviewThreads, issueId, verbose) {
-    logDebug('Processing images in GitHub PR content...', verbose);
-    // Process review bodies
-    const processedReviews = await Promise.all(reviews.map(async (review) => {
-        if (!review.body) {
-            return review;
-        }
-        const { processedMarkdown } = await downloadImagesForClaudeCode(review.body, issueId);
-        return { ...review, body: processedMarkdown };
-    }));
-    // Process comment bodies in review threads
-    const processedThreads = await Promise.all(reviewThreads.map(async (thread) => {
-        const processedComments = await Promise.all(thread.comments.map(async (comment) => {
-            if (!comment.body) {
-                return comment;
-            }
-            const { processedMarkdown } = await downloadImagesForClaudeCode(comment.body, issueId);
-            return { ...comment, body: processedMarkdown };
-        }));
-        return { ...thread, comments: processedComments };
-    }));
-    logDebug('Finished processing images in GitHub PR content', verbose);
-    return {
-        processedReviews,
-        processedThreads,
-    };
-}
-/**
- * Fetch complete code refine context
- * @param issueId - The issue ID
- * @param githubToken - GitHub token for API access
- * @param verbose - Enable verbose logging
- * @param pullRequestUrl - Optional PR URL (for multi-branch issues, use branch's PR URL)
- */
-export async function fetchCodeRefineContext(issueId, githubToken, verbose, pullRequestUrl) {
-    // Fetch issue info using shared API
-    const issue = await getIssue(issueId, verbose);
-    // Use provided PR URL (from branch)
-    const prUrl = pullRequestUrl;
-    if (!prUrl) {
-        throw new Error(`No pull request URL found for issue ${issueId}. Cannot perform code refine.`);
-    }
-    // Parse PR URL
-    const prInfo = parsePullRequestUrl(prUrl);
-    if (!prInfo) {
-        throw new Error(`Invalid pull request URL: ${prUrl}. Expected format: https://github.com/owner/repo/pull/123`);
-    }
-    const { owner, repo, prNumber } = prInfo;
-    // Initialize Octokit with GitHub token
-    const octokit = new Octokit({
-        auth: githubToken,
-    });
-    // Fetch PR data using GraphQL API and additional context
-    const [prData, userStories, testCases] = await Promise.all([
-        fetchPRDataGraphQL(octokit, owner, repo, prNumber, verbose),
-        fetchUserStories(issueId, verbose),
-        fetchTestCases(issueId, verbose),
-    ]);
-    // Process images in GitHub PR content (reviews and comments may contain markdown images)
-    const { processedReviews, processedThreads } = await processGitHubContentImages(prData.reviews, prData.reviewThreads, issueId, verbose);
-    // Extract review comments from unresolved threads (use processed threads)
-    const reviewComments = processedThreads.flatMap((thread) => thread.comments);
-    logDebug(`Summary: ${processedReviews.length} reviews requesting changes, ${processedThreads.length} unresolved threads, ${reviewComments.length} total comments`, verbose);
-    return {
-        issueId,
-        issueName: issue.name,
-        issueDescription: issue.description ?? null,
-        pullRequestUrl: prUrl,
-        pullRequestNumber: prNumber,
-        owner,
-        repo,
-        reviews: processedReviews,
-        reviewComments,
-        reviewThreads: processedThreads,
-        technicalDesign: issue.technical_design,
-        userStories,
-        testCases,
-    };
-}
-/**
- * Format code refine context for prompt
- */
-export function formatContextForPrompt(context) {
-    const sections = [];
-    // Issue information
-    sections.push(`# Issue Information`);
-    sections.push(`**Issue ID**: ${context.issueId}`);
-    sections.push(`**Issue Name**: ${context.issueName}`);
-    if (context.issueDescription) {
-        sections.push(`**Description**: ${context.issueDescription}`);
-    }
-    sections.push(`**Pull Request**: ${context.pullRequestUrl} (#${context.pullRequestNumber})`);
-    sections.push('');
-    // Reviews requesting changes
-    if (context.reviews.length > 0) {
-        sections.push(`## Code Reviews Requesting Changes`);
-        sections.push('');
-        context.reviews.forEach((review, idx) => {
-            sections.push(`### Review ${idx + 1} by @${review.user.login}`);
-            sections.push(`**Submitted**: ${review.submitted_at}`);
-            if (review.body) {
-                sections.push(`**Feedback**:`);
-                sections.push(review.body);
-            }
-            sections.push('');
-        });
-    }
-    // Review threads (unresolved conversations)
-    if (context.reviewThreads && context.reviewThreads.length > 0) {
-        sections.push(`## Unresolved Review Threads`);
-        sections.push(`*These conversations must be resolved before the PR can be merged.*`);
-        sections.push('');
-        context.reviewThreads.forEach((thread, idx) => {
-            sections.push(`### Thread ${idx + 1} ${thread.isOutdated ? '(Outdated)' : ''}`);
-            // Show thread location
-            if (thread.line !== null) {
-                sections.push(`**Line**: ${thread.line}`);
-            }
-            if (thread.startLine !== null && thread.startLine !== thread.line) {
-                sections.push(`**Line Range**: ${thread.startLine} - ${thread.line || thread.originalLine}`);
-            }
-            sections.push(`**Status**: ❌ Unresolved`);
-            sections.push('');
-            // Show all comments in this thread
-            thread.comments.forEach((comment, commentIdx) => {
-                sections.push(`#### ${commentIdx === 0 ? 'Original Comment' : `Reply ${commentIdx}`} by @${comment.user.login}`);
-                if (comment.path) {
-                    sections.push(`**File**: ${comment.path}`);
-                }
-                if (comment.url) {
-                    sections.push(`**URL**: ${comment.url}`);
-                }
-                if (commentIdx === 0 && comment.diff_hunk) {
-                    sections.push(`**Context**:`);
-                    sections.push('```diff');
-                    sections.push(comment.diff_hunk);
-                    sections.push('```');
-                }
-                sections.push(`**Comment**:`);
-                sections.push(comment.body);
-                sections.push('');
-            });
-        });
-    }
-    else if (context.reviewComments.length > 0) {
-        // Fallback to old format if no thread data available
-        sections.push(`## Review Comments`);
-        sections.push('');
-        context.reviewComments.forEach((comment, idx) => {
-            sections.push(`### Comment ${idx + 1} by @${comment.user.login}`);
-            if (comment.path) {
-                sections.push(`**File**: ${comment.path}`);
-            }
-            if (comment.line !== null) {
-                sections.push(`**Line**: ${comment.line}`);
-            }
-            if (comment.diff_hunk) {
-                sections.push(`**Context**:`);
-                sections.push('```diff');
-                sections.push(comment.diff_hunk);
-                sections.push('```');
-            }
-            sections.push(`**Comment**:`);
-            sections.push(comment.body);
-            sections.push('');
-        });
-    }
-    // Technical design
-    if (context.technicalDesign) {
-        sections.push(`## Technical Design`);
-        sections.push('');
-        sections.push(context.technicalDesign);
-        sections.push('');
-    }
-    // User stories
-    if (context.userStories && context.userStories.length > 0) {
-        sections.push(`## User Stories`);
-        sections.push('');
-        context.userStories.forEach((story) => {
-            sections.push(`### ${story.title}`);
-            sections.push(story.description || '');
-            sections.push('');
-        });
-    }
-    // Test cases
-    if (context.testCases && context.testCases.length > 0) {
-        sections.push(`## Test Cases`);
-        sections.push('');
-        context.testCases.forEach((testCase) => {
-            sections.push(`### ${testCase.title}`);
-            if (testCase.description) {
-                sections.push(testCase.description);
-            }
-            sections.push('');
-        });
-    }
-    return sections.join('\n');
-}