edsger 0.72.4 → 0.72.6

package/dist/index.js

@@ -58,7 +58,7 @@ import { runWorkflow } from './commands/workflow/index.js';
 import { DEFAULT_MAX_FILES as FIND_ARCHITECTURE_DEFAULT_MAX_FILES } from './phases/find-architecture/index.js';
 import { DEFAULT_MAX_FILES as FIND_SMELLS_DEFAULT_MAX_FILES } from './phases/find-smells/index.js';
 import { SMELL_CATEGORIES, } from './phases/find-smells/types.js';
-import { deregisterSession, registerSession, } from './system/session-manager.js';
+import { deregisterSession, registerSession, startHeartbeat, } from './system/session-manager.js';
 import { logError, logInfo } from './utils/logger.js';
 // Get package.json version dynamically
 // eslint-disable-next-line @typescript-eslint/naming-convention -- ESM __filename/__dirname polyfill
@@ -89,6 +89,10 @@ program
 program.hook('preAction', async (_thisCommand, actionCommand) => {
     if (process.env.EDSGER_PROCESS_KEY) {
         await registerSession({ command: actionCommand.name() });
+        // Keep last_heartbeat fresh while the run is alive, so consumers of the
+        // cli_sessions row (the desktop's tab views) can tell a live session from
+        // a stale one left behind by a crash / SIGKILL.
+        startHeartbeat();
     }
 });
 program.hook('postAction', async () => {
@@ -96,6 +100,46 @@ program.hook('postAction', async () => {
         await deregisterSession();
     }
 });
+/**
+ * Mark the session row stopped (bounded, best-effort) and exit non-zero.
+ *
+ * Every command's catch block used to call `process.exit(1)` directly, which
+ * skips the postAction hook above — the cli_sessions row stayed 'running'
+ * forever and the desktop kept showing a ghost in-progress run that no Stop
+ * button could clear.
+ */
+function exitWithError(error) {
+    logError(error instanceof Error ? error.message : String(error));
+    void Promise.race([
+        deregisterSession(),
+        new Promise((resolve) => {
+            setTimeout(resolve, 3000);
+        }),
+    ]).finally(() => process.exit(1));
+}
+// The desktop's Stop button sends SIGTERM (escalating to SIGKILL after 5s).
+// Without a handler the process dies with its cli_sessions row still
+// 'running' — same ghost-run problem as the error path above. Finalize the
+// row (bounded) before exiting. Commands that install their own handlers
+// (build, agent-workflow, task-worker, chat-serve, ...) own the process
+// lifetime; in that case only the session row is finalized here.
+for (const signal of ['SIGTERM', 'SIGINT']) {
+    const onTermination = () => {
+        const finalize = Promise.race([
+            deregisterSession(),
+            new Promise((resolve) => {
+                setTimeout(resolve, 3000);
+            }),
+        ]);
+        const others = process
+            .listeners(signal)
+            .filter((listener) => listener !== onTermination);
+        if (others.length === 0) {
+            void finalize.finally(() => process.exit(signal === 'SIGINT' ? 130 : 143));
+        }
+    };
+    process.on(signal, onTermination);
+}
 // ============================================================
 // Subcommand: edsger login
 // ============================================================
@@ -107,8 +151,7 @@ program
         await runLogin();
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -122,8 +165,7 @@ program
         runLogout();
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -137,8 +179,7 @@ program
         runStatus();
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -190,8 +231,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -217,8 +257,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -244,8 +283,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -271,8 +309,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -298,8 +335,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 const diagramSubcommands = [
@@ -349,8 +385,7 @@ for (const sub of diagramSubcommands) {
             });
         }
         catch (error) {
-            logError(error instanceof Error ? error.message : String(error));
-            process.exit(1);
+            exitWithError(error);
         }
     });
 }
@@ -373,8 +408,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -394,8 +428,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -425,8 +458,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -452,8 +484,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -487,8 +518,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -518,8 +548,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -537,8 +566,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -556,8 +584,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -572,8 +599,7 @@ program
         await runIssueAnalysisCommand({ issueId, verbose: opts.verbose });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -605,8 +631,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -633,8 +658,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -649,8 +673,7 @@ program
         await runChatServeCommand({ verbose: opts.verbose });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -665,8 +688,7 @@ program
         await runUserStoriesAnalysisCommand({ issueId, verbose: opts.verbose });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -681,8 +703,7 @@ program
         await runTestCasesAnalysisCommand({ issueId, verbose: opts.verbose });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -697,8 +718,7 @@ program
         await runTechnicalDesignCommand({ issueId, verbose: opts.verbose });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -716,8 +736,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -737,8 +756,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -755,8 +773,7 @@ program
         await runPRReview(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -780,8 +797,7 @@ program
         await runFindBugs(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -807,8 +823,7 @@ program
         await runQualityBenchmarkCli(productId ?? '', opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -823,8 +838,7 @@ program
         await runSyncGithubIssues(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -840,8 +854,7 @@ program
         await runSyncOrgRepos(teamId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -859,8 +872,7 @@ program
         await runSyncSentryIssues(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -878,8 +890,7 @@ program
         await runSyncDatadog(teamId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -904,8 +915,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -925,8 +935,7 @@ program
         await runDiscover(teamId, runId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // Subcommand: edsger sync-terraform <teamId>
@@ -945,8 +954,7 @@ program
         await runSyncTerraform(teamId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -978,8 +986,7 @@ program
         await runFindFeatures(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1004,8 +1011,7 @@ program
         await runFindSmells(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1029,8 +1035,7 @@ program
         await runFindArchitecture(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1046,8 +1051,7 @@ program
         await runProductTestCases(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1073,8 +1077,7 @@ program
         });
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1092,8 +1095,7 @@ program
         await runPRResolve(productId, opts);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 // ============================================================
@@ -1117,16 +1119,15 @@ program.action(async (options, command) => {
     // bugs look like the agent inexplicably running with the wrong intent.
     // Treat any leftover positional arg as an unknown command and abort.
     if (command.args.length > 0) {
-        logError(`Unknown command: ${command.args[0]}`);
         logError(`Run 'edsger --help' to see available commands.`);
-        process.exit(1);
+        exitWithError(new Error(`Unknown command: ${command.args[0]}`));
+        return;
     }
     try {
         await runEdsger(options);
     }
     catch (error) {
-        logError(error instanceof Error ? error.message : String(error));
-        process.exit(1);
+        exitWithError(error);
     }
 });
 export const runEdsger = async (options) => {

package/dist/system/session-manager.js

@@ -215,11 +215,16 @@ export async function sendHeartbeat(currentIssueId, currentIssueName) {
  * Start periodic heartbeats
  */
 export function startHeartbeat() {
+    if (heartbeatTimer) {
+        return;
+    }
     heartbeatTimer = setInterval(() => {
         sendHeartbeat().catch(() => {
             /* noop */
         });
     }, HEARTBEAT_INTERVAL);
+    // The heartbeat alone must never keep a finished command's process alive.
+    heartbeatTimer.unref?.();
 }
 /**
  * Stop periodic heartbeats

package/dist/utils/validation.d.ts

@@ -1,5 +1,37 @@
 import { loadConfig } from '../config.js';
 import { type CliOptions } from '../types/index.js';
+/**
+ * Determine the correct npm install target for optional dependencies.
+ *
+ * `Function('return import("pkg")')()` resolves from the edsger module's
+ * own location, walking up the node_modules chain.  We need to install
+ * packages into a directory that sits on that resolution path.
+ *
+ * - Source checkout / monorepo  → `npm install` in the edsger package dir
+ * - Project dependency  → `npm install` in the project root (has package.json)
+ * - Global-style install  → `npm install -g --prefix <prefix>`
+ *
+ * The global-style case covers both a plain `npm install -g edsger` and the
+ * desktop app's managed install (`npm install -g edsger --prefix <userData>/cli`).
+ * In both, edsger lives at `<prefix>/lib/node_modules/edsger` (or
+ * `<prefix>/node_modules/edsger` on Windows) and there is NO package.json at
+ * the directory that owns that node_modules. Running a *project-local*
+ * `npm install` there would treat every already-installed package — including
+ * edsger and all its dependencies — as extraneous and PRUNE them, destroying
+ * the install. We must install with `--prefix` into the same prefix instead.
+ */
+export interface NpmInstallTarget {
+    global: boolean;
+    cwd?: string;
+    prefix?: string;
+}
+/**
+ * Pure resolution of the npm install target, given edsger's own directory and
+ * a predicate for testing whether a path exists. Separated from
+ * {@link getNpmInstallTarget} so it can be unit-tested without touching the
+ * real filesystem or `import.meta.url`.
+ */
+export declare function resolveNpmInstallTarget(edsgerDir: string, fileExists: (p: string) => boolean): NpmInstallTarget;
 export interface ValidationResult {
     config: ReturnType<typeof loadConfig>;
     mcpServerUrl: string;

package/dist/utils/validation.js

@@ -1,9 +1,37 @@
 import { execSync, spawnSync } from 'child_process';
-import { dirname, resolve, sep } from 'path';
+import { existsSync } from 'fs';
+import { basename, dirname, join, resolve, sep } from 'path';
 import { fileURLToPath } from 'url';
 import { getMcpServerUrl, getMcpToken } from '../auth/auth-store.js';
 import { loadConfig, validateConfig } from '../config.js';
 import { logInfo, logWarning } from './logger.js';
+/**
+ * Pure resolution of the npm install target, given edsger's own directory and
+ * a predicate for testing whether a path exists. Separated from
+ * {@link getNpmInstallTarget} so it can be unit-tested without touching the
+ * real filesystem or `import.meta.url`.
+ */
+export function resolveNpmInstallTarget(edsgerDir, fileExists) {
+    const nodeModulesSegment = `${sep}node_modules${sep}`;
+    if (!edsgerDir.includes(nodeModulesSegment)) {
+        // Source checkout / monorepo — install in edsger's own package dir
+        return { global: false, cwd: edsgerDir };
+    }
+    // edsger is inside some node_modules tree. The directory that owns the
+    // outermost node_modules containing edsger is the candidate install root.
+    const installRoot = edsgerDir.split(nodeModulesSegment)[0];
+    // A real project dependency has a package.json at that root, so a
+    // project-local install safely adds to its dependencies without pruning.
+    if (fileExists(join(installRoot, 'package.json'))) {
+        return { global: false, cwd: installRoot };
+    }
+    // No package.json → global-style install. Derive the npm prefix so the
+    // package lands on edsger's resolution path. Unix global installs nest
+    // under `<prefix>/lib`; Windows installs put node_modules directly under
+    // `<prefix>`.
+    const prefix = basename(installRoot) === 'lib' ? dirname(installRoot) : installRoot;
+    return { global: true, prefix };
+}
 /**
  * Determine the correct npm install target for optional dependencies.
  *
@@ -11,33 +39,22 @@ import { logInfo, logWarning } from './logger.js';
  * own location, walking up the node_modules chain.  We need to install
  * packages into a directory that sits on that resolution path.
  *
- * - Global install  → `npm install -g`
- * - Project dependency  → `npm install` in the project root
- * - Monorepo / development  → `npm install` in the edsger package dir
+ * - Source checkout / monorepo  → `npm install` in the edsger package dir
+ * - Project dependency  → `npm install` in the project root (has package.json)
+ * - Global-style install  → `npm install -g --prefix <prefix>`
+ *
+ * The global-style case covers both a plain `npm install -g edsger` and the
+ * desktop app's managed install (`npm install -g edsger --prefix <userData>/cli`).
+ * In both, edsger lives at `<prefix>/lib/node_modules/edsger` (or
+ * `<prefix>/node_modules/edsger` on Windows) and there is NO package.json at
+ * the directory that owns that node_modules. Running a *project-local*
+ * `npm install` there would treat every already-installed package — including
+ * edsger and all its dependencies — as extraneous and PRUNE them, destroying
+ * the install. We must install with `--prefix` into the same prefix instead.
  */
 function getNpmInstallTarget() {
     const edsgerDir = resolve(dirname(fileURLToPath(import.meta.url)), '../..');
-    const nodeModulesSegment = `${sep}node_modules${sep}`;
-    if (!edsgerDir.includes(nodeModulesSegment)) {
-        // Source checkout / monorepo — install in edsger's own package dir
-        return { global: false, cwd: edsgerDir };
-    }
-    // edsger is inside some node_modules tree
-    try {
-        const globalPrefix = execSync('npm config get prefix', {
-            encoding: 'utf-8',
-            stdio: ['pipe', 'pipe', 'ignore'],
-        }).trim();
-        if (edsgerDir.startsWith(globalPrefix)) {
-            return { global: true };
-        }
-    }
-    catch {
-        // ignore — fall through to project-local
-    }
-    // Project dependency — install at the project root (parent of node_modules)
-    const projectRoot = edsgerDir.split(nodeModulesSegment)[0];
-    return { global: false, cwd: projectRoot };
+    return resolveNpmInstallTarget(edsgerDir, existsSync);
 }
 /**
  * Common configuration validation for all CLI commands
@@ -106,7 +123,8 @@ const restartProcess = (envFlag) => {
 function npmInstall(packageName) {
     const target = getNpmInstallTarget();
     const globalFlag = target.global ? ' -g' : '';
-    const cmd = `npm install${globalFlag} ${packageName}`;
+    const prefixFlag = target.prefix ? ` --prefix "${target.prefix}"` : '';
+    const cmd = `npm install${globalFlag}${prefixFlag} ${packageName}`;
     logInfo(`  $ ${cmd}${target.cwd ? ` (in ${target.cwd})` : ''}`);
     execSync(cmd, { cwd: target.cwd, stdio: 'inherit' });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.72.4",
+  "version": "0.72.6",
   "type": "module",
   "bin": {
     "edsger": "dist/index.js"