edsger 0.56.1 → 0.56.2

package/dist/commands/quality-benchmark/index.d.ts

@@ -1,16 +1,22 @@
 /**
  * CLI command: `edsger quality-benchmark <productId>`
  *
- * Runs the quality-benchmark phase against a local repo checkout and
+ * Runs the quality-benchmark phase against the product's GitHub repo and
  * writes the resulting JSON report to disk. Persistence to the
  * `quality_reports` table is the caller's responsibility — desktop-app
  * picks the JSON up via stdout / file and writes via its supabase
  * client, exactly the same pattern used by other CLI commands.
  *
+ * Default invocation (desktop): no --repo, no --branch — the CLI fetches
+ * the product's GitHub config via MCP, clones (or reuses) the repo into
+ * `~/edsger/quality-<owner>-<repo>`, and analyses its default branch.
+ *
  * Usage:
  *   edsger quality-benchmark <productId>
- *     --repo <path>            (required) local repo checkout
- *     --branch <name>          (optional) branch name (informational)
+ *     --repo <path>            (optional) override the auto-clone with a
+ *                              local checkout (used by tests / power users)
+ *     --branch <name>          (optional) override the detected default
+ *                              branch on the report envelope
  *     --pkg-manager <name>     (optional) npm|pnpm|yarn (auto-detected if absent)
  *     --no-install             refuse to install missing tools
  *     --output <path>          where to write the JSON report
@@ -18,7 +24,8 @@
  *     --verbose                print every progress event
  */
 export interface QualityBenchmarkCliOptions {
-    repo: string;
+    /** Optional local-checkout override; when absent the CLI clones the product's repo. */
+    repo?: string;
     branch?: string;
     pkgManager?: string;
     install?: boolean;

package/dist/commands/quality-benchmark/index.js

@@ -1,16 +1,22 @@
 /**
  * CLI command: `edsger quality-benchmark <productId>`
  *
- * Runs the quality-benchmark phase against a local repo checkout and
+ * Runs the quality-benchmark phase against the product's GitHub repo and
  * writes the resulting JSON report to disk. Persistence to the
  * `quality_reports` table is the caller's responsibility — desktop-app
  * picks the JSON up via stdout / file and writes via its supabase
  * client, exactly the same pattern used by other CLI commands.
  *
+ * Default invocation (desktop): no --repo, no --branch — the CLI fetches
+ * the product's GitHub config via MCP, clones (or reuses) the repo into
+ * `~/edsger/quality-<owner>-<repo>`, and analyses its default branch.
+ *
  * Usage:
  *   edsger quality-benchmark <productId>
- *     --repo <path>            (required) local repo checkout
- *     --branch <name>          (optional) branch name (informational)
+ *     --repo <path>            (optional) override the auto-clone with a
+ *                              local checkout (used by tests / power users)
+ *     --branch <name>          (optional) override the detected default
+ *                              branch on the report envelope
  *     --pkg-manager <name>     (optional) npm|pnpm|yarn (auto-detected if absent)
  *     --no-install             refuse to install missing tools
  *     --output <path>          where to write the JSON report
@@ -19,15 +25,39 @@
  */
 import { mkdirSync, writeFileSync } from 'node:fs';
 import { dirname, resolve } from 'node:path';
+import { getGitHubConfigByProduct } from '../../api/github.js';
 import { callMcpEndpoint } from '../../api/mcp-client.js';
 import { fetchProductBasics } from '../../phases/find-shared/mcp.js';
 import { runQualityBenchmark, } from '../../phases/quality-benchmark/index.js';
+import { prepareQualityWorkspace } from '../../phases/quality-benchmark/workspace.js';
 import { logError, logInfo, logSuccess, logWarning, } from '../../utils/logger.js';
 export async function runQualityBenchmarkCli(productId, options) {
-    const repoRoot = resolve(options.repo);
     const installEnabled = options.install !== false;
     logInfo(`Starting quality benchmark for product ${productId}`);
-    logInfo(`Repo: ${repoRoot}`);
+    let repoRoot;
+    let resolvedBranch;
+    if (options.repo) {
+        repoRoot = resolve(options.repo);
+        resolvedBranch = options.branch;
+        logInfo(`Repo (override): ${repoRoot}`);
+    }
+    else {
+        const gh = await getGitHubConfigByProduct(productId, options.verbose);
+        if (!gh.configured || !gh.token || !gh.owner || !gh.repo) {
+            logError(`Cannot run quality benchmark: ${gh.message ??
+                'GitHub is not configured for this product. Connect a repo in product settings.'}`);
+            process.exit(1);
+        }
+        const ws = prepareQualityWorkspace({
+            owner: gh.owner,
+            repo: gh.repo,
+            token: gh.token,
+            verbose: options.verbose,
+        });
+        repoRoot = ws.repoPath;
+        resolvedBranch = options.branch ?? ws.branch;
+        logInfo(`Repo: ${repoRoot} (branch: ${resolvedBranch})`);
+    }
     if (!installEnabled) {
         logWarning('Install consent NOT granted (--no-install). Missing tools will be marked unmeasured.');
     }
@@ -52,7 +82,7 @@ export async function runQualityBenchmarkCli(productId, options) {
         productId,
         productName,
         repoRoot,
-        branch: options.branch,
+        branch: resolvedBranch,
         packageManager: options.pkgManager,
         installEnabled,
         onProgress,
@@ -72,7 +102,7 @@ export async function runQualityBenchmarkCli(productId, options) {
         run_id: outcome.runId,
         product_id: productId,
         commit_sha: outcome.commitSha,
-        branch: options.branch ?? null,
+        branch: resolvedBranch ?? null,
         started_at: outcome.startedAt,
         completed_at: outcome.completedAt,
         duration_seconds: outcome.durationSeconds,
@@ -88,7 +118,7 @@ export async function runQualityBenchmarkCli(productId, options) {
                 product_id: productId,
                 commit_sha: outcome.commitSha,
                 rubric_version: outcome.report.rubric_version,
-                branch: options.branch ?? null,
+                branch: resolvedBranch ?? null,
                 repo_root: repoRoot,
                 detected_context: outcome.report.detected_context,
                 tool_versions: outcome.report.tool_versions,

package/dist/index.js

@@ -491,9 +491,9 @@ program
 // ============================================================
 program
     .command('quality-benchmark <productId>')
-    .description('Run an industrial-grade code quality benchmark against a local repo')
-    .requiredOption('--repo <path>', 'Path to the local repo checkout')
-    .option('--branch <name>', 'Branch name (informational; does not checkout)')
+    .description("Run an industrial-grade code quality benchmark against the product's GitHub repo")
+    .option('--repo <path>', "Override the auto-clone with a local checkout (default: clone the product's repo into ~/edsger/quality-<owner>-<repo>)")
+    .option('--branch <name>', 'Override the detected default branch on the report envelope')
     .option('--pkg-manager <name>', 'npm | pnpm | yarn (auto-detected if absent)')
     .option('--no-install', 'Refuse to install missing tools; mark them unmeasured')
     .option('--output <path>', 'Where to write the JSON report (default: ./quality-report-<commit>.json)')

package/dist/phases/quality-benchmark/workspace.d.ts

@@ -0,0 +1,31 @@
+/**
+ * Git workspace prep for `edsger quality-benchmark`.
+ *
+ * Mirrors the convention in `phases/pr-resolve/workspace.ts`:
+ *   - Clones into `~/edsger/quality-<owner>-<repo>`
+ *   - Reuses + fetches + hard-resets to the remote default branch when the
+ *     dir already has a `.git`
+ *   - Authenticates via `buildCredentialArgs(token)` so the GitHub App
+ *     installation token never lands in the remote URL or `ps`
+ *
+ * Quality runs are read-only — no per-commit / per-run subdirectory, one
+ * checkout per (owner, repo) is enough and lets repeated runs skip the
+ * full clone cost.
+ */
+export interface PrepareQualityWorkspaceOptions {
+    owner: string;
+    repo: string;
+    token: string;
+    verbose?: boolean;
+}
+export interface QualityWorkspace {
+    /** Absolute path to the checkout. */
+    repoPath: string;
+    /** The default branch we ended up on (e.g. "main"). */
+    branch: string;
+}
+export declare function getQualityWorkspacePath(owner: string, repo: string): string;
+/**
+ * Clone (or reuse) the product's repo and check out its default branch.
+ */
+export declare function prepareQualityWorkspace(options: PrepareQualityWorkspaceOptions): QualityWorkspace;

package/dist/phases/quality-benchmark/workspace.js

@@ -0,0 +1,110 @@
+/**
+ * Git workspace prep for `edsger quality-benchmark`.
+ *
+ * Mirrors the convention in `phases/pr-resolve/workspace.ts`:
+ *   - Clones into `~/edsger/quality-<owner>-<repo>`
+ *   - Reuses + fetches + hard-resets to the remote default branch when the
+ *     dir already has a `.git`
+ *   - Authenticates via `buildCredentialArgs(token)` so the GitHub App
+ *     installation token never lands in the remote URL or `ps`
+ *
+ * Quality runs are read-only — no per-commit / per-run subdirectory, one
+ * checkout per (owner, repo) is enough and lets repeated runs skip the
+ * full clone cost.
+ */
+import { execFileSync, execSync } from 'child_process';
+import { existsSync } from 'fs';
+import { homedir } from 'os';
+import { join } from 'path';
+import { logError, logInfo, logSuccess } from '../../utils/logger.js';
+import { buildCredentialArgs } from '../pr-resolve/workspace.js';
+export function getQualityWorkspacePath(owner, repo) {
+    return join(homedir(), 'edsger', `quality-${owner}-${repo}`);
+}
+/**
+ * Clone (or reuse) the product's repo and check out its default branch.
+ */
+export function prepareQualityWorkspace(options) {
+    const { owner, repo, token, verbose } = options;
+    const repoPath = getQualityWorkspacePath(owner, repo);
+    const repoUrl = `https://github.com/${owner}/${repo}.git`;
+    const credArgs = buildCredentialArgs(token);
+    if (existsSync(join(repoPath, '.git'))) {
+        logInfo(`Reusing existing quality workspace at ${repoPath}`);
+        try {
+            execSync(`git remote set-url origin "${repoUrl}"`, {
+                cwd: repoPath,
+                stdio: 'pipe',
+            });
+        }
+        catch {
+            // Non-fatal — the URL may already be correct.
+        }
+        try {
+            execFileSync('git', [...credArgs, 'fetch', 'origin', '--prune'], {
+                cwd: repoPath,
+                stdio: 'pipe',
+            });
+        }
+        catch {
+            logError('Could not fetch latest changes; analysis will use cached state');
+        }
+        const branch = detectDefaultBranch(repoPath, credArgs);
+        try {
+            execFileSync('git', ['checkout', '-B', branch, `origin/${branch}`], {
+                cwd: repoPath,
+                stdio: 'pipe',
+            });
+            execFileSync('git', ['reset', '--hard', `origin/${branch}`], {
+                cwd: repoPath,
+                stdio: 'pipe',
+            });
+        }
+        catch (error) {
+            throw new Error(`Failed to update workspace to origin/${branch}: ${error instanceof Error ? error.message : String(error)}`);
+        }
+        if (verbose) {
+            logInfo(`Workspace synced to origin/${branch}`);
+        }
+        return { repoPath, branch };
+    }
+    logInfo(`Cloning ${owner}/${repo} for quality benchmark...`);
+    try {
+        execFileSync('git', [...credArgs, 'clone', repoUrl, repoPath], {
+            stdio: 'pipe',
+        });
+        logSuccess(`Cloned to ${repoPath}`);
+    }
+    catch (error) {
+        throw new Error(`Failed to clone ${owner}/${repo}: ${error instanceof Error ? error.message : String(error)}`);
+    }
+    const branch = detectDefaultBranch(repoPath, credArgs);
+    return { repoPath, branch };
+}
+/**
+ * Return the remote's default branch (the one `origin/HEAD` points at).
+ * Falls back to `main` if the symbolic ref isn't set — `git remote set-head`
+ * is used to (re)populate it before reading.
+ */
+function detectDefaultBranch(repoPath, credArgs) {
+    try {
+        execFileSync('git', [...credArgs, 'remote', 'set-head', 'origin', '-a'], {
+            cwd: repoPath,
+            stdio: 'pipe',
+        });
+    }
+    catch {
+        // Non-fatal; the symbolic ref may already be set from a fresh clone.
+    }
+    try {
+        const out = execFileSync('git', ['symbolic-ref', '--short', 'refs/remotes/origin/HEAD'], { cwd: repoPath, stdio: ['ignore', 'pipe', 'pipe'] }).toString();
+        const ref = out.trim();
+        if (ref.startsWith('origin/')) {
+            return ref.slice('origin/'.length);
+        }
+    }
+    catch {
+        // fall through
+    }
+    return 'main';
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.56.1",
+  "version": "0.56.2",
   "type": "module",
   "bin": {
     "edsger": "dist/index.js"