edsger 0.49.0 → 0.50.0

package/dist/phases/code-refine-verification/github.d.ts

@@ -21,11 +21,27 @@ export declare function fetchFileContent(opts: FetchFileContentOptions): Promise
  * Fetch PR file changes (diff information and full content)
  */
 export declare function fetchPRFileChanges(octokit: Octokit, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<PRFileChange[]>;
+export interface GraphQLClient {
+    graphql: <ResponseData>(query: string, variables?: Record<string, unknown>) => Promise<ResponseData>;
+}
+/**
+ * Page through every `reviewThreads` connection, following `pageInfo.endCursor`
+ * until GitHub reports `hasNextPage: false`. Exported for tests.
+ */
+export declare function fetchAllReviewThreads(octokit: GraphQLClient, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<ReviewThread[]>;
 /**
  * Fetch unresolved review threads using GitHub GraphQL API
  * This provides accurate resolution status unlike REST API
  */
 export declare function fetchUnresolvedReviewThreads(octokit: Octokit, owner: string, repo: string, prNumber: number, verbose?: boolean): Promise<ReviewThread[]>;
+/**
+ * For any thread whose `comments` connection was truncated (>100 comments),
+ * page through the remaining comments and append them to the thread in place.
+ * Each thread is hydrated concurrently; the per-thread loop is still
+ * sequential because each page depends on the previous cursor. Exported for
+ * tests.
+ */
+export declare function hydrateThreadComments(octokit: GraphQLClient, threads: ReviewThread[], verbose?: boolean): Promise<void>;
 /**
  * Mark review threads as resolved using GraphQL API
  */

package/dist/phases/code-refine-verification/github.js

@@ -87,50 +87,108 @@ export async function fetchPRFileChanges(octokit, owner, repo, prNumber, verbose
         return [];
     }
 }
-/**
- * Fetch unresolved review threads using GitHub GraphQL API
- * This provides accurate resolution status unlike REST API
- */
-export async function fetchUnresolvedReviewThreads(octokit, owner, repo, prNumber, verbose) {
-    try {
-        if (verbose) {
-            logInfo('🔍 Fetching review threads via GraphQL API...');
-        }
-        const query = `
-      query($owner: String!, $repo: String!, $prNumber: Int!) {
-        repository(owner: $owner, name: $repo) {
-          pullRequest(number: $prNumber) {
-            reviewThreads(first: 100) {
+const REVIEW_THREADS_QUERY = `
+  query($owner: String!, $repo: String!, $prNumber: Int!, $threadCursor: String) {
+    repository(owner: $owner, name: $repo) {
+      pullRequest(number: $prNumber) {
+        reviewThreads(first: 100, after: $threadCursor) {
+          pageInfo {
+            hasNextPage
+            endCursor
+          }
+          nodes {
+            id
+            isResolved
+            isOutdated
+            comments(first: 100) {
+              totalCount
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
               nodes {
                 id
-                isResolved
-                isOutdated
-                comments(first: 100) {
-                  totalCount
-                  nodes {
-                    id
-                    author {
-                      login
-                    }
-                    body
-                    path
-                    line
-                    url
-                  }
+                author {
+                  login
                 }
+                body
+                path
+                line
+                url
               }
             }
           }
         }
       }
-    `;
-        const result = await octokit.graphql(query, {
+    }
+  }
+`;
+const THREAD_COMMENTS_QUERY = `
+  query($threadId: ID!, $cursor: String) {
+    node(id: $threadId) {
+      ... on PullRequestReviewThread {
+        comments(first: 100, after: $cursor) {
+          pageInfo {
+            hasNextPage
+            endCursor
+          }
+          nodes {
+            id
+            author {
+              login
+            }
+            body
+            path
+            line
+            url
+          }
+        }
+      }
+    }
+  }
+`;
+/**
+ * Page through every `reviewThreads` connection, following `pageInfo.endCursor`
+ * until GitHub reports `hasNextPage: false`. Exported for tests.
+ */
+export async function fetchAllReviewThreads(octokit, owner, repo, prNumber, verbose) {
+    const allThreads = [];
+    let threadCursor = null;
+    let threadPage = 0;
+    while (true) {
+        threadPage += 1;
+        const result = await octokit.graphql(REVIEW_THREADS_QUERY, {
             owner,
             repo,
             prNumber,
+            threadCursor,
         });
-        const allThreads = result?.repository
-            ?.pullRequest?.reviewThreads?.nodes || [];
+        const page = result.repository?.pullRequest?.reviewThreads;
+        const pageThreads = page?.nodes ?? [];
+        allThreads.push(...pageThreads);
+        if (verbose) {
+            logInfo(`   · page ${threadPage}: fetched ${pageThreads.length} thread(s) (total so far: ${allThreads.length})`);
+        }
+        const pageInfo = page?.pageInfo;
+        if (!pageInfo?.hasNextPage || !pageInfo.endCursor) {
+            break;
+        }
+        threadCursor = pageInfo.endCursor;
+    }
+    return allThreads;
+}
+/**
+ * Fetch unresolved review threads using GitHub GraphQL API
+ * This provides accurate resolution status unlike REST API
+ */
+export async function fetchUnresolvedReviewThreads(octokit, owner, repo, prNumber, verbose) {
+    try {
+        if (verbose) {
+            logInfo('🔍 Fetching review threads via GraphQL API...');
+        }
+        const allThreads = await fetchAllReviewThreads(octokit, owner, repo, prNumber, verbose);
+        // Fill in any threads whose comments were truncated at 100
+        await hydrateThreadComments(octokit, allThreads, verbose);
         // Filter for truly unresolved threads
         // - Exclude resolved threads (isResolved = true)
         // - Exclude outdated threads (isOutdated = true) - these mean code has changed, should auto-resolve
@@ -158,6 +216,34 @@ export async function fetchUnresolvedReviewThreads(octokit, owner, repo, prNumbe
         return [];
     }
 }
+/**
+ * For any thread whose `comments` connection was truncated (>100 comments),
+ * page through the remaining comments and append them to the thread in place.
+ * Each thread is hydrated concurrently; the per-thread loop is still
+ * sequential because each page depends on the previous cursor. Exported for
+ * tests.
+ */
+export async function hydrateThreadComments(octokit, threads, verbose) {
+    await Promise.all(threads.map((thread) => hydrateOneThreadComments(octokit, thread, verbose)));
+}
+async function hydrateOneThreadComments(octokit, thread, verbose) {
+    let { pageInfo } = thread.comments;
+    let cursor = pageInfo?.endCursor ?? null;
+    while (pageInfo?.hasNextPage && cursor) {
+        const result = await octokit.graphql(THREAD_COMMENTS_QUERY, {
+            threadId: thread.id,
+            cursor,
+        });
+        const page = result.node?.comments;
+        const pageComments = page?.nodes ?? [];
+        thread.comments.nodes.push(...pageComments);
+        if (verbose) {
+            logInfo(`   · thread ${thread.id}: fetched ${pageComments.length} extra comment(s)`);
+        }
+        pageInfo = page?.pageInfo;
+        cursor = pageInfo?.endCursor ?? null;
+    }
+}
 /**
  * Mark review threads as resolved using GraphQL API
  */

package/dist/phases/code-refine-verification/types.d.ts

@@ -2,22 +2,27 @@
  * Type definitions for Code Refine Verification
  */
 import { type EdsgerConfig } from '../../types/index.js';
+export interface ReviewThreadComment {
+    id: string;
+    author: {
+        login: string;
+    };
+    body: string;
+    path: string;
+    line: number | null;
+    url: string;
+}
 export interface ReviewThread {
     id: string;
     isResolved: boolean;
     isOutdated: boolean;
     comments: {
         totalCount: number;
-        nodes: {
-            id: string;
-            author: {
-                login: string;
-            };
-            body: string;
-            path: string;
-            line: number | null;
-            url: string;
-        }[];
+        pageInfo?: {
+            hasNextPage: boolean;
+            endCursor: string | null;
+        };
+        nodes: ReviewThreadComment[];
     };
 }
 export interface PRFileChange {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.49.0",
+  "version": "0.50.0",
   "type": "module",
   "bin": {
     "edsger": "dist/index.js"

package/vitest.config.ts

@@ -2,10 +2,14 @@ import { defineConfig } from 'vitest/config'
 
 export default defineConfig({
   test: {
-    // The other __tests__ folders in this package use the node:test API
-    // (assert + node --test), not vitest. We scope vitest to just the
-    // run-sheet tests for now; migrating the rest can happen separately.
-    include: ['src/phases/run-sheet/__tests__/**/*.test.ts'],
+    // Most other __tests__ folders in this package use the node:test API
+    // (assert + node --test), not vitest. Scope vitest to the folders whose
+    // tests are written against `vitest`; migrating the rest can happen
+    // separately.
+    include: [
+      'src/phases/run-sheet/__tests__/**/*.test.ts',
+      'src/phases/code-refine-verification/__tests__/**/*.test.ts',
+    ],
     exclude: ['dist/**', 'node_modules/**'],
     environment: 'node',
   },