edsger 0.45.1 → 0.47.0

package/dist/commands/build/__tests__/build.test.js

@@ -0,0 +1,206 @@
+/**
+ * Unit tests for the build command's pure/utility functions.
+ * Tests project discovery, scheme parsing, plist generation, and API key management.
+ */
+import assert from 'node:assert';
+import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync, } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, beforeEach, describe, it } from 'node:test';
+import { cleanupApiKeyFile, discoverSchemes, findXcodeProjects, generateExportOptionsPlist, writeApiKeyFile, } from '../index.js';
+// ── Helpers ────────────────────────────────────────────────────────
+function createTmpDir() {
+    const dir = join(tmpdir(), `edsger-build-test-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+    mkdirSync(dir, { recursive: true });
+    return dir;
+}
+// ── findXcodeProjects ──────────────────────────────────────────────
+describe('findXcodeProjects', () => {
+    let tmpDir;
+    beforeEach(() => {
+        tmpDir = createTmpDir();
+    });
+    afterEach(() => {
+        rmSync(tmpDir, { recursive: true, force: true });
+    });
+    it('returns empty array for directory with no Xcode projects', () => {
+        mkdirSync(join(tmpDir, 'src'), { recursive: true });
+        writeFileSync(join(tmpDir, 'src', 'main.swift'), '');
+        const results = findXcodeProjects(tmpDir);
+        assert.deepStrictEqual(results, []);
+    });
+    it('finds a single .xcodeproj', () => {
+        mkdirSync(join(tmpDir, 'MyApp.xcodeproj'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+        assert.strictEqual(results[0].path, 'MyApp.xcodeproj');
+        assert.strictEqual(results[0].type, 'project');
+    });
+    it('finds a single .xcworkspace', () => {
+        mkdirSync(join(tmpDir, 'MyApp.xcworkspace'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+        assert.strictEqual(results[0].path, 'MyApp.xcworkspace');
+        assert.strictEqual(results[0].type, 'workspace');
+    });
+    it('sorts workspaces before projects', () => {
+        mkdirSync(join(tmpDir, 'MyApp.xcodeproj'), { recursive: true });
+        mkdirSync(join(tmpDir, 'MyApp.xcworkspace'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 2);
+        assert.strictEqual(results[0].type, 'workspace');
+        assert.strictEqual(results[1].type, 'project');
+    });
+    it('finds projects in subdirectories', () => {
+        mkdirSync(join(tmpDir, 'ios', 'MyApp.xcworkspace'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+        assert.strictEqual(results[0].path, join('ios', 'MyApp.xcworkspace'));
+    });
+    it('excludes Pods directory', () => {
+        mkdirSync(join(tmpDir, 'Pods', 'SomePod.xcodeproj'), { recursive: true });
+        mkdirSync(join(tmpDir, 'MyApp.xcodeproj'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+        assert.strictEqual(results[0].path, 'MyApp.xcodeproj');
+    });
+    it('excludes node_modules directory', () => {
+        mkdirSync(join(tmpDir, 'node_modules', 'react-native', 'React.xcodeproj'), {
+            recursive: true,
+        });
+        mkdirSync(join(tmpDir, 'ios', 'MyApp.xcodeproj'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+        assert.strictEqual(results[0].path, join('ios', 'MyApp.xcodeproj'));
+    });
+    it('excludes DerivedData directory', () => {
+        mkdirSync(join(tmpDir, 'DerivedData', 'Build.xcodeproj'), {
+            recursive: true,
+        });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 0);
+    });
+    it('excludes .build directory', () => {
+        mkdirSync(join(tmpDir, '.build', 'Something.xcodeproj'), {
+            recursive: true,
+        });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 0);
+    });
+    it('sorts shallower paths first among same type', () => {
+        mkdirSync(join(tmpDir, 'deep', 'nested', 'A.xcodeproj'), {
+            recursive: true,
+        });
+        mkdirSync(join(tmpDir, 'B.xcodeproj'), { recursive: true });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results[0].path, 'B.xcodeproj');
+    });
+    it('does not recurse deeper than 4 levels', () => {
+        mkdirSync(join(tmpDir, 'a', 'b', 'c', 'd', 'e', 'Deep.xcodeproj'), {
+            recursive: true,
+        });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 0);
+    });
+    it('finds projects at exactly depth 4', () => {
+        mkdirSync(join(tmpDir, 'a', 'b', 'c', 'd', 'Ok.xcodeproj'), {
+            recursive: true,
+        });
+        const results = findXcodeProjects(tmpDir);
+        assert.strictEqual(results.length, 1);
+    });
+});
+// ── generateExportOptionsPlist ─────────────────────────────────────
+describe('generateExportOptionsPlist', () => {
+    it('generates valid plist with app-store method', () => {
+        const plist = generateExportOptionsPlist('TEAM123', 'app-store');
+        assert.ok(plist.includes('<?xml version="1.0"'));
+        assert.ok(plist.includes('<string>app-store</string>'));
+        assert.ok(plist.includes('<string>TEAM123</string>'));
+        assert.ok(plist.includes('<key>uploadSymbols</key>'));
+        assert.ok(plist.includes('<true/>'));
+        assert.ok(plist.includes('<string>automatic</string>'));
+    });
+    it('generates plist with ad-hoc method', () => {
+        const plist = generateExportOptionsPlist('ABCD', 'ad-hoc');
+        assert.ok(plist.includes('<string>ad-hoc</string>'));
+        assert.ok(plist.includes('<string>ABCD</string>'));
+    });
+    it('generates plist with development method', () => {
+        const plist = generateExportOptionsPlist('XYZ', 'development');
+        assert.ok(plist.includes('<string>development</string>'));
+    });
+    it('includes all required keys', () => {
+        const plist = generateExportOptionsPlist('T', 'app-store');
+        assert.ok(plist.includes('<key>method</key>'));
+        assert.ok(plist.includes('<key>teamID</key>'));
+        assert.ok(plist.includes('<key>uploadSymbols</key>'));
+        assert.ok(plist.includes('<key>signingStyle</key>'));
+    });
+    it('escapes XML special characters in teamId', () => {
+        const plist = generateExportOptionsPlist('</string><key>evil</key><string>', 'app-store');
+        assert.ok(!plist.includes('<key>evil</key>'));
+        assert.ok(plist.includes('&lt;/string&gt;&lt;key&gt;evil&lt;/key&gt;&lt;string&gt;'));
+    });
+    it('escapes XML special characters in exportMethod', () => {
+        const plist = generateExportOptionsPlist('TEAM', 'a&b<c>');
+        assert.ok(plist.includes('a&amp;b&lt;c&gt;'));
+    });
+});
+// ── API key file management ────────────────────────────────────────
+describe('writeApiKeyFile', () => {
+    const testKeyId = `test-key-${Date.now()}`;
+    const testPrivateKey = '-----BEGIN PRIVATE KEY-----\ntest\n-----END PRIVATE KEY-----';
+    afterEach(() => {
+        cleanupApiKeyFile(testKeyId);
+    });
+    it('writes key file with correct content', () => {
+        const keyPath = writeApiKeyFile(testKeyId, testPrivateKey);
+        assert.ok(existsSync(keyPath));
+        assert.strictEqual(readFileSync(keyPath, 'utf-8'), testPrivateKey);
+    });
+    it('writes key file to ~/.edsger/keys/ directory', () => {
+        const keyPath = writeApiKeyFile(testKeyId, testPrivateKey);
+        assert.ok(keyPath.includes('.edsger'));
+        assert.ok(keyPath.includes('keys'));
+        assert.ok(keyPath.endsWith(`.p8`));
+    });
+    it('names file as AuthKey_<keyId>.p8', () => {
+        const keyPath = writeApiKeyFile(testKeyId, testPrivateKey);
+        assert.ok(keyPath.endsWith(`AuthKey_${testKeyId}.p8`));
+    });
+    it('rejects keyId with path traversal characters', () => {
+        assert.throws(() => writeApiKeyFile('../../etc/evil', 'key'), (err) => err.message.includes('Invalid API key ID'));
+    });
+    it('rejects keyId with slashes', () => {
+        assert.throws(() => writeApiKeyFile('key/id', 'key'), (err) => err.message.includes('Invalid API key ID'));
+    });
+});
+describe('cleanupApiKeyFile', () => {
+    it('removes existing key file', () => {
+        const testKeyId = `cleanup-test-${Date.now()}`;
+        const keyPath = writeApiKeyFile(testKeyId, 'test');
+        assert.ok(existsSync(keyPath));
+        cleanupApiKeyFile(testKeyId);
+        assert.ok(!existsSync(keyPath));
+    });
+    it('does not throw for non-existent key', () => {
+        assert.doesNotThrow(() => {
+            cleanupApiKeyFile('non-existent-key-id');
+        });
+    });
+});
+// ── discoverSchemes ────────────────────────────────────────────────
+// Note: These tests only run meaningfully on macOS with Xcode installed.
+// They verify the parsing logic by checking that the function doesn't crash
+// when given a non-existent project (returns empty array).
+describe('discoverSchemes', () => {
+    it('returns empty array for non-existent project', () => {
+        const schemes = discoverSchemes('/tmp', 'nonexistent.xcodeproj', 'project');
+        assert.deepStrictEqual(schemes, []);
+    });
+    it('returns empty array for non-existent workspace', () => {
+        const schemes = discoverSchemes('/tmp', 'nonexistent.xcworkspace', 'workspace');
+        assert.deepStrictEqual(schemes, []);
+    });
+});

package/dist/commands/build/__tests__/detect-project.test.d.ts

@@ -0,0 +1,6 @@
+/**
+ * Unit tests for the AI build plan module.
+ * Tests the directory tree builder, response parser, and command whitelist
+ * without real AI calls.
+ */
+export {};

package/dist/commands/build/__tests__/detect-project.test.js

@@ -0,0 +1,160 @@
+/**
+ * Unit tests for the AI build plan module.
+ * Tests the directory tree builder, response parser, and command whitelist
+ * without real AI calls.
+ */
+import assert from 'node:assert';
+import { mkdirSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, beforeEach, describe, it } from 'node:test';
+import { buildDirectoryTree, parseBuildPlan, validateInstallSteps, } from '../detect-project.js';
+// ── Helpers ────────────────────────────────────────────────────────
+function createTmpDir() {
+    const dir = join(tmpdir(), `edsger-detect-test-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+    mkdirSync(dir, { recursive: true });
+    return dir;
+}
+// ── buildDirectoryTree ─────────────────────────────────────────────
+describe('buildDirectoryTree', () => {
+    let tmpDir;
+    beforeEach(() => {
+        tmpDir = createTmpDir();
+    });
+    afterEach(() => {
+        rmSync(tmpDir, { recursive: true, force: true });
+    });
+    it('builds a tree for a React Native structure', () => {
+        mkdirSync(join(tmpDir, 'ios', 'MyApp.xcworkspace'), { recursive: true });
+        mkdirSync(join(tmpDir, 'ios', 'MyApp.xcodeproj'), { recursive: true });
+        mkdirSync(join(tmpDir, 'android'), { recursive: true });
+        mkdirSync(join(tmpDir, 'src'), { recursive: true });
+        writeFileSync(join(tmpDir, 'package.json'), '{}');
+        writeFileSync(join(tmpDir, 'ios', 'Podfile'), '');
+        const tree = buildDirectoryTree(tmpDir, 2);
+        assert.ok(tree.includes('ios/'));
+        assert.ok(tree.includes('MyApp.xcworkspace/'));
+        assert.ok(tree.includes('package.json'));
+    });
+    it('excludes node_modules and Pods', () => {
+        mkdirSync(join(tmpDir, 'node_modules', 'pkg'), { recursive: true });
+        mkdirSync(join(tmpDir, 'ios', 'Pods'), { recursive: true });
+        mkdirSync(join(tmpDir, 'src'), { recursive: true });
+        const tree = buildDirectoryTree(tmpDir);
+        assert.ok(!tree.includes('node_modules'));
+        assert.ok(!tree.includes('Pods'));
+        assert.ok(tree.includes('src/'));
+    });
+    it('respects max depth', () => {
+        mkdirSync(join(tmpDir, 'a', 'b', 'c', 'd', 'e'), { recursive: true });
+        writeFileSync(join(tmpDir, 'a', 'b', 'c', 'd', 'e', 'deep.txt'), '');
+        const tree = buildDirectoryTree(tmpDir, 2);
+        assert.ok(!tree.includes('deep.txt'));
+    });
+    it('returns empty string for empty directory', () => {
+        assert.strictEqual(buildDirectoryTree(tmpDir), '');
+    });
+});
+// ── parseBuildPlan ─────────────────────────────────────────────────
+describe('parseBuildPlan', () => {
+    it('parses a valid JSON response with code block', () => {
+        const response = `\`\`\`json
+{
+  "build_plan": {
+    "project_type": "react-native",
+    "install_steps": [
+      { "cmd": "npm", "args": ["ci"], "cwd": "" },
+      { "cmd": "pod", "args": ["install"], "cwd": "ios" }
+    ],
+    "project_path": "ios/MyApp.xcworkspace",
+    "scheme_hint": "MyApp",
+    "reasoning": "React Native project with CocoaPods"
+  }
+}
+\`\`\``;
+        const plan = parseBuildPlan(response);
+        assert.ok(plan);
+        assert.strictEqual(plan.projectType, 'react-native');
+        assert.strictEqual(plan.projectPath, 'ios/MyApp.xcworkspace');
+        assert.strictEqual(plan.schemeHint, 'MyApp');
+        assert.strictEqual(plan.installSteps.length, 2);
+        assert.strictEqual(plan.installSteps[0].cmd, 'npm');
+        assert.strictEqual(plan.installSteps[1].cmd, 'pod');
+        assert.strictEqual(plan.installSteps[1].cwd, 'ios');
+    });
+    it('parses raw JSON without code block', () => {
+        const response = JSON.stringify({
+            build_plan: {
+                project_type: 'native',
+                install_steps: [],
+                project_path: 'App.xcodeproj',
+                scheme_hint: 'App',
+                reasoning: 'Simple native project',
+            },
+        });
+        const plan = parseBuildPlan(response);
+        assert.ok(plan);
+        assert.strictEqual(plan.projectType, 'native');
+        assert.strictEqual(plan.installSteps.length, 0);
+    });
+    it('returns null for empty project_path', () => {
+        const response = JSON.stringify({
+            build_plan: {
+                project_type: 'native',
+                install_steps: [],
+                project_path: '',
+                scheme_hint: '',
+                reasoning: '',
+            },
+        });
+        assert.strictEqual(parseBuildPlan(response), null);
+    });
+    it('returns null for garbage input', () => {
+        assert.strictEqual(parseBuildPlan('not json at all'), null);
+    });
+    it('handles missing optional fields gracefully', () => {
+        const response = JSON.stringify({
+            build_plan: {
+                project_type: 'flutter',
+                project_path: 'ios/Runner.xcworkspace',
+            },
+        });
+        const plan = parseBuildPlan(response);
+        assert.ok(plan);
+        assert.strictEqual(plan.schemeHint, '');
+        assert.strictEqual(plan.installSteps.length, 0);
+    });
+});
+// ── validateInstallSteps ───────────────────────────────────────────
+describe('validateInstallSteps', () => {
+    it('allows known safe commands', () => {
+        const steps = [
+            { cmd: 'npm', args: ['ci'], cwd: '' },
+            { cmd: 'yarn', args: ['install'], cwd: '' },
+            { cmd: 'pod', args: ['install'], cwd: 'ios' },
+            { cmd: 'flutter', args: ['pub', 'get'], cwd: '' },
+            { cmd: 'xcodegen', args: ['generate'], cwd: '' },
+            { cmd: 'tuist', args: ['generate'], cwd: '' },
+            { cmd: 'bundle', args: ['install'], cwd: '' },
+        ];
+        const valid = validateInstallSteps(steps);
+        assert.strictEqual(valid.length, 7);
+    });
+    it('filters out disallowed commands', () => {
+        const steps = [
+            { cmd: 'npm', args: ['ci'], cwd: '' },
+            { cmd: 'rm', args: ['-rf', '/'], cwd: '' },
+            { cmd: 'curl', args: ['http://evil.com'], cwd: '' },
+            { cmd: 'pod', args: ['install'], cwd: 'ios' },
+        ];
+        const valid = validateInstallSteps(steps);
+        assert.strictEqual(valid.length, 2);
+        assert.strictEqual(valid[0].cmd, 'npm');
+        assert.strictEqual(valid[1].cmd, 'pod');
+    });
+    it('returns empty array for all-disallowed steps', () => {
+        const steps = [{ cmd: 'bash', args: ['-c', 'echo pwned'], cwd: '' }];
+        const valid = validateInstallSteps(steps);
+        assert.strictEqual(valid.length, 0);
+    });
+});

package/dist/commands/build/__tests__/run-build.test.d.ts

@@ -0,0 +1,6 @@
+/**
+ * Integration tests for the runBuild orchestration function.
+ * Uses dependency injection (BuildDeps) to mock external calls
+ * while testing the full decision-making pipeline.
+ */
+export {};