edsger 0.44.0 → 0.45.1

package/dist/phases/pr-execution/__tests__/file-assigner.test.js

@@ -1,303 +0,0 @@
-import assert from 'node:assert';
-import { describe, it } from 'node:test';
-import { applyAssignments, findUnassignedFiles, removeDeletedFilesFromPRs, } from '../file-assigner.js';
-function makePR(overrides) {
-    return {
-        feature_id: 'feat-1',
-        name: `PR ${overrides.sequence}`,
-        description: null,
-        branch_name: null,
-        base_pr_id: null,
-        pull_request_url: null,
-        pull_request_number: null,
-        compare_url: null,
-        status: 'pending',
-        last_synced_commit: null,
-        files: null,
-        created_by: 'user',
-        created_at: '2026-01-01',
-        updated_at: '2026-01-01',
-        ...overrides,
-    };
-}
-function cf(path, changeType = 'modified') {
-    return { path, change_type: changeType };
-}
-// ============================================================
-// findUnassignedFiles
-// ============================================================
-void describe('findUnassignedFiles', () => {
-    void it('returns all files when no PR has files', () => {
-        const prs = [makePR({ id: '1', sequence: 1, files: null })];
-        const result = findUnassignedFiles([cf('a.ts'), cf('b.ts')], prs);
-        assert.deepStrictEqual(result, [cf('a.ts'), cf('b.ts')]);
-    });
-    void it('returns empty when all files are assigned', () => {
-        const prs = [
-            makePR({
-                id: '1',
-                sequence: 1,
-                files: [
-                    { path: 'a.ts', change_type: 'modified' },
-                    { path: 'b.ts', change_type: 'added' },
-                ],
-            }),
-        ];
-        const result = findUnassignedFiles([cf('a.ts'), cf('b.ts', 'added')], prs);
-        assert.deepStrictEqual(result, []);
-    });
-    void it('returns only unassigned files', () => {
-        const prs = [
-            makePR({
-                id: '1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-            makePR({
-                id: '2',
-                sequence: 2,
-                files: [{ path: 'b.ts', change_type: 'added' }],
-            }),
-        ];
-        const result = findUnassignedFiles([cf('a.ts'), cf('b.ts'), cf('c.ts'), cf('d.ts', 'added')], prs);
-        assert.deepStrictEqual(result, [cf('c.ts'), cf('d.ts', 'added')]);
-    });
-    void it('handles PRs with empty files array', () => {
-        const prs = [
-            makePR({ id: '1', sequence: 1, files: [] }),
-            makePR({
-                id: '2',
-                sequence: 2,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-        ];
-        const result = findUnassignedFiles([cf('a.ts'), cf('b.ts')], prs);
-        assert.deepStrictEqual(result, [cf('b.ts')]);
-    });
-    void it('returns empty for empty changed files', () => {
-        const prs = [
-            makePR({
-                id: '1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-        ];
-        const result = findUnassignedFiles([], prs);
-        assert.deepStrictEqual(result, []);
-    });
-    void it('handles files spread across multiple PRs', () => {
-        const prs = [
-            makePR({
-                id: '1',
-                sequence: 1,
-                files: [
-                    { path: 'src/auth/login.ts', change_type: 'modified' },
-                    { path: 'src/auth/session.ts', change_type: 'modified' },
-                ],
-            }),
-            makePR({
-                id: '2',
-                sequence: 2,
-                files: [
-                    { path: 'src/api/users.ts', change_type: 'added' },
-                    { path: 'src/api/roles.ts', change_type: 'added' },
-                ],
-            }),
-        ];
-        const changedFiles = [
-            cf('src/auth/login.ts'),
-            cf('src/auth/session.ts'),
-            cf('src/api/users.ts'),
-            cf('src/api/roles.ts'),
-            cf('src/auth/oauth.ts', 'added'),
-            cf('README.md'),
-        ];
-        const result = findUnassignedFiles(changedFiles, prs);
-        assert.deepStrictEqual(result, [
-            cf('src/auth/oauth.ts', 'added'),
-            cf('README.md'),
-        ]);
-    });
-});
-// ============================================================
-// applyAssignments
-// ============================================================
-void describe('applyAssignments', () => {
-    void it('merges new files into existing PR files', async () => {
-        const prs = [
-            makePR({
-                id: 'pr-1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-        ];
-        const unassigned = [cf('b.ts', 'added')];
-        const updates = [];
-        const mockUpdater = (prId, u) => {
-            updates.push({ prId, files: u.files });
-            return Promise.resolve();
-        };
-        const count = await applyAssignments([{ file: 'b.ts', pr_id: 'pr-1' }], unassigned, prs, mockUpdater);
-        assert.strictEqual(count, 1);
-        assert.strictEqual(updates.length, 1);
-        assert.strictEqual(updates[0].prId, 'pr-1');
-        assert.deepStrictEqual(updates[0].files, [
-            { path: 'a.ts', change_type: 'modified' },
-            { path: 'b.ts', change_type: 'added' },
-        ]);
-    });
-    void it('deduplicates files already in PR', async () => {
-        const prs = [
-            makePR({
-                id: 'pr-1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-        ];
-        const unassigned = [cf('a.ts')];
-        const updates = [];
-        const mockUpdater = (_prId, u) => {
-            updates.push({ files: u.files });
-            return Promise.resolve();
-        };
-        await applyAssignments([{ file: 'a.ts', pr_id: 'pr-1' }], unassigned, prs, mockUpdater);
-        // File list should not have duplicates
-        assert.deepStrictEqual(updates[0].files, [
-            { path: 'a.ts', change_type: 'modified' },
-        ]);
-    });
-    void it('skips unknown PR ids', async () => {
-        const prs = [makePR({ id: 'pr-1', sequence: 1, files: [] })];
-        const unassigned = [cf('x.ts', 'added')];
-        let called = false;
-        const mockUpdater = () => {
-            called = true;
-            return Promise.resolve();
-        };
-        const count = await applyAssignments([{ file: 'x.ts', pr_id: 'unknown-id' }], unassigned, prs, mockUpdater);
-        assert.strictEqual(count, 0);
-        assert.strictEqual(called, false);
-    });
-    void it('uses change_type from git, not a hardcoded default', async () => {
-        const prs = [makePR({ id: 'pr-1', sequence: 1, files: [] })];
-        const unassigned = [cf('new.ts', 'added')];
-        const updates = [];
-        const mockUpdater = (_prId, u) => {
-            updates.push({ files: u.files });
-            return Promise.resolve();
-        };
-        await applyAssignments([{ file: 'new.ts', pr_id: 'pr-1' }], unassigned, prs, mockUpdater);
-        assert.strictEqual(updates[0].files[0].change_type, 'added');
-    });
-    void it('distributes files to multiple PRs', async () => {
-        const prs = [
-            makePR({ id: 'pr-1', sequence: 1, files: [] }),
-            makePR({ id: 'pr-2', sequence: 2, files: [] }),
-        ];
-        const unassigned = [
-            cf('a.ts', 'added'),
-            cf('b.ts', 'modified'),
-        ];
-        const updates = [];
-        const mockUpdater = (prId) => {
-            updates.push({ prId });
-            return Promise.resolve();
-        };
-        const count = await applyAssignments([
-            { file: 'a.ts', pr_id: 'pr-1' },
-            { file: 'b.ts', pr_id: 'pr-2' },
-        ], unassigned, prs, mockUpdater);
-        assert.strictEqual(count, 2);
-        assert.deepStrictEqual(updates.map((u) => u.prId), ['pr-1', 'pr-2']);
-    });
-    void it('handles updater failure gracefully', async () => {
-        const prs = [makePR({ id: 'pr-1', sequence: 1, files: [] })];
-        const unassigned = [cf('a.ts')];
-        const mockUpdater = () => {
-            return Promise.reject(new Error('DB error'));
-        };
-        const count = await applyAssignments([{ file: 'a.ts', pr_id: 'pr-1' }], unassigned, prs, mockUpdater);
-        assert.strictEqual(count, 0);
-    });
-});
-// ============================================================
-// removeDeletedFilesFromPRs
-// ============================================================
-void describe('removeDeletedFilesFromPRs', () => {
-    void it('removes deleted files from PR file lists', async () => {
-        const prs = [
-            makePR({
-                id: 'pr-1',
-                sequence: 1,
-                files: [
-                    { path: 'keep.ts', change_type: 'modified' },
-                    { path: 'gone.ts', change_type: 'added' },
-                ],
-            }),
-        ];
-        const changedFiles = [
-            cf('keep.ts'),
-            cf('gone.ts', 'deleted'),
-        ];
-        const updates = [];
-        const mockUpdater = (prId, u) => {
-            updates.push({ prId, files: u.files });
-            return Promise.resolve();
-        };
-        const count = await removeDeletedFilesFromPRs(changedFiles, prs, mockUpdater);
-        assert.strictEqual(count, 1);
-        assert.deepStrictEqual(updates[0].files, [
-            { path: 'keep.ts', change_type: 'modified' },
-        ]);
-    });
-    void it('returns 0 when no files are deleted', async () => {
-        const prs = [
-            makePR({
-                id: 'pr-1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-        ];
-        let called = false;
-        const mockUpdater = () => {
-            called = true;
-            return Promise.resolve();
-        };
-        const count = await removeDeletedFilesFromPRs([cf('a.ts')], prs, mockUpdater);
-        assert.strictEqual(count, 0);
-        assert.strictEqual(called, false);
-    });
-    void it('skips PRs with no matching deleted files', async () => {
-        const prs = [
-            makePR({
-                id: 'pr-1',
-                sequence: 1,
-                files: [{ path: 'a.ts', change_type: 'modified' }],
-            }),
-            makePR({
-                id: 'pr-2',
-                sequence: 2,
-                files: [{ path: 'b.ts', change_type: 'added' }],
-            }),
-        ];
-        const updates = [];
-        const mockUpdater = (prId) => {
-            updates.push(prId);
-            return Promise.resolve();
-        };
-        await removeDeletedFilesFromPRs([cf('b.ts', 'deleted')], prs, mockUpdater);
-        // Only pr-2 should be updated
-        assert.deepStrictEqual(updates, ['pr-2']);
-    });
-    void it('handles PRs with null files', async () => {
-        const prs = [makePR({ id: 'pr-1', sequence: 1, files: null })];
-        let called = false;
-        const mockUpdater = () => {
-            called = true;
-            return Promise.resolve();
-        };
-        const count = await removeDeletedFilesFromPRs([cf('a.ts', 'deleted')], prs, mockUpdater);
-        assert.strictEqual(count, 0);
-        assert.strictEqual(called, false);
-    });
-});

package/dist/phases/pr-resolve/__tests__/checklist-learner.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/phases/pr-resolve/__tests__/checklist-learner.test.js

@@ -1,157 +0,0 @@
-import assert from 'node:assert';
-import { describe, it } from 'node:test';
-import { buildLearnerPrompt } from '../checklist-learner.js';
-// ── helpers ──────────────────────────────────────────────────
-function makeThread(id, overrides) {
-    return {
-        id,
-        isResolved: false,
-        isOutdated: false,
-        comments: {
-            totalCount: 1,
-            nodes: [
-                {
-                    id: `${id}-c1`,
-                    author: { login: overrides?.author || 'reviewer' },
-                    body: overrides?.body || 'Please fix this',
-                    path: overrides?.path || 'src/index.ts',
-                    line: overrides && 'line' in overrides ? (overrides.line ?? null) : 10,
-                    url: `https://github.com/o/r/pull/1#${id}`,
-                },
-            ],
-        },
-    };
-}
-function makeMap(entries) {
-    return new Map(entries);
-}
-// ── buildLearnerPrompt ──────────────────────────────────────
-void describe('buildLearnerPrompt', () => {
-    void it('includes addressed comment count in header', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-            { comment_id: 'comment_2', action: 'changed', reply: 'Done' },
-        ];
-        const threads = [makeThread('t1'), makeThread('t2')];
-        const map = makeMap([
-            ['comment_1', 't1'],
-            ['comment_2', 't2'],
-        ]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(prompt.includes('2 review comment(s)'));
-    });
-    void it('includes reviewer, file path, line, and comment body', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Added null check' },
-        ];
-        const threads = [
-            makeThread('t1', {
-                path: 'src/auth.ts',
-                line: 42,
-                body: 'Missing null check here',
-                author: 'alice',
-            }),
-        ];
-        const map = makeMap([['comment_1', 't1']]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(prompt.includes('src/auth.ts'));
-        assert.ok(prompt.includes('42'));
-        assert.ok(prompt.includes('@alice'));
-        assert.ok(prompt.includes('Missing null check here'));
-        assert.ok(prompt.includes('Added null check'));
-    });
-    void it('includes resolution text for each comment', () => {
-        const comments = [
-            {
-                comment_id: 'comment_1',
-                action: 'changed',
-                reply: 'Refactored to use try/catch',
-            },
-        ];
-        const threads = [makeThread('t1')];
-        const map = makeMap([['comment_1', 't1']]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(prompt.includes('**Resolution**: Refactored to use try/catch'));
-    });
-    void it('includes summary when provided', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-        ];
-        const threads = [makeThread('t1')];
-        const map = makeMap([['comment_1', 't1']]);
-        const prompt = buildLearnerPrompt(comments, threads, map, 'Improved error handling across 3 files');
-        assert.ok(prompt.includes('## Overall Summary'));
-        assert.ok(prompt.includes('Improved error handling across 3 files'));
-    });
-    void it('omits summary section when not provided', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-        ];
-        const threads = [makeThread('t1')];
-        const map = makeMap([['comment_1', 't1']]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(!prompt.includes('## Overall Summary'));
-    });
-    void it('handles comment with no matching thread gracefully', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-        ];
-        // Empty threads — no match for comment_1
-        const map = makeMap([['comment_1', 'nonexistent']]);
-        const prompt = buildLearnerPrompt(comments, [], map);
-        // Should still include the comment section with resolution
-        assert.ok(prompt.includes('## comment_1'));
-        assert.ok(prompt.includes('**Resolution**: Fixed'));
-        // Should NOT include reviewer info since thread was not found
-        assert.ok(!prompt.includes('**Reviewer**'));
-    });
-    void it('handles comment_id not in map gracefully', () => {
-        const comments = [
-            { comment_id: 'comment_99', action: 'changed', reply: 'Fixed' },
-        ];
-        const prompt = buildLearnerPrompt(comments, [], new Map());
-        assert.ok(prompt.includes('## comment_99'));
-        assert.ok(prompt.includes('**Resolution**: Fixed'));
-    });
-    void it('omits line when null', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-        ];
-        const threads = [makeThread('t1', { line: null })];
-        const map = makeMap([['comment_1', 't1']]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(prompt.includes('**File**: src/index.ts'));
-        assert.ok(!prompt.includes('**Line**'));
-    });
-    void it('uses threadById map correctly for multiple comments', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fix A' },
-            { comment_id: 'comment_3', action: 'changed', reply: 'Fix C' },
-        ];
-        const threads = [
-            makeThread('t1', { body: 'Issue A', path: 'a.ts' }),
-            makeThread('t2', { body: 'Issue B', path: 'b.ts' }),
-            makeThread('t3', { body: 'Issue C', path: 'c.ts' }),
-        ];
-        const map = makeMap([
-            ['comment_1', 't1'],
-            ['comment_2', 't2'],
-            ['comment_3', 't3'],
-        ]);
-        const prompt = buildLearnerPrompt(comments, threads, map);
-        assert.ok(prompt.includes('Issue A'));
-        assert.ok(prompt.includes('a.ts'));
-        assert.ok(prompt.includes('Issue C'));
-        assert.ok(prompt.includes('c.ts'));
-        // comment_2 was not in addressedComments, should not appear
-        assert.ok(!prompt.includes('Issue B'));
-    });
-    void it('includes instructions section', () => {
-        const comments = [
-            { comment_id: 'comment_1', action: 'changed', reply: 'Fixed' },
-        ];
-        const prompt = buildLearnerPrompt(comments, [makeThread('t1')], makeMap([['comment_1', 't1']]));
-        assert.ok(prompt.includes('## Instructions'));
-        assert.ok(prompt.includes('code_review checklists'));
-    });
-});

package/dist/phases/pr-resolve/__tests__/prompts.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/phases/pr-resolve/__tests__/prompts.test.js

@@ -1,116 +0,0 @@
-import assert from 'node:assert';
-import { describe, it } from 'node:test';
-import { createResolveSystemPrompt, createResolveUserPrompt, } from '../prompts.js';
-function makeThread(id, overrides) {
-    const nodes = [
-        {
-            id: `${id}-comment-1`,
-            author: { login: overrides?.author || 'reviewer' },
-            body: overrides?.body || 'Please fix this',
-            path: overrides?.path || 'src/index.ts',
-            line: overrides?.line ?? 10,
-            url: `https://github.com/owner/repo/pull/1#discussion_${id}`,
-        },
-    ];
-    if (overrides?.followUps) {
-        for (const fu of overrides.followUps) {
-            nodes.push({
-                id: `${id}-followup`,
-                author: { login: fu.author },
-                body: fu.body,
-                path: overrides?.path || 'src/index.ts',
-                line: overrides?.line ?? 10,
-                url: `https://github.com/owner/repo/pull/1#discussion_${id}_fu`,
-            });
-        }
-    }
-    return {
-        id,
-        isResolved: false,
-        isOutdated: false,
-        comments: {
-            totalCount: nodes.length,
-            nodes,
-        },
-    };
-}
-void describe('createResolveSystemPrompt', () => {
-    void it('includes decision criteria', () => {
-        const prompt = createResolveSystemPrompt();
-        assert.ok(prompt.includes('Make the change when'));
-        assert.ok(prompt.includes('Skip the change when'));
-    });
-    void it('specifies comment_id format', () => {
-        const prompt = createResolveSystemPrompt();
-        assert.ok(prompt.includes('comment_id'));
-        assert.ok(prompt.includes('comment_1'));
-    });
-    void it('includes result format', () => {
-        const prompt = createResolveSystemPrompt();
-        assert.ok(prompt.includes('resolve_result'));
-        assert.ok(prompt.includes('"action"'));
-        assert.ok(prompt.includes('"reply"'));
-    });
-});
-void describe('createResolveUserPrompt', () => {
-    void it('uses sequential comment IDs not thread IDs', () => {
-        const threads = [makeThread('PRRT_kwDOxx_1'), makeThread('PRRT_kwDOxx_2')];
-        const { prompt, commentIdToThreadId } = createResolveUserPrompt(threads);
-        // Should use comment_1, comment_2 in the prompt
-        assert.ok(prompt.includes('## comment_1'));
-        assert.ok(prompt.includes('## comment_2'));
-        // Should NOT include opaque GraphQL IDs
-        assert.ok(!prompt.includes('PRRT_kwDOxx_1'));
-        assert.ok(!prompt.includes('PRRT_kwDOxx_2'));
-        // Mapping should be correct
-        assert.strictEqual(commentIdToThreadId.get('comment_1'), 'PRRT_kwDOxx_1');
-        assert.strictEqual(commentIdToThreadId.get('comment_2'), 'PRRT_kwDOxx_2');
-        assert.strictEqual(commentIdToThreadId.size, 2);
-    });
-    void it('includes file path and line number', () => {
-        const threads = [makeThread('t1', { path: 'src/auth.ts', line: 42 })];
-        const { prompt } = createResolveUserPrompt(threads);
-        assert.ok(prompt.includes('src/auth.ts'));
-        assert.ok(prompt.includes('42'));
-    });
-    void it('includes comment body', () => {
-        const threads = [
-            makeThread('t1', { body: 'This should use a const instead of let' }),
-        ];
-        const { prompt } = createResolveUserPrompt(threads);
-        assert.ok(prompt.includes('This should use a const instead of let'));
-    });
-    void it('includes follow-up comments', () => {
-        const threads = [
-            makeThread('t1', {
-                body: 'Main comment',
-                followUps: [{ author: 'dev', body: 'I disagree because...' }],
-            }),
-        ];
-        const { prompt } = createResolveUserPrompt(threads);
-        assert.ok(prompt.includes('Main comment'));
-        assert.ok(prompt.includes('I disagree because...'));
-        assert.ok(prompt.includes('@dev'));
-    });
-    void it('includes instruction to use exact comment IDs', () => {
-        const threads = [makeThread('t1'), makeThread('t2'), makeThread('t3')];
-        const { prompt } = createResolveUserPrompt(threads);
-        assert.ok(prompt.includes('comment_1, comment_2, comment_3'));
-    });
-    void it('handles threads with no comments gracefully', () => {
-        const emptyThread = {
-            id: 'empty',
-            isResolved: false,
-            isOutdated: false,
-            comments: { totalCount: 0, nodes: [] },
-        };
-        const { commentIdToThreadId } = createResolveUserPrompt([emptyThread]);
-        // Empty thread should be skipped (no comment nodes to index)
-        assert.strictEqual(commentIdToThreadId.size, 0);
-    });
-    void it('returns correct count in header', () => {
-        const threads = [makeThread('t1'), makeThread('t2')];
-        const { prompt } = createResolveUserPrompt(threads);
-        assert.ok(prompt.includes('2 unresolved review comment(s)'));
-    });
-});

package/dist/phases/pr-resolve/__tests__/resolve-mapping.test.d.ts

@@ -1 +0,0 @@
-export {};