edsger 0.42.0 → 0.43.0

package/dist/phases/pr-resolve/workspace.js

@@ -21,16 +21,20 @@ export function buildCredentialArgs(token) {
 }
 /**
  * Get the workspace path for a PR resolve operation.
+ * Includes owner/repo to avoid collisions when resolving PRs from different repos.
  */
-export function getResolveWorkspacePath(prNumber) {
-    return join(homedir(), 'edsger', `pr-resolve-${prNumber}`);
+export function getResolveWorkspacePath(owner, repo, prNumber) {
+    return join(homedir(), 'edsger', `pr-resolve-${owner}-${repo}-${prNumber}`);
 }
 /**
  * Clone or reuse a repo for PR resolve.
+ * For fork PRs, clones from the fork repo. If the fork branch is unavailable,
+ * falls back to fetching the PR ref from the upstream repo.
  * Returns the workspace path.
  */
-export function prepareWorkspace(owner, repo, headRef, prNumber, token, verbose) {
-    const repoPath = getResolveWorkspacePath(prNumber);
+export function prepareWorkspace(options) {
+    const { owner, repo, headRef, prNumber, token, verbose, forkFallback } = options;
+    const repoPath = getResolveWorkspacePath(owner, repo, prNumber);
     const repoUrl = `https://github.com/${owner}/${repo}.git`;
     const gitCredentialArgs = buildCredentialArgs(token);
     if (existsSync(join(repoPath, '.git'))) {
@@ -66,16 +70,41 @@ export function prepareWorkspace(owner, repo, headRef, prNumber, token, verbose)
     }
     else {
         logInfo(`Cloning ${owner}/${repo} (branch: ${headRef})...`);
-        execFileSync('git', [
-            ...gitCredentialArgs,
-            'clone',
-            '--branch',
-            headRef,
-            '--single-branch',
-            repoUrl,
-            repoPath,
-        ], { stdio: 'pipe' });
-        logSuccess(`Cloned to ${repoPath}`);
+        try {
+            execFileSync('git', [
+                ...gitCredentialArgs,
+                'clone',
+                '--branch',
+                headRef,
+                '--single-branch',
+                repoUrl,
+                repoPath,
+            ], { stdio: 'pipe' });
+            logSuccess(`Cloned to ${repoPath}`);
+        }
+        catch (error) {
+            // If clone fails and this is a fork PR, fall back to upstream PR ref
+            if (forkFallback) {
+                logInfo(`Fork branch not available, falling back to PR ref from ${forkFallback.upstreamOwner}/${forkFallback.upstreamRepo}`);
+                const upstreamUrl = `https://github.com/${forkFallback.upstreamOwner}/${forkFallback.upstreamRepo}.git`;
+                execFileSync('git', [...gitCredentialArgs, 'clone', upstreamUrl, repoPath], { stdio: 'pipe' });
+                // Fetch the PR ref and check it out
+                execFileSync('git', [
+                    ...gitCredentialArgs,
+                    'fetch',
+                    'origin',
+                    `pull/${prNumber}/head:${headRef}`,
+                ], { cwd: repoPath, stdio: 'pipe' });
+                execSync(`git checkout ${headRef}`, {
+                    cwd: repoPath,
+                    stdio: 'pipe',
+                });
+                logSuccess(`Cloned via PR ref to ${repoPath}`);
+            }
+            else {
+                throw error;
+            }
+        }
     }
     // Configure git user for commits
     try {

package/dist/phases/pr-review/__tests__/prompts.test.js

@@ -1,46 +1,46 @@
 import assert from 'node:assert';
 import { describe, it } from 'node:test';
 import { createStandaloneReviewSystemPrompt, createStandaloneReviewUserPrompt, } from '../prompts.js';
-describe('createStandaloneReviewSystemPrompt', () => {
-    it('includes review focus areas', () => {
+void describe('createStandaloneReviewSystemPrompt', () => {
+    void it('includes review focus areas', () => {
         const prompt = createStandaloneReviewSystemPrompt();
         assert.ok(prompt.includes('Code Quality'));
         assert.ok(prompt.includes('Security'));
         assert.ok(prompt.includes('Performance'));
     });
-    it('specifies JSON result format', () => {
+    void it('specifies JSON result format', () => {
         const prompt = createStandaloneReviewSystemPrompt();
         assert.ok(prompt.includes('review_result'));
         assert.ok(prompt.includes('"file"'));
         assert.ok(prompt.includes('"line"'));
         assert.ok(prompt.includes('"comment"'));
     });
-    it('includes assessment options', () => {
+    void it('includes assessment options', () => {
         const prompt = createStandaloneReviewSystemPrompt();
         assert.ok(prompt.includes('APPROVE'));
         assert.ok(prompt.includes('REQUEST_CHANGES'));
         assert.ok(prompt.includes('COMMENT'));
     });
-    it('does not include feature/checklist instructions', () => {
+    void it('does not include feature/checklist instructions', () => {
         const prompt = createStandaloneReviewSystemPrompt();
         assert.ok(!prompt.includes('checklist'));
         assert.ok(!prompt.includes('feature_id'));
         assert.ok(!prompt.includes('user stories'));
     });
 });
-describe('createStandaloneReviewUserPrompt', () => {
-    it('includes context info in the prompt', () => {
+void describe('createStandaloneReviewUserPrompt', () => {
+    void it('includes context info in the prompt', () => {
         const contextInfo = '# Pull Request\n**Title**: Fix auth bug\n';
         const prompt = createStandaloneReviewUserPrompt(contextInfo);
         assert.ok(prompt.includes('Fix auth bug'));
     });
-    it('includes review instructions', () => {
+    void it('includes review instructions', () => {
         const prompt = createStandaloneReviewUserPrompt('some context');
         assert.ok(prompt.includes('Analyze Each File'));
         assert.ok(prompt.includes('Identify Issues'));
         assert.ok(prompt.includes('Actionable Feedback'));
     });
-    it('mentions severity categories', () => {
+    void it('mentions severity categories', () => {
         const prompt = createStandaloneReviewUserPrompt('context');
         assert.ok(prompt.includes('Critical'));
         assert.ok(prompt.includes('Major'));

package/dist/phases/pr-review/__tests__/review-comments.test.js

@@ -36,7 +36,7 @@ function mapCommentsToReviewPayload(agentComments, files) {
     }
     return result;
 }
-describe('review comment mapping (integration)', () => {
+void describe('review comment mapping (integration)', () => {
     const samplePatch = `@@ -1,5 +1,7 @@
  import { useState } from 'react'
 
@@ -47,7 +47,7 @@ describe('review comment mapping (integration)', () => {
 +  const [count, setCount] = useState<number>(0)
    return <div>{count}</div>`;
     const files = [{ filename: 'src/App.tsx', patch: samplePatch }];
-    it('maps exact line comments to correct diff positions', () => {
+    void it('maps exact line comments to correct diff positions', () => {
         const comments = [
             {
                 file: 'src/App.tsx',
@@ -63,7 +63,7 @@ describe('review comment mapping (integration)', () => {
         // No "Note" prefix since line was exact
         assert.ok(!result[0].body.includes('**Note**'));
     });
-    it('adjusts line numbers when exact line not in diff', () => {
+    void it('adjusts line numbers when exact line not in diff', () => {
         // Line 2 is blank (in diff) but line 100 is way outside
         const comments = [{ file: 'src/App.tsx', line: 8, comment: 'Fix this' }];
         const result = mapCommentsToReviewPayload(comments, files);
@@ -73,7 +73,7 @@ describe('review comment mapping (integration)', () => {
         }
         // If no match within range, it's filtered out - also valid
     });
-    it('filters out comments for files not in diff', () => {
+    void it('filters out comments for files not in diff', () => {
         const comments = [
             {
                 file: 'src/other.ts',
@@ -84,7 +84,7 @@ describe('review comment mapping (integration)', () => {
         const result = mapCommentsToReviewPayload(comments, files);
         assert.strictEqual(result.length, 0);
     });
-    it('handles multiple comments on same file', () => {
+    void it('handles multiple comments on same file', () => {
         const comments = [
             { file: 'src/App.tsx', line: 3, comment: 'Comment A' },
             { file: 'src/App.tsx', line: 6, comment: 'Comment B' },
@@ -94,7 +94,7 @@ describe('review comment mapping (integration)', () => {
         assert.ok(result[0].body.includes('Comment A'));
         assert.ok(result[1].body.includes('Comment B'));
     });
-    it('handles files with no patch (binary files)', () => {
+    void it('handles files with no patch (binary files)', () => {
         const binaryFiles = [
             { filename: 'image.png' }, // no patch
             { filename: 'src/App.tsx', patch: samplePatch },

package/dist/phases/pr-review/index.js

@@ -14,6 +14,7 @@ import { createStandaloneReviewSystemPrompt, createStandaloneReviewUserPrompt, }
 /**
  * Review a standalone PR and post comments to GitHub.
  */
+// eslint-disable-next-line complexity
 export async function reviewStandalonePR(options) {
     const { pullRequestUrl, githubToken, verbose, prId } = options;
     logInfo(`Starting standalone PR review: ${pullRequestUrl}`);

package/dist/phases/pr-shared/__tests__/agent-utils.test.js

@@ -1,8 +1,8 @@
 import assert from 'node:assert';
 import { describe, it } from 'node:test';
 import { extractTextFromContent, tryExtractResult, tryParseJsonFromResponse, userMessage, } from '../agent-utils.js';
-describe('userMessage', () => {
-    it('creates a user message object', () => {
+void describe('userMessage', () => {
+    void it('creates a user message object', () => {
         const msg = userMessage('hello');
         assert.deepStrictEqual(msg, {
             type: 'user',
@@ -10,8 +10,8 @@ describe('userMessage', () => {
         });
     });
 });
-describe('extractTextFromContent', () => {
-    it('extracts text items from content array', () => {
+void describe('extractTextFromContent', () => {
+    void it('extracts text items from content array', () => {
         const content = [
             { type: 'text', text: 'hello' },
             { type: 'tool_use', id: '123', name: 'read', input: {} },
@@ -20,35 +20,35 @@ describe('extractTextFromContent', () => {
         const result = extractTextFromContent(content);
         assert.strictEqual(result, 'hello\nworld\n');
     });
-    it('returns empty string for no text items', () => {
+    void it('returns empty string for no text items', () => {
         const content = [{ type: 'tool_use', id: '123', name: 'read', input: {} }];
         const result = extractTextFromContent(content);
         assert.strictEqual(result, '');
     });
-    it('returns empty string for empty array', () => {
+    void it('returns empty string for empty array', () => {
         assert.strictEqual(extractTextFromContent([]), '');
     });
 });
-describe('tryParseJsonFromResponse', () => {
-    it('parses JSON from code block', () => {
+void describe('tryParseJsonFromResponse', () => {
+    void it('parses JSON from code block', () => {
         const text = 'Here is the result:\n```json\n{"key": "value"}\n```\nDone.';
         const result = tryParseJsonFromResponse(text);
         assert.deepStrictEqual(result, { key: 'value' });
     });
-    it('parses raw JSON', () => {
+    void it('parses raw JSON', () => {
         const text = '{"key": "value"}';
         const result = tryParseJsonFromResponse(text);
         assert.deepStrictEqual(result, { key: 'value' });
     });
-    it('returns null for invalid JSON', () => {
+    void it('returns null for invalid JSON', () => {
         const result = tryParseJsonFromResponse('not json at all');
         assert.strictEqual(result, null);
     });
-    it('returns null for empty string', () => {
+    void it('returns null for empty string', () => {
         const result = tryParseJsonFromResponse('');
         assert.strictEqual(result, null);
     });
-    it('parses JSON block with surrounding text', () => {
+    void it('parses JSON block with surrounding text', () => {
         const text = `I analyzed the code and here are my findings:
 
 \`\`\`json
@@ -66,22 +66,22 @@ That's my review.`;
         assert.ok(result.review_result);
     });
 });
-describe('tryExtractResult', () => {
-    it('extracts keyed result from JSON code block', () => {
+void describe('tryExtractResult', () => {
+    void it('extracts keyed result from JSON code block', () => {
         const text = '```json\n{"review_result": {"summary": "good"}}\n```';
         const result = tryExtractResult(text, 'review_result');
         assert.deepStrictEqual(result, { summary: 'good' });
     });
-    it('returns whole object if key not found but JSON valid', () => {
+    void it('returns whole object if key not found but JSON valid', () => {
         const text = '{"summary": "good", "comments": []}';
         const result = tryExtractResult(text, 'review_result');
         assert.deepStrictEqual(result, { summary: 'good', comments: [] });
     });
-    it('returns null for unparseable text', () => {
+    void it('returns null for unparseable text', () => {
         const result = tryExtractResult('no json here', 'review_result');
         assert.strictEqual(result, null);
     });
-    it('extracts resolve_result key', () => {
+    void it('extracts resolve_result key', () => {
         const text = '```json\n{"resolve_result": {"comments": [{"comment_id": "comment_1", "action": "changed", "reply": "fixed"}]}}\n```';
         const result = tryExtractResult(text, 'resolve_result');
         assert.ok(result);

package/dist/phases/pr-shared/__tests__/context.test.js

@@ -1,8 +1,8 @@
 import assert from 'node:assert';
 import { describe, it } from 'node:test';
 import { formatStandalonePRContextForPrompt, parsePullRequestUrl, } from '../context.js';
-describe('parsePullRequestUrl (re-exported)', () => {
-    it('parses a standard GitHub PR URL', () => {
+void describe('parsePullRequestUrl (re-exported)', () => {
+    void it('parses a standard GitHub PR URL', () => {
         const result = parsePullRequestUrl('https://github.com/owner/repo/pull/123');
         assert.deepStrictEqual(result, {
             owner: 'owner',
@@ -10,7 +10,7 @@ describe('parsePullRequestUrl (re-exported)', () => {
             prNumber: 123,
         });
     });
-    it('parses URL with trailing path segments', () => {
+    void it('parses URL with trailing path segments', () => {
         const result = parsePullRequestUrl('https://github.com/my-org/my-repo/pull/456/files');
         assert.deepStrictEqual(result, {
             owner: 'my-org',
@@ -18,14 +18,14 @@ describe('parsePullRequestUrl (re-exported)', () => {
             prNumber: 456,
         });
     });
-    it('returns null for non-PR URL', () => {
+    void it('returns null for non-PR URL', () => {
         assert.strictEqual(parsePullRequestUrl('https://github.com/owner/repo/issues/1'), null);
     });
-    it('returns null for non-GitHub URL', () => {
+    void it('returns null for non-GitHub URL', () => {
         assert.strictEqual(parsePullRequestUrl('https://example.com/pull/1'), null);
     });
 });
-describe('formatStandalonePRContextForPrompt', () => {
+void describe('formatStandalonePRContextForPrompt', () => {
     const context = {
         pullRequestUrl: 'https://github.com/owner/repo/pull/42',
         pullRequestNumber: 42,
@@ -61,33 +61,33 @@ describe('formatStandalonePRContextForPrompt', () => {
             },
         ],
     };
-    it('includes PR URL and number', () => {
+    void it('includes PR URL and number', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('#42'));
         assert.ok(output.includes('github.com/owner/repo/pull/42'));
     });
-    it('includes PR title and author', () => {
+    void it('includes PR title and author', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('Fix bug in auth'));
         assert.ok(output.includes('@testuser'));
     });
-    it('includes branch info', () => {
+    void it('includes branch info', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('fix/auth'));
         assert.ok(output.includes('main'));
     });
-    it('includes file diff', () => {
+    void it('includes file diff', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('src/auth.ts'));
         assert.ok(output.includes('+added'));
         assert.ok(output.includes('+5 -2'));
     });
-    it('includes commit info', () => {
+    void it('includes commit info', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('abc1234'));
         assert.ok(output.includes('fix: auth bug'));
     });
-    it('includes PR body/description', () => {
+    void it('includes PR body/description', () => {
         const output = formatStandalonePRContextForPrompt(context);
         assert.ok(output.includes('This fixes the login issue'));
     });

package/dist/phases/pr-splitting/import-dep-validator.js

@@ -155,6 +155,9 @@ export function getTransitiveDependencies(file, graph) {
     const stack = [file];
     while (stack.length > 0) {
         const current = stack.pop();
+        if (current === undefined) {
+            continue;
+        }
         const deps = graph.get(current);
         if (!deps) {
             continue;
@@ -169,11 +172,8 @@ export function getTransitiveDependencies(file, graph) {
     return result;
 }
 const MAX_FIX_ITERATIONS = 100;
-/**
- * Move a dependency file from a later PR to an earlier PR that needs it.
- * Returns true if a file was moved.
- */
-function moveDepToEarlierPR(dep, prIdx, sorted, fileToPRIndex, movedFiles, reason) {
+function moveDepToEarlierPR(options) {
+    const { dep, prIdx, sorted, fileToPRIndex, movedFiles, reason } = options;
     const depPRIdx = fileToPRIndex.get(dep);
     if (depPRIdx === undefined || depPRIdx <= prIdx) {
         return false;
@@ -229,7 +229,15 @@ export function autoFixPROrdering(pullRequests, dependencyGraph) {
             for (const file of sorted[prIdx].files ?? []) {
                 const transitiveDeps = getTransitiveDependencies(file.path, dependencyGraph);
                 for (const dep of transitiveDeps) {
-                    const moved = moveDepToEarlierPR(dep, prIdx, sorted, fileToPRIndex, movedFiles, `imported by ${file.path}`);
+                    const moved = moveDepToEarlierPR({
+                        dep,
+                        prIdx,
+                        sorted,
+                        fileToPRIndex,
+                        movedFiles,
+                        reason: `imported by ${file.path}`,
+                    });
+                    // eslint-disable-next-line max-depth
                     if (moved) {
                         changed = true;
                     }

package/dist/phases/pr-splitting/index.js

@@ -27,7 +27,9 @@ async function* prompt(analysisPrompt) {
  * then uses AI to produce a PR split plan saved to the database.
  * Human review is expected before running the pr-execution phase.
  */
-export const splitFeatureIntoPRs = async (options, config) => {
+export const splitFeatureIntoPRs = async (options, config
+// eslint-disable-next-line complexity
+) => {
     const { featureId, verbose, replaceExisting } = options;
     if (verbose) {
         logInfo(`Starting PR splitting for feature ID: ${featureId}`);

package/dist/phases/technical-design/index.js

@@ -24,7 +24,9 @@ async function* prompt(analysisPrompt) {
         setTimeout(res, 10000);
     });
 }
-export const generateTechnicalDesign = async (options, config, checklistContext) => {
+export const generateTechnicalDesign = async (options, config, checklistContext
+// eslint-disable-next-line complexity
+) => {
     const { featureId, verbose } = options;
     if (verbose) {
         logInfo(`Starting technical design generation for feature ID: ${featureId}`);

package/dist/phases/test-cases-analysis/index.js

@@ -6,7 +6,9 @@ import { executeTestCasesAnalysisQuery, parseAnalysisResult } from './agent.js';
 import { prepareTestCasesAnalysisContext } from './context.js';
 import { buildTestCasesAnalysisResult, deleteSpecificTestCases, deleteTestCaseArtifacts, getAllDraftTestCaseIds, resetReadyTestCasesToDraft, saveTestCasesAsDraft, updateTestCasesToReady, } from './outcome.js';
 import { createTestCasesAnalysisSystemPrompt } from './prompts.js';
-export const analyseTestCases = async (options, config, checklistContext) => {
+export const analyseTestCases = async (options, config, checklistContext
+// eslint-disable-next-line complexity
+) => {
     const { featureId, verbose } = options;
     if (verbose) {
         logInfo(`Starting test cases analysis for feature ID: ${featureId}`);

package/dist/phases/user-stories-analysis/index.js

@@ -6,7 +6,9 @@ import { executeUserStoriesAnalysisQuery, parseAnalysisResult, } from './agent.j
 import { prepareUserStoriesAnalysisContext } from './context.js';
 import { buildUserStoriesAnalysisResult, deleteSpecificUserStories, deleteUserStoryArtifacts, getAllDraftUserStoryIds, resetReadyUserStoriesToDraft, saveUserStoriesAsDraft, updateUserStoriesToReady, } from './outcome.js';
 import { createUserStoriesAnalysisSystemPrompt } from './prompts.js';
-export const analyseUserStories = async (options, config, checklistContext) => {
+export const analyseUserStories = async (options, config, checklistContext
+// eslint-disable-next-line complexity
+) => {
     const { featureId, verbose } = options;
     if (verbose) {
         logInfo(`Starting user stories analysis for feature ID: ${featureId}`);

package/dist/services/phase-hooks/__tests__/hook-executor.test.js

@@ -163,6 +163,7 @@ void describe('executeHook', () => {
     ) {
         // Return a function that returns an async iterable
         return () => ({
+            // eslint-disable-next-line @typescript-eslint/require-await
             async *[Symbol.asyncIterator]() {
                 for (const msg of messages) {
                     yield msg;
@@ -172,7 +173,7 @@ void describe('executeHook', () => {
     }
     function makeDeps(overrides = {}) {
         return {
-            loadSkillFile: async () => defaultSkillFile,
+            loadSkillFile: () => Promise.resolve(defaultSkillFile),
             queryFn: mockQuery([
                 {
                     type: 'result',
@@ -184,7 +185,7 @@ void describe('executeHook', () => {
         };
     }
     void it('returns skipped when skill file not found', async () => {
-        const deps = makeDeps({ loadSkillFile: async () => null });
+        const deps = makeDeps({ loadSkillFile: () => Promise.resolve(null) });
         const result = await executeHook(makeBinding(), makeContext(), false, deps);
         assert.strictEqual(result.status, 'skipped');
         assert.ok(result.message.includes('not found'));
@@ -266,7 +267,7 @@ void describe('executeHook', () => {
     void it('passes correct model and maxTurns from frontmatter', async () => {
         let capturedOptions = {};
         const deps = makeDeps({
-            loadSkillFile: async () => ({
+            loadSkillFile: () => Promise.resolve({
                 frontmatter: { model: 'haiku', maxTurns: 5 },
                 body: 'Test prompt',
             }),
@@ -274,6 +275,7 @@ void describe('executeHook', () => {
             queryFn: ((opts) => {
                 capturedOptions = opts.options;
                 return {
+                    // eslint-disable-next-line @typescript-eslint/require-await
                     async *[Symbol.asyncIterator]() {
                         yield {
                             type: 'result',
@@ -292,7 +294,7 @@ void describe('executeHook', () => {
     void it('uses DEFAULT_MODEL when frontmatter has no model', async () => {
         let capturedOptions = {};
         const deps = makeDeps({
-            loadSkillFile: async () => ({
+            loadSkillFile: () => Promise.resolve({
                 frontmatter: {},
                 body: 'Test prompt',
             }),
@@ -300,6 +302,7 @@ void describe('executeHook', () => {
             queryFn: ((opts) => {
                 capturedOptions = opts.options;
                 return {
+                    // eslint-disable-next-line @typescript-eslint/require-await
                     async *[Symbol.asyncIterator]() {
                         yield {
                             type: 'result',

package/dist/services/phase-hooks/__tests__/hook-runner.test.js

@@ -37,10 +37,10 @@ function makeContext(overrides = {}) {
 }
 function makeDeps(overrides = {}) {
     return {
-        executeHook: async (binding) => makeResult(binding),
+        executeHook: (binding) => Promise.resolve(makeResult(binding)),
         getCachedBindings: () => null,
         getBindingsForPhase: () => [],
-        logHookEvent: async () => { },
+        logHookEvent: () => Promise.resolve(),
         ...overrides,
     };
 }
@@ -86,9 +86,9 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [binding],
-            executeHook: async (b) => {
+            executeHook: (b) => {
                 executeCalls.push(b);
-                return makeResult(b);
+                return Promise.resolve(makeResult(b));
             },
         });
         const result = await runHooksForPhase(makeContext(), deps);
@@ -109,9 +109,9 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [b1, b2],
-            executeHook: async (b) => {
+            executeHook: (b) => {
                 order.push(b.id);
-                return makeResult(b);
+                return Promise.resolve(makeResult(b));
             },
         });
         await runHooksForPhase(makeContext(), deps);
@@ -133,15 +133,15 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [b1, b2],
-            executeHook: async (b) => {
+            executeHook: (b) => {
                 executedIds.push(b.id);
                 if (b.id === 'blocker') {
-                    return makeResult(b, {
+                    return Promise.resolve(makeResult(b, {
                         status: 'error',
                         message: 'Validation failed',
-                    });
+                    }));
                 }
-                return makeResult(b);
+                return Promise.resolve(makeResult(b));
             },
         });
         const result = await runHooksForPhase(makeContext(), deps);
@@ -165,14 +165,14 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [b1, b2],
-            executeHook: async (b) => {
+            executeHook: (b) => {
                 if (b.id === 'warner') {
-                    return makeResult(b, {
+                    return Promise.resolve(makeResult(b, {
                         status: 'error',
                         message: 'Non-critical issue',
-                    });
+                    }));
                 }
-                return makeResult(b);
+                return Promise.resolve(makeResult(b));
             },
         });
         const result = await runHooksForPhase(makeContext(), deps);
@@ -192,11 +192,11 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [b1, b2],
-            executeHook: async (b) => {
+            executeHook: (b) => {
                 if (b.id === 'skipper') {
-                    return makeResult(b, { status: 'error', message: 'Ignored' });
+                    return Promise.resolve(makeResult(b, { status: 'error', message: 'Ignored' }));
                 }
-                return makeResult(b);
+                return Promise.resolve(makeResult(b));
             },
         });
         const result = await runHooksForPhase(makeContext(), deps);
@@ -214,8 +214,9 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [binding],
-            logHookEvent: async ({ result: r }) => {
+            logHookEvent: ({ result: r }) => {
                 logCalls.push(r.hookId);
+                return Promise.resolve();
             },
         });
         await runHooksForPhase(makeContext(), deps);
@@ -231,8 +232,8 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [binding],
-            logHookEvent: async () => {
-                throw new Error('Logging failed');
+            logHookEvent: () => {
+                return Promise.reject(new Error('Logging failed'));
             },
         });
         const result = await runHooksForPhase(makeContext(), deps);
@@ -250,7 +251,7 @@ void describe('runHooksForPhase', () => {
         const deps = makeDeps({
             getCachedBindings: () => cached,
             getBindingsForPhase: () => [binding],
-            executeHook: async (b) => makeResult(b, { status: 'skipped', message: 'Not found' }),
+            executeHook: (b) => Promise.resolve(makeResult(b, { status: 'skipped', message: 'Not found' })),
         });
         const result = await runHooksForPhase(makeContext(), deps);
         // 'skipped' is not an error, so on_failure policy should not apply

package/dist/services/phase-hooks/hook-executor.js

@@ -94,6 +94,7 @@ export async function executeHook(binding, context, verbose, deps = defaultDeps)
             if (message.type === 'assistant') {
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 for (const item of (message.message?.content ?? [])) {
+                    // eslint-disable-next-line max-depth
                     if (item.type === 'text') {
                         resultText += item.text;
                     }