edsger 0.21.1 → 0.21.3

package/dist/phases/code-implementation/branch-pr-creator.js

@@ -5,6 +5,19 @@
 import { Octokit } from '@octokit/rest';
 import { execSync } from 'child_process';
 import { logInfo, logError } from '../../utils/logger.js';
+// GitHub PR title best practice: keep under 72 characters
+const MAX_PR_TITLE_LENGTH = 72;
+const PR_TITLE_PREFIX = 'feat: ';
+const MAX_FEATURE_NAME_LENGTH = MAX_PR_TITLE_LENGTH - PR_TITLE_PREFIX.length;
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 /**
  * Convert a feat/ branch name to a dev/ branch name
  * e.g., "feat/abc123/1-database" -> "dev/abc123/1-database"
@@ -142,8 +155,9 @@ export async function createBranchPullRequest(config, devBranchName, featureName
                 pullRequestNumber: existingPR.number,
             };
         }
-        // Generate PR title and body
-        const title = `feat: ${featureName}`;
+        // Generate PR title and body (truncate to keep under 72 chars)
+        const truncatedName = truncateText(featureName, MAX_FEATURE_NAME_LENGTH);
+        const title = `${PR_TITLE_PREFIX}${truncatedName}`;
         const body = `## Branch Implementation
 
 ${branchDescription}

package/dist/phases/code-implementation/index.js

@@ -10,6 +10,16 @@ import { prepareCustomBranchGitEnvironment, syncFeatBranchWithMain, } from '../.
 import { getCurrentBranch, updateBranch, getBranches, createBranches, getBaseBranchInfo, } from '../../services/branches.js';
 import { createBranchPullRequest, } from './branch-pr-creator.js';
 import { getGitHubConfig } from '../../api/github.js';
+import { getFeature } from '../../api/features/index.js';
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 function userMessage(content) {
     return {
         type: 'user',
@@ -50,11 +60,25 @@ export const implementFeatureCode = async (options, config, checklistContext) =>
             if (verbose) {
                 logInfo(`📋 Creating default branch record for feature: ${featureId}`);
             }
+            // Fetch feature info to get the feature name for branch naming
+            let featureName = 'Feature Implementation';
+            try {
+                const featureInfo = await getFeature(featureId, verbose);
+                if (featureInfo?.name) {
+                    // Truncate feature name for branch display (max 100 chars)
+                    featureName = truncateText(featureInfo.name, 100);
+                }
+            }
+            catch (error) {
+                if (verbose) {
+                    logInfo(`Could not fetch feature name, using default: ${error}`);
+                }
+            }
             const defaultBranchName = `dev/${featureId}`;
             const createdBranches = await createBranches({ featureId, verbose }, [
                 {
-                    name: 'Main Implementation',
-                    description: 'Default branch for feature implementation',
+                    name: featureName,
+                    description: `Implementation branch for: ${featureName}`,
                     branch_name: defaultBranchName,
                     status: 'pending',
                 },

package/dist/phases/code-refine-verification/llm-analyzer.d.ts

@@ -12,7 +12,7 @@ export interface ThreadAnalysisResult {
  * Analyze whether a review thread has been addressed by examining code changes
  * Uses LLM to intelligently determine if the feedback was addressed
  */
-export declare function analyzeThreadWithLLM(thread: ReviewThread, fileChange: PRFileChange | undefined, config: EdsgerConfig, verbose?: boolean): Promise<ThreadAnalysisResult>;
+export declare function analyzeThreadWithLLM(thread: ReviewThread, fileChange: PRFileChange | undefined, allFileChanges: PRFileChange[], config: EdsgerConfig, verbose?: boolean): Promise<ThreadAnalysisResult>;
 /**
  * Analyze all review threads in parallel using LLM
  */

package/dist/phases/code-refine-verification/llm-analyzer.js

@@ -9,7 +9,7 @@ import { createThreadAnalysisPrompt } from './prompts.js';
  * Analyze whether a review thread has been addressed by examining code changes
  * Uses LLM to intelligently determine if the feedback was addressed
  */
-export async function analyzeThreadWithLLM(thread, fileChange, config, verbose) {
+export async function analyzeThreadWithLLM(thread, fileChange, allFileChanges, config, verbose) {
     const firstComment = thread.comments.nodes[0];
     if (!firstComment) {
         return {
@@ -17,25 +17,26 @@ export async function analyzeThreadWithLLM(thread, fileChange, config, verbose)
             reason: 'Comment thread exists but has no comments',
         };
     }
-    // If file was not changed at all, feedback definitely not addressed
-    if (!fileChange || !fileChange.patch) {
-        return {
-            isAddressed: false,
-            reason: `File ${firstComment.path} has not been modified in this PR`,
-        };
-    }
     // If file was deleted, thread should be resolved as obsolete
-    if (fileChange.status === 'removed') {
+    if (fileChange?.status === 'removed') {
         return {
             isAddressed: true,
             reason: 'File has been removed',
         };
     }
+    // Check if there are any file changes at all
+    const hasAnyChanges = allFileChanges.some((fc) => fc.patch);
+    if (!hasAnyChanges) {
+        return {
+            isAddressed: false,
+            reason: 'No code changes found in this PR',
+        };
+    }
     try {
         if (verbose) {
             logInfo(`🤖 Using LLM to analyze if comment in ${firstComment.path}:${firstComment.line} has been addressed...`);
         }
-        const analysisPrompt = createThreadAnalysisPrompt(thread, fileChange, firstComment);
+        const analysisPrompt = createThreadAnalysisPrompt(thread, fileChange, allFileChanges, firstComment);
         let lastResponse = '';
         let analysisResult = null;
         function* userMessage() {
@@ -119,7 +120,7 @@ export async function analyzeAllThreads(threads, fileChanges, config, verbose) {
     const results = await Promise.all(threads.map(async (thread) => {
         const firstComment = thread.comments.nodes[0];
         const fileChange = fileChanges.find((fc) => fc.filename === firstComment?.path);
-        const analysis = await analyzeThreadWithLLM(thread, fileChange, config, verbose);
+        const analysis = await analyzeThreadWithLLM(thread, fileChange, fileChanges, config, verbose);
         return {
             thread,
             analysis,

package/dist/phases/code-refine-verification/prompts.d.ts

@@ -2,4 +2,4 @@ import { ReviewThread, PRFileChange } from './types.js';
 /**
  * Create prompt for LLM to analyze if a comment thread has been addressed
  */
-export declare function createThreadAnalysisPrompt(thread: ReviewThread, fileChange: PRFileChange, firstComment: ReviewThread['comments']['nodes'][0]): string;
+export declare function createThreadAnalysisPrompt(thread: ReviewThread, fileChange: PRFileChange | undefined, allFileChanges: PRFileChange[], firstComment: ReviewThread['comments']['nodes'][0]): string;

package/dist/phases/code-refine-verification/prompts.js

@@ -1,44 +1,86 @@
 /**
  * Create prompt for LLM to analyze if a comment thread has been addressed
  */
-export function createThreadAnalysisPrompt(thread, fileChange, firstComment) {
+export function createThreadAnalysisPrompt(thread, fileChange, allFileChanges, firstComment) {
     const allComments = thread.comments.nodes
         .map((c, idx) => `Comment ${idx + 1} by @${c.author.login}:\n${c.body}`)
         .join('\n\n');
     // Build the code context section
     let codeContext = '';
-    // Include diff (what changed)
-    if (fileChange.patch) {
-        codeContext += `**Code Changes (Diff):**
+    const commentFilePath = firstComment.path;
+    // Check if the comment's file was modified
+    const commentFileModified = fileChange && fileChange.patch;
+    if (commentFileModified) {
+        // Include diff for the comment's file
+        codeContext += `**Changes in ${commentFilePath} (where the comment was made):**
 \`\`\`diff
 ${fileChange.patch}
 \`\`\`
 
 `;
-    }
-    // Include full file content for better context
-    if (fileChange.fullContent) {
-        // Truncate very large files to avoid context limits
-        const maxLength = 10000;
-        const content = fileChange.fullContent.length > maxLength
-            ? fileChange.fullContent.substring(0, maxLength) +
-                '\n\n... (file truncated, showing first 10000 characters)'
-            : fileChange.fullContent;
-        codeContext += `**Complete File Content (After Changes):**
+        // Include full file content for better context
+        if (fileChange.fullContent) {
+            const maxLength = 10000;
+            const content = fileChange.fullContent.length > maxLength
+                ? fileChange.fullContent.substring(0, maxLength) +
+                    '\n\n... (file truncated, showing first 10000 characters)'
+                : fileChange.fullContent;
+            codeContext += `**Complete File Content of ${commentFilePath} (After Changes):**
 \`\`\`
 ${content}
 \`\`\`
 
 `;
+        }
     }
-    if (!codeContext) {
-        codeContext = '(No code information available)\n\n';
+    else {
+        codeContext += `**Note:** The file where the comment was made (${commentFilePath}) was NOT modified in this PR.
+This could be intentional - the comment may be requesting changes to a DIFFERENT file.
+
+`;
+    }
+    // Include other file changes - important for cross-file requests
+    // (e.g., "add these variables to the env example file")
+    const otherChanges = allFileChanges.filter((fc) => fc.filename !== commentFilePath && fc.patch);
+    if (otherChanges.length > 0) {
+        codeContext += `**Other Files Changed in This PR:**\n`;
+        // Show summary of all changed files first
+        codeContext += `Changed files: ${otherChanges.map((fc) => fc.filename).join(', ')}\n\n`;
+        // Include diffs for potentially relevant files (env files, config files, etc.)
+        // and a sample of other changes
+        const relevantPatterns = [
+            /\.env/i,
+            /config/i,
+            /example/i,
+            /sample/i,
+            /template/i,
+        ];
+        const relevantChanges = otherChanges.filter((fc) => relevantPatterns.some((pattern) => pattern.test(fc.filename)));
+        const otherSampleChanges = otherChanges
+            .filter((fc) => !relevantChanges.includes(fc))
+            .slice(0, 3); // Limit to avoid context overflow
+        const changesToShow = [...relevantChanges, ...otherSampleChanges];
+        for (const change of changesToShow) {
+            if (change.patch) {
+                codeContext += `**Changes in ${change.filename}:**
+\`\`\`diff
+${change.patch}
+\`\`\`
+
+`;
+            }
+        }
+        if (otherChanges.length > changesToShow.length) {
+            codeContext += `(${otherChanges.length - changesToShow.length} additional files changed but not shown)\n\n`;
+        }
+    }
+    if (!codeContext.includes('```')) {
+        codeContext = '(No code changes available)\n\n';
     }
     return `You are analyzing whether a code review comment has been addressed by subsequent code changes.
 
 **Review Thread Information:**
-- File: ${firstComment.path}
-- Line: ${firstComment.line || 'N/A'}
+- Comment Location: ${firstComment.path}:${firstComment.line || 'N/A'}
 - Thread has ${thread.comments.totalCount} comment(s)
 
 **Review Comments:**
@@ -47,21 +89,20 @@ ${allComments}
 ${codeContext}
 
 **Your Task:**
-Analyze whether the code changes adequately address the feedback in the review comments. You have access to:
-1. **The diff** showing what was changed
-2. **The complete file content** after changes for full context
+Analyze whether the code changes adequately address the feedback in the review comments.
 
-Consider:
-1. Does the feedback request a specific code change?
-2. Have those changes (or equivalent changes) been made?
-3. If the feedback points to a specific line, use the full file content to understand the broader context
-4. Check if related areas of code were modified to address the concern
-5. Use the complete file to verify the fix is properly integrated
+**IMPORTANT - Cross-File Requests:**
+- A comment on file A may request changes to file B (e.g., "add this to the env example file")
+- The comment may use variable names (like "clientId") that differ from the actual environment variable names (like "SPOKE_CLIENT_ID")
+- Focus on whether the **intent** of the feedback was addressed, regardless of which file was modified
+- Check ALL changed files, not just the file where the comment was made
 
-**Important:**
-- The comment may point to a specific line, but the fix might be in nearby code
-- Focus on whether the **underlying issue** was addressed, not just whether that exact line was modified
-- Use the full file content to understand the complete context and verify the implementation
+Consider:
+1. Does the feedback request a specific code change? What is the **intent**?
+2. Have those changes (or equivalent changes) been made in ANY file?
+3. If the comment mentions adding something to a config/env file, check if those files were modified
+4. Variable names in comments may not match actual implementation names
+5. Focus on whether the underlying issue was addressed, not literal string matching
 
 Return your analysis in this JSON format:
 \`\`\`json
@@ -72,9 +113,8 @@ Return your analysis in this JSON format:
 \`\`\`
 
 Example responses:
-- If a comment says "add null check" and the code shows a null check was added: {"isAddressed": true, "reason": "Null check added in the updated code"}
-- If a comment suggests a refactor but no relevant changes are visible: {"isAddressed": false, "reason": "No refactoring changes visible in diff or file content"}
-- If code was modified in related areas addressing the concern: {"isAddressed": true, "reason": "Related code modified to address the concern"}
-- If the full context shows the issue is resolved differently: {"isAddressed": true, "reason": "Issue resolved through alternative implementation visible in full file"}
+- {"isAddressed": true, "reason": "Null check added in the updated code"}
+- {"isAddressed": false, "reason": "No relevant changes found to address the feedback"}
+- {"isAddressed": true, "reason": "Requested changes made in the appropriate file"}
 `;
 }

package/dist/phases/pull-request/creator.js

@@ -4,6 +4,19 @@
  */
 import { Octokit } from '@octokit/rest';
 import { execSync } from 'child_process';
+// GitHub PR title best practice: keep under 72 characters
+const MAX_PR_TITLE_LENGTH = 72;
+const PR_TITLE_PREFIX = 'feat: ';
+const MAX_FEATURE_NAME_LENGTH = MAX_PR_TITLE_LENGTH - PR_TITLE_PREFIX.length;
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 /**
  * Get current Git branch name
  */
@@ -108,12 +121,14 @@ const switchToMainBranch = (mainBranch = 'main', verbose) => {
 };
 /**
  * Generate pull request title from feature name
+ * Truncates to keep under 72 characters (GitHub best practice)
  */
 const generatePRTitle = (featureName) => {
     // Remove feature ID prefix if present (e.g., "FEAT-123: Feature Name" -> "Feature Name")
     const cleanName = featureName.replace(/^[A-Z]+-\d+:\s*/, '');
-    // Convert to lowercase for conventional commits format
-    return `feat: ${cleanName.toLowerCase()}`;
+    // Truncate to keep total title under 72 chars
+    const truncatedName = truncateText(cleanName.toLowerCase(), MAX_FEATURE_NAME_LENGTH);
+    return `${PR_TITLE_PREFIX}${truncatedName}`;
 };
 /**
  * Check if a pull request already exists from head to base

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.21.1",
+  "version": "0.21.3",
   "type": "module",
   "bin": {
     "edsger": "dist/index.js"

package/.claude/settings.local.json

@@ -1,28 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Read(//Users/steven/development/edsger/**)",
-      "Bash(npm run build)",
-      "Bash(node:*)",
-      "Bash(git add:*)",
-      "Bash(git commit:*)",
-      "Bash(ls:*)",
-      "Bash(cat:*)",
-      "Bash(npm run typecheck:*)",
-      "Bash(git diff:*)",
-      "WebSearch",
-      "WebFetch(domain:supabase.com)",
-      "Bash(npm install:*)",
-      "Bash(grep:*)",
-      "Bash(npx supabase gen types typescript --help:*)",
-      "Bash(git -C /Users/steven/development/edsger status)",
-      "Bash(git -C /Users/steven/development/edsger diff)",
-      "Bash(git -C /Users/steven/development/edsger log --oneline -5)",
-      "Bash(git -C /Users/steven/development/edsger add supabase/migrations/20251231000000_drop_unused_views.sql)",
-      "Bash(git -C /Users/steven/development/edsger commit -m \"$\\(cat <<''EOF''\nchore: drop unused database views\n\nRemove test_report_summary and user_stories_with_context views that are defined but never used in the application.\n\n🤖 Generated with [Claude Code]\\(https://claude.com/claude-code\\)\n\nCo-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>\nEOF\n\\)\")",
-      "Bash(git -C /Users/steven/development/edsger commit -m \"$\\(cat <<''EOF''\nchore: drop unused database views\n\nRemove test_report_summary and user_stories_with_context views\nthat are defined but never used in the application.\n\n🤖 Generated with [Claude Code]\\(https://claude.com/claude-code\\)\n\nCo-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>\nEOF\n\\)\")"
-    ],
-    "deny": [],
-    "ask": []
-  }
-}

package/.env.local

@@ -1,12 +0,0 @@
-OPENAI_API_KEY=
-TRIGGER_SECRET_KEY=
-RECALL_AI_API_KEY=
-RECALL_WEBHOOK_SECRET=
-NEXT_PUBLIC_APP_URL=
-RESEND_API_KEY=
-EMAIL_FROM=
-GITHUB_APP_ID=
-GITHUB_APP_PRIVATE_KEY=
-GITHUB_APP_SLUG=
-DEEPGRAM_API_KEY=
-DEEPGRAM_PROJECT_ID=

package/dist/api/features/__tests__/regression-prevention.test.d.ts

@@ -1,5 +0,0 @@
-/**
- * Specialized tests for status regression prevention
- * Focuses on the core business requirement: preventing backward status movement
- */
-export {};