edsger 0.21.0 → 0.21.2

package/dist/phases/code-implementation/branch-pr-creator.js

@@ -5,6 +5,19 @@
 import { Octokit } from '@octokit/rest';
 import { execSync } from 'child_process';
 import { logInfo, logError } from '../../utils/logger.js';
+// GitHub PR title best practice: keep under 72 characters
+const MAX_PR_TITLE_LENGTH = 72;
+const PR_TITLE_PREFIX = 'feat: ';
+const MAX_FEATURE_NAME_LENGTH = MAX_PR_TITLE_LENGTH - PR_TITLE_PREFIX.length;
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 /**
  * Convert a feat/ branch name to a dev/ branch name
  * e.g., "feat/abc123/1-database" -> "dev/abc123/1-database"
@@ -142,8 +155,9 @@ export async function createBranchPullRequest(config, devBranchName, featureName
                 pullRequestNumber: existingPR.number,
             };
         }
-        // Generate PR title and body
-        const title = `feat: ${featureName}`;
+        // Generate PR title and body (truncate to keep under 72 chars)
+        const truncatedName = truncateText(featureName, MAX_FEATURE_NAME_LENGTH);
+        const title = `${PR_TITLE_PREFIX}${truncatedName}`;
         const body = `## Branch Implementation
 
 ${branchDescription}

package/dist/phases/code-implementation/index.js

@@ -10,6 +10,16 @@ import { prepareCustomBranchGitEnvironment, syncFeatBranchWithMain, } from '../.
 import { getCurrentBranch, updateBranch, getBranches, createBranches, getBaseBranchInfo, } from '../../services/branches.js';
 import { createBranchPullRequest, } from './branch-pr-creator.js';
 import { getGitHubConfig } from '../../api/github.js';
+import { getFeature } from '../../api/features/index.js';
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 function userMessage(content) {
     return {
         type: 'user',
@@ -50,11 +60,25 @@ export const implementFeatureCode = async (options, config, checklistContext) =>
             if (verbose) {
                 logInfo(`📋 Creating default branch record for feature: ${featureId}`);
             }
+            // Fetch feature info to get the feature name for branch naming
+            let featureName = 'Feature Implementation';
+            try {
+                const featureInfo = await getFeature(featureId, verbose);
+                if (featureInfo?.name) {
+                    // Truncate feature name for branch display (max 100 chars)
+                    featureName = truncateText(featureInfo.name, 100);
+                }
+            }
+            catch (error) {
+                if (verbose) {
+                    logInfo(`Could not fetch feature name, using default: ${error}`);
+                }
+            }
             const defaultBranchName = `dev/${featureId}`;
             const createdBranches = await createBranches({ featureId, verbose }, [
                 {
-                    name: 'Main Implementation',
-                    description: 'Default branch for feature implementation',
+                    name: featureName,
+                    description: `Implementation branch for: ${featureName}`,
                     branch_name: defaultBranchName,
                     status: 'pending',
                 },

package/dist/phases/pull-request/creator.js

@@ -4,6 +4,19 @@
  */
 import { Octokit } from '@octokit/rest';
 import { execSync } from 'child_process';
+// GitHub PR title best practice: keep under 72 characters
+const MAX_PR_TITLE_LENGTH = 72;
+const PR_TITLE_PREFIX = 'feat: ';
+const MAX_FEATURE_NAME_LENGTH = MAX_PR_TITLE_LENGTH - PR_TITLE_PREFIX.length;
+/**
+ * Truncate text to a maximum length, adding ellipsis if truncated
+ */
+function truncateText(text, maxLength) {
+    if (text.length <= maxLength) {
+        return text;
+    }
+    return text.slice(0, maxLength - 3) + '...';
+}
 /**
  * Get current Git branch name
  */
@@ -108,12 +121,14 @@ const switchToMainBranch = (mainBranch = 'main', verbose) => {
 };
 /**
  * Generate pull request title from feature name
+ * Truncates to keep under 72 characters (GitHub best practice)
  */
 const generatePRTitle = (featureName) => {
     // Remove feature ID prefix if present (e.g., "FEAT-123: Feature Name" -> "Feature Name")
     const cleanName = featureName.replace(/^[A-Z]+-\d+:\s*/, '');
-    // Convert to lowercase for conventional commits format
-    return `feat: ${cleanName.toLowerCase()}`;
+    // Truncate to keep total title under 72 chars
+    const truncatedName = truncateText(cleanName.toLowerCase(), MAX_FEATURE_NAME_LENGTH);
+    return `${PR_TITLE_PREFIX}${truncatedName}`;
 };
 /**
  * Check if a pull request already exists from head to base

package/dist/phases/pull-request/handler.js

@@ -4,7 +4,6 @@
 import { getFeature } from '../../api/features/index.js';
 import { getGitHubConfig } from '../../api/github.js';
 import { createPullRequest } from './creator.js';
-import { logFeaturePhaseEvent } from '../../services/audit-logs.js';
 import { getCurrentBranch, updateBranch, } from '../../services/branches.js';
 /**
  * Create pull request for successful feature implementation
@@ -14,33 +13,12 @@ export async function handlePullRequestCreation({ featureId, results, testingRes
     if (verbose) {
         console.log('🔄 Creating pull request for successful feature...');
     }
-    // Log phase start
-    await logFeaturePhaseEvent({
-        featureId,
-        eventType: 'phase_started',
-        phase: 'pull_request',
-        result: 'info',
-        metadata: {
-            timestamp: new Date().toISOString(),
-        },
-    }, verbose);
     // Get feature details for PR creation
     const feature = await getFeature(featureId, verbose);
     if (!feature) {
         if (verbose) {
             console.log('⚠️ Could not fetch feature details for pull request creation');
         }
-        // Log phase failure
-        await logFeaturePhaseEvent({
-            featureId,
-            eventType: 'phase_failed',
-            phase: 'pull_request',
-            result: 'error',
-            errorMessage: 'Could not fetch feature details',
-            metadata: {
-                timestamp: new Date().toISOString(),
-            },
-        }, verbose);
         return false;
     }
     // Get current branch for the feature
@@ -59,20 +37,6 @@ export async function handlePullRequestCreation({ featureId, results, testingRes
             console.log(`ℹ️ Pull request already exists: ${currentBranch.pull_request_url}`);
             console.log('✅ Skipping PR creation, using existing pull request');
         }
-        // Log phase completion with existing PR
-        await logFeaturePhaseEvent({
-            featureId,
-            eventType: 'phase_completed',
-            phase: 'pull_request',
-            result: 'success',
-            metadata: {
-                pull_request_url: currentBranch.pull_request_url,
-                branch_id: currentBranch.id,
-                skipped: true,
-                reason: 'Pull request already exists',
-                timestamp: new Date().toISOString(),
-            },
-        }, verbose);
         return true;
     }
     // Get GitHub configuration from product developer settings
@@ -85,17 +49,6 @@ export async function handlePullRequestCreation({ featureId, results, testingRes
             console.log('⚠️ GitHub configuration not found. Skipping pull request creation.');
             console.log(`   ${githubConfig.message || 'Please configure a developer with GitHub App installation in the product settings.'}`);
         }
-        // Log phase failure
-        await logFeaturePhaseEvent({
-            featureId,
-            eventType: 'phase_failed',
-            phase: 'pull_request',
-            result: 'error',
-            errorMessage: githubConfig.message || 'GitHub configuration not found',
-            metadata: {
-                timestamp: new Date().toISOString(),
-            },
-        }, verbose);
         return false;
     }
     const { token: githubToken, owner: githubOwner, repo: githubRepo, } = githubConfig;
@@ -141,19 +94,6 @@ export async function handlePullRequestCreation({ featureId, results, testingRes
                 }
             }
         }
-        // Log phase completion
-        await logFeaturePhaseEvent({
-            featureId,
-            eventType: 'phase_completed',
-            phase: 'pull_request',
-            result: 'success',
-            metadata: {
-                pull_request_url: prResult.pullRequestUrl,
-                pull_request_number: prResult.pullRequestNumber,
-                branch_id: currentBranch?.id,
-                timestamp: new Date().toISOString(),
-            },
-        }, verbose);
         if (verbose) {
             console.log(`✅ Pull request created${currentBranch ? ' and branch updated' : ''}`);
         }
@@ -163,17 +103,6 @@ export async function handlePullRequestCreation({ featureId, results, testingRes
         if (verbose) {
             console.log(`⚠️ Pull request creation failed: ${prResult.error}`);
         }
-        // Log phase failure
-        await logFeaturePhaseEvent({
-            featureId,
-            eventType: 'phase_failed',
-            phase: 'pull_request',
-            result: 'error',
-            errorMessage: prResult.error,
-            metadata: {
-                timestamp: new Date().toISOString(),
-            },
-        }, verbose);
         return false;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.21.0",
+  "version": "0.21.2",
   "type": "module",
   "bin": {
     "edsger": "dist/index.js"