edsger 0.2.11 → 0.2.13

package/dist/phases/technical-design/analyzer.js

@@ -168,20 +168,54 @@ async function prepareDesignContext(mcpServerUrl, mcpToken, featureId, checklist
     }
     // Add feedbacks context to the design prompt
     try {
+        if (verbose) {
+            logInfo(`🔍 Fetching feedbacks from MCP: ${mcpServerUrl}/mcp (phase: technical-design)`);
+        }
         feedbacksContext = await getFeedbacksForPhase({ featureId, mcpServerUrl, mcpToken, verbose }, 'technical-design');
+        if (verbose) {
+            logInfo(`📋 Feedbacks fetched successfully: ${feedbacksContext.feedbacks.length} feedbacks found`);
+            if (feedbacksContext.feedbacks.length > 0) {
+                logInfo('📝 Feedbacks details:');
+                feedbacksContext.feedbacks.forEach((fb, idx) => {
+                    logInfo(`   ${idx + 1}. [${fb.feedback_type}] ${fb.title} (priority: ${fb.priority}, resolved: ${fb.is_resolved || false})`);
+                    logInfo(`      Content: ${fb.content.substring(0, 150)}...`);
+                    if (fb.reference_section) {
+                        logInfo(`      Section: ${fb.reference_section}`);
+                    }
+                    if (fb.reference_line_start) {
+                        const lineInfo = fb.reference_line_end
+                            ? `Lines ${fb.reference_line_start}-${fb.reference_line_end}`
+                            : `Line ${fb.reference_line_start}`;
+                        logInfo(`      Location: ${lineInfo}`);
+                    }
+                    if (fb.reference_content) {
+                        logInfo(`      Referenced: ${fb.reference_content.substring(0, 100)}...`);
+                    }
+                });
+            }
+        }
         if (feedbacksContext.feedbacks.length > 0) {
             hasFeedbacks = true;
             const feedbacksInfo = formatFeedbacksForContext(feedbacksContext);
             finalContextInfo = finalContextInfo + '\n\n' + feedbacksInfo;
             if (verbose) {
-                logInfo(`Added ${feedbacksContext.feedbacks.length} human feedbacks to design context`);
+                logInfo(`✅ Added ${feedbacksContext.feedbacks.length} human feedbacks to design context`);
+                logInfo(`📄 Feedbacks section length: ${feedbacksInfo.length} characters`);
+            }
+        }
+        else {
+            if (verbose) {
+                logInfo('ℹ️  No unresolved feedbacks found for this phase');
             }
         }
     }
     catch (error) {
         // Don't fail if feedbacks fetch fails - just log and continue
         if (verbose) {
-            logInfo(`Note: Could not fetch feedbacks (${error instanceof Error ? error.message : String(error)})`);
+            logError(`❌ Failed to fetch feedbacks: ${error instanceof Error ? error.message : String(error)}`);
+            if (error instanceof Error && error.stack) {
+                logError(`   Stack: ${error.stack}`);
+            }
         }
     }
     // Add checklist context to the design prompt

package/dist/services/feedbacks.d.ts

@@ -4,7 +4,7 @@
  */
 import { PipelinePhaseOptions } from '../types/pipeline.js';
 export type { PipelinePhaseOptions };
-export type FeedbackType = 'requirement' | 'constraint' | 'preference' | 'context' | 'quality_criteria';
+export type FeedbackType = 'requirement' | 'constraint' | 'preference' | 'context' | 'quality_criteria' | 'issue' | 'suggestion';
 export interface Feedback {
     id: string;
     feature_id: string | null;
@@ -15,9 +15,16 @@ export interface Feedback {
     content: string;
     priority: number;
     is_active: boolean;
+    is_resolved?: boolean;
+    resolved_at?: string | null;
+    resolved_by?: string | null;
     created_by: string;
     created_at: string;
     updated_at: string;
+    reference_line_start?: number | null;
+    reference_line_end?: number | null;
+    reference_section?: string | null;
+    reference_content?: string | null;
 }
 export interface FeedbacksContext {
     phase: string;

package/dist/services/feedbacks.js

@@ -11,8 +11,19 @@ export async function getFeedbacksForPhase(options, phase) {
     // Convert phase name from hyphen to underscore format for database compatibility
     // e.g., 'feature-analysis' -> 'feature_analysis'
     const dbPhase = phase.replace(/-/g, '_');
+    const requestBody = {
+        jsonrpc: '2.0',
+        id: 1,
+        method: 'feedbacks/get',
+        params: {
+            feature_id: featureId,
+            phase: dbPhase,
+        },
+    };
     if (verbose) {
         console.log(`🔍 Fetching feedbacks: phase="${phase}" (db: "${dbPhase}"), feature_id="${featureId}"`);
+        console.log(`📡 MCP URL: ${mcpServerUrl}/mcp`);
+        console.log(`📦 Request body:`, JSON.stringify(requestBody, null, 2));
     }
     const response = await fetch(`${mcpServerUrl}/mcp`, {
         method: 'POST',
@@ -20,32 +31,42 @@ export async function getFeedbacksForPhase(options, phase) {
             'Content-Type': 'application/json',
             Authorization: `Bearer ${mcpToken}`,
         },
-        body: JSON.stringify({
-            jsonrpc: '2.0',
-            id: 1,
-            method: 'feedbacks/get',
-            params: {
-                feature_id: featureId,
-                phase: dbPhase,
-            },
-        }),
+        body: JSON.stringify(requestBody),
     });
+    if (verbose) {
+        console.log(`📥 Response status: ${response.status} ${response.statusText}`);
+    }
     if (!response.ok) {
         const errorText = await response.text();
+        if (verbose) {
+            console.log(`❌ Response error body:`, errorText);
+        }
         throw new Error(`Failed to fetch feedbacks for phase "${phase}": ${response.status} ${response.statusText}. Response: ${errorText}`);
     }
     const data = await response.json();
+    if (verbose) {
+        console.log(`📋 MCP response:`, JSON.stringify(data, null, 2));
+    }
     if (data.error) {
+        if (verbose) {
+            console.log(`❌ MCP error:`, data.error);
+        }
         throw new Error(`MCP Error for phase "${phase}": ${data.error.message || JSON.stringify(data.error)}`);
     }
     // Handle empty result gracefully
     if (!data.result) {
+        if (verbose) {
+            console.log(`⚠️  Empty result from MCP, returning empty feedbacks array`);
+        }
         return {
             phase,
             feature_id: featureId,
             feedbacks: [],
         };
     }
+    if (verbose) {
+        console.log(`✅ Successfully fetched ${data.result.feedbacks?.length || 0} feedbacks`);
+    }
     return data.result;
 }
 /**
@@ -78,6 +99,14 @@ export function formatFeedbacksForContext(context) {
     if (grouped.quality_criteria && grouped.quality_criteria.length > 0) {
         sections.push(`## ✅ Quality Criteria\n\n${formatFeedbacksList(grouped.quality_criteria)}`);
     }
+    // Issues
+    if (grouped.issue && grouped.issue.length > 0) {
+        sections.push(`## 🐛 Issues to Address\n\n${formatFeedbacksList(grouped.issue)}`);
+    }
+    // Suggestions
+    if (grouped.suggestion && grouped.suggestion.length > 0) {
+        sections.push(`## 💭 Suggestions\n\n${formatFeedbacksList(grouped.suggestion)}`);
+    }
     const phaseDisplay = context.phase.replace(/_/g, '-');
     return `
 ---
@@ -109,7 +138,21 @@ function formatFeedbacksList(feedbacks) {
     return sorted
         .map((feedback, idx) => {
         const priorityBadge = getPriorityBadge(feedback.priority);
-        return `### ${idx + 1}. ${feedback.title} ${priorityBadge}\n\n${feedback.content}\n`;
+        // Build reference info if available
+        let referenceInfo = '';
+        if (feedback.reference_section) {
+            referenceInfo += `\n**Reference Section**: ${feedback.reference_section}`;
+        }
+        if (feedback.reference_line_start) {
+            const lineRange = feedback.reference_line_end
+                ? `Lines ${feedback.reference_line_start}-${feedback.reference_line_end}`
+                : `Line ${feedback.reference_line_start}`;
+            referenceInfo += `\n**Reference Location**: ${lineRange}`;
+        }
+        if (feedback.reference_content) {
+            referenceInfo += `\n**Referenced Content**:\n\`\`\`\n${feedback.reference_content}\n\`\`\``;
+        }
+        return `### ${idx + 1}. ${feedback.title} ${priorityBadge}\n\n${feedback.content}${referenceInfo}\n`;
     })
         .join('\n');
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edsger",
-  "version": "0.2.11",
+  "version": "0.2.13",
   "type": "module",
   "main": "dist/index.js",
   "bin": {