edinburgh 0.1.3 → 0.3.0

package/build/src/indexes.js

@@ -1,11 +1,9 @@
 import * as olmdb from "olmdb";
 import { DatabaseError } from "olmdb";
-import { Bytes } from "./bytes.js";
-import { getMockModel, modelRegistry } from "./models.js";
-import { assert, logLevel } from "./utils.js";
+import { DataPack } from "./datapack.js";
+import { getMockModel } from "./models.js";
+import { assert, logLevel, delayedInits, tryDelayedInits } from "./utils.js";
 import { deserializeType, serializeType } from "./types.js";
-/** @internal Symbol used to access the underlying model from a proxy */
-export const TARGET_SYMBOL = Symbol('target');
 const MAX_INDEX_ID_PREFIX = -1;
 const INDEX_ID_PREFIX = -2;
 /**
@@ -13,7 +11,7 @@ const INDEX_ID_PREFIX = -2;
  * Handles common iteration logic for both primary and unique indexes.
  * Implements both Iterator and Iterable interfaces for efficiency.
  */
-class IndexRangeIterator {
+export class IndexRangeIterator {
     iterator;
     indexId;
     parentIndex;
@@ -34,11 +32,11 @@ class IndexRangeIterator {
             return { done: true, value: undefined };
         }
         // Extract the key without the index ID
-        const keyBytes = new Bytes(entry.value.key);
+        const keyBytes = new DataPack(entry.value.key);
         const entryIndexId = keyBytes.readNumber();
         assert(entryIndexId === this.indexId);
         // Use polymorphism to get the model from the entry
-        const model = this.parentIndex._getModelFromEntry(keyBytes, new Bytes(entry.value.value));
+        const model = this.parentIndex._pairToInstance(keyBytes, entry.value.value);
         if (!model) {
             // This shouldn't happen, but skip if it does
             return this.next();
@@ -57,6 +55,47 @@ class IndexRangeIterator {
         }
     }
 }
+const canonicalUint8Arrays = new Map();
+export function testArraysEqual(array1, array2) {
+    if (array1.length !== array2.length)
+        return false;
+    for (let i = 0; i < array1.length; i++) {
+        if (array1[i] !== array2[i])
+            return false;
+    }
+    return true;
+}
+/**
+ * Get a singleton instance of a Uint8Array containing the given data.
+ * @param data - The Uint8Array to canonicalize.
+ * @returns A unique Uint8Array, backed by a right-sized copy of the ArrayBuffer.
+ */
+function getSingletonUint8Array(data) {
+    let hash = 5381, reclaimHash;
+    for (const byte of data) {
+        hash = ((hash << 5) + hash + byte) >>> 0;
+    }
+    while (true) {
+        let weakRef = canonicalUint8Arrays.get(hash);
+        if (!weakRef)
+            break;
+        if (weakRef) {
+            const orgData = weakRef.deref();
+            if (!orgData) { // weakRef expired
+                if (reclaimHash === undefined)
+                    reclaimHash = hash;
+            }
+            else if (data === orgData || testArraysEqual(data, orgData)) {
+                return orgData;
+            }
+            // else: hash collision, use open addressing
+        }
+        hash = (hash + 1) >>> 0;
+    }
+    let copy = data.slice(); // Make a copy, backed by a new, correctly sized ArrayBuffer
+    canonicalUint8Arrays.set(reclaimHash === undefined ? hash : reclaimHash, new WeakRef(copy));
+    return copy;
+}
 /**
  * Base class for database indexes for efficient lookups on model fields.
  *
@@ -68,93 +107,61 @@ class IndexRangeIterator {
 export class BaseIndex {
     _fieldNames;
     _MyModel;
+    _fieldTypes = new Map();
+    _fieldCount;
     /**
      * Create a new index.
      * @param MyModel - The model class this index belongs to.
      * @param _fieldNames - Array of field names that make up this index.
      */
-    constructor(MyModel, _fieldNames, isPrimary = false) {
+    constructor(MyModel, _fieldNames) {
         this._fieldNames = _fieldNames;
-        this._MyModel = MyModel = getMockModel(MyModel);
-        // The primary key should be [0] in _indexes
-        (MyModel._indexes ||= [])[isPrimary ? 'unshift' : 'push'](this);
+        this._MyModel = getMockModel(MyModel);
+        delayedInits.add(this);
+        tryDelayedInits();
     }
-    _cachedIndexId;
-    /**
-     * Deserialize index key bytes back to field values.
-     * @param bytes - Bytes to read from.
-     * @returns Array of field values.
-     */
-    _deserializeKey(bytes) {
-        const result = [];
-        for (let i = 0; i < this._fieldNames.length; i++) {
-            const fieldName = this._fieldNames[i];
-            const fieldConfig = this._MyModel.fields[fieldName];
-            fieldConfig.type.deserialize(result, i, bytes);
+    _delayedInit() {
+        if (!this._MyModel.fields)
+            return false; // Awaiting model init
+        for (const fieldName of this._fieldNames) {
+            assert(typeof fieldName === 'string', 'Field names must be strings');
+            this._fieldTypes.set(fieldName, this._MyModel.fields[fieldName].type);
         }
-        return result;
+        this._fieldCount = this._fieldNames.length;
+        return true;
     }
-    /**
-     * Serialize field values to bytes for index key.
-     * @param args - Field values to serialize (can be partial for range queries).
-     * @param bytes - Bytes to write to.
-     * @internal
-     */
-    _serializeArgs(args, bytes) {
-        const argsArray = Array.isArray(args) ? args : Object.values(args);
-        assert(argsArray.length <= this._fieldNames.length);
-        for (let i = 0; i < argsArray.length; i++) {
-            const fieldName = this._fieldNames[i];
-            const fieldConfig = this._MyModel.fields[fieldName];
-            fieldConfig.type.validateAndSerialize(argsArray, i, bytes);
+    _cachedIndexId;
+    _argsToKeyBytes(args, allowPartial) {
+        assert(allowPartial ? args.length <= this._fieldCount : args.length === this._fieldCount);
+        const bytes = new DataPack();
+        bytes.write(this._getIndexId());
+        let index = 0;
+        for (const fieldType of this._fieldTypes.values()) {
+            // For partial keys, undefined values are acceptable and represent open range suffixes
+            if (index >= args.length)
+                break;
+            fieldType.serialize(args[index++], bytes);
         }
+        return bytes;
     }
-    /**
-     * Create database key from field values.
-     * @param args - Field values.
-     * @returns Database key bytes.
-     */
-    _getKeyFromArgs(args) {
-        assert(args.length === this._fieldNames.length);
-        let indexId = this._getIndexId();
-        let keyBytes = new Bytes().writeNumber(indexId);
-        this._serializeArgs(args, keyBytes);
-        return keyBytes.getBuffer();
+    _argsToKeySingleton(args) {
+        const bytes = this._argsToKeyBytes(args, false);
+        return getSingletonUint8Array(bytes.toUint8Array());
     }
-    /**
-     * Serialize model fields to bytes for index key.
-     * @param model - Model instance.
-     * @param bytes - Bytes to write to.
-     */
-    _serializeModel(model, bytes) {
-        for (let i = 0; i < this._fieldNames.length; i++) {
-            const fieldName = this._fieldNames[i];
-            const fieldConfig = this._MyModel.fields[fieldName];
-            fieldConfig.type.validateAndSerialize(model, fieldName, bytes, model);
+    _hasNullIndexValues(model) {
+        for (const fieldName of this._fieldTypes.keys()) {
+            if (model[fieldName] == null)
+                return true;
         }
+        return false;
     }
-    /**
-     * Create database key from model instance.
-     * @param model - Model instance.
-     * @param includeIndexId - Whether to include index ID in key.
-     * @returns Database key bytes or undefined if skipped.
-     * @internal
-     */
-    _getKeyFromModel(model, includeIndexId) {
-        const bytes = new Bytes();
-        if (includeIndexId)
-            bytes.writeNumber(this._getIndexId());
-        this._serializeModel(model, bytes);
-        return bytes.getBuffer();
-    }
-    /**
-     * Extract field values from model for this index.
-     * @param model - Model instance.
-     * @returns Field values or undefined if should be skipped.
-     * @internal
-     */
-    _modelToArgs(model) {
-        return this._checkSkip(model) ? undefined : this._fieldNames.map((fieldName) => model[fieldName]);
+    _instanceToKeyBytes(model) {
+        const bytes = new DataPack();
+        bytes.write(this._getIndexId());
+        for (const [fieldName, fieldType] of this._fieldTypes.entries()) {
+            fieldType.serialize(model[fieldName], bytes);
+        }
+        return bytes;
     }
     /**
      * Get or create unique index ID for this index.
@@ -164,47 +171,34 @@ export class BaseIndex {
         // Resolve an index to a number
         let indexId = this._cachedIndexId;
         if (indexId == null) {
-            const indexNameBytes = new Bytes().writeNumber(INDEX_ID_PREFIX).writeString(this._MyModel.tableName).writeString(this._getTypeName());
+            const indexNameBytes = new DataPack().write(INDEX_ID_PREFIX).write(this._MyModel.tableName).write(this._getTypeName());
             for (let name of this._fieldNames) {
-                indexNameBytes.writeString(name);
+                indexNameBytes.write(name);
                 serializeType(this._MyModel.fields[name].type, indexNameBytes);
             }
-            const indexNameBuf = indexNameBytes.getBuffer();
+            const indexNameBuf = indexNameBytes.toUint8Array();
             let result = olmdb.get(indexNameBuf);
             if (result) {
-                indexId = this._cachedIndexId = new Bytes(result).readNumber();
+                indexId = this._cachedIndexId = new DataPack(result).readNumber();
             }
             else {
-                const maxIndexIdBuf = new Bytes().writeNumber(MAX_INDEX_ID_PREFIX).getBuffer();
+                const maxIndexIdBuf = new DataPack().write(MAX_INDEX_ID_PREFIX).toUint8Array();
                 result = olmdb.get(maxIndexIdBuf);
-                indexId = result ? new Bytes(result).readNumber() + 1 : 1;
+                indexId = result ? new DataPack(result).readNumber() + 1 : 1;
                 olmdb.onCommit(() => {
                     // Only if the transaction succeeds can we cache this id
                     this._cachedIndexId = indexId;
                 });
-                const idBuf = new Bytes().writeNumber(indexId).getBuffer();
+                const idBuf = new DataPack().write(indexId).toUint8Array();
                 olmdb.put(indexNameBuf, idBuf);
                 olmdb.put(maxIndexIdBuf, idBuf); // This will also cause the transaction to rerun if we were raced
                 if (logLevel >= 1) {
-                    console.log(`Created index ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] with id ${indexId}`);
+                    console.log(`Create ${this} with id ${indexId}`);
                 }
             }
         }
         return indexId;
     }
-    /**
-     * Check if indexing should be skipped for a model instance.
-     * @param model - Model instance.
-     * @returns true if indexing should be skipped.
-     */
-    _checkSkip(model) {
-        for (const fieldName of this._fieldNames) {
-            const fieldConfig = this._MyModel.fields[fieldName];
-            if (fieldConfig.type.checkSkipIndex(model, fieldName))
-                return true;
-        }
-        return false;
-    }
     /**
      * Find model instances using flexible range query options.
      *
@@ -265,51 +259,63 @@ export class BaseIndex {
      */
     find(opts = {}) {
         const indexId = this._getIndexId();
-        let startKey = new Bytes().writeNumber(indexId);
-        let endKey = startKey.copy();
+        let startKey;
+        let endKey;
         if ('is' in opts) {
-            // Exact match - set both start and end to the same value
-            this._serializeArgs(toArray(opts.is), startKey);
-            endKey = startKey.copy().increment();
+            // Exact match - set both 'from' and 'to' to the same value
+            startKey = this._argsToKeyBytes(toArray(opts.is), true);
+            endKey = startKey.clone(true).increment();
         }
         else {
             // Range query
             if ('from' in opts) {
-                this._serializeArgs(toArray(opts.from), startKey);
+                startKey = this._argsToKeyBytes(toArray(opts.from), true);
             }
             else if ('after' in opts) {
-                this._serializeArgs(toArray(opts.after), startKey);
+                startKey = this._argsToKeyBytes(toArray(opts.after), true);
                 if (!startKey.increment()) {
                     // There can be nothing 'after' - return an empty iterator
                     return new IndexRangeIterator(undefined, indexId, this);
                 }
             }
+            else {
+                // Open start: begin at first key for this index id
+                startKey = this._argsToKeyBytes([], true);
+            }
             if ('to' in opts) {
-                this._serializeArgs(toArray(opts.to), endKey);
-                endKey.increment();
+                endKey = this._argsToKeyBytes(toArray(opts.to), true).increment();
             }
             else if ('before' in opts) {
-                this._serializeArgs(toArray(opts.before), endKey);
+                endKey = this._argsToKeyBytes(toArray(opts.before), true);
             }
             else {
-                endKey = endKey.increment(); // Next indexId
+                // Open end: end at first key of the next index id
+                endKey = this._argsToKeyBytes([], true).increment(); // Next indexId
             }
         }
         // For reverse scans, swap start/end keys since OLMDB expects it
         const scanStart = opts.reverse ? endKey : startKey;
         const scanEnd = opts.reverse ? startKey : endKey;
+        if (logLevel >= 3) {
+            console.log(`Scan ${this} start=${scanStart} end=${scanEnd} reverse=${opts.reverse || false}`);
+        }
         const iterator = olmdb.scan({
-            start: scanStart?.getBuffer(),
-            end: scanEnd?.getBuffer(),
+            start: scanStart?.toUint8Array(),
+            end: scanEnd?.toUint8Array(),
             reverse: opts.reverse || false,
         });
         return new IndexRangeIterator(iterator, indexId, this);
     }
+    toString() {
+        return `${this._getIndexId()}:${this._MyModel.tableName}:${this._getTypeName()}[${Array.from(this._fieldTypes.keys()).join(',')}]`;
+    }
 }
 function toArray(args) {
-    // Use type assertion to satisfy TypeScript while maintaining runtime correctness
+    // Convert single value or array to array format compatible with Partial<ARG_TYPES>
     return (Array.isArray(args) ? args : [args]);
 }
+/** @internal Symbol used to attach modified instances, keyed by singleton primary key, to a transaction */
+export const INSTANCES_BY_PK_SYMBOL = Symbol('instances');
 /**
  * Primary index that stores the actual model data.
  *
@@ -317,12 +323,40 @@ function toArray(args) {
  * @template F - The field names that make up this index.
  */
 export class PrimaryIndex extends BaseIndex {
+    _nonKeyFields;
+    _lazyDescriptors = {};
+    _resetDescriptors = {};
     constructor(MyModel, fieldNames) {
-        super(MyModel, fieldNames, true);
-        if (MyModel._pk && MyModel._pk !== this) {
+        super(MyModel, fieldNames);
+        if (MyModel._primary) {
             throw new DatabaseError(`Model ${MyModel.tableName} already has a primary key defined`, 'INIT_ERROR');
         }
-        MyModel._pk = this;
+        MyModel._primary = this;
+    }
+    _delayedInit() {
+        if (!super._delayedInit())
+            return false;
+        const MyModel = this._MyModel;
+        this._nonKeyFields = Object.keys(MyModel.fields).filter(fieldName => !this._fieldNames.includes(fieldName));
+        for (const fieldName of this._nonKeyFields) {
+            this._lazyDescriptors[fieldName] = {
+                configurable: true,
+                enumerable: true,
+                get() {
+                    this.constructor._primary._lazyNow(this);
+                    return this[fieldName];
+                },
+                set(value) {
+                    this.constructor._primary._lazyNow(this);
+                    this[fieldName] = value;
+                }
+            };
+            this._resetDescriptors[fieldName] = {
+                writable: true,
+                enumerable: true
+            };
+        }
+        return true;
     }
     /**
      * Get a model instance by primary key values.
@@ -335,85 +369,132 @@ export class PrimaryIndex extends BaseIndex {
      * ```
      */
     get(...args) {
-        let keyBuffer = this._getKeyFromArgs(args);
-        if (logLevel >= 3) {
-            console.log(`Getting primary ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] (id=${this._getIndexId()}) with key`, args, keyBuffer);
+        return this._get(args, false);
+    }
+    /**
+     * Does the same as as `get()`, but will delay loading the instance from disk until the first
+     * property access. In case it turns out the instance doesn't exist, an error will be thrown
+     * at that time.
+     * @param args Primary key field values. (Or a single Uint8Array containing the key.)
+     * @returns The (lazily loaded) model instance.
+     */
+    getLazy(...args) {
+        return this._get(args, true);
+    }
+    _get(args, lazy) {
+        let key, keyParts;
+        if (args.length === 1 && args[0] instanceof Uint8Array) {
+            key = getSingletonUint8Array(args[0]);
+        }
+        else {
+            key = this._argsToKeySingleton(args);
+            keyParts = args;
+        }
+        const cachedInstances = olmdb.getTransactionData(INSTANCES_BY_PK_SYMBOL);
+        const cached = cachedInstances.get(key);
+        if (cached)
+            return cached;
+        let valueBuffer;
+        if (!lazy) {
+            valueBuffer = olmdb.get(key);
+            if (logLevel >= 3) {
+                console.log(`Get ${this} key=${new DataPack(key)} result=${valueBuffer && new DataPack(valueBuffer)}`);
+            }
+            if (!valueBuffer)
+                return;
         }
-        let valueBuffer = olmdb.get(keyBuffer);
-        if (!valueBuffer)
-            return;
         // This is a primary index. So we can now deserialize all primary and non-primary fields into instance values.
         const model = new this._MyModel();
-        // We'll want to set all loaded values on the unproxied target object.
-        const unproxied = model[TARGET_SYMBOL];
-        unproxied._state = 2; // Loaded from disk, unmodified
-        const valueBytes = new Bytes(valueBuffer);
-        let primaryKeyIndex = 0;
-        for (const [fieldName, fieldConfig] of Object.entries(this._MyModel.fields)) {
-            if (this._fieldNames.includes(fieldName)) { // Value is part of primary key
-                unproxied[fieldName] = args[primaryKeyIndex];
-                primaryKeyIndex++;
+        // Store the canonical primary key on the model
+        model._primaryKey = key;
+        // Set the primary key fields on the model
+        if (keyParts) {
+            let index = 0;
+            for (const fieldName of this._fieldTypes.keys()) {
+                model._setLoadedField(fieldName, keyParts[index++]);
             }
-            else {
-                // We're passing in the proxied model
-                fieldConfig.type.deserialize(unproxied, fieldName, valueBytes, model);
+        }
+        else {
+            const bytes = new DataPack(key);
+            assert(bytes.readNumber() === this._MyModel._primary._getIndexId()); // Skip index id
+            for (const [fieldName, fieldType] of this._fieldTypes.entries()) {
+                model._setLoadedField(fieldName, fieldType.deserialize(bytes));
             }
         }
+        if (valueBuffer) {
+            // Set other fields
+            this._setNonKeyValues(model, new DataPack(valueBuffer));
+        }
+        else {
+            // Lazy - set getters for other fields
+            Object.defineProperties(model, this._lazyDescriptors);
+        }
+        cachedInstances.set(key, model);
         return model;
     }
     /**
-     * Extract model from iterator entry for primary index.
-     * @param keyBytes - Key bytes with index ID already read.
-     * @param valueBytes - Value bytes from the entry.
-     * @returns Model instance or undefined.
-     * @internal
+     * Create a canonical primary key buffer for the given model instance.
+     * Returns a singleton Uint8Array for stable Map/Set identity usage.
      */
-    _getModelFromEntry(keyBytes, valueBytes) {
+    _instanceToKeySingleton(model) {
+        const bytes = this._instanceToKeyBytes(model);
+        return getSingletonUint8Array(bytes.toUint8Array());
+    }
+    _lazyNow(model) {
+        let valueBuffer = olmdb.get(model._primaryKey);
+        if (logLevel >= 3) {
+            console.log(`Lazy retrieve ${this} key=${new DataPack(model._primaryKey)} result=${valueBuffer && new DataPack(valueBuffer)}`);
+        }
+        if (!valueBuffer)
+            throw new DatabaseError(`Lazy-loaded ${model.constructor.name}#${model._primaryKey} does not exist`, 'LAZY_FAIL');
+        Object.defineProperties(model, this._resetDescriptors);
+        this._setNonKeyValues(model, new DataPack(valueBuffer));
+    }
+    _setNonKeyValues(model, valueBytes) {
+        const fieldConfigs = this._MyModel.fields;
+        for (const fieldName of this._nonKeyFields) {
+            const value = fieldConfigs[fieldName].type.deserialize(valueBytes);
+            model._setLoadedField(fieldName, value);
+        }
+    }
+    _keyToArray(key) {
+        const bytes = new DataPack(key);
+        return this._fieldTypes.values().map((fieldType) => {
+            return fieldType.deserialize(bytes);
+        });
+    }
+    _pairToInstance(keyBytes, valueBuffer) {
+        const valueBytes = new DataPack(valueBuffer);
         const model = new this._MyModel();
-        // We'll want to set all loaded values on the unproxied target object.
-        const unproxied = model[TARGET_SYMBOL];
-        unproxied._state = 2; // Loaded from disk, unmodified
-        for (let i = 0; i < this._fieldNames.length; i++) {
-            const fieldName = this._fieldNames[i];
-            const fieldConfig = this._MyModel.fields[fieldName];
-            fieldConfig.type.deserialize(unproxied, fieldName, keyBytes);
-        }
-        for (const [fieldName, fieldConfig] of Object.entries(this._MyModel.fields)) {
-            if (this._fieldNames.includes(fieldName))
-                continue; // Value is part of primary key
-            // We're passing in the proxied model
-            fieldConfig.type.deserialize(unproxied, fieldName, valueBytes, model);
+        for (const [fieldName, fieldType] of this._fieldTypes.entries()) {
+            model._setLoadedField(fieldName, fieldType.deserialize(keyBytes));
         }
+        model._primaryKey = getSingletonUint8Array(keyBytes.toUint8Array());
+        this._setNonKeyValues(model, valueBytes);
         return model;
     }
-    /**
-     * Save primary index entry.
-     * @param model - Model instance.
-     * @param originalKey - Original key if updating.
-     */
-    _save(model, originalKey) {
-        // Note: this can (and usually will) be called on the non-proxied model instance.
-        assert(this._MyModel.prototype === model.constructor.prototype);
-        let newKey = this._getKeyFromModel(model, true);
-        if (originalKey && Buffer.compare(newKey, originalKey))
-            throw new DatabaseError(`Cannot change primary key for ${this._MyModel.tableName}[${this._fieldNames.join(', ')}]: ${originalKey} -> ${newKey}`, 'PRIMARY_CHANGE');
-        // Serialize all non-primary key fields
-        let valBytes = new Bytes();
-        for (const [fieldName, fieldConfig] of Object.entries(model._fields)) {
-            if (!this._fieldNames.includes(fieldName)) {
-                fieldConfig.type.validateAndSerialize(model, fieldName, valBytes, model);
-            }
+    _getTypeName() {
+        return 'primary';
+    }
+    _write(model) {
+        let valueBytes = new DataPack();
+        const fieldConfigs = this._MyModel.fields;
+        for (const fieldName of this._nonKeyFields) {
+            const fieldConfig = fieldConfigs[fieldName];
+            fieldConfig.type.serialize(model[fieldName], valueBytes);
         }
-        olmdb.put(newKey, valBytes.getBuffer());
         if (logLevel >= 2) {
-            const keyBytes = new Bytes(newKey);
-            let indexId = keyBytes.readNumber();
-            console.log(`Saved primary ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] (id=${indexId}) with key`, this._deserializeKey(keyBytes), keyBytes.getBuffer());
+            console.log(`Write ${this} key=${new DataPack(model._getCreatePrimaryKey())} value=${valueBytes}`);
         }
-        return newKey;
+        olmdb.put(model._getCreatePrimaryKey(), valueBytes.toUint8Array());
     }
-    _getTypeName() {
-        return 'primary';
+    _delete(model) {
+        if (model._primaryKey) {
+            if (logLevel >= 2) {
+                console.log(`Delete ${this} key=${new DataPack(model._primaryKey)}`);
+            }
+            olmdb.del(model._primaryKey);
+        }
     }
 }
 /**
@@ -423,6 +504,10 @@ export class PrimaryIndex extends BaseIndex {
  * @template F - The field names that make up this index.
  */
 export class UniqueIndex extends BaseIndex {
+    constructor(MyModel, fieldNames) {
+        super(MyModel, fieldNames);
+        (this._MyModel._secondaries ||= []).push(this);
+    }
     /**
      * Get a model instance by unique index key values.
      * @param args - The unique index key values.
@@ -434,20 +519,41 @@ export class UniqueIndex extends BaseIndex {
      * ```
      */
     get(...args) {
-        let keyBuffer = this._getKeyFromArgs(args);
+        let keyBuffer = this._argsToKeySingleton(args);
+        let valueBuffer = olmdb.get(keyBuffer);
         if (logLevel >= 3) {
-            console.log(`Getting unique ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] (id=${this._getIndexId()}) with key`, args, keyBuffer);
+            console.log(`Get ${this} key=${new DataPack(keyBuffer)} result=${valueBuffer}`);
         }
-        let valueBuffer = olmdb.get(keyBuffer);
         if (!valueBuffer)
             return;
-        const pk = this._MyModel._pk;
-        const valueArgs = pk._deserializeKey(new Bytes(valueBuffer));
-        const result = pk.get(...valueArgs);
+        const pk = this._MyModel._primary;
+        const result = pk.get(valueBuffer);
         if (!result)
-            throw new DatabaseError(`Unique index ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] points at non-existing primary for key: ${args.join(', ')}`, 'CONSISTENCY_ERROR');
+            throw new DatabaseError(`Unique index ${this} points at non-existing primary for key: ${args.join(', ')}`, 'CONSISTENCY_ERROR');
         return result;
     }
+    _delete(model) {
+        if (!this._hasNullIndexValues(model)) {
+            const keyBytes = this._instanceToKeyBytes(model);
+            if (logLevel >= 2) {
+                console.log(`Delete ${this} key=${keyBytes}`);
+            }
+            olmdb.del(keyBytes.toUint8Array());
+        }
+    }
+    _write(model) {
+        if (!this._hasNullIndexValues(model)) {
+            const key = this._instanceToKeyBytes(model);
+            if (logLevel >= 2) {
+                console.log(`Write ${this} key=${key} value=${new DataPack(model._primaryKey)}`);
+            }
+            const keyBuffer = key.toUint8Array();
+            if (olmdb.get(keyBuffer)) {
+                throw new DatabaseError(`Unique constraint violation for ${this} key ${key}`, 'UNIQUE_CONSTRAINT');
+            }
+            olmdb.put(keyBuffer, model._primaryKey);
+        }
+    }
     /**
      * Extract model from iterator entry for unique index.
      * @param keyBytes - Key bytes with index ID already read.
@@ -455,49 +561,28 @@ export class UniqueIndex extends BaseIndex {
      * @returns Model instance or undefined.
      * @internal
      */
-    _getModelFromEntry(keyBytes, valueBytes) {
+    _pairToInstance(keyBytes, valueBuffer) {
         // For unique indexes, the value contains the primary key
-        const pk = this._MyModel._pk;
-        const primaryKeyArgs = pk._deserializeKey(valueBytes);
-        return pk.get(...primaryKeyArgs);
-    }
-    /**
-     * Save unique index entry.
-     * @param model - Model instance.
-     * @param originalKey - Original key if updating.
-     */
-    _save(model, originalKey) {
-        // Note: this can (and usually will) be called on the non-proxied model instance.
-        assert(this._MyModel.prototype === model.constructor.prototype);
-        let newKey = this._checkSkip(model) ? undefined : this._getKeyFromModel(model, true);
-        if (originalKey) {
-            if (newKey && Buffer.compare(newKey, originalKey) === 0) {
-                // No change in index key, nothing to do
-                return newKey;
-            }
-            olmdb.del(originalKey);
-        }
-        if (!newKey) {
-            // No new key, nothing to do
-            return;
-        }
-        // Check that this is not a duplicate key
-        if (olmdb.get(newKey)) {
-            throw new DatabaseError(`Unique constraint violation for ${model.constructor.tableName}[${this._fieldNames.join('+')}]`, 'UNIQUE_CONSTRAINT');
-        }
-        let linkKey = model.constructor._pk._getKeyFromModel(model, false);
-        olmdb.put(newKey, linkKey);
-        if (logLevel >= 2) {
-            console.log(`Saved unique index ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] with key ${newKey}`);
+        const pk = this._MyModel._primary;
+        const model = pk.getLazy(valueBuffer);
+        // Read the index fields from the key, overriding lazy loading for these fields
+        for (const [name, fieldType] of this._fieldTypes.entries()) {
+            // getLazy will have created a getter for this field - make it a normal property instead
+            Object.defineProperty(model, name, {
+                writable: true,
+                configurable: true,
+                enumerable: true
+            });
+            model._setLoadedField(name, fieldType.deserialize(keyBytes));
         }
-        return newKey;
+        return model;
     }
     _getTypeName() {
         return 'unique';
     }
 }
 // OLMDB does not support storing empty values, so we use a single byte value for secondary indexes.
-const SECONDARY_VALUE = new Uint8Array([1]); // Single byte value for secondary indexes
+const SECONDARY_VALUE = new DataPack().write(undefined).toUint8Array(); // Single byte value for secondary indexes
 /**
  * Secondary index for non-unique lookups.
  *
@@ -505,69 +590,61 @@ const SECONDARY_VALUE = new Uint8Array([1]); // Single byte value for secondary
  * @template F - The field names that make up this index.
  */
 export class SecondaryIndex extends BaseIndex {
-    /**
-     * Save secondary index entry.
-     * @param model - Model instance.
-     * @param originalKey - Original key if updating.
-     */
-    _save(model, originalKey) {
-        // Note: this can (and usually will) be called on the non-proxied model instance.
-        assert(this._MyModel.prototype === model.constructor.prototype);
-        let newKey = this._getKeyFromModel(model, true);
-        if (originalKey) {
-            if (newKey && Buffer.compare(newKey, originalKey) === 0) {
-                // No change in index key, nothing to do
-                return;
-            }
-            olmdb.del(originalKey);
-        }
-        if (!newKey) {
-            // No new key, nothing to do (index should be skipped)
-            return;
-        }
-        // For secondary indexes, we store a single byte value
-        olmdb.put(newKey, SECONDARY_VALUE);
-        if (logLevel >= 2) {
-            console.log(`Saved secondary index ${this._MyModel.tableName}[${this._fieldNames.join(', ')}] with key ${newKey}`);
-        }
-        return newKey;
+    constructor(MyModel, fieldNames) {
+        super(MyModel, fieldNames);
+        (this._MyModel._secondaries ||= []).push(this);
     }
     /**
      * Extract model from iterator entry for secondary index.
      * @param keyBytes - Key bytes with index ID already read.
-     * @param valueBytes - Value bytes from the entry.
+     * @param valueBuffer - Value Uint8Array from the entry.
      * @returns Model instance or undefined.
      * @internal
      */
-    _getModelFromEntry(keyBytes, valueBytes) {
+    _pairToInstance(keyBytes, valueBuffer) {
         // For secondary indexes, the primary key is stored after the index fields in the key
-        // First skip past the index fields
-        const temp = [];
-        for (let i = 0; i < this._fieldNames.length; i++) {
-            const fieldName = this._fieldNames[i];
-            const fieldConfig = this._MyModel.fields[fieldName];
-            fieldConfig.type.deserialize(temp, 0, keyBytes);
-        }
-        // Now deserialize the primary key from the remaining bytes
-        const pk = this._MyModel._pk;
-        const primaryKeyArgs = pk._deserializeKey(keyBytes);
-        return pk.get(...primaryKeyArgs);
+        // Read the index fields, saving them for later
+        const indexFields = new Map();
+        for (const [name, type] of this._fieldTypes.entries()) {
+            indexFields.set(name, type.deserialize(keyBytes));
+        }
+        const primaryKey = keyBytes.readUint8Array();
+        const model = this._MyModel._primary.getLazy(primaryKey);
+        // Add the index fields to the model, overriding lazy loading for these fields
+        for (const [name, value] of indexFields) {
+            // getLazy will have created a getter for this field - make it a normal property instead
+            Object.defineProperty(model, name, {
+                writable: true,
+                configurable: true,
+                enumerable: true
+            });
+            model._setLoadedField(name, value);
+        }
+        return model;
     }
-    /**
-     * Create secondary index key that includes both index fields and primary key.
-     * @param model - Model instance.
-     * @returns Database key bytes or undefined if skipped.
-     */
-    _getKeyFromModel(model, includeIndexId) {
-        const bytes = new Bytes();
-        if (includeIndexId)
-            bytes.writeNumber(this._getIndexId());
-        // Write the index fields
-        this._serializeModel(model, bytes);
-        // Write the primary key fields
-        const pk = this._MyModel._pk;
-        pk._serializeModel(model, bytes);
-        return bytes.getBuffer();
+    _instanceToKeyBytes(model) {
+        // index id + index fields + primary key
+        const bytes = super._instanceToKeyBytes(model);
+        bytes.write(model._getCreatePrimaryKey());
+        return bytes;
+    }
+    _write(model) {
+        if (this._hasNullIndexValues(model))
+            return;
+        const keyBytes = this._instanceToKeyBytes(model);
+        if (logLevel >= 2) {
+            console.log(`Write ${this} key=${keyBytes}`);
+        }
+        olmdb.put(keyBytes.toUint8Array(), SECONDARY_VALUE);
+    }
+    _delete(model) {
+        if (this._hasNullIndexValues(model))
+            return;
+        const keyBytes = this._instanceToKeyBytes(model);
+        if (logLevel >= 2) {
+            console.log(`Delete ${this} key=${keyBytes}`);
+        }
+        olmdb.del(keyBytes.toUint8Array());
     }
     _getTypeName() {
         return 'secondary';
@@ -592,8 +669,8 @@ export function dump() {
     let indexesById = new Map();
     console.log("--- Database dump ---");
     for (const { key, value } of olmdb.scan()) {
-        const kb = new Bytes(key);
-        const vb = new Bytes(value);
+        const kb = new DataPack(key);
+        const vb = new DataPack(value);
         const indexId = kb.readNumber();
         if (indexId === MAX_INDEX_ID_PREFIX) {
             console.log("* Max index id", vb.readNumber());
@@ -606,9 +683,8 @@ export function dump() {
                 const name = kb.readString();
                 fields[name] = deserializeType(kb, 0);
             }
-            const fieldDescription = Object.entries(fields).map(([name, type]) => `${name}:${type}`);
             const indexId = vb.readNumber();
-            console.log(`* Definition for ${type} ${indexId} for ${name}[${fieldDescription.join(',')}]`);
+            console.log(`* Index definition ${indexId}:${name}:${type}[${Object.keys(fields).join(',')}]`);
             indexesById.set(indexId, { name, type, fields });
         }
         else if (indexId > 0 && indexesById.has(indexId)) {
@@ -616,15 +692,14 @@ export function dump() {
             const { name, type, fields } = index;
             const rowKey = {};
             for (const [fieldName, fieldType] of Object.entries(fields)) {
-                fieldType.deserialize(rowKey, fieldName, kb);
+                rowKey[fieldName] = fieldType.deserialize(kb);
             }
-            const Model = modelRegistry[name];
+            // const Model = modelRegistry[name]!;
             // TODO: once we're storing schemas (serializeType) in the db, we can deserialize here
-            let displayValue = (type === 'secondary') ? Model._pk._deserializeKey(kb) : vb;
-            console.log(`* Row for ${type} ${indexId} with key ${JSON.stringify(rowKey)}`, displayValue);
+            console.log(`* Row for ${indexId}:${name}:${type}[${Object.keys(fields).join(',')}] key=${kb} value=${vb}`);
         }
         else {
-            console.log(`* Unhandled ${indexId} index key=${kb} value=${vb}`);
+            console.log(`* Unhandled '${indexId}' key=${kb} value=${vb}`);
         }
     }
     console.log("--- End of database dump ---");