edge-currency-plugins 3.11.0 → 3.13.0

package/lib/common/plugin/types.js

@@ -313,6 +313,12 @@ var _types3 = require('../utxobased/db/types');
 
 
 
+
+
+
+
+
+
 
 
 

package/lib/common/utxobased/engine/ServerStates.js

@@ -91,6 +91,47 @@ var _constants = require('./constants');
 
 
 
+
+
+
+
+
+
+/**
+ * How long broadcastTx gives the first wave (our sockets and Edge's own HTTP
+ * servers) before it also sends the transaction to the NOWNodes HTTP servers.
+ * NOWNodes is a third party, so it should only see a transaction when our own
+ * infrastructure has not already carried it. A first wave that fails outright
+ * does not wait this long; the second wave fires as soon as it has all failed.
+ */
+ const NOWNODES_BROADCAST_DELAY_MS = 2000; exports.NOWNODES_BROADCAST_DELAY_MS = NOWNODES_BROADCAST_DELAY_MS
+
+/**
+ * Every broadcast attempt is counted toward "all attempts failed", so every
+ * attempt must settle. Sockets already expire a request after 30 seconds
+ * (Socket.ts); HTTP has no such bound of its own, and a server that accepts
+ * the connection and never answers would otherwise hold the whole broadcast
+ * open. This mirrors the socket figure.
+ */
+ const BROADCAST_ATTEMPT_TIMEOUT_MS = 30000; exports.BROADCAST_ATTEMPT_TIMEOUT_MS = BROADCAST_ATTEMPT_TIMEOUT_MS
+
+const withTimeout = async ( 
+  promise,
+  ms,
+  message
+) => {
+  let timer
+  const timeout = new Promise((resolve, reject) => {
+    timer = setTimeout(() => {
+      reject(new Error(message))
+    }, ms)
+  })
+  try {
+    return await Promise.race([promise, timeout])
+  } finally {
+    if (timer != null) clearTimeout(timer)
+  }
+}
 
  function makeServerStates(config) {
   const {
@@ -103,6 +144,7 @@ var _constants = require('./constants');
     walletInfo
   } = config
   const { serverConfigs = [] } = pluginInfo.engineInfo
+  const { broadcastTimeoutMs = exports.BROADCAST_ATTEMPT_TIMEOUT_MS } = config
   log('Making server states')
 
   const serverStatesCache = {}
@@ -366,112 +408,171 @@ var _constants = require('./constants');
   }
 
   const instance = {
+    /**
+     * Broadcast in two waves:
+     *
+     * 1. Immediately: every blockbook in the connection cache (whether or not
+     *    its socket has finished connecting; a queued request transmits as
+     *    soon as the socket opens, and times out otherwise) and every
+     *    `blockbook` HTTP server, which are Edge's own.
+     * 2. After NOWNODES_BROADCAST_DELAY_MS, or as soon as every first-wave
+     *    attempt has failed, whichever comes first: the `blockbook-nownode`
+     *    HTTP servers. These are a third party and only see the transaction
+     *    when our own infrastructure has not already carried it.
+     *
+     * The first success wins. The promise rejects only after every attempt
+     * has failed. Earlier versions only used HTTP when no socket was
+     * connected, so a single socket that looked connected but never answered
+     * could fail the whole broadcast without any HTTP attempt.
+     */
     async broadcastTx(transaction) {
       return await new Promise((resolve, reject) => {
-        let resolved = false
-        let bad = 0
-
-        const wsUris = Object.keys(serverStatesCache).filter(
-          uri => serverStatesCache[uri].blockbook != null
-        )
-
-        // Determine if there are any connected blockbook instances
-        const isAnyBlockbookConnected = wsUris.some(
-          uri => serverStatesCache[uri].blockbook.isConnected
-        )
-
-        if (isAnyBlockbookConnected) {
-          for (const uri of wsUris) {
-            const { blockbook } = serverStatesCache[uri]
-            if (blockbook == null) continue
-            blockbook
-              .broadcastTx(transaction)
-              .then(response => {
-                if (!resolved) {
-                  resolved = true
-                  resolve(response.result)
-                }
-              })
-              .catch((e) => {
-                if (++bad === wsUris.length) {
-                  const msg = e != null ? `With error ${e.message}` : ''
-                  log.error(
-                    `broadcastTx fail: ${JSON.stringify(transaction)}\n${msg}`
-                  )
-                  reject(e)
-                }
-              })
+        
+
+
+
+
+        const httpAttempt = (
+          uri,
+          headers
+        ) => ({
+          uri,
+          run: async () => {
+            const response = await io.fetchCors(`${uri}/api/v2/sendtx/`, {
+              method: 'POST',
+              headers,
+              body: transaction.signedTx
+            })
+            if (!response.ok) {
+              throw new Error(
+                `Failed to broadcast transaction via Blockbook: HTTP ${response.status}`
+              )
+            }
+            const json = await response.json()
+            return _blockbookApi.asBlockbookResponse.call(void 0, (0, _blockbookApi.asBroadcastTxResponse))(json).result
           }
+        })
+
+        //
+        // Build both waves up front, so `attempts` is the full count and an
+        // all-fail first wave cannot reject before the second has run.
+        //
+        const firstWave = []
+        const secondWave = []
+
+        for (const uri of Object.keys(serverStatesCache)) {
+          const { blockbook } = serverStatesCache[uri]
+          if (blockbook == null) continue
+          firstWave.push({
+            uri,
+            run: async () => (await blockbook.broadcastTx(transaction)).result
+          })
         }
 
-        // Broadcast through any HTTP URI that may be configured, only if no
-        // blockbook instances are connected.
-        if (!isAnyBlockbookConnected) {
-          // This is for the future when we want to get HTTP servers from the user
-          // settings:
-          // const httpUris = pluginState.getLocalServers(Infinity, [
-          //   /^http(?:s)?:/i
-          // ])
-
-          const { nowNodesApiKey } = initOptions
-          const nowNodeUris = serverConfigs
-            .filter(config => config.type === 'blockbook-nownode')
-            .map(config => config.uris)
-            .flat(1)
-
-          // If there are no HTTP servers, reject the promise
-          if (nowNodeUris.length < 1) {
-            // If no HTTP servers are available, and we had no connected blockbook
-            // instances, reject the promise with a message indicating no
-            // available connections.
+        // This is for the future when we want to get HTTP servers from the user
+        // settings:
+        // const httpUris = pluginState.getLocalServers(Infinity, [
+        //   /^http(?:s)?:/i
+        // ])
+        const { nowNodesApiKey } = initOptions
+        for (const config of serverConfigs) {
+          if (config.type === 'blockbook-nownode') {
+            // NOWNodes requires the key, and the key must not go anywhere else:
+            if (nowNodesApiKey == null) {
+              log.warn(
+                'broadcastTx: skipping NOWNodes HTTP servers (no nowNodesApiKey)'
+              )
+              continue
+            }
+            for (const uri of config.uris) {
+              secondWave.push(httpAttempt(uri, { 'api-key': nowNodesApiKey }))
+            }
+          } else {
+            for (const uri of config.uris) {
+              firstWave.push(httpAttempt(uri, {}))
+            }
+          }
+        }
+
+        const attempts = firstWave.length + secondWave.length
+        if (attempts === 0) {
+          reject(
+            new Error('No available connections. Check your internet signal.')
+          )
+          return
+        }
+
+        let resolved = false
+        let failures = 0
+        const failureMessages = []
+        let secondWaveFired = false
+        let secondWaveTimer
+
+        const onSuccess = (uri, txid) => {
+          if (resolved) return
+          resolved = true
+          if (secondWaveTimer != null) clearTimeout(secondWaveTimer)
+          log(`broadcastTx succeeded via ${uri}: ${txid}`)
+          resolve(txid)
+        }
+        const onFailure = (uri, error) => {
+          const message = error instanceof Error ? error.message : String(error)
+          failureMessages.push(`${uri}: ${message}`)
+          log.warn(`broadcastTx attempt failed for ${uri}: ${message}`)
+          failures++
+          if (resolved) return
+          if (failures === attempts) {
+            log.error(
+              `broadcastTx fail: ${JSON.stringify(
+                transaction
+              )}\n${failureMessages.join('\n')}`
+            )
             reject(
-              new Error('No available connections. Check your internet signal.')
+              error instanceof Error
+                ? error
+                : new Error(`Broadcast failed: ${failureMessages.join('; ')}`)
             )
             return
           }
-
-          // If there is no key for the NowNode servers:
-          if (nowNodesApiKey == null) {
-            reject(new Error('Missing connection key for fallback servers.'))
-            return
+          // Every first-wave attempt has failed, so there is nothing left to
+          // wait for. Fire the second wave now rather than sit out the delay.
+          if (!secondWaveFired && failures >= firstWave.length) {
+            fireSecondWave()
           }
-
-          for (const uri of nowNodeUris) {
-            log.warn('Falling back to NOWNode server broadcast over HTTP:', uri)
-
-            // HTTP Fallback
-            io.fetchCors(`${uri}/api/v2/sendtx/`, {
-              method: 'POST',
-              headers: {
-                'api-key': nowNodesApiKey
-              },
-              body: transaction.signedTx
+        }
+        const fire = (attempt) => {
+          withTimeout(
+            attempt.run(),
+            broadcastTimeoutMs,
+            `Timeout for broadcast to ${attempt.uri}`
+          )
+            .then(txid => {
+              onSuccess(attempt.uri, txid)
             })
-              .then(async response => {
-                if (!response.ok) {
-                  throw new Error(
-                    `Failed to broadcast transaction via Blockbook: HTTP ${response.status}`
-                  )
-                }
-                const json = await response.json()
-                return _blockbookApi.asBlockbookResponse.call(void 0, (0, _blockbookApi.asBroadcastTxResponse))(json)
-              })
-              .then(response => {
-                if (!resolved) {
-                  resolved = true
-                  resolve(response.result)
-                }
-              })
-              .catch((e) => {
-                if (++bad === nowNodeUris.length) {
-                  const msg = e != null ? `With error ${e.message}` : ''
-                  log.error(
-                    `broadcastTx fail: ${JSON.stringify(transaction)}\n${msg}`
-                  )
-                  reject(e)
-                }
-              })
-          }
+            .catch((error) => {
+              onFailure(attempt.uri, error)
+            })
+        }
+        const fireSecondWave = () => {
+          if (secondWaveFired) return
+          secondWaveFired = true
+          if (secondWaveTimer != null) clearTimeout(secondWaveTimer)
+          if (secondWave.length === 0) return
+          log.warn(
+            'broadcastTx: first wave has not resolved, trying NOWNodes servers'
+          )
+          for (const attempt of secondWave) fire(attempt)
+        }
+
+        for (const attempt of firstWave) fire(attempt)
+        if (firstWave.length === 0) {
+          // Nothing of our own to try first:
+          fireSecondWave()
+        } else if (secondWave.length > 0) {
+          secondWaveTimer = setTimeout(
+            fireSecondWave,
+            exports.NOWNODES_BROADCAST_DELAY_MS
+          )
         }
       })
     },

package/lib/common/utxobased/engine/UtxoEngine.js

@@ -45,6 +45,9 @@ var _cleaners3 = require('../keymanager/cleaners');
 
 
 var _keymanager = require('../keymanager/keymanager');
+
+
+
 var _types5 = require('../keymanager/types');
 var _utils = require('../keymanager/utxopicker/utils');
 var _paymentRequest = require('./paymentRequest');
@@ -797,11 +800,20 @@ var _UtxoWalletTools = require('./UtxoWalletTools');
       opts
     ) {
       const otherParams = _types7.asUtxoSignMessageOtherParams.call(void 0, opts.otherParams)
-      const { publicAddress } = otherParams
-      const scriptPubkey = walletTools.addressToScriptPubkey(publicAddress)
+      const { publicAddress, signatureFormat } = otherParams
+      // An address the wallet cannot sign for reaches us two ways: it parses
+      // but is not ours, or it is not an address of this chain at all and
+      // `addressToScriptPubkey` throws. Both are the same thing to a caller,
+      // so give them one named error rather than assorted parser prose.
+      let scriptPubkey
+      try {
+        scriptPubkey = walletTools.addressToScriptPubkey(publicAddress)
+      } catch (e2) {
+        throw new (0, _types5.AddressNotOwnedError)()
+      }
       const addressData = await dataLayer.fetchAddress(scriptPubkey)
       if (_optionalChain([addressData, 'optionalAccess', _13 => _13.path]) == null) {
-        throw new Error('Missing data-layer address to sign with')
+        throw new (0, _types5.AddressNotOwnedError)()
       }
       const privateKey = asMaybeCurrencyPrivateKey(privateKeys)
 
@@ -818,7 +830,8 @@ var _UtxoWalletTools = require('./UtxoWalletTools');
       const signature = await walletTools.signMessageBase64({
         path: _optionalChain([addressData, 'optionalAccess', _14 => _14.path]),
         message,
-        xprivKeys
+        xprivKeys,
+        signatureFormat
       })
       return signature
     },

package/lib/common/utxobased/engine/UtxoWalletTools.js

@@ -25,6 +25,7 @@ var _keymanager = require('../keymanager/keymanager');
 
 
 
+
 var _utils = require('./utils');
 
 
@@ -92,6 +93,7 @@ var _utils = require('./utils');
 
 
 
+
 
 
  function makeUtxoWalletTools(
@@ -236,12 +238,23 @@ var _utils = require('./utils');
       return { address, scriptPubkey, redeemScript }
     },
 
-    signMessageBase64({ path, message, xprivKeys }) {
+    signMessageBase64({
+      path,
+      message,
+      xprivKeys,
+      signatureFormat
+    }) {
       const privKey = fns.getPrivateKey({
         path,
         xprivKeys
       })
-      return _keymanager.signMessageBase64.call(void 0, message, privKey)
+      return _keymanager.signMessageBase64.call(void 0, 
+        message,
+        privKey,
+        path.format,
+        coin,
+        signatureFormat
+      )
     }
   }
 

package/lib/common/utxobased/engine/types.js

@@ -11,6 +11,7 @@ var _cleaners = require('cleaners');
 
 
 var _types3 = require('../../plugin/types');
+var _types5 = require('../keymanager/types');
 
 
 
@@ -42,7 +43,12 @@ var _types3 = require('../../plugin/types');
 
 
  const asUtxoSignMessageOtherParams = _cleaners.asObject.call(void 0, {
-  publicAddress: _cleaners.asString
+  publicAddress: _cleaners.asString,
+  // Defaults to the legacy Electrum encoding so existing callers keep the
+  // format they already produce. BIP-137 is opt-in, since emitting a BIP-137
+  // header to a verifier expecting the legacy one is just as broken as the
+  // reverse.
+  signatureFormat: _cleaners.asMaybe.call(void 0, _types5.asUtxoSignatureFormat, 'electrum')
 }); exports.asUtxoSignMessageOtherParams = asUtxoSignMessageOtherParams
 
 const asOutputSort = _cleaners.asValue.call(void 0, 'bip69', 'targets')

package/lib/common/utxobased/info/bitcoin.js

@@ -20,8 +20,8 @@ const currencyInfo = {
 
   // Explorers:
   blockExplorer: 'https://blockchair.com/bitcoin/block/%s',
-  addressExplorer: 'https://blockchair.com/bitcoin/address/%s',
-  transactionExplorer: 'https://blockchair.com/bitcoin/transaction/%s',
+  addressExplorer: 'https://mempool.space/address/%s',
+  transactionExplorer: 'https://mempool.space/tx/%s',
 
   denominations: [
     { name: 'BTC', multiplier: '100000000', symbol: '₿' },
@@ -53,7 +53,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://btc-wusa1.edge.app', 'https://btc-eu1.edge.app']
     },
     {

package/lib/common/utxobased/info/bitcoincash.js

@@ -53,7 +53,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://bch-eusa1.edge.app']
     },
     {

package/lib/common/utxobased/info/bitcoingold.js

@@ -73,7 +73,7 @@ const engineInfo = {
   coinType: 156,
 
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Gold Signed Message:\n'],
+    messagePrefix: ['\x1dBitcoin Gold Signed Message:\n'],
     wif: [0x80],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/bitcoingoldtestnet.js

@@ -65,7 +65,7 @@ const engineInfo = {
   coinType: 1,
 
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Gold Signed Message:\n'],
+    messagePrefix: ['\x1dBitcoin Gold Signed Message:\n'],
     wif: [0xef],
     legacyXPriv: [0x04358394],
     legacyXPub: [0x043587cf],

package/lib/common/utxobased/info/dash.js

@@ -52,7 +52,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://dash-wusa1.edge.app']
     },
     {
@@ -99,7 +99,8 @@ const engineInfo = {
   segwit: false,
   coinType: 5,
   prefixes: {
-    messagePrefix: ['unused'],
+    // Dash kept its pre-rebrand DarkCoin magic; not a typo.
+    messagePrefix: ['\x19DarkCoin Signed Message:\n'],
     wif: [0xcc],
     legacyXPriv: [0x02fe52f8],
     legacyXPub: [0x02fe52cc],

package/lib/common/utxobased/info/digibyte.js

@@ -46,7 +46,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://dgb-eu1.edge.app']
     },
     {
@@ -79,7 +79,7 @@ const engineInfo = {
   segwit: true,
   coinType: 20,
   prefixes: {
-    messagePrefix: ['\x18Digibyte Signed Message:\n'],
+    messagePrefix: ['\x19DigiByte Signed Message:\n'],
     wif: [0x80, 0x9e],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/dogecoin.js

@@ -48,7 +48,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://doge-eusa1.edge.app']
     },
     {
@@ -81,7 +81,7 @@ const engineInfo = {
   coinType: 3,
   utxoPicker: _dogeUtxoPicker.makeDogeUtxoPicker.call(void 0, ),
   prefixes: {
-    messagePrefix: ['\x18Dogecoin Signed Message:\n'],
+    messagePrefix: ['\x19Dogecoin Signed Message:\n'],
     wif: [0x9e],
     legacyXPriv: [0x02fac398],
     legacyXPub: [0x02facafd],

package/lib/common/utxobased/info/ecash.js

@@ -80,7 +80,7 @@ const engineInfo = {
   includeCashaddrPrefix: true,
 
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Signed Message::\n'],
+    messagePrefix: ['\x16eCash Signed Message:\n'],
     wif: [0x80],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/feathercoin.js

@@ -63,7 +63,7 @@ var _commonInfo = require('./commonInfo');
   segwit: true,
   coinType: 8,
   prefixes: {
-    messagePrefix: ['\x18Feathercoin Signed Message:\n'],
+    messagePrefix: ['\x1cFeathercoin Signed Message:\n'],
     wif: [0x8e],
     legacyXPriv: [0x0488daee],
     legacyXPub: [0x0488bc26],

package/lib/common/utxobased/info/litecoin.js

@@ -20,8 +20,8 @@ var _commonInfo = require('./commonInfo');
 
   // Explorers:
   blockExplorer: 'https://blockchair.com/litecoin/block/%s',
-  addressExplorer: 'https://blockchair.com/litecoin/address/%s',
-  transactionExplorer: 'https://blockchair.com/litecoin/transaction/%s',
+  addressExplorer: 'https://litecoinspace.org/address/%s',
+  transactionExplorer: 'https://litecoinspace.org/tx/%s',
 
   denominations: [
     { name: 'LTC', multiplier: '100000000', symbol: 'Ł' },
@@ -50,7 +50,7 @@ var _commonInfo = require('./commonInfo');
  const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://ltc-wusa1.edge.app']
     },
     {
@@ -83,7 +83,7 @@ var _commonInfo = require('./commonInfo');
   segwit: true,
   coinType: 2,
   prefixes: {
-    messagePrefix: ['\x18Litecoin Signed Message:\n'],
+    messagePrefix: ['\x19Litecoin Signed Message:\n'],
     wif: [0xb0],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/pivx.js

@@ -44,7 +44,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://pivx-wusa1.edge.app']
     },
     {
@@ -79,7 +79,8 @@ const engineInfo = {
     /*
     [Prefix reference](https://github.com/PIVX-Project/PIVX/blob/b89a9fc04e9e31bb3fd009df0506c957a00ad536/src/chainparams.cpp#L329)
     */
-    messagePrefix: ['PIVX Signed Message:\n'],
+    // PIVX inherited DarkNet from its Dash fork ancestry; not a typo.
+    messagePrefix: ['\x18DarkNet Signed Message:\n'],
     wif: [0xd4],
     legacyXPriv: [0x0221312b],
     legacyXPub: [0x022d2533],

package/lib/common/utxobased/info/qtum.js

@@ -42,7 +42,7 @@ const currencyInfo = {
 const engineInfo = {
   serverConfigs: [
     {
-      type: 'blockbook-nownode',
+      type: 'blockbook',
       uris: ['https://qtum-wusa1.edge.app']
     }
   ],
@@ -70,7 +70,7 @@ const engineInfo = {
   segwit: false,
   coinType: 2301,
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Signed Message:\n'],
+    messagePrefix: ['\x15Qtum Signed Message:\n'],
     wif: [0x80],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/ravencoin.js

@@ -60,7 +60,7 @@ const engineInfo = {
   segwit: false,
   coinType: 175,
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Signed Message:\n'],
+    messagePrefix: ['\x16Raven Signed Message:\n'],
     wif: [0x80],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],

package/lib/common/utxobased/info/smartcash.js

@@ -71,7 +71,7 @@ const engineInfo = {
   bs58EncodeFunc: base58smart.encode,
   wifEncodeFunc: wifsmart.encode,
   prefixes: {
-    messagePrefix: ['\x18Bitcoin Signed Message:\n'],
+    messagePrefix: ['\x1aSmartCash Signed Message:\n'],
     wif: [0xbf],
     legacyXPriv: [0x0488ade4],
     legacyXPub: [0x0488b21e],