edfcore 0.6.226 → 0.6.228
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/annotations-query.d.ts.map +1 -1
- package/dist/annotations-query.js +38 -2
- package/dist/annotations-query.js.map +1 -1
- package/dist/chunks.d.ts.map +1 -1
- package/dist/chunks.js +17 -2
- package/dist/chunks.js.map +1 -1
- package/dist/constants.d.ts +1 -1
- package/dist/constants.js +1 -1
- package/docs/CHANGELOG.md +32 -0
- package/package.json +1 -1
- package/src/annotations-query.ts +40 -2
- package/src/chunks.ts +17 -2
- package/src/constants.ts +1 -1
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"annotations-query.d.ts","sourceRoot":"","sources":["../src/annotations-query.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAKH,OAAO,KAAK,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAC;AAmDrE;;;;;;;GAOG;AACH,wBAAgB,uBAAuB,CACrC,WAAW,EAAE,SAAS,aAAa,EAAE,EACrC,MAAM,EAAE,mBAAmB,GAC1B,SAAS,aAAa,EAAE,
|
|
1
|
+
{"version":3,"file":"annotations-query.d.ts","sourceRoot":"","sources":["../src/annotations-query.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAKH,OAAO,KAAK,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAC;AAmDrE;;;;;;;GAOG;AACH,wBAAgB,uBAAuB,CACrC,WAAW,EAAE,SAAS,aAAa,EAAE,EACrC,MAAM,EAAE,mBAAmB,GAC1B,SAAS,aAAa,EAAE,CA6E1B;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,uBAAuB,CACrC,WAAW,EAAE,SAAS,aAAa,EAAE,EACrC,KAAK,EAAE,MAAM,GAAG,MAAM,GAAG,CAAC,CAAC,IAAI,EAAE,MAAM,KAAK,OAAO,CAAC,GACnD,SAAS,aAAa,EAAE,CAiB1B;AAED;;;;;GAKG;AACH,wBAAgB,sBAAsB,CACpC,WAAW,EAAE,SAAS,aAAa,EAAE,GACpC,aAAa,CAAC;IAAE,QAAQ,CAAC,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAA;CAAE,CAAC,CASlE;AAED;;;;;;;;GAQG;AACH,wBAAgB,aAAa,CAC3B,WAAW,EAAE,SAAS,aAAa,EAAE,EACrC,OAAO,EAAE,MAAM,GACd,SAAS,aAAa,EAAE,CA2B1B"}
|
|
@@ -82,8 +82,29 @@ export function filterAnnotationsByTime(annotations, window) {
|
|
|
82
82
|
// Cannot read properties of undefined (reading 'startSeconds')`, naming a field rather than the
|
|
83
83
|
// argument, with no `Next:` clause.
|
|
84
84
|
if (typeof window !== 'object' || window === null) {
|
|
85
|
-
|
|
86
|
-
|
|
85
|
+
/*
|
|
86
|
+
* A NUMBER, which is an INSTANT, and the one wrong window whose advice led somewhere worse than
|
|
87
|
+
* where it started.
|
|
88
|
+
*
|
|
89
|
+
* "Pass a window carrying startSeconds and durationSeconds" is followable: a reader holding a
|
|
90
|
+
* cursor position writes `{ startSeconds: t, durationSeconds: 0 }`, because a window over one
|
|
91
|
+
* instant has no length. `annotationsAt`'s own docblock says what that does — the window form
|
|
92
|
+
* "works — a zero-length window — except that `filterAnnotationsByTime` returns nothing for a
|
|
93
|
+
* non-positive duration, so the obvious call returns an empty list at every position" — and it
|
|
94
|
+
* is why that function exists at all. So the advice ended in silence rather than in an error,
|
|
95
|
+
* at the call a viewer makes on every mouse move.
|
|
96
|
+
*
|
|
97
|
+
* The sibling is one export away and takes exactly what was passed. 0.6.88 made this argument
|
|
98
|
+
* for `readWindow` and `readRecords`, the other pair in this package that differ only in the
|
|
99
|
+
* unit they bound by.
|
|
100
|
+
*/
|
|
101
|
+
throw new RangeError(`filterAnnotationsByTime(): the window is ${describeValue(window)}, not an object.` +
|
|
102
|
+
(typeof window === 'number'
|
|
103
|
+
? ' That is an instant, and this call bounds events by an interval — a zero-length one ' +
|
|
104
|
+
'returns nothing, so a cursor position asked for as a window reads as no annotations ' +
|
|
105
|
+
'at every position. Next: call annotationsAt(annotations, seconds), which takes the ' +
|
|
106
|
+
'instant, or pass a window carrying startSeconds and durationSeconds.'
|
|
107
|
+
: ' Next: pass a window carrying startSeconds and durationSeconds.'));
|
|
87
108
|
}
|
|
88
109
|
/*
|
|
89
110
|
* An ARRAY, which is an object and therefore walked straight past the check above.
|
|
@@ -178,6 +199,21 @@ export function countAnnotationsByText(annotations) {
|
|
|
178
199
|
*/
|
|
179
200
|
export function annotationsAt(annotations, seconds) {
|
|
180
201
|
assertAnnotations(annotations, 'annotationsAt');
|
|
202
|
+
/*
|
|
203
|
+
* And the OTHER WAY. `filterAnnotationsByTime` is the neighbour this function's docblock names,
|
|
204
|
+
* the two differ only in whether they bound by an instant or by an interval, and a window here
|
|
205
|
+
* reached `secondsToTicks` — which answered "seconds must be a number of seconds, and was given
|
|
206
|
+
* an object. Next: convert it first". There is no conversion: a window is not a number spelled
|
|
207
|
+
* differently, and the reader was being sent to invent one.
|
|
208
|
+
*/
|
|
209
|
+
const given = seconds;
|
|
210
|
+
if (typeof given === 'object' && given !== null && !Array.isArray(given)) {
|
|
211
|
+
if ('startSeconds' in given || 'durationSeconds' in given) {
|
|
212
|
+
throw new RangeError('annotationsAt(): that is a time window, and this call takes a single instant in seconds. ' +
|
|
213
|
+
'Next: pass window.startSeconds for the instant under a cursor, or call ' +
|
|
214
|
+
'filterAnnotationsByTime(annotations, window), which is the one that takes an interval.');
|
|
215
|
+
}
|
|
216
|
+
}
|
|
181
217
|
const at = secondsToTicks(seconds, 'seconds');
|
|
182
218
|
return Object.freeze(annotations.filter((annotation) => {
|
|
183
219
|
const onset = annotation.onsetTicksFromFirstRecord;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"annotations-query.js","sourceRoot":"","sources":["../src/annotations-query.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAEH,OAAO,EAAE,aAAa,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAChE,OAAO,EAAE,cAAc,EAAE,MAAM,gBAAgB,CAAC;AAChD,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAGnD;;;;;;;;;;;;GAYG;AACH,SAAS,iBAAiB,CAAC,WAAqC,EAAE,IAAY;IAC5E,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,WAAW,CAAC,EAAE,CAAC;QAChC,MAAM,IAAI,UAAU,CAClB,GAAG,IAAI,2BAA2B,aAAa,CAAC,WAAW,CAAC,iCAAiC;YAC3F,0FAA0F;YAC1F,4CAA4C,CAC/C,CAAC;IACJ,CAAC;IACD;;;;;;;;;;;;;;;;;OAiBG;IACH,MAAM,KAAK,GAAG,WAAW,CAAC,CAAC,CAAwD,CAAC;IACpF,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,IAAI,OAAO,KAAK,EAAE,yBAAyB,KAAK,QAAQ;QAAE,OAAO;IAC7F,MAAM,IAAI,UAAU,CAClB,GAAG,IAAI,wFAAwF;QAC7F,8FAA8F;QAC9F,8FAA8F;QAC9F,8DAA8D,CACjE,CAAC;AACJ,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,uBAAuB,CACrC,WAAqC,EACrC,MAA2B;IAE3B,iBAAiB,CAAC,WAAW,EAAE,yBAAyB,CAAC,CAAC;IAC1D,6FAA6F;IAC7F,8FAA8F;IAC9F,0FAA0F;IAC1F,gGAAgG;IAChG,oCAAoC;IACpC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI,EAAE,CAAC;QAClD,MAAM,IAAI,UAAU,CAClB,4CAA4C,aAAa,CAAC,MAAM,CAAC,
|
|
1
|
+
{"version":3,"file":"annotations-query.js","sourceRoot":"","sources":["../src/annotations-query.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAEH,OAAO,EAAE,aAAa,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAChE,OAAO,EAAE,cAAc,EAAE,MAAM,gBAAgB,CAAC;AAChD,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAGnD;;;;;;;;;;;;GAYG;AACH,SAAS,iBAAiB,CAAC,WAAqC,EAAE,IAAY;IAC5E,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,WAAW,CAAC,EAAE,CAAC;QAChC,MAAM,IAAI,UAAU,CAClB,GAAG,IAAI,2BAA2B,aAAa,CAAC,WAAW,CAAC,iCAAiC;YAC3F,0FAA0F;YAC1F,4CAA4C,CAC/C,CAAC;IACJ,CAAC;IACD;;;;;;;;;;;;;;;;;OAiBG;IACH,MAAM,KAAK,GAAG,WAAW,CAAC,CAAC,CAAwD,CAAC;IACpF,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,IAAI,OAAO,KAAK,EAAE,yBAAyB,KAAK,QAAQ;QAAE,OAAO;IAC7F,MAAM,IAAI,UAAU,CAClB,GAAG,IAAI,wFAAwF;QAC7F,8FAA8F;QAC9F,8FAA8F;QAC9F,8DAA8D,CACjE,CAAC;AACJ,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,uBAAuB,CACrC,WAAqC,EACrC,MAA2B;IAE3B,iBAAiB,CAAC,WAAW,EAAE,yBAAyB,CAAC,CAAC;IAC1D,6FAA6F;IAC7F,8FAA8F;IAC9F,0FAA0F;IAC1F,gGAAgG;IAChG,oCAAoC;IACpC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI,EAAE,CAAC;QAClD;;;;;;;;;;;;;;;WAeG;QACH,MAAM,IAAI,UAAU,CAClB,4CAA4C,aAAa,CAAC,MAAM,CAAC,kBAAkB;YACjF,CAAC,OAAO,MAAM,KAAK,QAAQ;gBACzB,CAAC,CAAC,sFAAsF;oBACtF,sFAAsF;oBACtF,qFAAqF;oBACrF,sEAAsE;gBACxE,CAAC,CAAC,iEAAiE,CAAC,CACzE,CAAC;IACJ,CAAC;IACD;;;;;;;;;;;;;OAaG;IACH,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QAC1B,MAAM,IAAI,UAAU,CAClB,yFAAyF;YACvF,yFAAyF;YACzF,yFAAyF;YACzF,YAAY,CACf,CAAC;IACJ,CAAC;IACD,MAAM,IAAI,GAAG,cAAc,CAAC,MAAM,CAAC,YAAY,EAAE,qBAAqB,CAAC,CAAC;IACxE,MAAM,EAAE,GAAG,IAAI,GAAG,cAAc,CAAC,MAAM,CAAC,eAAe,EAAE,wBAAwB,CAAC,CAAC;IACnF,IAAI,EAAE,IAAI,IAAI;QAAE,OAAO,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;IAEzC,OAAO,MAAM,CAAC,MAAM,CAClB,WAAW,CAAC,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE;QAChC,MAAM,KAAK,GAAG,UAAU,CAAC,yBAAyB,CAAC;QACnD,MAAM,GAAG,GAAG,KAAK,GAAG,CAAC,UAAU,CAAC,aAAa,IAAI,EAAE,CAAC,CAAC;QACrD,0FAA0F;QAC1F,yFAAyF;QACzF,EAAE;QACF,4EAA4E;QAC5E,2FAA2F;QAC3F,4FAA4F;QAC5F,4FAA4F;QAC5F,0FAA0F;QAC1F,2FAA2F;QAC3F,yCAAyC;QACzC,OAAO,KAAK,GAAG,EAAE,IAAI,CAAC,GAAG,GAAG,IAAI,IAAI,CAAC,GAAG,KAAK,KAAK,IAAI,KAAK,IAAI,IAAI,CAAC,CAAC,CAAC;IACxE,CAAC,CAAC,CACH,CAAC;AACJ,CAAC;AAED;;;;;;;;;;;;;;;GAeG;AACH,MAAM,UAAU,uBAAuB,CACrC,WAAqC,EACrC,KAAoD;IAEpD,iBAAiB,CAAC,WAAW,EAAE,yBAAyB,CAAC,CAAC;IAC1D,MAAM,IAAI,GACR,OAAO,KAAK,KAAK,QAAQ;QACvB,CAAC,CAAC,CAAC,IAAY,EAAW,EAAE,CAAC,IAAI,KAAK,KAAK;QAC3C,CAAC,CAAC,KAAK,YAAY,MAAM;YACvB,CAAC,CAAC,sFAAsF;gBACtF,uEAAuE;gBACvE,WAAW,CAAC,KAAK,CAAC;YACpB,CAAC,CAAC,aAAa,CACX,KAAK,EACL,yBAAyB,EACzB,iEAAiE,EACjE,kFAAkF;gBAChF,sBAAsB,CACzB,CAAC;IACV,OAAO,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClF,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,sBAAsB,CACpC,WAAqC;IAErC,iBAAiB,CAAC,WAAW,EAAE,wBAAwB,CAAC,CAAC;IACzD,MAAM,MAAM,GAAG,IAAI,GAAG,EAAkB,CAAC;IACzC,KAAK,MAAM,UAAU,IAAI,WAAW,EAAE,CAAC;QACrC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;IACtE,CAAC;IACD,OAAO,MAAM,CAAC,MAAM,CAClB,CAAC,GAAG,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,CACxF,CAAC;AACJ,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,aAAa,CAC3B,WAAqC,EACrC,OAAe;IAEf,iBAAiB,CAAC,WAAW,EAAE,eAAe,CAAC,CAAC;IAChD;;;;;;OAMG;IACH,MAAM,KAAK,GAAG,OAAmF,CAAC;IAClG,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QACzE,IAAI,cAAc,IAAI,KAAK,IAAI,iBAAiB,IAAI,KAAK,EAAE,CAAC;YAC1D,MAAM,IAAI,UAAU,CAClB,2FAA2F;gBACzF,yEAAyE;gBACzE,wFAAwF,CAC3F,CAAC;QACJ,CAAC;IACH,CAAC;IACD,MAAM,EAAE,GAAG,cAAc,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;IAC9C,OAAO,MAAM,CAAC,MAAM,CAClB,WAAW,CAAC,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE;QAChC,MAAM,KAAK,GAAG,UAAU,CAAC,yBAAyB,CAAC;QACnD,MAAM,QAAQ,GAAG,UAAU,CAAC,aAAa,IAAI,EAAE,CAAC;QAChD,OAAO,QAAQ,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,IAAI,EAAE,IAAI,EAAE,GAAG,KAAK,GAAG,QAAQ,CAAC;IAC/E,CAAC,CAAC,CACH,CAAC;AACJ,CAAC"}
|
package/dist/chunks.d.ts.map
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"chunks.d.ts","sourceRoot":"","sources":["../src/chunks.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;GAqBG;AAMH,OAAO,KAAK,EAAE,QAAQ,EAAiC,MAAM,YAAY,CAAC;
|
|
1
|
+
{"version":3,"file":"chunks.d.ts","sourceRoot":"","sources":["../src/chunks.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;GAqBG;AAMH,OAAO,KAAK,EAAE,QAAQ,EAAiC,MAAM,YAAY,CAAC;AA8M1E;;;;;;;;;GASG;AACH,wBAAgB,WAAW,CAAC,MAAM,EAAE,SAAS,QAAQ,EAAE,GAAG,QAAQ,CAmGjE"}
|
package/dist/chunks.js
CHANGED
|
@@ -27,9 +27,24 @@ import { describeValue } from './text/describe.js';
|
|
|
27
27
|
/** Reads as one line at the call site, and keeps the `chunks[i]` non-null assertions out of it. */
|
|
28
28
|
function at(chunks, index) {
|
|
29
29
|
const chunk = chunks[index];
|
|
30
|
-
|
|
30
|
+
/*
|
|
31
|
+
* `null` as well as `undefined`, because JSON is how a hole arrives.
|
|
32
|
+
*
|
|
33
|
+
* The advice below is about a hole, and the transport that produces one spells it `null`:
|
|
34
|
+
* `JSON.stringify` writes an absent element as `null`, so a chunk array crossing a worker
|
|
35
|
+
* boundary, a cache or a message channel comes back with `null` where nothing was. That is the
|
|
36
|
+
* same route `a-selection-from-json.test.ts` follows for the selection, and
|
|
37
|
+
* `design-decisions.md` follows for a chunk — "what parses back has no `.length` where a caller
|
|
38
|
+
* expects one".
|
|
39
|
+
*
|
|
40
|
+
* `undefined` was refused here in a sentence; `null` reached `chunk.records` on the next check
|
|
41
|
+
* and threw V8's `Cannot read properties of null (reading 'records')`. Every other wrong element
|
|
42
|
+
* — a number, a string, an object, one signal of a chunk — already had a sentence of its own, so
|
|
43
|
+
* `null` was the one value in this array that left the package without a `Next:` clause.
|
|
44
|
+
*/
|
|
45
|
+
if (chunk === undefined || chunk === null) {
|
|
31
46
|
throw new RangeError(`mergeChunks: no chunk at ${index}. Next: pass the array readWindow() returned, with no ` +
|
|
32
|
-
'holes and nothing spliced out of it.');
|
|
47
|
+
'holes and nothing spliced out of it — JSON writes one as null.');
|
|
33
48
|
}
|
|
34
49
|
/*
|
|
35
50
|
* The ELEMENTS, which the array guard below never reached.
|
package/dist/chunks.js.map
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"chunks.js","sourceRoot":"","sources":["../src/chunks.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;GAqBG;AAEH,OAAO,EAAE,iBAAiB,EAAE,MAAM,4BAA4B,CAAC;AAC/D,OAAO,EAAE,cAAc,EAAE,MAAM,gBAAgB,CAAC;AAChD,OAAO,EAAE,SAAS,EAAE,MAAM,mBAAmB,CAAC;AAC9C,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAGnD,mGAAmG;AACnG,SAAS,EAAE,CAAC,MAA2B,EAAE,KAAa;IACpD,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;IAC5B,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;
|
|
1
|
+
{"version":3,"file":"chunks.js","sourceRoot":"","sources":["../src/chunks.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;GAqBG;AAEH,OAAO,EAAE,iBAAiB,EAAE,MAAM,4BAA4B,CAAC;AAC/D,OAAO,EAAE,cAAc,EAAE,MAAM,gBAAgB,CAAC;AAChD,OAAO,EAAE,SAAS,EAAE,MAAM,mBAAmB,CAAC;AAC9C,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAGnD,mGAAmG;AACnG,SAAS,EAAE,CAAC,MAA2B,EAAE,KAAa;IACpD,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;IAC5B;;;;;;;;;;;;;;OAcG;IACH,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;QAC1C,MAAM,IAAI,UAAU,CAClB,4BAA4B,KAAK,wDAAwD;YACvF,gEAAgE,CACnE,CAAC;IACJ,CAAC;IACD;;;;;;;;;;;;;;;OAeG;IACH,IAAI,OAAQ,KAA+B,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;QACjE,MAAM,IAAI,UAAU,CAClB,6BAA6B,KAAK,OAChC,OAAQ,KAAmC,CAAC,WAAW,KAAK,QAAQ;YAClE,CAAC,CAAC,2CAA2C;YAC7C,CAAC,CAAC,GAAG,aAAa,CAAC,KAAK,CAAC,eAC7B,2FAA2F;YACzF,6DAA6D,CAChE,CAAC;IACJ,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,SAAS,cAAc,CAAC,QAAkB,EAAE,IAAc,EAAE,KAAa;IACvE,IAAI,IAAI,CAAC,aAAa,KAAK,SAAS,EAAE,CAAC;QACrC,+FAA+F;QAC/F,4FAA4F;QAC5F,yFAAyF;QACzF,6FAA6F;QAC7F,qEAAqE;QACrE,EAAE;QACF,+FAA+F;QAC/F,yFAAyF;QACzF,iEAAiE;QACjE,MAAM,GAAG,GAAG,IAAI,CAAC,aAAa,CAAC;QAC/B,MAAM,WAAW,GAAG,GAAG,CAAC,aAAa,GAAG,EAAE,CAAC;QAC3C,MAAM,IAAI,UAAU,CAClB,WAAW;YACT,CAAC,CAAC,sBAAsB,KAAK,iCAAiC,CAAC,GAAG,CAAC,eAAe,OAAO;gBACrF,wFAAwF;gBACxF,mFAAmF;gBACnF,4BAA4B;YAChC,CAAC,CAAC,sBAAsB,KAAK,4BAA4B,GAAG,CAAC,eAAe,MAAM;gBAC9E,oFAAoF;gBACpF,oFAAoF;gBACpF,+DAA+D,CACtE,CAAC;IACJ,CAAC;IAED,MAAM,aAAa,GAAG,QAAQ,CAAC,OAAO,CAAC,KAAK,GAAG,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC;IACtE,IAAI,IAAI,CAAC,OAAO,CAAC,KAAK,KAAK,aAAa,EAAE,CAAC;QACzC,MAAM,IAAI,UAAU,CAClB,sBAAsB,KAAK,qBAAqB,IAAI,CAAC,OAAO,CAAC,KAAK,yBAAyB;YACzF,cAAc,aAAa,6DAA6D;YACxF,0DAA0D,CAC7D,CAAC;IACJ,CAAC;IAED,uFAAuF;IACvF,oEAAoE;IACpE,EAAE;IACF,4FAA4F;IAC5F,2FAA2F;IAC3F,8FAA8F;IAC9F,0EAA0E;IAC1E,MAAM,gBAAgB,GAAG,QAAQ,CAAC,UAAU,GAAG,QAAQ,CAAC,aAAa,CAAC;IACtE,MAAM,cAAc,GAAG,IAAI,CAAC,UAAU,CAAC;IACvC,IAAI,gBAAgB,KAAK,cAAc,EAAE,CAAC;QACxC,yFAAyF;QACzF,wFAAwF;QACxF,8FAA8F;QAC9F,8FAA8F;QAC9F,8FAA8F;QAC9F,iFAAiF;QACjF,MAAM,UAAU,GAAG,cAAc,GAAG,gBAAgB,CAAC;QACrD,MAAM,WAAW,GAAG,UAAU,GAAG,EAAE,CAAC;QACpC,MAAM,SAAS,GAAG,cAAc,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;QACzE,MAAM,IAAI,UAAU,CAClB,sBAAsB,KAAK,cAAc,IAAI,CAAC,YAAY,mCAAmC;YAC3F,MAAM,cAAc,CAAC,gBAAgB,CAAC,OAAO;YAC7C,CAAC,WAAW;gBACV,CAAC,CAAC,iBAAiB,SAAS,4DAA4D;oBACtF,+EAA+E;oBAC/E,oFAAoF;oBACpF,QAAQ;gBACV,CAAC,CAAC,sBAAsB,SAAS,uDAAuD;oBACtF,gFAAgF;oBAChF,2CAA2C,CAAC;YAChD,uFAAuF;YACvF,6EAA6E,CAChF,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACH,MAAM,kBAAkB,GAAG,QAAQ,CAAC,UAAU,GAAG,QAAQ,CAAC,UAAU,CAAC;IACrE,IAAI,IAAI,CAAC,UAAU,KAAK,kBAAkB,EAAE,CAAC;QAC3C,MAAM,IAAI,UAAU,CAClB,sBAAsB,KAAK,mBAAmB,IAAI,CAAC,UAAU,4BAA4B;YACvF,WAAW,kBAAkB,+DAA+D;YAC5F,0FAA0F;YAC1F,0FAA0F;YAC1F,+EAA+E,CAClF,CAAC;IACJ,CAAC;IAED,IAAI,IAAI,CAAC,OAAO,CAAC,MAAM,KAAK,QAAQ,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;QACpD,MAAM,IAAI,UAAU,CAClB,sBAAsB,KAAK,YAAY,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,QAAQ,CAAC,cAAc;YAC3F,YAAY;YACZ,GAAG,QAAQ,CAAC,OAAO,CAAC,MAAM,yDAAyD;YACnF,uFAAuF,CAC1F,CAAC;IACJ,CAAC;IAED,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;QAChD,MAAM,MAAM,GAAG,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAmB,CAAC;QACrD,MAAM,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAmB,CAAC;QAChD,IAAI,KAAK,CAAC,WAAW,KAAK,MAAM,CAAC,WAAW,EAAE,CAAC;YAC7C,MAAM,IAAI,UAAU,CAClB,sBAAsB,KAAK,eAAe,KAAK,CAAC,WAAW,gBAAgB,CAAC,cAAc;gBACxF,oBAAoB,MAAM,CAAC,WAAW,iDAAiD;gBACvF,uFAAuF,CAC1F,CAAC;QACJ,CAAC;QACD,MAAM,cAAc,GAAG,MAAM,CAAC,gBAAgB,GAAG,MAAM,CAAC,WAAW,CAAC;QACpE,IAAI,KAAK,CAAC,gBAAgB,KAAK,cAAc,EAAE,CAAC;YAC9C,MAAM,IAAI,UAAU,CAClB,uBAAuB,KAAK,CAAC,WAAW,aAAa,KAAK,oBAAoB;gBAC5E,GAAG,KAAK,CAAC,gBAAgB,qCAAqC,cAAc,IAAI;gBAChF,wFAAwF;gBACxF,iDAAiD,CACpD,CAAC;QACJ,CAAC;IACH,CAAC;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,WAAW,CAAC,MAA2B;IACrD;;;;;;;;;;OAUG;IACH,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QAC3B,MAAM,IAAI,UAAU,CAClB,+BACE,OAAQ,MAA0C,EAAE,OAAO,KAAK,QAAQ;YACtE,CAAC,CAAC,wCAAwC;YAC1C,CAAC,CAAC,GAAG,aAAa,CAAC,MAAM,CAAC,gBAC9B,oFAAoF;YAClF,oDAAoD,CACvD,CAAC;IACJ,CAAC;IACD,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACxB,MAAM,IAAI,UAAU,CAClB,0FAA0F;YACxF,sFAAsF;YACtF,wBAAwB,CAC3B,CAAC;IACJ,CAAC;IAED,MAAM,KAAK,GAAG,EAAE,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAC5B,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAEtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;QAC1C,cAAc,CAAC,EAAE,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,CAAC,MAAM,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACtD,CAAC;IAED,MAAM,IAAI,GAAG,EAAE,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAE3C,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,QAAQ,EAAE,EAAE;QAC1D,IAAI,KAAK,GAAG,CAAC,CAAC;QACd,IAAI,UAAU,GAAG,CAAC,CAAC;QACnB,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC3B,MAAM,MAAM,GAAG,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAmB,CAAC;YACzD,KAAK,IAAI,MAAM,CAAC,WAAW,CAAC;YAC5B,UAAU,IAAI,MAAM,CAAC,sBAAsB,CAAC;QAC9C,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,UAAU,CAAC,KAAK,CAAC,CAAC;QACtC,IAAI,OAAO,GAAG,CAAC,CAAC;QAChB,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC3B,MAAM,MAAM,GAAG,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAmB,CAAC;YACzD,4FAA4F;YAC5F,4FAA4F;YAC5F,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,EAAE,MAAM,CAAC,WAAW,CAAC,EAAE,OAAO,CAAC,CAAC;YACrE,OAAO,IAAI,MAAM,CAAC,WAAW,CAAC;QAChC,CAAC;QAED,OAAO;YACL,WAAW,EAAE,WAAW,CAAC,WAAW;YACpC,WAAW,EAAE,KAAK;YAClB,OAAO;YACP,gBAAgB,EAAE,WAAW,CAAC,gBAAgB;YAC9C,YAAY,EAAE,WAAW,CAAC,YAAY;YACtC,UAAU,EAAE,WAAW,CAAC,UAAU;YAClC,sBAAsB,EAAE,UAAU;SACV,CAAC;IAC7B,CAAC,CAAC,CAAC;IAEH,IAAI,UAAU,GAAG,CAAC,CAAC;IACnB,MAAM,WAAW,GAAoB,EAAE,CAAC;IACxC,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,UAAU,IAAI,KAAK,CAAC,UAAU,CAAC;QAC/B,yFAAyF;QACzF,4FAA4F;QAC5F,iBAAiB,CAAC,WAAW,EAAE,KAAK,CAAC,WAAW,CAAC,CAAC;IACpD,CAAC;IAED,OAAO;QACL,OAAO,EAAE;YACP,KAAK,EAAE,KAAK,CAAC,OAAO,CAAC,KAAK;YAC1B,KAAK,EAAE,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,OAAO,CAAC,KAAK;SACrE;QACD,YAAY,EAAE,KAAK,CAAC,YAAY;QAChC,UAAU,EAAE,KAAK,CAAC,UAAU;QAC5B,6FAA6F;QAC7F,0FAA0F;QAC1F,yFAAyF;QACzF,6DAA6D;QAC7D,aAAa,EAAE,IAAI,CAAC,UAAU,GAAG,IAAI,CAAC,aAAa,GAAG,KAAK,CAAC,UAAU;QACtE,eAAe,EAAE,cAAc,CAAC,IAAI,CAAC,UAAU,GAAG,IAAI,CAAC,aAAa,GAAG,KAAK,CAAC,UAAU,CAAC;QACxF,UAAU,EAAE,KAAK,CAAC,UAAU;QAC5B,UAAU;QACV,OAAO,EAAE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC;QAC/B,wFAAwF;QACxF,sDAAsD;QACtD,aAAa,EAAE,KAAK,CAAC,aAAa;QAClC,WAAW,EAAE,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC;KACxC,CAAC;AACJ,CAAC"}
|
package/dist/constants.d.ts
CHANGED
|
@@ -109,5 +109,5 @@ export declare const SIGNAL_FIELD_BLOCK_OFFSETS: {
|
|
|
109
109
|
readonly reserved: 224;
|
|
110
110
|
};
|
|
111
111
|
/** Published package version. Kept in sync with package.json by a test. */
|
|
112
|
-
export declare const VERSION = "0.6.
|
|
112
|
+
export declare const VERSION = "0.6.228";
|
|
113
113
|
//# sourceMappingURL=constants.d.ts.map
|
package/dist/constants.js
CHANGED
package/docs/CHANGELOG.md
CHANGED
|
@@ -6,6 +6,38 @@ alone does not tell you whether you were affected.
|
|
|
6
6
|
edfcore is pre-1.0. Patch releases have carried behaviour changes where the old behaviour was a
|
|
7
7
|
defect; those are called out below.
|
|
8
8
|
|
|
9
|
+
## 0.6.228
|
|
10
|
+
|
|
11
|
+
- **Fixed** `mergeChunks` throwing V8's `Cannot read properties of null (reading 'records')` for a
|
|
12
|
+
`null` element. Every other wrong element in that array already had a sentence — `undefined` is
|
|
13
|
+
"no chunk at 0", a number, a string and an object are "the value at 0 is …, not a chunk", and one
|
|
14
|
+
signal of a chunk is named as that — so `null` was the one value in it that left the package with
|
|
15
|
+
no `Next:` clause.
|
|
16
|
+
- It is also how a hole actually arrives. The advice already says "with no holes and nothing
|
|
17
|
+
spliced out of it", and the transport that makes one spells it `null`: `JSON.stringify` writes an
|
|
18
|
+
absent element that way, so a chunk array that crossed a worker boundary, a cache or a message
|
|
19
|
+
channel comes back with `null` where nothing was.
|
|
20
|
+
- Same sentence as `undefined`, because it is the same mistake, with the spelling named.
|
|
21
|
+
|
|
22
|
+
## 0.6.227
|
|
23
|
+
|
|
24
|
+
- **Fixed** `annotationsAt` and `filterAnnotationsByTime` refusing each other's argument without
|
|
25
|
+
naming each other. They differ in one thing — an instant or an interval — and `annotationsAt`
|
|
26
|
+
exists because of it: the window form "works — a zero-length window — except that
|
|
27
|
+
`filterAnnotationsByTime` returns nothing for a non-positive duration, so the obvious call
|
|
28
|
+
returns an empty list at every position".
|
|
29
|
+
- A number where the window belongs was the costly direction, because its advice was followable. A
|
|
30
|
+
reader holding a cursor position, told to "pass a window carrying startSeconds and
|
|
31
|
+
durationSeconds", writes `{ startSeconds: t, durationSeconds: 0 }` — and gets `[]` at every
|
|
32
|
+
position, with no error, at the call a viewer makes on every mouse move. The sibling that takes
|
|
33
|
+
the number is one export away and is now named.
|
|
34
|
+
- A window where the instant belongs reached `secondsToTicks` and was told to "convert it first".
|
|
35
|
+
A window is not a number spelled differently, so there was nothing to convert; it now names
|
|
36
|
+
`window.startSeconds` and `filterAnnotationsByTime`. 0.6.88 made the same argument for
|
|
37
|
+
`readWindow` and `readRecords`, the other pair that differ only in the unit they bound by.
|
|
38
|
+
- Every other wrong window keeps the refusal it had, including the array one that names
|
|
39
|
+
`resolveTimeWindow`, and neither function's answer changes.
|
|
40
|
+
|
|
9
41
|
## 0.6.226
|
|
10
42
|
|
|
11
43
|
- **Fixed** `sampleAt`, `sampleStartTicksOf` and `sampleStartSecondsOf` calling the canonical
|
package/package.json
CHANGED
package/src/annotations-query.ts
CHANGED
|
@@ -92,9 +92,30 @@ export function filterAnnotationsByTime(
|
|
|
92
92
|
// Cannot read properties of undefined (reading 'startSeconds')`, naming a field rather than the
|
|
93
93
|
// argument, with no `Next:` clause.
|
|
94
94
|
if (typeof window !== 'object' || window === null) {
|
|
95
|
+
/*
|
|
96
|
+
* A NUMBER, which is an INSTANT, and the one wrong window whose advice led somewhere worse than
|
|
97
|
+
* where it started.
|
|
98
|
+
*
|
|
99
|
+
* "Pass a window carrying startSeconds and durationSeconds" is followable: a reader holding a
|
|
100
|
+
* cursor position writes `{ startSeconds: t, durationSeconds: 0 }`, because a window over one
|
|
101
|
+
* instant has no length. `annotationsAt`'s own docblock says what that does — the window form
|
|
102
|
+
* "works — a zero-length window — except that `filterAnnotationsByTime` returns nothing for a
|
|
103
|
+
* non-positive duration, so the obvious call returns an empty list at every position" — and it
|
|
104
|
+
* is why that function exists at all. So the advice ended in silence rather than in an error,
|
|
105
|
+
* at the call a viewer makes on every mouse move.
|
|
106
|
+
*
|
|
107
|
+
* The sibling is one export away and takes exactly what was passed. 0.6.88 made this argument
|
|
108
|
+
* for `readWindow` and `readRecords`, the other pair in this package that differ only in the
|
|
109
|
+
* unit they bound by.
|
|
110
|
+
*/
|
|
95
111
|
throw new RangeError(
|
|
96
|
-
`filterAnnotationsByTime(): the window is ${describeValue(window)}, not an object
|
|
97
|
-
|
|
112
|
+
`filterAnnotationsByTime(): the window is ${describeValue(window)}, not an object.` +
|
|
113
|
+
(typeof window === 'number'
|
|
114
|
+
? ' That is an instant, and this call bounds events by an interval — a zero-length one ' +
|
|
115
|
+
'returns nothing, so a cursor position asked for as a window reads as no annotations ' +
|
|
116
|
+
'at every position. Next: call annotationsAt(annotations, seconds), which takes the ' +
|
|
117
|
+
'instant, or pass a window carrying startSeconds and durationSeconds.'
|
|
118
|
+
: ' Next: pass a window carrying startSeconds and durationSeconds.'),
|
|
98
119
|
);
|
|
99
120
|
}
|
|
100
121
|
/*
|
|
@@ -213,6 +234,23 @@ export function annotationsAt(
|
|
|
213
234
|
seconds: number,
|
|
214
235
|
): readonly EdfAnnotation[] {
|
|
215
236
|
assertAnnotations(annotations, 'annotationsAt');
|
|
237
|
+
/*
|
|
238
|
+
* And the OTHER WAY. `filterAnnotationsByTime` is the neighbour this function's docblock names,
|
|
239
|
+
* the two differ only in whether they bound by an instant or by an interval, and a window here
|
|
240
|
+
* reached `secondsToTicks` — which answered "seconds must be a number of seconds, and was given
|
|
241
|
+
* an object. Next: convert it first". There is no conversion: a window is not a number spelled
|
|
242
|
+
* differently, and the reader was being sent to invent one.
|
|
243
|
+
*/
|
|
244
|
+
const given = seconds as { startSeconds?: unknown; durationSeconds?: unknown } | null | undefined;
|
|
245
|
+
if (typeof given === 'object' && given !== null && !Array.isArray(given)) {
|
|
246
|
+
if ('startSeconds' in given || 'durationSeconds' in given) {
|
|
247
|
+
throw new RangeError(
|
|
248
|
+
'annotationsAt(): that is a time window, and this call takes a single instant in seconds. ' +
|
|
249
|
+
'Next: pass window.startSeconds for the instant under a cursor, or call ' +
|
|
250
|
+
'filterAnnotationsByTime(annotations, window), which is the one that takes an interval.',
|
|
251
|
+
);
|
|
252
|
+
}
|
|
253
|
+
}
|
|
216
254
|
const at = secondsToTicks(seconds, 'seconds');
|
|
217
255
|
return Object.freeze(
|
|
218
256
|
annotations.filter((annotation) => {
|
package/src/chunks.ts
CHANGED
|
@@ -30,10 +30,25 @@ import type { EdfChunk, EdfChunkSignal, EdfDiagnostic } from './types.js';
|
|
|
30
30
|
/** Reads as one line at the call site, and keeps the `chunks[i]` non-null assertions out of it. */
|
|
31
31
|
function at(chunks: readonly EdfChunk[], index: number): EdfChunk {
|
|
32
32
|
const chunk = chunks[index];
|
|
33
|
-
|
|
33
|
+
/*
|
|
34
|
+
* `null` as well as `undefined`, because JSON is how a hole arrives.
|
|
35
|
+
*
|
|
36
|
+
* The advice below is about a hole, and the transport that produces one spells it `null`:
|
|
37
|
+
* `JSON.stringify` writes an absent element as `null`, so a chunk array crossing a worker
|
|
38
|
+
* boundary, a cache or a message channel comes back with `null` where nothing was. That is the
|
|
39
|
+
* same route `a-selection-from-json.test.ts` follows for the selection, and
|
|
40
|
+
* `design-decisions.md` follows for a chunk — "what parses back has no `.length` where a caller
|
|
41
|
+
* expects one".
|
|
42
|
+
*
|
|
43
|
+
* `undefined` was refused here in a sentence; `null` reached `chunk.records` on the next check
|
|
44
|
+
* and threw V8's `Cannot read properties of null (reading 'records')`. Every other wrong element
|
|
45
|
+
* — a number, a string, an object, one signal of a chunk — already had a sentence of its own, so
|
|
46
|
+
* `null` was the one value in this array that left the package without a `Next:` clause.
|
|
47
|
+
*/
|
|
48
|
+
if (chunk === undefined || chunk === null) {
|
|
34
49
|
throw new RangeError(
|
|
35
50
|
`mergeChunks: no chunk at ${index}. Next: pass the array readWindow() returned, with no ` +
|
|
36
|
-
'holes and nothing spliced out of it.',
|
|
51
|
+
'holes and nothing spliced out of it — JSON writes one as null.',
|
|
37
52
|
);
|
|
38
53
|
}
|
|
39
54
|
/*
|
package/src/constants.ts
CHANGED