edfcore 0.5.62 → 0.5.64
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/constants.d.ts +1 -1
- package/dist/constants.js +1 -1
- package/docs/CHANGELOG.md +50 -0
- package/package.json +1 -1
- package/src/constants.ts +1 -1
package/dist/constants.d.ts
CHANGED
|
@@ -109,5 +109,5 @@ export declare const SIGNAL_FIELD_BLOCK_OFFSETS: {
|
|
|
109
109
|
readonly reserved: 224;
|
|
110
110
|
};
|
|
111
111
|
/** Published package version. Kept in sync with package.json by a test. */
|
|
112
|
-
export declare const VERSION = "0.5.
|
|
112
|
+
export declare const VERSION = "0.5.64";
|
|
113
113
|
//# sourceMappingURL=constants.d.ts.map
|
package/dist/constants.js
CHANGED
package/docs/CHANGELOG.md
CHANGED
|
@@ -6,6 +6,56 @@ alone does not tell you whether you were affected.
|
|
|
6
6
|
edfcore is pre-1.0. Patch releases have carried behaviour changes where the old behaviour was a
|
|
7
7
|
defect; those are called out below.
|
|
8
8
|
|
|
9
|
+
## 0.5.64
|
|
10
|
+
|
|
11
|
+
- **Added** the reading half of "edfcore reads, it does not write". `reads-not-writes.test.ts`
|
|
12
|
+
checks the five places the package SAYS so — the README, AGENTS.md, `comparison.md`,
|
|
13
|
+
`design-decisions.md` and the npm keywords — and all five are about the missing feature: edfcore
|
|
14
|
+
produces no EDF files. None of them is about the bytes you already have, which is the exposure a
|
|
15
|
+
caller has without reading a page.
|
|
16
|
+
- It is structural rather than hypothetical. `byteSource` is zero-copy, so `readRecordBytes` hands
|
|
17
|
+
`decodeInt16` a `subarray` of the caller's own array, and a decode loop that wrote where it meant
|
|
18
|
+
to read would corrupt the caller's copy of their recording in place — with nothing downstream
|
|
19
|
+
looking wrong, because the samples returned would still be the samples that were there.
|
|
20
|
+
- `we-never-write-your-bytes.test.ts` captures the buffer, runs open, index, a full validation
|
|
21
|
+
sweep, inspect, annotations, records, windows, envelopes, a stream and scaling over it, and
|
|
22
|
+
requires it byte for byte afterwards — over all ten `AWKWARD` shapes and a gapped file, in two
|
|
23
|
+
wirings.
|
|
24
|
+
- The two wirings are the point. Behind `cachedSource` every decode runs over the cache's own copy,
|
|
25
|
+
so a write in the decoder can never reach the caller and that half of the sweep would pass
|
|
26
|
+
regardless. Unwrapped is the case that carries the property. Putting an in-place write in
|
|
27
|
+
`decodeInt16` fails the unwrapped half on eight files and leaves the cached half green, which is
|
|
28
|
+
what makes the distinction worth spelling out rather than wiring one and moving on.
|
|
29
|
+
- `fileSource` is asked the same thing of the filesystem, where a write would be worse: the bytes
|
|
30
|
+
on disk and the file's modification time both survive a full read. And the one buffer edfcore
|
|
31
|
+
does write into is asserted to BE written — `out` on `toPhysical` — so the rule reads as a rule
|
|
32
|
+
and not as a tautology.
|
|
33
|
+
|
|
34
|
+
## 0.5.63
|
|
35
|
+
|
|
36
|
+
- **Added** the other half of the zero-copy bargain. `byteSource` is documented as handing out
|
|
37
|
+
`subarray` views over the caller's own buffer, and `io/bytes.ts` argues that is safe because the
|
|
38
|
+
adapter retains nothing the caller does not already hold. That is a claim about the ADAPTER. The
|
|
39
|
+
values the reading API builds out of those views are what a caller keeps, and nothing said
|
|
40
|
+
whether any of them still points at the buffer.
|
|
41
|
+
- Two sites state the rule for themselves and neither was checked: `header/parse.ts` copies the
|
|
42
|
+
header bytes so "a header that quietly changed under a hexdump" cannot happen, and
|
|
43
|
+
`diagnostics/collector.ts` copies a diagnostic's evidence because "a diagnostic outlives the read
|
|
44
|
+
that produced it".
|
|
45
|
+
- The second is the one holding it up. `readHeader` joins its two reads into a buffer of its own,
|
|
46
|
+
so the header is copied twice over and the `copyBytes` there is belt on braces. The four
|
|
47
|
+
`rawBytes` in `tal/` are `sliceBytes` — a `subarray` of the record bytes — and `readRecordBytes`
|
|
48
|
+
returns those straight from the source. Removing the collector's `.slice()` makes a
|
|
49
|
+
`TAL_MALFORMED` diagnostic hand back a window into the caller's file, and this file fails.
|
|
50
|
+
- `nothing-points-at-your-buffer.test.ts` walks every value every entry point returns over all ten
|
|
51
|
+
`AWKWARD` shapes, a gapped file and one whose TAL onsets are not numbers, and requires every
|
|
52
|
+
typed array to be backed by some other buffer. Then it overwrites the caller's bytes end to end
|
|
53
|
+
and compares each answer against a `structuredClone` taken before — the failure a caller would
|
|
54
|
+
actually meet, having reused the array they fetched into.
|
|
55
|
+
- Two assertions keep it honest: that a `byteSource` read really does alias, so the risk is real,
|
|
56
|
+
and that the sweep reached a diagnostic quoting record bytes rather than only the header, so a
|
|
57
|
+
pass is not a pass on the one path that was never in question.
|
|
58
|
+
|
|
9
59
|
## 0.5.62
|
|
10
60
|
|
|
11
61
|
- **Fixed** `byteSource` accepting a detached `ArrayBuffer` and building a zero-byte source over
|
package/package.json
CHANGED
package/src/constants.ts
CHANGED