edfcore 0.3.19 → 0.3.20

package/CHANGELOG.md

@@ -6,6 +6,26 @@ alone does not tell you whether you were affected.
 edfcore is pre-1.0. Patch releases have carried behaviour changes where the old behaviour was a
 defect; those are called out below.
 
+## 0.3.20
+
+- **Fixed** `byteSource` refusing an `ArrayBuffer` that crossed a realm boundary — an iframe, an
+  Electron contextBridge, jsdom, a Node `vm` context. The guard tested `bytes instanceof
+  ArrayBuffer`, which is false for a buffer created in another realm, so a real, fully usable
+  552-byte file was rejected.
+- The message made it worse twice over. `describe()` had no buffer branch, so it called the
+  ArrayBuffer **"a plain object"** — pointing the reader at the wrong problem entirely — and then
+  advised them to "pass ... the ArrayBuffer itself", which is exactly what they had done. Nothing
+  in it suggested the workaround that does work, `new Uint8Array(thatBuffer)`.
+- **This was the last realm-unsafe `instanceof` on a cross-realm value in the package**, and it sat
+  twelve lines above the comment explaining why `instanceof` is wrong here, beside `isByteArray`,
+  which was rewritten off `instanceof` in 0.2.23 for this exact reason. The `SharedArrayBuffer`
+  half of the same expression already used the built-in tag. So a cross-realm `Uint8Array` was
+  accepted while the buffer behind it was not.
+- Both halves now test `Object.prototype.toString`, which reads `Symbol.toStringTag` off the buffer
+  prototype and is a value every realm agrees on. It admits nothing new: a plain object, an Array,
+  a string and a number all report a different tag, and `Int8Array` is still refused for the
+  documented reason. `describe()` names buffers, so any future refusal says what it actually got.
+
 ## 0.3.19
 
 **Two places where content was dropped under a diagnostic saying it was not.** Both are annotation

package/dist/constants.d.ts

@@ -109,5 +109,5 @@ export declare const SIGNAL_FIELD_BLOCK_OFFSETS: {
     readonly reserved: 224;
 };
 /** Published package version. Kept in sync with package.json by a test. */
-export declare const VERSION = "0.3.19";
+export declare const VERSION = "0.3.20";
 //# sourceMappingURL=constants.d.ts.map

package/dist/constants.js

@@ -79,5 +79,5 @@ export const SIGNAL_FIELD_BLOCK_OFFSETS = {
     reserved: 224,
 };
 /** Published package version. Kept in sync with package.json by a test. */
-export const VERSION = '0.3.19';
+export const VERSION = '0.3.20';
 //# sourceMappingURL=constants.js.map

package/dist/io/bytes.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"bytes.d.ts","sourceRoot":"","sources":["../../src/io/bytes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAGH,OAAO,KAAK,EAAE,UAAU,EAAe,MAAM,aAAa,CAAC;AAe3D,wBAAgB,UAAU,CAAC,KAAK,EAAE,WAAW,GAAG,UAAU,GAAG,UAAU,CAsCtE"}
+{"version":3,"file":"bytes.d.ts","sourceRoot":"","sources":["../../src/io/bytes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAGH,OAAO,KAAK,EAAE,UAAU,EAAe,MAAM,aAAa,CAAC;AAkC3D,wBAAgB,UAAU,CAAC,KAAK,EAAE,WAAW,GAAG,UAAU,GAAG,UAAU,CAoCtE"}

package/dist/io/bytes.js

@@ -21,8 +21,26 @@ function describe(value) {
         return Object.prototype.toString.call(value).slice(8, -1);
     if (Array.isArray(value))
         return 'a plain Array';
+    // Buffers are named too. Without this a refusal called them "a plain object", which sent the
+    // reader looking for the wrong problem entirely.
+    if (BUFFER_TAGS.has(Object.prototype.toString.call(value))) {
+        return Object.prototype.toString.call(value).slice(8, -1);
+    }
     return typeof value === 'object' ? 'a plain object' : `a ${typeof value}`;
 }
+/**
+ * The built-in tags, not `instanceof`.
+ *
+ * A tag comes from `Symbol.toStringTag` on the buffer prototype and every realm agrees on it;
+ * `instanceof ArrayBuffer` is false for a buffer that crossed a realm boundary — an iframe, an
+ * Electron contextBridge, jsdom, a Node `vm` context. Until 0.3.20 the ArrayBuffer half of the
+ * guard below used `instanceof` while the SharedArrayBuffer half already used the tag, so a real,
+ * fully usable ArrayBuffer from another realm was refused as "a plain object" and told to "pass
+ * the ArrayBuffer itself" — which is what the caller had done. `new Uint8Array(thatBuffer)` was
+ * accepted, because `isByteArray` twelve lines below was rewritten in 0.2.23 for this exact
+ * reason and this one was missed.
+ */
+const BUFFER_TAGS = new Set(['[object ArrayBuffer]', '[object SharedArrayBuffer]']);
 export function byteSource(bytes) {
     // Refused at CONSTRUCTION, because the alternative is worse than an error. `new Uint8Array(x)`
     // accepts almost anything: a string, a plain object and `null` all yield an empty array, and a
@@ -33,8 +51,7 @@ export function byteSource(bytes) {
     // `Int8Array` is rejected too, and deliberately: it has one byte per element so it passes any
     // length check, and its already-signed elements are sign-extended a second time during decode
     // (see `assertExactRead`). Fabricated microvolts, with no error anywhere.
-    const isBuffer = bytes instanceof ArrayBuffer ||
-        Object.prototype.toString.call(bytes) === '[object SharedArrayBuffer]';
+    const isBuffer = BUFFER_TAGS.has(Object.prototype.toString.call(bytes));
     if (!isBuffer && !isByteArray(bytes)) {
         throw new EdfSourceError(`byteSource() needs an ArrayBuffer or a Uint8Array, received ${describe(bytes)}. ` +
             'Next: pass `new Uint8Array(await blob.arrayBuffer())`, `await readFile(path)`, or the ' +

package/dist/io/bytes.js.map

@@ -1 +1 @@
-{"version":3,"file":"bytes.js","sourceRoot":"","sources":["../../src/io/bytes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,cAAc,EAAE,MAAM,cAAc,CAAC;AAE9C,OAAO,EAAE,eAAe,EAAE,eAAe,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAE5F;;;GAGG;AACH,SAAS,QAAQ,CAAC,KAAc;IAC9B,IAAI,KAAK,KAAK,IAAI;QAAE,OAAO,MAAM,CAAC;IAClC,IAAI,KAAK,KAAK,SAAS;QAAE,OAAO,WAAW,CAAC;IAC5C,IAAI,WAAW,CAAC,MAAM,CAAC,KAAK,CAAC;QAAE,OAAO,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IACzF,IAAI,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC;QAAE,OAAO,eAAe,CAAC;IACjD,OAAO,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,KAAK,OAAO,KAAK,EAAE,CAAC;AAC5E,CAAC;AAED,MAAM,UAAU,UAAU,CAAC,KAA+B;IACxD,+FAA+F;IAC/F,+FAA+F;IAC/F,+FAA+F;IAC/F,gGAAgG;IAChG,4FAA4F;IAC5F,EAAE;IACF,8FAA8F;IAC9F,8FAA8F;IAC9F,0EAA0E;IAC1E,MAAM,QAAQ,GACZ,KAAK,YAAY,WAAW;QAC5B,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,4BAA4B,CAAC;IACzE,IAAI,CAAC,QAAQ,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,EAAE,CAAC;QACrC,MAAM,IAAI,cAAc,CACtB,+DAA+D,QAAQ,CAAC,KAAK,CAAC,IAAI;YAChF,wFAAwF;YACxF,wFAAwF;YACxF,4EAA4E,EAC9E,EAAE,MAAM,EAAE,CAAC,EAAE,eAAe,EAAE,CAAC,EAAE,CAClC,CAAC;IACJ,CAAC;IAED,2FAA2F;IAC3F,oFAAoF;IACpF,MAAM,IAAI,GAAe,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,UAAU,CAAC,KAAoB,CAAC,CAAC;IAC3F,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC;IAEnC,OAAO;QACL,UAAU;QACV,KAAK,CAAC,IAAI,CAAC,MAAc,EAAE,MAAc,EAAE,OAAqB;YAC9D,cAAc,CAAC,OAAO,CAAC,CAAC;YACxB,eAAe,CAAC,MAAM,EAAE,MAAM,EAAE,UAAU,CAAC,CAAC;YAC5C,iFAAiF;YACjF,+EAA+E;YAC/E,OAAO,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC;QACjF,CAAC;KACF,CAAC;AACJ,CAAC"}
+{"version":3,"file":"bytes.js","sourceRoot":"","sources":["../../src/io/bytes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,cAAc,EAAE,MAAM,cAAc,CAAC;AAE9C,OAAO,EAAE,eAAe,EAAE,eAAe,EAAE,WAAW,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAE5F;;;GAGG;AACH,SAAS,QAAQ,CAAC,KAAc;IAC9B,IAAI,KAAK,KAAK,IAAI;QAAE,OAAO,MAAM,CAAC;IAClC,IAAI,KAAK,KAAK,SAAS;QAAE,OAAO,WAAW,CAAC;IAC5C,IAAI,WAAW,CAAC,MAAM,CAAC,KAAK,CAAC;QAAE,OAAO,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IACzF,IAAI,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC;QAAE,OAAO,eAAe,CAAC;IACjD,6FAA6F;IAC7F,iDAAiD;IACjD,IAAI,WAAW,CAAC,GAAG,CAAC,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;QAC3D,OAAO,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC5D,CAAC;IACD,OAAO,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,KAAK,OAAO,KAAK,EAAE,CAAC;AAC5E,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,CAAC,sBAAsB,EAAE,4BAA4B,CAAC,CAAC,CAAC;AAEpF,MAAM,UAAU,UAAU,CAAC,KAA+B;IACxD,+FAA+F;IAC/F,+FAA+F;IAC/F,+FAA+F;IAC/F,gGAAgG;IAChG,4FAA4F;IAC5F,EAAE;IACF,8FAA8F;IAC9F,8FAA8F;IAC9F,0EAA0E;IAC1E,MAAM,QAAQ,GAAG,WAAW,CAAC,GAAG,CAAC,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;IACxE,IAAI,CAAC,QAAQ,IAAI,CAAC,WAAW,CAAC,KAAK,CAAC,EAAE,CAAC;QACrC,MAAM,IAAI,cAAc,CACtB,+DAA+D,QAAQ,CAAC,KAAK,CAAC,IAAI;YAChF,wFAAwF;YACxF,wFAAwF;YACxF,4EAA4E,EAC9E,EAAE,MAAM,EAAE,CAAC,EAAE,eAAe,EAAE,CAAC,EAAE,CAClC,CAAC;IACJ,CAAC;IAED,2FAA2F;IAC3F,oFAAoF;IACpF,MAAM,IAAI,GAAe,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,UAAU,CAAC,KAAoB,CAAC,CAAC;IAC3F,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC;IAEnC,OAAO;QACL,UAAU;QACV,KAAK,CAAC,IAAI,CAAC,MAAc,EAAE,MAAc,EAAE,OAAqB;YAC9D,cAAc,CAAC,OAAO,CAAC,CAAC;YACxB,eAAe,CAAC,MAAM,EAAE,MAAM,EAAE,UAAU,CAAC,CAAC;YAC5C,iFAAiF;YACjF,+EAA+E;YAC/E,OAAO,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAAC,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC;QACjF,CAAC;KACF,CAAC;AACJ,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "edfcore",
-  "version": "0.3.19",
+  "version": "0.3.20",
   "description": "Modern, typed, zero-dependency reader for EDF, EDF+, BDF and BDF+ biosignal files. Works in browsers and Node with true random access.",
   "keywords": [
     "edf",

package/src/constants.ts

@@ -93,4 +93,4 @@ export const SIGNAL_FIELD_BLOCK_OFFSETS = {
 } as const;
 
 /** Published package version. Kept in sync with package.json by a test. */
-export const VERSION = '0.3.19';
+export const VERSION = '0.3.20';

package/src/io/bytes.ts

@@ -20,9 +20,28 @@ function describe(value: unknown): string {
   if (value === undefined) return 'undefined';
   if (ArrayBuffer.isView(value)) return Object.prototype.toString.call(value).slice(8, -1);
   if (Array.isArray(value)) return 'a plain Array';
+  // Buffers are named too. Without this a refusal called them "a plain object", which sent the
+  // reader looking for the wrong problem entirely.
+  if (BUFFER_TAGS.has(Object.prototype.toString.call(value))) {
+    return Object.prototype.toString.call(value).slice(8, -1);
+  }
   return typeof value === 'object' ? 'a plain object' : `a ${typeof value}`;
 }
 
+/**
+ * The built-in tags, not `instanceof`.
+ *
+ * A tag comes from `Symbol.toStringTag` on the buffer prototype and every realm agrees on it;
+ * `instanceof ArrayBuffer` is false for a buffer that crossed a realm boundary — an iframe, an
+ * Electron contextBridge, jsdom, a Node `vm` context. Until 0.3.20 the ArrayBuffer half of the
+ * guard below used `instanceof` while the SharedArrayBuffer half already used the tag, so a real,
+ * fully usable ArrayBuffer from another realm was refused as "a plain object" and told to "pass
+ * the ArrayBuffer itself" — which is what the caller had done. `new Uint8Array(thatBuffer)` was
+ * accepted, because `isByteArray` twelve lines below was rewritten in 0.2.23 for this exact
+ * reason and this one was missed.
+ */
+const BUFFER_TAGS = new Set(['[object ArrayBuffer]', '[object SharedArrayBuffer]']);
+
 export function byteSource(bytes: ArrayBuffer | Uint8Array): ByteSource {
   // Refused at CONSTRUCTION, because the alternative is worse than an error. `new Uint8Array(x)`
   // accepts almost anything: a string, a plain object and `null` all yield an empty array, and a
@@ -33,9 +52,7 @@ export function byteSource(bytes: ArrayBuffer | Uint8Array): ByteSource {
   // `Int8Array` is rejected too, and deliberately: it has one byte per element so it passes any
   // length check, and its already-signed elements are sign-extended a second time during decode
   // (see `assertExactRead`). Fabricated microvolts, with no error anywhere.
-  const isBuffer =
-    bytes instanceof ArrayBuffer ||
-    Object.prototype.toString.call(bytes) === '[object SharedArrayBuffer]';
+  const isBuffer = BUFFER_TAGS.has(Object.prototype.toString.call(bytes));
   if (!isBuffer && !isByteArray(bytes)) {
     throw new EdfSourceError(
       `byteSource() needs an ArrayBuffer or a Uint8Array, received ${describe(bytes)}. ` +