edf2csv 0.7.257 → 0.7.258

package/dist/convert/run.d.ts

@@ -78,6 +78,15 @@ export interface ConvertResult {
 }
 export declare function convert(inputPath: string, options?: ConvertOptions): Promise<ConvertResult>;
 export declare function defaultOutputDir(inputPath: string): string;
+/**
+ * Turn a Node filesystem error into something a person can act on: an errno as a sentence,
+ * so Node's own text never reaches the screen.
+ *
+ * Exported for the CLI's last-resort stdout listener, which is the third and last place a
+ * write failure becomes a message and the one that was still printing `ENOSPC: no space left
+ * on device, write`.
+ */
+export declare function describeFsError(cause: unknown): string;
 /**
  * What the durations in the events that will actually be written look like.
  *

package/dist/convert/run.js

@@ -341,8 +341,15 @@ async function prepareOutputDir(dir, force) {
         }
     }
 }
-/** Turn a Node filesystem error into something a person can act on. */
-function describeFsError(cause) {
+/**
+ * Turn a Node filesystem error into something a person can act on: an errno as a sentence,
+ * so Node's own text never reaches the screen.
+ *
+ * Exported for the CLI's last-resort stdout listener, which is the third and last place a
+ * write failure becomes a message and the one that was still printing `ENOSPC: no space left
+ * on device, write`.
+ */
+export function describeFsError(cause) {
     const code = cause?.code;
     if (code === 'EACCES' || code === 'EPERM')
         return 'permission denied';
@@ -357,6 +364,20 @@ function describeFsError(cause) {
         return 'the filesystem is read-only';
     if (code === 'ENAMETOOLONG')
         return 'the path is too long';
+    /*
+      The two `writeHint` knew and this did not, which showed once the write failures started
+      coming through here: `writeHint` reads the same errno off the same error and has a
+      sentence for eleven of them, this had seven, and the gap was the two that only a write
+      reaches. `EISDIR` is a directory sitting where an output file belongs, which is the
+      commonest way to make one of these happen on purpose.
+  
+      `EPIPE` is deliberately not here. The writer treats a reader hanging up as the ordinary
+      end of a pipeline rather than as a failure, so it never becomes a message.
+    */
+    if (code === 'EISDIR')
+        return 'a directory is sitting there already';
+    if (code === 'EMFILE' || code === 'ENFILE')
+        return 'too many files are open';
     /*
       The one this list could not describe, and the recursive mkdir above is what makes it
       surprising: every parent is created on the way, so "no such file or directory" is not a
@@ -530,8 +551,24 @@ async function writeSignalFiles(file, plan, outputDir, recordStarts, options, on
             throw new ConversionError('INPUT_UNREADABLE', cause.message, `${cause.hint ? `${cause.hint} ` : ''}What was written to ${where} before it failed is ` +
                 `incomplete and should not be used.`);
         }
-        const detail = cause instanceof Error ? cause.message : String(cause);
-        throw new ConversionError('WRITE_FAILED', `Writing to ${outputDir === null ? 'stdout' : `"${outputDir}"`} failed: ${detail}`, writeHint(cause, outputDir === null));
+        /*
+          Through `describeFsError`, like the destination errors above, and not through Node's
+          own text.
+    
+          That function exists to keep an errno and the internal call that raised it off the
+          screen — its comment says so in as many words, quoting the leak it was written for:
+          `Cannot create "dangle/x": ENOENT: no such file or directory, mkdir 'dangle'.` The
+          write failures never joined it, so a directory sitting where signals.csv belongs read
+    
+              error: Writing to "out" failed: EISDIR: illegal operation on a directory, open 'out/signals.csv'
+    
+          with the errno token, the syscall, the path repeated, and no full stop — the one
+          diagnostic shape this tool went back and fixed. The hint printed directly under it has
+          always read the same errno and said "A directory is sitting where that file belongs",
+          so the answer was in hand; it was the sentence above it that had not asked.
+        */
+        throw new ConversionError('WRITE_FAILED', `Writing to ${outputDir === null ? 'stdout' : `"${outputDir}"`} failed: ` +
+            `${describeFsError(cause)}.`, writeHint(cause, outputDir === null));
     }
 }
 /**
@@ -893,8 +930,8 @@ async function writeOutputFile(outputDir, name, contents, gzip = false, bom = fa
         await writeFile(path.join(outputDir, name), gzip ? gzipSync(contents) : contents, gzip ? undefined : 'utf8');
     }
     catch (cause) {
-        const detail = cause instanceof Error ? cause.message : String(cause);
-        throw new ConversionError('WRITE_FAILED', `Writing "${name}" to "${outputDir}" failed: ${detail}`, writeHint(cause));
+        // The same as the signal tables above; see the note there.
+        throw new ConversionError('WRITE_FAILED', `Writing "${name}" to "${outputDir}" failed: ${describeFsError(cause)}.`, writeHint(cause));
     }
 }
 async function writeChannelsCsv(outputDir, file, plan, gzip, bom) {