edf2csv 0.5.104 → 0.5.106

package/CHANGELOG.md

@@ -3,6 +3,53 @@
 Notable changes to edf2csv. Versions follow [semantic versioning](https://semver.org); while the
 major version is 0, a minor bump may contain breaking changes.
 
+## 0.5.106
+
+### Fixed: two warnings printed together, and the second denied the first
+
+```
+warning: This is a discontinuous (EDF+D) recording: its data records are not contiguous in time.
+         Each row carries its true recording time, so gaps stay visible instead of being closed.
+warning: This file is marked discontinuous but has no annotation channel, so where its records
+         sit in time is not recorded anywhere.
+         Times are written as if the records were contiguous. Any gaps are lost.
+```
+
+The column runs contiguously from zero. No row carries a true recording time, because none is
+recorded — which the second warning says plainly, four lines under the first one promising the
+opposite.
+
+The header parser raises the first, and it cannot know: whether the record starts can be derived
+is settled after the annotation channel has been read. So the promise is withdrawn where the
+answer is, the way `withoutFileRateWarning` already drops a header diagnostic the plan has
+superseded. A file that can keep it keeps it — `discontinuous.edf` still says gaps stay visible,
+and its rows still carry the nine-second gap.
+
+## 0.5.105
+
+### Fixed: a BDF+ recording was told it is "marked continuous (EDF+C)"
+
+```
+warning: This file is marked continuous (EDF+C), but 2 of its 3 data records say they start
+         somewhere other than where continuity puts them.
+         Times are written as if the records were contiguous, which is what EDF+C means. If
+         the recording really has gaps, the file should have been marked EDF+D.
+```
+
+on a file whose reserved field reads `BDF+C`. Neither `EDF+C` nor `EDF+D` appears anywhere in
+it, so a reader who greps the header for what the warning names finds nothing — and `EDF+D` is
+not a value BDF+ defines, so the remedy is for the wrong format. `continuity` normalises the
+BDF markers to the internal `EDF+` tags, and this message printed the tag.
+
+The sibling discontinuous warning has substituted the BDF spelling since 0.3.x, in the same
+file, from the same header field. The continuous branch never got it.
+
+It reads `BDF+C` and `BDF+D` for a BDF+ file now, and the test refuses either EDF marker
+anywhere in the message or its hint. An EDF file is unchanged.
+
+The same sentence counted with a hard-coded plural: "1 of its 3 data records say they start
+... where continuity puts them". It says "says it starts ... puts it" at one.
+
 ## 0.5.104
 
 ### Fixed: signals.csv and annotations.csv came out a thousand seconds apart, in silence

package/dist/cli.js

@@ -23,7 +23,7 @@ import { ChannelSelectionError } from './convert/channels.js';
 // Shared with the library so a bad option is the same error whichever way it arrived.
 import { OptionError } from './convert/options.js';
 import { TimeRangeError, parseTimeSpec } from './convert/time-range.js';
-import { deriveRecordStarts } from './convert/timing.js';
+import { deriveRecordStarts, withTimingPromiseKept } from './convert/timing.js';
 import { formatDiagnostics, formatInfo, infoJson, formatSummary, printable, printableLines, summaryJson } from './cli/report.js';
 import { counted, listed } from './format/list.js';
 import { VERSION } from './version.js';
@@ -750,7 +750,7 @@ async function showInfo(input, shared, asJson, jsonIndent, batch = false, toStdo
         audit?.verify();
         // Under --json the warnings travel inside the document, exactly as they do for a
         // conversion, so stderr stays empty and the whole result is one parseable thing.
-        const diagnostics = [...withoutFileRateWarning(file.diagnostics), ...plan.diagnostics];
+        const diagnostics = [...withTimingPromiseKept(withoutFileRateWarning(file.diagnostics), timing.starts !== null), ...plan.diagnostics];
         if (!asJson && diagnostics.length > 0) {
             /*
               Named when there is more than one recording to confuse it with.