echarts 4.5.0-rc.2 → 4.8.0

package/lib/layout/barGrid.js

@@ -263,7 +263,6 @@ function doCalBarWidthAndOffset(seriesInfoList) {
     // will be shared by series. Consider that they have default values,
     // only the attributes set on the last series will work.
     // Do not change this fact unless there will be a break change.
-    // TODO
 
     var barWidth = seriesInfo.barWidth;
 
@@ -317,7 +316,7 @@ function doCalBarWidthAndOffset(seriesInfoList) {
 
         if (finalWidth !== autoWidth) {
           column.width = finalWidth;
-          remainedWidth -= finalWidth;
+          remainedWidth -= finalWidth + barGapPercent * finalWidth;
           autoWidthCount--;
         }
       } else {
@@ -336,7 +335,7 @@ function doCalBarWidthAndOffset(seriesInfoList) {
         }
 
         column.width = finalWidth;
-        remainedWidth -= finalWidth;
+        remainedWidth -= finalWidth + barGapPercent * finalWidth;
         autoWidthCount--;
       }
     }); // Recalculate width again
@@ -428,12 +427,7 @@ function layout(seriesType, ecModel) {
 
     for (var idx = 0, len = data.count(); idx < len; idx++) {
       var value = data.get(valueDim, idx);
-      var baseValue = data.get(baseDim, idx); // If dataZoom in filteMode: 'empty', the baseValue can be set as NaN in "axisProxy".
-
-      if (isNaN(value) || isNaN(baseValue)) {
-        continue;
-      }
-
+      var baseValue = data.get(baseDim, idx);
       var sign = value >= 0 ? 'p' : 'n';
       var baseCoord = valueAxisStart; // Because of the barMinHeight, we can not use the value in
       // stackResultDimension directly.
@@ -467,9 +461,12 @@ function layout(seriesType, ecModel) {
 
         if (Math.abs(width) < barMinHeight) {
           width = (width < 0 ? -1 : 1) * barMinHeight;
-        }
+        } // Ignore stack from NaN value
+
 
-        stacked && (lastStackCoords[stackId][baseValue][sign] += width);
+        if (!isNaN(width)) {
+          stacked && (lastStackCoords[stackId][baseValue][sign] += width);
+        }
       } else {
         var coord = cartesian.dataToPoint([baseValue, value]);
         x = coord[0] + columnOffset;
@@ -480,9 +477,12 @@ function layout(seriesType, ecModel) {
         if (Math.abs(height) < barMinHeight) {
           // Include zero to has a positive bar
           height = (height <= 0 ? -1 : 1) * barMinHeight;
-        }
+        } // Ignore stack from NaN value
 
-        stacked && (lastStackCoords[stackId][baseValue][sign] += height);
+
+        if (!isNaN(height)) {
+          stacked && (lastStackCoords[stackId][baseValue][sign] += height);
+        }
       }
 
       data.setItemLayout(idx, {
@@ -506,6 +506,7 @@ var largeLayout = {
 
     var data = seriesModel.getData();
     var cartesian = seriesModel.coordinateSystem;
+    var coordLayout = cartesian.grid.getRect();
     var baseAxis = cartesian.getBaseAxis();
     var valueAxis = cartesian.getOtherAxis(baseAxis);
     var valueDim = data.mapDimension(valueAxis.dim);
@@ -526,6 +527,7 @@ var largeLayout = {
     function progress(params, data) {
       var count = params.count;
       var largePoints = new LargeArr(count * 2);
+      var largeBackgroundPoints = new LargeArr(count * 2);
       var largeDataIndices = new LargeArr(count);
       var dataIndex;
       var coord = [];
@@ -538,7 +540,9 @@ var largeLayout = {
         valuePair[1 - valueDimIdx] = data.get(baseDim, dataIndex);
         coord = cartesian.dataToPoint(valuePair, null, coord); // Data index might not be in order, depends on `progressiveChunkMode`.
 
+        largeBackgroundPoints[pointsOffset] = valueAxisHorizontal ? coordLayout.x + coordLayout.width : coord[0];
         largePoints[pointsOffset++] = coord[0];
+        largeBackgroundPoints[pointsOffset] = valueAxisHorizontal ? coord[1] : coordLayout.y + coordLayout.height;
         largePoints[pointsOffset++] = coord[1];
         largeDataIndices[idxOffset++] = dataIndex;
       }
@@ -546,8 +550,10 @@ var largeLayout = {
       data.setLayout({
         largePoints: largePoints,
         largeDataIndices: largeDataIndices,
+        largeBackgroundPoints: largeBackgroundPoints,
         barWidth: barWidth,
         valueAxisStart: getValueAxisStart(baseAxis, valueAxis, false),
+        backgroundStart: valueAxisHorizontal ? coordLayout.x : coordLayout.y,
         valueAxisHorizontal: valueAxisHorizontal
       });
     }

package/lib/layout/barPolar.js

@@ -96,11 +96,6 @@ function barLayoutPolar(seriesType, ecModel, api) {
     for (var idx = 0, len = data.count(); idx < len; idx++) {
       var value = data.get(valueDim, idx);
       var baseValue = data.get(baseDim, idx);
-
-      if (isNaN(value)) {
-        continue;
-      }
-
       var sign = value >= 0 ? 'p' : 'n';
       var baseCoord = valueAxisStart; // Because of the barMinHeight, we can not use the value in
       // stackResultDimension directly.

package/lib/loading/default.js

@@ -22,6 +22,8 @@ var zrUtil = require("zrender/lib/core/util");
 
 var graphic = require("../util/graphic");
 
+var textContain = require("zrender/lib/contain/text");
+
 /*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
@@ -54,11 +56,16 @@ function _default(api, opts) {
   opts = opts || {};
   zrUtil.defaults(opts, {
     text: 'loading',
-    color: '#c23531',
     textColor: '#000',
+    fontSize: '12px',
     maskColor: 'rgba(255, 255, 255, 0.8)',
+    showSpinner: true,
+    color: '#c23531',
+    spinnerRadius: 10,
+    lineWidth: 5,
     zlevel: 0
   });
+  var group = new graphic.Group();
   var mask = new graphic.Rect({
     style: {
       fill: opts.maskColor
@@ -66,24 +73,13 @@ function _default(api, opts) {
     zlevel: opts.zlevel,
     z: 10000
   });
-  var arc = new graphic.Arc({
-    shape: {
-      startAngle: -PI / 2,
-      endAngle: -PI / 2 + 0.1,
-      r: 10
-    },
-    style: {
-      stroke: opts.color,
-      lineCap: 'round',
-      lineWidth: 5
-    },
-    zlevel: opts.zlevel,
-    z: 10001
-  });
+  group.add(mask);
+  var font = opts.fontSize + ' sans-serif';
   var labelRect = new graphic.Rect({
     style: {
       fill: 'none',
       text: opts.text,
+      font: font,
       textPosition: 'right',
       textDistance: 10,
       textFill: opts.textColor
@@ -91,25 +87,45 @@ function _default(api, opts) {
     zlevel: opts.zlevel,
     z: 10001
   });
-  arc.animateShape(true).when(1000, {
-    endAngle: PI * 3 / 2
-  }).start('circularInOut');
-  arc.animateShape(true).when(1000, {
-    startAngle: PI * 3 / 2
-  }).delay(300).start('circularInOut');
-  var group = new graphic.Group();
-  group.add(arc);
   group.add(labelRect);
-  group.add(mask); // Inject resize
+
+  if (opts.showSpinner) {
+    var arc = new graphic.Arc({
+      shape: {
+        startAngle: -PI / 2,
+        endAngle: -PI / 2 + 0.1,
+        r: opts.spinnerRadius
+      },
+      style: {
+        stroke: opts.color,
+        lineCap: 'round',
+        lineWidth: opts.lineWidth
+      },
+      zlevel: opts.zlevel,
+      z: 10001
+    });
+    arc.animateShape(true).when(1000, {
+      endAngle: PI * 3 / 2
+    }).start('circularInOut');
+    arc.animateShape(true).when(1000, {
+      startAngle: PI * 3 / 2
+    }).delay(300).start('circularInOut');
+    group.add(arc);
+  } // Inject resize
+
 
   group.resize = function () {
-    var cx = api.getWidth() / 2;
+    var textWidth = textContain.getWidth(opts.text, font);
+    var r = opts.showSpinner ? opts.spinnerRadius : 0; // cx = (containerWidth - arcDiameter - textDistance - textWidth) / 2
+    // textDistance needs to be calculated when both animation and text exist
+
+    var cx = (api.getWidth() - r * 2 - (opts.showSpinner && textWidth ? 10 : 0) - textWidth) / 2 // only show the text
+    - (opts.showSpinner ? 0 : textWidth / 2);
     var cy = api.getHeight() / 2;
-    arc.setShape({
+    opts.showSpinner && arc.setShape({
       cx: cx,
       cy: cy
     });
-    var r = arc.shape.r;
     labelRect.setShape({
       x: cx - r,
       y: cy - r,

package/lib/model/Series.js

@@ -95,11 +95,11 @@ var SeriesModel = ComponentModel.extend({
   defaultOption: null,
 
   /**
-   * Data provided for legend
-   * @type {Function}
+   * legend visual provider to the legend component
+   * @type {Object}
    */
   // PENDING
-  legendDataProvider: null,
+  legendVisualProvider: null,
 
   /**
    * Access path of color for visual
@@ -569,7 +569,7 @@ function dataTaskReset(context) {
 
 function dataTaskProgress(param, context) {
   // Avoid repead cloneShallow when data just created in reset.
-  if (param.end > context.outputData.count()) {
+  if (context.outputData && param.end > context.outputData.count()) {
     context.model.getRawData().cloneShallow(context.outputData);
   }
 } // TODO refactor

package/lib/model/referHelper.js

@@ -56,7 +56,8 @@ var each = _util.each;
 // check: "modelHelper" of tooltip and "BrushTargetManager".
 
 /**
- * @return {Object} For example:
+ * @class
+ * For example:
  * {
  *     coordSysName: 'cartesian2d',
  *     coordSysDims: ['x', 'y', ...],
@@ -68,19 +69,46 @@ var each = _util.each;
  *         x: xAxisModel,
  *         y: undefined
  *     }),
- *     // It also indicate that whether there is category axis.
+ *     // The index of the first category axis in `coordSysDims`.
+ *     // `null/undefined` means no category axis exists.
  *     firstCategoryDimIndex: 1,
  *     // To replace user specified encode.
  * }
  */
-function getCoordSysDefineBySeries(seriesModel) {
+function CoordSysInfo(coordSysName) {
+  /**
+   * @type {string}
+   */
+  this.coordSysName = coordSysName;
+  /**
+   * @type {Array.<string>}
+   */
+
+  this.coordSysDims = [];
+  /**
+   * @type {module:zrender/core/util#HashMap}
+   */
+
+  this.axisMap = createHashMap();
+  /**
+   * @type {module:zrender/core/util#HashMap}
+   */
+
+  this.categoryAxisMap = createHashMap();
+  /**
+   * @type {number}
+   */
+
+  this.firstCategoryDimIndex = null;
+}
+/**
+ * @return {module:model/referHelper#CoordSysInfo}
+ */
+
+
+function getCoordSysInfoBySeries(seriesModel) {
   var coordSysName = seriesModel.get('coordinateSystem');
-  var result = {
-    coordSysName: coordSysName,
-    coordSysDims: [],
-    axisMap: createHashMap(),
-    categoryAxisMap: createHashMap()
-  };
+  var result = new CoordSysInfo(coordSysName);
   var fetch = fetchers[coordSysName];
 
   if (fetch) {
@@ -104,7 +132,7 @@ var fetchers = {
 
     if (isCategory(yAxisModel)) {
       categoryAxisMap.set('y', yAxisModel);
-      result.firstCategoryDimIndex = 1;
+      result.firstCategoryDimIndex == null & (result.firstCategoryDimIndex = 1);
     }
   },
   singleAxis: function (seriesModel, result, axisMap, categoryAxisMap) {
@@ -132,7 +160,7 @@ var fetchers = {
 
     if (isCategory(angleAxisModel)) {
       categoryAxisMap.set('angle', angleAxisModel);
-      result.firstCategoryDimIndex = 1;
+      result.firstCategoryDimIndex == null && (result.firstCategoryDimIndex = 1);
     }
   },
   geo: function (seriesModel, result, axisMap, categoryAxisMap) {
@@ -159,4 +187,4 @@ function isCategory(axisModel) {
   return axisModel.get('type') === 'category';
 }
 
-exports.getCoordSysDefineBySeries = getCoordSysDefineBySeries;
+exports.getCoordSysInfoBySeries = getCoordSysInfoBySeries;

package/lib/scale/Interval.js

@@ -97,10 +97,95 @@ var IntervalScale = Scale.extend({
   },
 
   /**
+   * @param {boolean} [expandToNicedExtent=false] If expand the ticks to niced extent.
    * @return {Array.<number>}
    */
-  getTicks: function () {
-    return helper.intervalScaleGetTicks(this._interval, this._extent, this._niceExtent, this._intervalPrecision);
+  getTicks: function (expandToNicedExtent) {
+    var interval = this._interval;
+    var extent = this._extent;
+    var niceTickExtent = this._niceExtent;
+    var intervalPrecision = this._intervalPrecision;
+    var ticks = []; // If interval is 0, return [];
+
+    if (!interval) {
+      return ticks;
+    } // Consider this case: using dataZoom toolbox, zoom and zoom.
+
+
+    var safeLimit = 10000;
+
+    if (extent[0] < niceTickExtent[0]) {
+      if (expandToNicedExtent) {
+        ticks.push(roundNumber(niceTickExtent[0] - interval, intervalPrecision));
+      } else {
+        ticks.push(extent[0]);
+      }
+    }
+
+    var tick = niceTickExtent[0];
+
+    while (tick <= niceTickExtent[1]) {
+      ticks.push(tick); // Avoid rounding error
+
+      tick = roundNumber(tick + interval, intervalPrecision);
+
+      if (tick === ticks[ticks.length - 1]) {
+        // Consider out of safe float point, e.g.,
+        // -3711126.9907707 + 2e-10 === -3711126.9907707
+        break;
+      }
+
+      if (ticks.length > safeLimit) {
+        return [];
+      }
+    } // Consider this case: the last item of ticks is smaller
+    // than niceTickExtent[1] and niceTickExtent[1] === extent[1].
+
+
+    var lastNiceTick = ticks.length ? ticks[ticks.length - 1] : niceTickExtent[1];
+
+    if (extent[1] > lastNiceTick) {
+      if (expandToNicedExtent) {
+        ticks.push(roundNumber(lastNiceTick + interval, intervalPrecision));
+      } else {
+        ticks.push(extent[1]);
+      }
+    }
+
+    return ticks;
+  },
+
+  /**
+   * @param {number} [splitNumber=5]
+   * @return {Array.<Array.<number>>}
+   */
+  getMinorTicks: function (splitNumber) {
+    var ticks = this.getTicks(true);
+    var minorTicks = [];
+    var extent = this.getExtent();
+
+    for (var i = 1; i < ticks.length; i++) {
+      var nextTick = ticks[i];
+      var prevTick = ticks[i - 1];
+      var count = 0;
+      var minorTicksGroup = [];
+      var interval = nextTick - prevTick;
+      var minorInterval = interval / splitNumber;
+
+      while (count < splitNumber - 1) {
+        var minorTick = numberUtil.round(prevTick + (count + 1) * minorInterval); // For the first and last interval. The count may be less than splitNumber.
+
+        if (minorTick > extent[0] && minorTick < extent[1]) {
+          minorTicksGroup.push(minorTick);
+        }
+
+        count++;
+      }
+
+      minorTicks.push(minorTicksGroup);
+    }
+
+    return minorTicks;
   },
 
   /**

package/lib/scale/Log.js

@@ -67,13 +67,14 @@ var LogScale = Scale.extend({
   },
 
   /**
+   * @param {boolean} [expandToNicedExtent=false] If expand the ticks to niced extent.
    * @return {Array.<number>}
    */
-  getTicks: function () {
+  getTicks: function (expandToNicedExtent) {
     var originalScale = this._originalScale;
     var extent = this._extent;
     var originalExtent = originalScale.getExtent();
-    return zrUtil.map(intervalScaleProto.getTicks.call(this), function (val) {
+    return zrUtil.map(intervalScaleProto.getTicks.call(this, expandToNicedExtent), function (val) {
       var powVal = numberUtil.round(mathPow(this.base, val)); // Fix #4158
 
       powVal = val === extent[0] && originalScale.__fixMin ? fixRoundingError(powVal, originalExtent[0]) : powVal;
@@ -82,6 +83,12 @@ var LogScale = Scale.extend({
     }, this);
   },
 
+  /**
+   * @param {number} splitNumber
+   * @return {Array.<Array.<number>>}
+   */
+  getMinorTicks: intervalScaleProto.getMinorTicks,
+
   /**
    * @param {number} val
    * @return {string}

package/lib/scale/helper.js

@@ -99,48 +99,6 @@ function fixExtent(niceTickExtent, extent) {
   }
 }
 
-function intervalScaleGetTicks(interval, extent, niceTickExtent, intervalPrecision) {
-  var ticks = []; // If interval is 0, return [];
-
-  if (!interval) {
-    return ticks;
-  } // Consider this case: using dataZoom toolbox, zoom and zoom.
-
-
-  var safeLimit = 10000;
-
-  if (extent[0] < niceTickExtent[0]) {
-    ticks.push(extent[0]);
-  }
-
-  var tick = niceTickExtent[0];
-
-  while (tick <= niceTickExtent[1]) {
-    ticks.push(tick); // Avoid rounding error
-
-    tick = roundNumber(tick + interval, intervalPrecision);
-
-    if (tick === ticks[ticks.length - 1]) {
-      // Consider out of safe float point, e.g.,
-      // -3711126.9907707 + 2e-10 === -3711126.9907707
-      break;
-    }
-
-    if (ticks.length > safeLimit) {
-      return [];
-    }
-  } // Consider this case: the last item of ticks is smaller
-  // than niceTickExtent[1] and niceTickExtent[1] === extent[1].
-
-
-  if (extent[1] > (ticks.length ? ticks[ticks.length - 1] : niceTickExtent[1])) {
-    ticks.push(extent[1]);
-  }
-
-  return ticks;
-}
-
 exports.intervalScaleNiceTicks = intervalScaleNiceTicks;
 exports.getIntervalPrecision = getIntervalPrecision;
-exports.fixExtent = fixExtent;
-exports.intervalScaleGetTicks = intervalScaleGetTicks;
+exports.fixExtent = fixExtent;

package/lib/stream/Scheduler.js

@@ -280,7 +280,15 @@ function performStageTasks(scheduler, stageHandlers, ecModel, payload, opt) {
           task.dirty();
         }
 
-        var performArgs = scheduler.getPerformArgs(task, opt.block);
+        var performArgs = scheduler.getPerformArgs(task, opt.block); // FIXME
+        // if intending to decalare `performRawSeries` in handlers, only
+        // stream-independent (specifically, data item independent) operations can be
+        // performed. Because is a series is filtered, most of the tasks will not
+        // be performed. A stream-dependent operation probably cause wrong biz logic.
+        // Perhaps we should not provide a separate callback for this case instead
+        // of providing the config `performRawSeries`. The stream-dependent operaions
+        // and stream-independent operations should better not be mixed.
+
         performArgs.skip = !stageHandler.performRawSeries && ecModel.isSeriesFiltered(task.context.model);
         updatePayload(task, payload);
         unfinished |= task.perform(performArgs);

package/lib/theme/dark.js

@@ -80,6 +80,9 @@ var theme = {
       },
       crossStyle: {
         color: contrastColor
+      },
+      label: {
+        color: '#000'
       }
     }
   },

package/lib/util/format.js

@@ -45,7 +45,7 @@ var numberUtil = require("./number");
 // import Text from 'zrender/src/graphic/Text';
 
 /**
- * 每三位默认加,格式化
+ * add commas after every three numbers
  * @param {string|number} x
  * @return {string}
  */
@@ -261,6 +261,22 @@ function getTextBoundingRect(opt) {
 function getTextRect(text, font, textAlign, textVerticalAlign, textPadding, rich, truncate, textLineHeight) {
   return textContain.getBoundingRect(text, font, textAlign, textVerticalAlign, textPadding, textLineHeight, rich, truncate);
 }
+/**
+ * open new tab
+ * @param {string} link url
+ * @param {string} target blank or self
+ */
+
+
+function windowOpen(link, target) {
+  if (target === '_blank' || target === 'blank') {
+    var blank = window.open();
+    blank.opener = null;
+    blank.location = link;
+  } else {
+    window.open(link, target);
+  }
+}
 
 exports.addCommas = addCommas;
 exports.toCamelCase = toCamelCase;
@@ -273,4 +289,5 @@ exports.formatTime = formatTime;
 exports.capitalFirst = capitalFirst;
 exports.truncateText = truncateText;
 exports.getTextBoundingRect = getTextBoundingRect;
-exports.getTextRect = getTextRect;
+exports.getTextRect = getTextRect;
+exports.windowOpen = windowOpen;

package/lib/util/graphic.js

@@ -727,11 +727,13 @@ function getHighlightDigit(highlightKey) {
  * @param {Object} opt Check `opt` of `setTextStyleCommon` to find other props.
  * @param {string|Function} [opt.defaultText]
  * @param {module:echarts/model/Model} [opt.labelFetcher] Fetch text by
- *      `opt.labelFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex)`
- * @param {module:echarts/model/Model} [opt.labelDataIndex] Fetch text by
- *      `opt.textFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex)`
- * @param {module:echarts/model/Model} [opt.labelDimIndex] Fetch text by
- *      `opt.textFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex)`
+ *      `opt.labelFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex, opt.labelProp)`
+ * @param {number} [opt.labelDataIndex] Fetch text by
+ *      `opt.textFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex, opt.labelProp)`
+ * @param {number} [opt.labelDimIndex] Fetch text by
+ *      `opt.textFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex, opt.labelProp)`
+ * @param {string} [opt.labelProp] Fetch text by
+ *      `opt.textFetcher.getFormattedLabel(opt.labelDataIndex, 'normal'/'emphasis', null, opt.labelDimIndex, opt.labelProp)`
  * @param {Object} [normalSpecified]
  * @param {Object} [emphasisSpecified]
  */
@@ -741,7 +743,8 @@ function setLabelStyle(normalStyle, emphasisStyle, normalModel, emphasisModel, o
   opt = opt || EMPTY_OBJ;
   var labelFetcher = opt.labelFetcher;
   var labelDataIndex = opt.labelDataIndex;
-  var labelDimIndex = opt.labelDimIndex; // This scenario, `label.normal.show = true; label.emphasis.show = false`,
+  var labelDimIndex = opt.labelDimIndex;
+  var labelProp = opt.labelProp; // This scenario, `label.normal.show = true; label.emphasis.show = false`,
   // is not supported util someone requests.
 
   var showNormal = normalModel.getShallow('show');
@@ -753,7 +756,7 @@ function setLabelStyle(normalStyle, emphasisStyle, normalModel, emphasisModel, o
 
   if (showNormal || showEmphasis) {
     if (labelFetcher) {
-      baseText = labelFetcher.getFormattedLabel(labelDataIndex, 'normal', null, labelDimIndex);
+      baseText = labelFetcher.getFormattedLabel(labelDataIndex, 'normal', null, labelDimIndex, labelProp);
     }
 
     if (baseText == null) {
@@ -762,7 +765,7 @@ function setLabelStyle(normalStyle, emphasisStyle, normalModel, emphasisModel, o
   }
 
   var normalStyleText = showNormal ? baseText : null;
-  var emphasisStyleText = showEmphasis ? zrUtil.retrieve2(labelFetcher ? labelFetcher.getFormattedLabel(labelDataIndex, 'emphasis', null, labelDimIndex) : null, baseText) : null; // Optimize: If style.text is null, text will not be drawn.
+  var emphasisStyleText = showEmphasis ? zrUtil.retrieve2(labelFetcher ? labelFetcher.getFormattedLabel(labelDataIndex, 'emphasis', null, labelDimIndex, labelProp) : null, baseText) : null; // Optimize: If style.text is null, text will not be drawn.
 
   if (normalStyleText != null || emphasisStyleText != null) {
     // Always set `textStyle` even if `normalStyle.text` is null, because default
@@ -1125,8 +1128,7 @@ function rollbackDefaultTextStyle(style) {
 }
 
 function getFont(opt, ecModel) {
-  // ecModel or default text style model.
-  var gTextStyleModel = ecModel || ecModel.getModel('textStyle');
+  var gTextStyleModel = ecModel && ecModel.getModel('textStyle');
   return zrUtil.trim([// FIXME in node-canvas fontWeight is before fontStyle
   opt.fontStyle || gTextStyleModel && gTextStyleModel.getShallow('fontStyle') || '', opt.fontWeight || gTextStyleModel && gTextStyleModel.getShallow('fontWeight') || '', (opt.fontSize || gTextStyleModel && gTextStyleModel.getShallow('fontSize') || 12) + 'px', opt.fontFamily || gTextStyleModel && gTextStyleModel.getShallow('fontFamily') || 'sans-serif'].join(' '));
 }
@@ -1168,7 +1170,7 @@ function animateOrSetProps(isUpdate, el, props, animatableModel, dataIndex, cb)
  * configuration in series.
  *
  * Caution: this method will stop previous animation.
- * So if do not use this method to one element twice before
+ * So do not use this method to one element twice before
  * animation starts, unless you know what you are doing.
  *
  * @param {module:zrender/Element} el
@@ -1195,7 +1197,7 @@ function updateProps(el, props, animatableModel, dataIndex, cb) {
  * configuration in series.
  *
  * Caution: this method will stop previous animation.
- * So if do not use this method to one element twice before
+ * So do not use this method to one element twice before
  * animation starts, unless you know what you are doing.
  *
  * @param {module:zrender/Element} el