ebay-mcp 1.8.8 → 1.8.9

package/build/api/client-trading.js

@@ -4,6 +4,9 @@ import { apiLogger } from '../utils/logger.js';
 import { isRecord } from '../utils/type-guards.js';
 const COMPAT_LEVEL = '1451';
 const SITE_ID = '0';
+/**
+ * XML-based client for eBay Trading API calls that are not covered by REST APIs.
+ */
 export class TradingApiClient {
     restClient;
     baseUrl;
@@ -12,10 +15,7 @@ export class TradingApiClient {
     constructor(restClient) {
         this.restClient = restClient;
         const env = restClient.getConfig().environment;
-        this.baseUrl =
-            env === 'sandbox'
-                ? 'https://api.sandbox.ebay.com'
-                : 'https://api.ebay.com';
+        this.baseUrl = env === 'sandbox' ? 'https://api.sandbox.ebay.com' : 'https://api.ebay.com';
         this.parser = new XMLParser({
             ignoreAttributes: false,
             removeNSPrefix: true,
@@ -43,9 +43,15 @@ export class TradingApiClient {
             suppressEmptyNode: true,
         });
     }
+    /**
+     * Return the Trading API base URL for the configured eBay environment.
+     */
     getTradingBaseUrl() {
         return this.baseUrl;
     }
+    /**
+     * Execute a named Trading API call with XML request/response conversion.
+     */
     async execute(callName, params) {
         const token = await this.restClient.getOAuthClient().getAccessToken();
         const requestTag = `${callName}Request`;
@@ -100,9 +106,7 @@ export class TradingApiClient {
         if (result.Ack === 'Failure' || result.Ack === 'PartialFailure') {
             const errors = result.Errors;
             const firstError = Array.isArray(errors) ? errors[0] : errors;
-            const message = firstError?.ShortMessage ||
-                firstError?.LongMessage ||
-                'Unknown Trading API error';
+            const message = firstError?.ShortMessage || firstError?.LongMessage || 'Unknown Trading API error';
             throw new Error(message);
         }
         return result;

package/build/api/client.js

@@ -240,8 +240,9 @@ export class EbayApiClient {
     /**
      * Set user access and refresh tokens
      */
-    async setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry) {
+    setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry) {
         this.authClient.setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry);
+        return Promise.resolve();
     }
     /**
      * Get token information for debugging

package/build/api/communication/negotiation.js

@@ -62,7 +62,7 @@ export class NegotiationApi {
      * @throws Error if the request fails
      */
     async getOffersForListing(filter, limit, offset) {
-        return this.getOffersToBuyers(filter, limit, offset);
+        return await this.getOffersToBuyers(filter, limit, offset);
     }
     /**
      * Get a specific offer

package/build/api/communication/notification.js

@@ -1,4 +1,4 @@
-import { assertRequiredString, getPathWithContextError } from './shared.js';
+import { buildContinuationParams, deleteWithApiError, getWithApiError, postWithApiError, putWithApiError, requireObject, requireString, } from '../shared/request.js';
 /**
  * Notification API - Event notifications and subscriptions
  * Based on: docs/sell-apps/communication/commerce_notification_v1_oas3.json
@@ -9,53 +9,54 @@ export class NotificationApi {
     constructor(client) {
         this.client = client;
     }
+    path(endpoint) {
+        return `${this.basePath}${endpoint}`;
+    }
+    async get(endpoint, failureMessage, params) {
+        return await getWithApiError(this.client, this.path(endpoint), failureMessage, params);
+    }
+    async post(endpoint, failureMessage, body) {
+        return await postWithApiError(this.client, this.path(endpoint), failureMessage, body);
+    }
+    async put(endpoint, failureMessage, body) {
+        return await putWithApiError(this.client, this.path(endpoint), failureMessage, body);
+    }
+    async delete(endpoint, failureMessage) {
+        return await deleteWithApiError(this.client, this.path(endpoint), failureMessage);
+    }
+    async getContinuation(endpoint, failureMessage, limit, continuationToken) {
+        return await this.get(endpoint, failureMessage, buildContinuationParams(limit, continuationToken));
+    }
     /**
      * Get public key for validating notifications
      * @param publicKeyId Public key identifier.
      * @throws Error if required parameters are missing or invalid
      */
     async getPublicKey(publicKeyId) {
-        assertRequiredString(publicKeyId, 'publicKeyId');
-        return await getPathWithContextError(this.client, `${this.basePath}/public_key/${publicKeyId}`, 'Failed to get public key');
+        requireString(publicKeyId, 'publicKeyId');
+        return await this.get(`/public_key/${publicKeyId}`, 'Failed to get public key');
     }
     /**
      * Get notification config
      * @throws Error if the request fails
      */
     async getConfig() {
-        return await getPathWithContextError(this.client, `${this.basePath}/config`, 'Failed to get config');
+        return await this.get('/config', 'Failed to get config');
     }
     /**
      * Update notification config
      * @throws Error if required parameters are missing or invalid
      */
     async updateConfig(config) {
-        if (!config || typeof config !== 'object') {
-            throw new Error('config is required and must be an object');
-        }
-        try {
-            return await this.client.put(`${this.basePath}/config`, config);
-        }
-        catch (error) {
-            throw new Error(`Failed to update config: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireObject(config, 'config');
+        return await this.put('/config', 'Failed to update config', config);
     }
     /**
      * Get all destinations (paginated)
      * @throws Error if the request fails
      */
     async getDestinations(limit, continuationToken) {
-        const params = {};
-        if (limit !== undefined)
-            params.limit = String(limit);
-        if (continuationToken)
-            params.continuation_token = continuationToken;
-        try {
-            return await this.client.get(`${this.basePath}/destination`, params);
-        }
-        catch (error) {
-            throw new Error(`Failed to get destinations: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        return await this.getContinuation('/destination', 'Failed to get destinations', limit, continuationToken);
     }
     /**
      * Get destination
@@ -63,56 +64,33 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async getDestination(destinationId) {
-        assertRequiredString(destinationId, 'destinationId');
-        return await getPathWithContextError(this.client, `${this.basePath}/destination/${destinationId}`, 'Failed to get destination');
+        requireString(destinationId, 'destinationId');
+        return await this.get(`/destination/${destinationId}`, 'Failed to get destination');
     }
     /**
      * Create destination
      * @throws Error if required parameters are missing or invalid
      */
     async createDestination(destination) {
-        if (!destination || typeof destination !== 'object') {
-            throw new Error('destination is required and must be an object');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/destination`, destination);
-        }
-        catch (error) {
-            throw new Error(`Failed to create destination: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireObject(destination, 'destination');
+        return await this.post('/destination', 'Failed to create destination', destination);
     }
     /**
      * Update destination
      * @throws Error if required parameters are missing or invalid
      */
     async updateDestination(destinationId, destination) {
-        if (!destinationId || typeof destinationId !== 'string') {
-            throw new Error('destinationId is required and must be a string');
-        }
-        if (!destination || typeof destination !== 'object') {
-            throw new Error('destination is required and must be an object');
-        }
-        try {
-            return await this.client.put(`${this.basePath}/destination/${destinationId}`, destination);
-        }
-        catch (error) {
-            throw new Error(`Failed to update destination: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(destinationId, 'destinationId');
+        requireObject(destination, 'destination');
+        return await this.put(`/destination/${destinationId}`, 'Failed to update destination', destination);
     }
     /**
      * Delete destination
      * @throws Error if required parameters are missing or invalid
      */
     async deleteDestination(destinationId) {
-        if (!destinationId || typeof destinationId !== 'string') {
-            throw new Error('destinationId is required and must be a string');
-        }
-        try {
-            return await this.client.delete(`${this.basePath}/destination/${destinationId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to delete destination: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(destinationId, 'destinationId');
+        return await this.delete(`/destination/${destinationId}`, 'Failed to delete destination');
     }
     /**
      * Get all subscriptions
@@ -120,25 +98,7 @@ export class NotificationApi {
      * @throws Error if the request fails
      */
     async getSubscriptions(limit, continuationToken) {
-        const params = {};
-        if (limit !== undefined) {
-            if (typeof limit !== 'number' || limit < 1) {
-                throw new Error('limit must be a positive number when provided');
-            }
-            params.limit = limit;
-        }
-        if (continuationToken !== undefined) {
-            if (typeof continuationToken !== 'string') {
-                throw new Error('continuationToken must be a string when provided');
-            }
-            params.continuation_token = continuationToken;
-        }
-        try {
-            return await this.client.get(`${this.basePath}/subscription`, params);
-        }
-        catch (error) {
-            throw new Error(`Failed to get subscriptions: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        return await this.getContinuation('/subscription', 'Failed to get subscriptions', limit, continuationToken);
     }
     /**
      * Create a subscription
@@ -146,15 +106,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async createSubscription(subscription) {
-        if (!subscription || typeof subscription !== 'object') {
-            throw new Error('subscription is required and must be an object');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/subscription`, subscription);
-        }
-        catch (error) {
-            throw new Error(`Failed to create subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireObject(subscription, 'subscription');
+        return await this.post('/subscription', 'Failed to create subscription', subscription);
     }
     /**
      * Get a subscription
@@ -163,8 +116,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async getSubscription(subscriptionId) {
-        assertRequiredString(subscriptionId, 'subscriptionId');
-        return await getPathWithContextError(this.client, `${this.basePath}/subscription/${subscriptionId}`, 'Failed to get subscription');
+        requireString(subscriptionId, 'subscriptionId');
+        return await this.get(`/subscription/${subscriptionId}`, 'Failed to get subscription');
     }
     /**
      * Update a subscription
@@ -172,18 +125,9 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async updateSubscription(subscriptionId, subscription) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        if (!subscription || typeof subscription !== 'object') {
-            throw new Error('subscription is required and must be an object');
-        }
-        try {
-            return await this.client.put(`${this.basePath}/subscription/${subscriptionId}`, subscription);
-        }
-        catch (error) {
-            throw new Error(`Failed to update subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        requireObject(subscription, 'subscription');
+        return await this.put(`/subscription/${subscriptionId}`, 'Failed to update subscription', subscription);
     }
     /**
      * Delete a subscription
@@ -191,15 +135,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async deleteSubscription(subscriptionId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        try {
-            return await this.client.delete(`${this.basePath}/subscription/${subscriptionId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to delete subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        return await this.delete(`/subscription/${subscriptionId}`, 'Failed to delete subscription');
     }
     /**
      * Disable a subscription
@@ -207,15 +144,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async disableSubscription(subscriptionId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/subscription/${subscriptionId}/disable`, {});
-        }
-        catch (error) {
-            throw new Error(`Failed to disable subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        return await this.post(`/subscription/${subscriptionId}/disable`, 'Failed to disable subscription', {});
     }
     /**
      * Enable a subscription
@@ -223,15 +153,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async enableSubscription(subscriptionId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/subscription/${subscriptionId}/enable`, {});
-        }
-        catch (error) {
-            throw new Error(`Failed to enable subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        return await this.post(`/subscription/${subscriptionId}/enable`, 'Failed to enable subscription', {});
     }
     /**
      * Test a subscription
@@ -239,15 +162,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async testSubscription(subscriptionId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/subscription/${subscriptionId}/test`, {});
-        }
-        catch (error) {
-            throw new Error(`Failed to test subscription: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        return await this.post(`/subscription/${subscriptionId}/test`, 'Failed to test subscription', {});
     }
     /**
      * Get a topic
@@ -256,8 +172,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async getTopic(topicId) {
-        assertRequiredString(topicId, 'topicId');
-        return await getPathWithContextError(this.client, `${this.basePath}/topic/${topicId}`, 'Failed to get topic');
+        requireString(topicId, 'topicId');
+        return await this.get(`/topic/${topicId}`, 'Failed to get topic');
     }
     /**
      * Get all topics
@@ -265,25 +181,7 @@ export class NotificationApi {
      * @throws Error if the request fails
      */
     async getTopics(limit, continuationToken) {
-        const params = {};
-        if (limit !== undefined) {
-            if (typeof limit !== 'number' || limit < 1) {
-                throw new Error('limit must be a positive number when provided');
-            }
-            params.limit = limit;
-        }
-        if (continuationToken !== undefined) {
-            if (typeof continuationToken !== 'string') {
-                throw new Error('continuationToken must be a string when provided');
-            }
-            params.continuation_token = continuationToken;
-        }
-        try {
-            return await this.client.get(`${this.basePath}/topic`, params);
-        }
-        catch (error) {
-            throw new Error(`Failed to get topics: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        return await this.getContinuation('/topic', 'Failed to get topics', limit, continuationToken);
     }
     /**
      * Create a subscription filter
@@ -291,18 +189,9 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async createSubscriptionFilter(subscriptionId, filter) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        if (!filter || typeof filter !== 'object') {
-            throw new Error('filter is required and must be an object');
-        }
-        try {
-            return await this.client.post(`${this.basePath}/subscription/${subscriptionId}/filter`, filter);
-        }
-        catch (error) {
-            throw new Error(`Failed to create subscription filter: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        requireObject(filter, 'filter');
+        return await this.post(`/subscription/${subscriptionId}/filter`, 'Failed to create subscription filter', filter);
     }
     /**
      * Get a subscription filter
@@ -310,18 +199,9 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async getSubscriptionFilter(subscriptionId, filterId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        if (!filterId || typeof filterId !== 'string') {
-            throw new Error('filterId is required and must be a string');
-        }
-        try {
-            return await this.client.get(`${this.basePath}/subscription/${subscriptionId}/filter/${filterId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to get subscription filter: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        requireString(filterId, 'filterId');
+        return await this.get(`/subscription/${subscriptionId}/filter/${filterId}`, 'Failed to get subscription filter');
     }
     /**
      * Delete a subscription filter
@@ -329,17 +209,8 @@ export class NotificationApi {
      * @throws Error if required parameters are missing or invalid
      */
     async deleteSubscriptionFilter(subscriptionId, filterId) {
-        if (!subscriptionId || typeof subscriptionId !== 'string') {
-            throw new Error('subscriptionId is required and must be a string');
-        }
-        if (!filterId || typeof filterId !== 'string') {
-            throw new Error('filterId is required and must be a string');
-        }
-        try {
-            return await this.client.delete(`${this.basePath}/subscription/${subscriptionId}/filter/${filterId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to delete subscription filter: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        requireString(subscriptionId, 'subscriptionId');
+        requireString(filterId, 'filterId');
+        return await this.delete(`/subscription/${subscriptionId}/filter/${filterId}`, 'Failed to delete subscription filter');
     }
 }

package/build/api/communication/shared.js

@@ -1,4 +1,5 @@
 import { buildValidatedPaginatedParams } from '../shared/query-params.js';
+import { getWithApiError, requireString } from '../shared/request.js';
 /**
  * Build validated pagination query params.
  *
@@ -17,9 +18,7 @@ export function buildPaginatedQueryParams(filter, limit, offset) {
  * @param paramName Parameter name used in error text.
  */
 export function assertRequiredString(value, paramName) {
-    if (!value || typeof value !== 'string') {
-        throw new Error(`${paramName} is required and must be a string`);
-    }
+    requireString(value, paramName);
 }
 /**
  * Perform a GET request and wrap errors with endpoint-specific context.
@@ -30,12 +29,7 @@ export function assertRequiredString(value, paramName) {
  * @returns API response payload.
  */
 export async function getPathWithContextError(client, path, failureMessage) {
-    try {
-        return await client.get(path);
-    }
-    catch (error) {
-        throw new Error(`${failureMessage}: ${error instanceof Error ? error.message : 'Unknown error'}`);
-    }
+    return await getWithApiError(client, path, failureMessage);
 }
 /**
  * Perform a GET request with query params and wrap errors with endpoint-specific context.
@@ -47,12 +41,7 @@ export async function getPathWithContextError(client, path, failureMessage) {
  * @returns API response payload.
  */
 export async function getWithContextError(client, path, params, failureMessage) {
-    try {
-        return await client.get(path, params);
-    }
-    catch (error) {
-        throw new Error(`${failureMessage}: ${error instanceof Error ? error.message : 'Unknown error'}`);
-    }
+    return await getWithApiError(client, path, failureMessage, params);
 }
 /**
  * Perform a paginated GET request with validated filter/limit/offset params.