ebay-mcp 1.8.5 → 1.8.9

package/README.md

@@ -8,7 +8,6 @@
 [![API Coverage](https://img.shields.io/badge/API%20coverage-100%25-success)](src/tools/)
 [![License](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE)
 [![Contributors Welcome](https://img.shields.io/badge/contributors-welcome-brightgreen.svg)](CONTRIBUTING.md)
-[![grimoire-wizard](https://img.shields.io/npm/v/grimoire-wizard?label=wizard%3A+grimoire&color=0064D2)](https://github.com/YosefHayim/grimoire)
 
 [![MseeP.ai Security Assessment Badge](https://mseep.net/pr/yosefhayim-ebay-api-mcp-server-badge.png)](https://mseep.ai/app/yosefhayim-ebay-api-mcp-server)
 <a href="https://www.buymeacoffee.com/yosefhayim" target="_blank"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 60px !important;width: 217px !important;" ></a>
@@ -158,7 +157,7 @@ The interactive setup wizard handles everything for you:
 npm run setup
 ```
 
-> **Powered by [grimoire-wizard](https://github.com/YosefHayim/grimoire)** — a config-driven CLI wizard framework [![grimoire-wizard](https://img.shields.io/npm/v/grimoire-wizard?label=grimoire-wizard&color=0064D2)](https://www.npmjs.com/package/grimoire-wizard)
+> Built with a standard Node CLI prompt stack for reliable interactive setup.
 
 The wizard will:
 

package/build/api/client-trading.js

@@ -1,8 +1,12 @@
 import axios from 'axios';
 import { XMLBuilder, XMLParser } from 'fast-xml-parser';
 import { apiLogger } from '../utils/logger.js';
+import { isRecord } from '../utils/type-guards.js';
 const COMPAT_LEVEL = '1451';
 const SITE_ID = '0';
+/**
+ * XML-based client for eBay Trading API calls that are not covered by REST APIs.
+ */
 export class TradingApiClient {
     restClient;
     baseUrl;
@@ -11,10 +15,7 @@ export class TradingApiClient {
     constructor(restClient) {
         this.restClient = restClient;
         const env = restClient.getConfig().environment;
-        this.baseUrl =
-            env === 'sandbox'
-                ? 'https://api.sandbox.ebay.com'
-                : 'https://api.ebay.com';
+        this.baseUrl = env === 'sandbox' ? 'https://api.sandbox.ebay.com' : 'https://api.ebay.com';
         this.parser = new XMLParser({
             ignoreAttributes: false,
             removeNSPrefix: true,
@@ -42,9 +43,15 @@ export class TradingApiClient {
             suppressEmptyNode: true,
         });
     }
-    getBaseUrl() {
+    /**
+     * Return the Trading API base URL for the configured eBay environment.
+     */
+    getTradingBaseUrl() {
         return this.baseUrl;
     }
+    /**
+     * Execute a named Trading API call with XML request/response conversion.
+     */
     async execute(callName, params) {
         const token = await this.restClient.getOAuthClient().getAccessToken();
         const requestTag = `${callName}Request`;
@@ -75,12 +82,20 @@ export class TradingApiClient {
         }
         let parsed;
         try {
-            parsed = this.parser.parse(response.data);
+            const parsedValue = this.parser.parse(response.data);
+            if (!isRecord(parsedValue)) {
+                throw new Error('Trading API response must be an object');
+            }
+            parsed = parsedValue;
         }
         catch (e) {
             throw new Error(`Failed to parse Trading API ${callName} response: ${e instanceof Error ? e.message : String(e)}`);
         }
-        const result = (parsed[responseTag] || parsed);
+        const resultValue = parsed[responseTag] || parsed;
+        if (!isRecord(resultValue)) {
+            throw new Error(`Trading API ${callName} response payload is not an object`);
+        }
+        const result = resultValue;
         // Log warnings without failing
         if (result.Ack === 'Warning') {
             apiLogger.warn(`Trading API ${callName} returned warnings`, {
@@ -91,9 +106,7 @@ export class TradingApiClient {
         if (result.Ack === 'Failure' || result.Ack === 'PartialFailure') {
             const errors = result.Errors;
             const firstError = Array.isArray(errors) ? errors[0] : errors;
-            const message = firstError?.ShortMessage ||
-                firstError?.LongMessage ||
-                'Unknown Trading API error';
+            const message = firstError?.ShortMessage || firstError?.LongMessage || 'Unknown Trading API error';
             throw new Error(message);
         }
         return result;

package/build/api/client.js

@@ -240,8 +240,9 @@ export class EbayApiClient {
     /**
      * Set user access and refresh tokens
      */
-    async setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry) {
+    setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry) {
         this.authClient.setUserTokens(accessToken, refreshToken, accessTokenExpiry, refreshTokenExpiry);
+        return Promise.resolve();
     }
     /**
      * Get token information for debugging

package/build/api/communication/feedback.js

@@ -1,3 +1,4 @@
+import { getPaginatedWithContextError, getPathWithContextError } from './shared.js';
 /**
  * Feedback API - Manage buyer and seller feedback
  * Based on: docs/sell-apps/communication/commerce_feedback_v1_beta_oas3.json
@@ -11,34 +12,13 @@ export class FeedbackApi {
     /**
      * Get items awaiting feedback
      * Endpoint: GET /awaiting_feedback
+     * @param filter API filter expression.
+     * @param limit Maximum number of records to return.
+     * @param offset Zero-based pagination offset.
      * @throws Error if the request fails
      */
     async getAwaitingFeedback(filter, limit, offset) {
-        const params = {};
-        if (filter !== undefined) {
-            if (typeof filter !== 'string') {
-                throw new Error('filter must be a string when provided');
-            }
-            params.filter = filter;
-        }
-        if (limit !== undefined) {
-            if (typeof limit !== 'number' || limit < 1) {
-                throw new Error('limit must be a positive number when provided');
-            }
-            params.limit = limit;
-        }
-        if (offset !== undefined) {
-            if (typeof offset !== 'number' || offset < 0) {
-                throw new Error('offset must be a non-negative number when provided');
-            }
-            params.offset = offset;
-        }
-        try {
-            return await this.client.get(`${this.basePath}/awaiting_feedback`, params);
-        }
-        catch (error) {
-            throw new Error(`Failed to get awaiting feedback: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        return await getPaginatedWithContextError(this.client, `${this.basePath}/awaiting_feedback`, 'Failed to get awaiting feedback', filter, limit, offset);
     }
     /**
      * Get feedback for a transaction
@@ -64,12 +44,7 @@ export class FeedbackApi {
      * @throws Error if the request fails
      */
     async getFeedbackRatingSummary() {
-        try {
-            return await this.client.get(`${this.basePath}/feedback_rating_summary`);
-        }
-        catch (error) {
-            throw new Error(`Failed to get feedback rating summary: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        return await getPathWithContextError(this.client, `${this.basePath}/feedback_rating_summary`, 'Failed to get feedback rating summary');
     }
     /**
      * Leave feedback for a buyer

package/build/api/communication/message.js

@@ -1,3 +1,4 @@
+import { assertRequiredString, buildPaginatedQueryParams, getPathWithContextError, getWithContextError, } from './shared.js';
 /**
  * Message API - Buyer-seller messaging
  * Based on: docs/sell-apps/communication/commerce_message_v1_oas3.json
@@ -27,50 +28,36 @@ export class MessageApi {
     /**
      * Get conversations
      * Endpoint: GET /conversation
+     * @param filter API filter expression.
+     * @param limit Maximum number of records to return.
+     * @param offset Zero-based pagination offset.
      * @throws Error if the request fails
      */
     async getConversations(filter, limit, offset) {
-        const params = {};
-        if (filter !== undefined) {
-            if (typeof filter !== 'string') {
-                throw new Error('filter must be a string when provided');
-            }
-            params.filter = filter;
-        }
-        if (limit !== undefined) {
-            if (typeof limit !== 'number' || limit < 1) {
-                throw new Error('limit must be a positive number when provided');
-            }
-            params.limit = limit;
-        }
-        if (offset !== undefined) {
-            if (typeof offset !== 'number' || offset < 0) {
-                throw new Error('offset must be a non-negative number when provided');
-            }
-            params.offset = offset;
-        }
-        try {
-            return await this.client.get(`${this.basePath}/conversation`, params);
-        }
-        catch (error) {
-            throw new Error(`Failed to get conversations: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        const conversationPath = `${this.basePath}/conversation`;
+        const queryParams = this.buildConversationQueryParams(filter, limit, offset);
+        return await getWithContextError(this.client, conversationPath, queryParams, 'Failed to get conversations');
+    }
+    /**
+     * Build query params used by conversation listing endpoints.
+     *
+     * @param filter API filter expression.
+     * @param limit Maximum number of records to return.
+     * @param offset Zero-based pagination offset.
+     * @returns Validated conversation query params.
+     */
+    buildConversationQueryParams(filter, limit, offset) {
+        return buildPaginatedQueryParams(filter, limit, offset);
     }
     /**
      * Get a specific conversation
      * Endpoint: GET /conversation/{conversation_id}
+     * @param conversationId Conversation identifier.
      * @throws Error if required parameters are missing or invalid
      */
     async getConversation(conversationId) {
-        if (!conversationId || typeof conversationId !== 'string') {
-            throw new Error('conversationId is required and must be a string');
-        }
-        try {
-            return await this.client.get(`${this.basePath}/conversation/${conversationId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to get conversation: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        assertRequiredString(conversationId, 'conversationId');
+        return await getPathWithContextError(this.client, `${this.basePath}/conversation/${conversationId}`, 'Failed to get conversation');
     }
     /**
      * Send a message

package/build/api/communication/negotiation.js

@@ -1,3 +1,5 @@
+import { assertRequiredString, buildPaginatedQueryParams, getPathWithContextError, getWithContextError, } from './shared.js';
+import { buildTruthyPaginatedParams } from '../shared/query-params.js';
 /**
  * Negotiation API - Buyer-seller negotiations and offers
  * Based on: docs/sell-apps/communication/sell_negotiation_v1_oas3.json
@@ -11,30 +13,17 @@ export class NegotiationApi {
     /**
      * Find eligible items for a seller-initiated offer
      * Endpoint: GET /find_eligible_items
+     * @param filter API filter expression.
+     * @param limit Maximum number of records to return.
+     * @param offset Zero-based pagination offset.
      * @throws Error if the request fails
      */
     async findEligibleItems(filter, limit, offset) {
-        const params = {};
-        if (filter !== undefined) {
-            if (typeof filter !== 'string') {
-                throw new Error('filter must be a string when provided');
-            }
-            params.filter = filter;
-        }
-        if (limit !== undefined) {
-            if (typeof limit !== 'number' || limit < 1) {
-                throw new Error('limit must be a positive number when provided');
-            }
-            params.limit = limit;
-        }
-        if (offset !== undefined) {
-            if (typeof offset !== 'number' || offset < 0) {
-                throw new Error('offset must be a non-negative number when provided');
-            }
-            params.offset = offset;
-        }
+        const eligibleItemsPath = `${this.basePath}/find_eligible_items`;
+        const queryParams = buildPaginatedQueryParams(filter, limit, offset);
         try {
-            return await this.client.get(`${this.basePath}/find_eligible_items`, params);
+            const response = await this.client.get(eligibleItemsPath, queryParams);
+            return response;
         }
         catch (error) {
             throw new Error(`Failed to find eligible items: ${error instanceof Error ? error.message : 'Unknown error'}`);
@@ -58,17 +47,14 @@ export class NegotiationApi {
     }
     /**
      * Get offers to buyers (Best Offers)
+     * @param filter API filter expression.
+     * @param limit Maximum number of records to return.
+     * @param offset Zero-based pagination offset.
      * @deprecated This method does not match any endpoint in the OpenAPI spec
      */
     async getOffersToBuyers(filter, limit, offset) {
-        const params = {};
-        if (filter)
-            params.filter = filter;
-        if (limit)
-            params.limit = limit;
-        if (offset)
-            params.offset = offset;
-        return await this.client.get(`${this.basePath}/offer`, params);
+        const params = buildTruthyPaginatedParams(filter, limit, offset);
+        return await getWithContextError(this.client, `${this.basePath}/offer`, params, 'Failed to get offers to buyers');
     }
     /**
      * Get offers for listing (alias for getOffersToBuyers)
@@ -76,22 +62,16 @@ export class NegotiationApi {
      * @throws Error if the request fails
      */
     async getOffersForListing(filter, limit, offset) {
-        return this.getOffersToBuyers(filter, limit, offset);
+        return await this.getOffersToBuyers(filter, limit, offset);
     }
     /**
      * Get a specific offer
      * Endpoint: GET /offer/{offerId}
+     * @param offerId Offer identifier.
      * @throws Error if required parameters are missing or invalid
      */
     async getOffer(offerId) {
-        if (!offerId || typeof offerId !== 'string') {
-            throw new Error('offerId is required and must be a string');
-        }
-        try {
-            return await this.client.get(`${this.basePath}/offer/${offerId}`);
-        }
-        catch (error) {
-            throw new Error(`Failed to get offer: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
+        assertRequiredString(offerId, 'offerId');
+        return await getPathWithContextError(this.client, `${this.basePath}/offer/${offerId}`, 'Failed to get offer');
     }
 }