ebay-mcp-remote-edition 2.0.12 → 2.0.14

package/build/auth/kv-store.js

@@ -6,25 +6,28 @@ import axios from 'axios';
  * All data is lost on process restart.
  */
 export class InMemoryKVStore {
+    backendName = 'InMemoryKVStore';
     store = new Map();
-    async get(key) {
+    get(key) {
         const entry = this.store.get(key);
         if (!entry)
-            return null;
+            return Promise.resolve(null);
         if (entry.expiresAt !== undefined && Date.now() > entry.expiresAt) {
             this.store.delete(key);
-            return null;
+            return Promise.resolve(null);
         }
-        return entry.value;
+        return Promise.resolve(entry.value);
     }
-    async put(key, value, expirationTtl) {
+    put(key, value, expirationTtl) {
         this.store.set(key, {
             value,
             expiresAt: expirationTtl !== undefined ? Date.now() + expirationTtl * 1_000 : undefined,
         });
+        return Promise.resolve();
     }
-    async delete(key) {
+    delete(key) {
         this.store.delete(key);
+        return Promise.resolve();
     }
 }
 /**
@@ -32,6 +35,7 @@ export class InMemoryKVStore {
  * Used when EBAY_TOKEN_STORE_BACKEND=cloudflare-kv (the default for hosted deployments).
  */
 export class CloudflareKVStore {
+    backendName = 'CloudflareKVStore';
     client;
     accountId;
     namespaceId;
@@ -100,10 +104,25 @@ export class CloudflareKVStore {
         this.cache.clear();
     }
 }
-// ── Factory ───────────────────────────────────────────────────────────────────
+// ── Singleton factory ─────────────────────────────────────────────────────────
+/**
+ * Process-level singleton KV store.
+ *
+ * All callers within the same Node.js process share one backend instance.
+ * This is the root cause guard: it makes it impossible for two different
+ * MultiUserAuthStore instances to accidentally resolve to different backends
+ * (e.g. one reading EBAY_TOKEN_STORE_BACKEND before dotenv runs and one after).
+ *
+ * The singleton is lazy: it is created on the first call to `createKVStore()`
+ * and reused for every subsequent call.
+ *
+ * For automated tests only, call `resetKVStoreSingleton()` between test cases
+ * that need to swap the backend.
+ */
+let _kvStoreSingleton = null;
 /**
- * Returns the appropriate KV store backend based on the EBAY_TOKEN_STORE_BACKEND
- * environment variable:
+ * Returns (or lazily creates) the process-wide KV store singleton based on the
+ * EBAY_TOKEN_STORE_BACKEND environment variable:
  *
  *   memory        → InMemoryKVStore  (no external dependencies, data lost on restart)
  *   cloudflare-kv → CloudflareKVStore (default; requires CLOUDFLARE_* env vars)
@@ -112,14 +131,39 @@ export class CloudflareKVStore {
  * existing hosted deployments continue to work without any config change.
  */
 export function createKVStore() {
-    const backend = (process.env.EBAY_TOKEN_STORE_BACKEND ?? 'cloudflare-kv').toLowerCase().trim();
+    if (_kvStoreSingleton) {
+        return _kvStoreSingleton;
+    }
+    const rawEnv = process.env.EBAY_TOKEN_STORE_BACKEND;
+    const backend = (rawEnv ?? 'cloudflare-kv').toLowerCase().trim();
+    // Log exactly once, at the point the singleton is first constructed.
     switch (backend) {
         case 'memory':
-        case 'in-memory':
-            return new InMemoryKVStore();
+        case 'in-memory': {
+            console.log(`[kv-store] EBAY_TOKEN_STORE_BACKEND="${rawEnv ?? ''}" → using InMemoryKVStore (no external KV calls)`);
+            _kvStoreSingleton = new InMemoryKVStore();
+            break;
+        }
         case 'cloudflare-kv':
         case 'cloudflare':
-        default:
-            return new CloudflareKVStore();
+        default: {
+            console.log(`[kv-store] EBAY_TOKEN_STORE_BACKEND="${rawEnv ?? '(unset)'}" → using CloudflareKVStore (accountId="${process.env.CLOUDFLARE_ACCOUNT_ID ?? '(unset)'}") — set EBAY_TOKEN_STORE_BACKEND=memory to disable`);
+            _kvStoreSingleton = new CloudflareKVStore();
+            break;
+        }
     }
+    return _kvStoreSingleton;
+}
+/**
+ * **TEST USE ONLY** – resets (or replaces) the process-wide KV store singleton.
+ *
+ * Call this in `afterEach`/`beforeEach` when a test needs to control which
+ * backend is in use without mutating `process.env.EBAY_TOKEN_STORE_BACKEND`.
+ *
+ * @param replacement  Optional KV store to install as the new singleton.
+ *                     Pass `null` (default) to clear the singleton so that the
+ *                     next `createKVStore()` call rebuilds it from env.
+ */
+export function resetKVStoreSingleton(replacement = null) {
+    _kvStoreSingleton = replacement;
 }

package/build/auth/multi-user-store.js

@@ -1,7 +1,19 @@
 import { randomUUID } from 'crypto';
 import { createKVStore } from '../auth/kv-store.js';
 export class MultiUserAuthStore {
-    kv = createKVStore();
+    kv;
+    /**
+     * @param kv  Optional KV store override. If omitted the process-wide singleton
+     *            returned by `createKVStore()` is used (the normal production path).
+     *            Pass an explicit store in unit tests to avoid touching env vars.
+     */
+    constructor(kv) {
+        this.kv = kv ?? createKVStore();
+    }
+    /** Returns the backend name of the underlying KV store (e.g. "InMemoryKVStore"). */
+    get backendName() {
+        return this.kv.backendName;
+    }
     /**
      * In-memory map of sessionToken → timestamp of last KV write for touchSession.
      * Prevents a KV PUT on every single authenticated request — we only persist

package/build/server-http.js

@@ -21,6 +21,10 @@ const CONFIG = {
     oauthStartKey: process.env.OAUTH_START_KEY ?? '',
 };
 const authStore = new MultiUserAuthStore();
+// Emit the concrete backend class so logs can never claim "memory" while
+// actually using Cloudflare (or vice-versa).  This fires once on startup,
+// after dotenv has already been loaded by the config/environment import.
+console.log(`[auth-store] Active KV backend: ${authStore.backendName}`);
 function getServerBaseUrl() {
     return CONFIG.publicBaseUrl || `http://localhost:${CONFIG.port}`;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ebay-mcp-remote-edition",
-  "version": "2.0.12",
+  "version": "2.0.14",
   "description": "Remote + Local MCP server for eBay APIs - provides access to eBay developer functionality through MCP (Model Context Protocol)",
   "type": "module",
   "main": "build/index.js",