eagle-mem 4.13.0 → 4.13.1

package/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to the **Eagle Mem** project are documented here.
 
 ---
 
+## v4.13.1 Test-Suite & Packaging Hygiene
+
+Follow-up cleanup that clears the bounded items left after the v4.13.0 review. No runtime behavior change for normal sessions.
+
+- **`eagle-mem test` is now green from a published install.** Two suites failed when run from an installed package rather than a source checkout:
+  - *Compaction Survival Matrix* created its fixture repo inside `$ROOT_DIR`; from a published install that path is under `node_modules/`, which the code scanner excludes — so the fixture indexed 0 files and the post-compact "Relevant Code" recall never appeared. The fixture now lives in a neutral system temp dir and is indexed explicitly (no longer relying on a racy background auto-index).
+  - *Rust Migration Plan* guards `MIGRATION.md`, a maintainer roadmap intentionally not shipped in the npm package. It now **skips cleanly** when the doc is absent and runs strictly from a source checkout.
+  - The test runner learned an honest **"skipped"** state (a dev-only contract test with absent preconditions is neither a pass nor a failure).
+- **Antigravity Python hook test is now in the suite.** `tests/test_antigravity_hook.py` (mocked, stdlib-only) ran only by hand before; it's now a guarded python lane that skips cleanly if `python3` is unavailable.
+- **One source of truth for Claude hook registration.** `install.sh` and `update.sh` each held their own copy of the event→matcher→script mapping (the historical drift class). Extracted `eagle_register_claude_hooks` into `lib/hooks.sh`; both call it (installer verbose, updater quiet). Behavior preserved exactly.
+- **Dead-function sweep — analyzed, nothing removed.** A full cross-surface call-graph (`.sh`/`.py`/`.js`/skills/`bin`, 280 functions) found zero unreferenced functions and no computed-name dispatch; the "no shell caller" candidates are all reached via tests, skills, adapters, or the public CLI. Removing any would be regression risk with no benefit.
+
+---
+
 ## v4.13.0 Full-Spectrum Security & Reliability Hardening
 
 A six-lens fix-in-place review of the whole codebase (security, data integrity, reliability, token economy, code quality, architecture). 32 files hardened, 6 new regression suites, full smoke suite green. No behavioral surface for normal sessions changed — recall and capture are byte-for-byte the same; what changed is the failure, concurrency, and trust behavior underneath.

package/lib/hooks.sh

@@ -100,3 +100,40 @@ eagle_patch_hook() {
     [ -n "$description" ] && eagle_ok "$description"
     return 0
 }
+
+# Register (idempotently) the full Claude Code hook set into a settings.json.
+# Single source of truth for the event→matcher→script mapping so install.sh and
+# update.sh can never drift (the historical bug class). Requires $EAGLE_MEM_DIR.
+#   $1 = settings.json path
+#   $2 = "verbose" to print a "✓ <Event> hook" line per registration (installer);
+#        omitted/anything else = quiet (updater prints its own summary line).
+eagle_register_claude_hooks() {
+    local settings="$1"
+    local V=""
+    [ "${2:-}" = "verbose" ] && V=1
+
+    # Clean old registrations before re-registering (handles matcher changes across versions).
+    eagle_clean_hook_entries "$settings" "Stop" "$EAGLE_MEM_DIR/hooks/stop.sh"
+    eagle_clean_hook_entries "$settings" "PostToolUse" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
+    eagle_clean_hook_entries "$settings" "PreToolUse" "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh"
+
+    # ${V:+label} expands to the label only in verbose mode; otherwise to "",
+    # which makes eagle_patch_hook silent (it only prints when given a description).
+    eagle_patch_hook "$settings" "SessionStart" "" "$EAGLE_MEM_DIR/hooks/session-start.sh" "${V:+SessionStart hook}"
+    eagle_patch_hook "$settings" "Stop" "" "bash \"$EAGLE_MEM_DIR/hooks/stop.sh\"" "${V:+Stop hook}"
+    eagle_patch_hook "$settings" "PostToolUse" "Read|Write|Edit|Bash|TaskUpdate" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" "${V:+PostToolUse hook}"
+    eagle_patch_hook "$settings" "TaskCreated" "" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" "${V:+TaskCreated hook}"
+    eagle_patch_hook "$settings" "TaskCompleted" "" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" "${V:+TaskCompleted hook}"
+    eagle_patch_hook "$settings" "SessionEnd" "" "$EAGLE_MEM_DIR/hooks/session-end.sh" "${V:+SessionEnd hook}"
+    eagle_patch_hook "$settings" "UserPromptSubmit" "" "$EAGLE_MEM_DIR/hooks/user-prompt-submit.sh" "${V:+UserPromptSubmit hook}"
+    eagle_patch_hook "$settings" "PreToolUse" "Bash|Read|Edit|Write" "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh" "${V:+PreToolUse hook}"
+
+    # Allow agent-issued session capture to run without a permission prompt.
+    if eagle_patch_permission_allow "$settings" "Bash(eagle-mem session save:*)"; then
+        [ -n "$V" ] && eagle_ok "Capture permission ${DIM}(eagle-mem session save)${RESET}"
+    fi
+    # Explicit success: the trailing conditional above evaluates false in quiet
+    # mode (V empty), which would otherwise make this function return 1 and abort
+    # a `set -e` caller (update.sh) right after a fully successful registration.
+    return 0
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eagle-mem",
-  "version": "4.13.0",
+  "version": "4.13.1",
   "description": "Shared memory, release guardrails, RTK token protection, and worker lanes for Claude Code, Codex, OpenCode, Grok, and Google Antigravity",
   "bin": {
     "eagle-mem": "bin/eagle-mem"

package/scripts/install.sh

@@ -283,47 +283,9 @@ if [ "$claude_found" = true ]; then
             echo '{}' > "$SETTINGS"
         fi
 
-        eagle_patch_hook "$SETTINGS" "SessionStart" "" \
-            "$EAGLE_MEM_DIR/hooks/session-start.sh" \
-            "SessionStart hook"
-
-        # Clean old registrations before re-registering (handles matcher changes across versions)
-        eagle_clean_hook_entries "$SETTINGS" "Stop" "$EAGLE_MEM_DIR/hooks/stop.sh"
-        eagle_clean_hook_entries "$SETTINGS" "PostToolUse" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
-        eagle_clean_hook_entries "$SETTINGS" "PreToolUse" "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh"
-
-        eagle_patch_hook "$SETTINGS" "Stop" "" \
-            "bash \"$EAGLE_MEM_DIR/hooks/stop.sh\"" \
-            "Stop hook"
-
-        eagle_patch_hook "$SETTINGS" "PostToolUse" "Read|Write|Edit|Bash|TaskUpdate" \
-            "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" \
-            "PostToolUse hook"
-
-        eagle_patch_hook "$SETTINGS" "TaskCreated" "" \
-            "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" \
-            "TaskCreated hook"
-
-        eagle_patch_hook "$SETTINGS" "TaskCompleted" "" \
-            "$EAGLE_MEM_DIR/hooks/post-tool-use.sh" \
-            "TaskCompleted hook"
-
-        eagle_patch_hook "$SETTINGS" "SessionEnd" "" \
-            "$EAGLE_MEM_DIR/hooks/session-end.sh" \
-            "SessionEnd hook"
-
-        eagle_patch_hook "$SETTINGS" "UserPromptSubmit" "" \
-            "$EAGLE_MEM_DIR/hooks/user-prompt-submit.sh" \
-            "UserPromptSubmit hook"
-
-        eagle_patch_hook "$SETTINGS" "PreToolUse" "Bash|Read|Edit|Write" \
-            "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh" \
-            "PreToolUse hook"
-
-        # Allow agent-issued session capture to run without a permission prompt
-        if eagle_patch_permission_allow "$SETTINGS" "Bash(eagle-mem session save:*)"; then
-            eagle_ok "Capture permission ${DIM}(eagle-mem session save)${RESET}"
-        fi
+        # Single source of truth for the Claude hook set (see lib/hooks.sh);
+        # verbose mode prints a line per registration.
+        eagle_register_claude_hooks "$SETTINGS" verbose
     fi
 else
     eagle_info "Claude hooks skipped ${DIM}(Claude Code not detected)${RESET}"

package/scripts/test.sh

@@ -16,13 +16,24 @@ eagle_banner
 eagle_header "Smoke Tests"
 
 errors=0
+skipped=0
 
 run_check() {
     local name="$1"
     local cmd="$2"
     echo -e "  ${BOLD}→${RESET} $name"
-    if eval "$cmd" >/dev/null 2>&1; then
+    local rc=0
+    eval "$cmd" >/dev/null 2>&1 || rc=$?
+    if [ "$rc" -eq 0 ]; then
         eagle_ok "$name"
+    elif [ "$rc" -eq 2 ]; then
+        # Exit code 2 = the check skipped itself because its preconditions are
+        # absent in this environment — e.g. a dev-only contract test running
+        # from a published install, where the maintainer doc it guards is not
+        # shipped in the npm package. A skip is neither a pass nor a failure, so
+        # it must not increment the error count or fail the suite.
+        eagle_info "skipped: $name (preconditions not present here)"
+        skipped=$((skipped + 1))
     else
         eagle_fail "$name"
         # Assignment form (not ((errors++))) so a failing check does not abort
@@ -80,10 +91,17 @@ run_check "Data Integrity Hardening (migrate idempotency, SQL escaping, summary
 run_check "Mod-Tracker Concurrency (lock TTL, no lost append, observation dedup race)" "bash \"$SCRIPTS_DIR/../tests/test_mod_tracker_concurrency.sh\""
 run_check "Reliability Retention (scan in-flight vs freshness, eagle_events prune)" "bash \"$SCRIPTS_DIR/../tests/test_reliability_retention.sh\""
 run_check "Test Runner No-Abort (failing check does not kill the suite under set -e)" "bash \"$SCRIPTS_DIR/../tests/test_test_runner_no_abort.sh\""
+# Python lane: the native Antigravity hook (mocked). Subshell-wrapped so a
+# missing python3 yields a clean skip (exit 2) instead of aborting the suite.
+run_check "Antigravity Hook (native Python SDK lifecycle, mocked)" "( command -v python3 >/dev/null 2>&1 || exit 2; python3 \"$SCRIPTS_DIR/../tests/test_antigravity_hook.py\" )"
 
 echo ""
 if [ "$errors" -eq 0 ]; then
-    eagle_ok "All smoke tests passed"
+    if [ "$skipped" -gt 0 ]; then
+        eagle_ok "All smoke tests passed ($skipped skipped — preconditions not present here)"
+    else
+        eagle_ok "All smoke tests passed"
+    fi
     
     # Auto-verify the 7 core features in the database
     for feat in "compaction-survival" "feature-verification" "grok-cli-integration" "agent-orchestration" "Cross Agent Memory" "Installer And Updater" "Code Scan And Index"; do

package/scripts/update.sh

@@ -86,23 +86,9 @@ fi
 # ─── Re-register hooks (idempotent) ───────────────────────
 
 if [ "$claude_found" = true ] && [ -f "$SETTINGS" ] && command -v jq &>/dev/null; then
-    # Clean old registrations before re-registering (handles matcher changes across versions)
-    eagle_clean_hook_entries "$SETTINGS" "Stop" "$EAGLE_MEM_DIR/hooks/stop.sh"
-    eagle_clean_hook_entries "$SETTINGS" "PostToolUse" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
-    eagle_clean_hook_entries "$SETTINGS" "PreToolUse" "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh"
-
-    eagle_patch_hook "$SETTINGS" "SessionStart" "" "$EAGLE_MEM_DIR/hooks/session-start.sh"
-    eagle_patch_hook "$SETTINGS" "Stop" "" "bash \"$EAGLE_MEM_DIR/hooks/stop.sh\""
-    eagle_patch_hook "$SETTINGS" "PostToolUse" "Read|Write|Edit|Bash|TaskUpdate" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
-    eagle_patch_hook "$SETTINGS" "TaskCreated" "" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
-    eagle_patch_hook "$SETTINGS" "TaskCompleted" "" "$EAGLE_MEM_DIR/hooks/post-tool-use.sh"
-    eagle_patch_hook "$SETTINGS" "SessionEnd" "" "$EAGLE_MEM_DIR/hooks/session-end.sh"
-    eagle_patch_hook "$SETTINGS" "UserPromptSubmit" "" "$EAGLE_MEM_DIR/hooks/user-prompt-submit.sh"
-    eagle_patch_hook "$SETTINGS" "PreToolUse" "Bash|Read|Edit|Write" "$EAGLE_MEM_DIR/hooks/pre-tool-use.sh"
-
-    # Allow agent-issued session capture to run without a permission prompt
-    eagle_patch_permission_allow "$SETTINGS" "Bash(eagle-mem session save:*)"
-
+    # Single source of truth for the Claude hook set (see lib/hooks.sh); quiet
+    # mode — the updater prints one summary line instead of per-hook lines.
+    eagle_register_claude_hooks "$SETTINGS"
     eagle_ok "Hooks registered"
 fi
 

package/tests/test_compaction_survival_matrix.sh

@@ -7,7 +7,12 @@ set -euo pipefail
 ROOT_DIR="$(cd "$(dirname "$0")/.." && pwd)"
 EAGLE_BIN="$ROOT_DIR/bin/eagle-mem"
 
-tmp_dir=$(mktemp -d "$ROOT_DIR/.tmp-compaction-survival.XXXXXX")
+# Use a neutral system temp dir, NOT one inside $ROOT_DIR. From a published
+# install $ROOT_DIR lives under node_modules/, and the code scanner excludes
+# node_modules — so a fixture repo created here would index 0 files and the
+# post-compact "Relevant Code" recall would never appear (the suite is run from
+# the installed package via `eagle-mem test`).
+tmp_dir=$(mktemp -d "${TMPDIR:-/tmp}/eagle-compaction-survival.XXXXXX")
 trap 'rm -rf "$tmp_dir"' EXIT
 
 export HOME="$tmp_dir/home"
@@ -190,6 +195,13 @@ assert_json "$compaction_json" '
     and .metrics.semantic_graph_nodes >= 5
 ' "compaction --json did not report durable survival metrics"
 
+# Index the fixture code deterministically so the post-compact recall can
+# surface "Relevant Code". This previously relied on a background auto-index
+# that only won the race from a warm source checkout, so the assertion failed
+# when the suite ran from a published install via `eagle-mem test`. The
+# `index` command is synchronous, so chunks exist by the time the hook runs.
+( cd "$repo" && "$EAGLE_BIN" index >/dev/null 2>&1 )
+
 eagle_upsert_session "$post_session" "$project" "$repo" "test-model" "test" "codex" >/dev/null
 hook_input=$(jq -nc \
     --arg sid "$post_session" \

package/tests/test_rust_migration_plan.sh

@@ -18,7 +18,14 @@ require_contains() {
     fi
 }
 
-[ -f "$PLAN" ] || fail "missing MIGRATION.md"
+# MIGRATION.md is a maintainer-only roadmap and is intentionally NOT shipped in
+# the npm package (`files` allowlist), so this contract test has nothing to
+# guard when the suite runs from a published install via `eagle-mem test`.
+# Skip cleanly (exit 2) in that case; run strictly from a source checkout.
+if [ ! -f "$PLAN" ]; then
+    echo "skip: MIGRATION.md not present (dev-only contract test)" >&2
+    exit 2
+fi
 
 require_contains "~/.eagle-mem/memory\\.db" "the existing user database path"
 require_contains "compatibility wrapper" "the Bash compatibility wrapper"