duckdb 0.7.2-dev3546.0 → 0.7.2-dev3666.0

package/src/duckdb/src/include/duckdb/planner/operator_extension.hpp

@@ -16,7 +16,7 @@ namespace duckdb {
 
 //! The OperatorExtensionInfo holds static information relevant to the operator extension
 struct OperatorExtensionInfo {
-	DUCKDB_API virtual ~OperatorExtensionInfo() {
+	virtual ~OperatorExtensionInfo() {
 	}
 };
 
@@ -37,7 +37,7 @@ public:
 	virtual unique_ptr<LogicalExtensionOperator> Deserialize(LogicalDeserializationState &state,
 	                                                         FieldReader &reader) = 0;
 
-	DUCKDB_API virtual ~OperatorExtension() {
+	virtual ~OperatorExtension() {
 	}
 };
 

package/src/duckdb/src/include/duckdb/storage/storage_extension.hpp

@@ -20,7 +20,7 @@ class TransactionManager;
 
 //! The StorageExtensionInfo holds static information relevant to the storage extension
 struct StorageExtensionInfo {
-	DUCKDB_API virtual ~StorageExtensionInfo() {
+	virtual ~StorageExtensionInfo() {
 	}
 };
 
@@ -43,7 +43,7 @@ public:
 	//! Additional info passed to the various storage functions
 	shared_ptr<StorageExtensionInfo> storage_info;
 
-	DUCKDB_API virtual ~StorageExtension() {
+	virtual ~StorageExtension() {
 	}
 };
 

package/src/duckdb/src/planner/binder/statement/bind_copy.cpp

@@ -129,10 +129,15 @@ BoundStatement Binder::BindCopyTo(CopyStatement &stmt) {
 	if (per_thread_output && !partition_cols.empty()) {
 		throw NotImplementedException("Can't combine PER_THREAD_OUTPUT and PARTITION_BY for COPY");
 	}
-	bool is_file_and_exists = config.file_system->FileExists(stmt.info->file_path);
-	bool is_stdout = stmt.info->file_path == "/dev/stdout";
-	if (!user_set_use_tmp_file) {
-		use_tmp_file = is_file_and_exists && !per_thread_output && partition_cols.empty() && !is_stdout;
+	bool is_remote_file = config.file_system->IsRemoteFile(stmt.info->file_path);
+	if (is_remote_file) {
+		use_tmp_file = false;
+	} else {
+		bool is_file_and_exists = config.file_system->FileExists(stmt.info->file_path);
+		bool is_stdout = stmt.info->file_path == "/dev/stdout";
+		if (!user_set_use_tmp_file) {
+			use_tmp_file = is_file_and_exists && !per_thread_output && partition_cols.empty() && !is_stdout;
+		}
 	}
 
 	auto unique_column_names = GetUniqueNames(select_node.names);

package/src/duckdb/src/planner/binder/tableref/bind_basetableref.cpp

@@ -94,7 +94,7 @@ unique_ptr<BoundTableRef> Binder::Bind(BaseTableRef &ref) {
 			for (auto &scan : config.replacement_scans) {
 				auto replacement_function = scan.function(context, table_name, scan.data.get());
 				if (replacement_function) {
-					replacement_function->alias = ref.alias.empty() ? ref.table_name : ref.alias;
+					replacement_function->alias = ref.alias.empty() ? replacement_function->alias : ref.alias;
 					if (replacement_function->type == TableReferenceType::TABLE_FUNCTION) {
 						auto &table_function = replacement_function->Cast<TableFunctionRef>();
 						table_function.column_name_alias = ref.column_name_alias;

package/src/duckdb/src/storage/single_file_block_manager.cpp

@@ -241,10 +241,6 @@ void SingleFileBlockManager::Initialize(DatabaseHeader &header) {
 }
 
 void SingleFileBlockManager::LoadFreeList() {
-	if (options.read_only) {
-		// no need to load free list for read only db
-		return;
-	}
 	if (free_list_id == INVALID_BLOCK) {
 		// no free list
 		return;