duckdb 0.7.2-dev1901.0 → 0.7.2-dev2233.0

package/src/duckdb/src/execution/operator/join/physical_hash_join.cpp

@@ -1,8 +1,5 @@
 #include "duckdb/execution/operator/join/physical_hash_join.hpp"
 
-#include "duckdb/planner/expression/bound_aggregate_expression.hpp"
-#include "duckdb/planner/expression/bound_reference_expression.hpp"
-#include "duckdb/common/types/column_data_collection.hpp"
 #include "duckdb/common/vector_operations/vector_operations.hpp"
 #include "duckdb/execution/expression_executor.hpp"
 #include "duckdb/function/aggregate/distributive_functions.hpp"
@@ -12,6 +9,8 @@
 #include "duckdb/parallel/base_pipeline_event.hpp"
 #include "duckdb/parallel/pipeline.hpp"
 #include "duckdb/parallel/thread_context.hpp"
+#include "duckdb/planner/expression/bound_aggregate_expression.hpp"
+#include "duckdb/planner/expression/bound_reference_expression.hpp"
 #include "duckdb/storage/buffer_manager.hpp"
 #include "duckdb/storage/storage_manager.hpp"
 
@@ -52,20 +51,14 @@ PhysicalHashJoin::PhysicalHashJoin(LogicalOperator &op, unique_ptr<PhysicalOpera
 //===--------------------------------------------------------------------===//
 class HashJoinGlobalSinkState : public GlobalSinkState {
 public:
-	HashJoinGlobalSinkState(const PhysicalHashJoin &op, ClientContext &context)
-	    : finalized(false), scanned_data(false) {
+	HashJoinGlobalSinkState(const PhysicalHashJoin &op, ClientContext &context_p)
+	    : context(context_p), finalized(false), scanned_data(false) {
 		hash_table = op.InitializeHashTable(context);
 
 		// for perfect hash join
 		perfect_join_executor = make_uniq<PerfectHashJoinExecutor>(op, *hash_table, op.perfect_join_statistics);
 		// for external hash join
-		external = op.can_go_external && ClientConfig::GetConfig(context).force_external;
-		// memory usage per thread scales with max mem / num threads
-		double max_memory = BufferManager::GetBufferManager(context).GetMaxMemory();
-		double num_threads = TaskScheduler::GetScheduler(context).NumberOfThreads();
-		// HT may not exceed 60% of memory
-		max_ht_size = max_memory * 0.6;
-		sink_memory_per_thread = max_ht_size / num_threads;
+		external = ClientConfig::GetConfig(context).force_external;
 		// Set probe types
 		const auto &payload_types = op.children[0]->types;
 		probe_types.insert(probe_types.end(), op.condition_types.begin(), op.condition_types.end());
@@ -74,9 +67,10 @@ public:
 	}
 
 	void ScheduleFinalize(Pipeline &pipeline, Event &event);
-	void InitializeProbeSpill(ClientContext &context);
+	void InitializeProbeSpill();
 
 public:
+	ClientContext &context;
 	//! Global HT used by the join
 	unique_ptr<JoinHashTable> hash_table;
 	//! The perfect hash join executor (if any)
@@ -86,9 +80,6 @@ public:
 
 	//! Whether we are doing an external join
 	bool external;
-	//! Memory usage per thread during the Sink and Execute phases
-	idx_t max_ht_size;
-	idx_t sink_memory_per_thread;
 
 	//! Hash tables built by each thread
 	mutex lock;
@@ -115,9 +106,13 @@ public:
 		join_keys.Initialize(allocator, op.condition_types);
 
 		hash_table = op.InitializeHashTable(context);
+
+		hash_table->GetSinkCollection().InitializeAppendState(append_state);
 	}
 
 public:
+	PartitionedTupleDataAppendState append_state;
+
 	DataChunk build_chunk;
 	DataChunk join_keys;
 	ExpressionExecutor build_executor;
@@ -129,6 +124,7 @@ public:
 unique_ptr<JoinHashTable> PhysicalHashJoin::InitializeHashTable(ClientContext &context) const {
 	auto result =
 	    make_uniq<JoinHashTable>(BufferManager::GetBufferManager(context), conditions, build_types, join_type);
+	result->max_ht_size = double(BufferManager::GetBufferManager(context).GetMaxMemory()) * 0.6;
 	if (!delim_types.empty() && join_type == JoinType::MARK) {
 		// correlated MARK join
 		if (delim_types.size() + 1 == conditions.size()) {
@@ -187,12 +183,12 @@ unique_ptr<LocalSinkState> PhysicalHashJoin::GetLocalSinkState(ExecutionContext
 
 SinkResultType PhysicalHashJoin::Sink(ExecutionContext &context, GlobalSinkState &gstate_p, LocalSinkState &lstate_p,
                                       DataChunk &input) const {
-	auto &gstate = gstate_p.Cast<HashJoinGlobalSinkState>();
 	auto &lstate = lstate_p.Cast<HashJoinLocalSinkState>();
 
 	// resolve the join keys for the right chunk
 	lstate.join_keys.Reset();
 	lstate.build_executor.Execute(input, lstate.join_keys);
+
 	// build the HT
 	auto &ht = *lstate.hash_table;
 	if (!right_projection_map.empty()) {
@@ -202,21 +198,14 @@ SinkResultType PhysicalHashJoin::Sink(ExecutionContext &context, GlobalSinkState
 		for (idx_t i = 0; i < right_projection_map.size(); i++) {
 			lstate.build_chunk.data[i].Reference(input.data[right_projection_map[i]]);
 		}
-		ht.Build(lstate.join_keys, lstate.build_chunk);
+		ht.Build(lstate.append_state, lstate.join_keys, lstate.build_chunk);
 	} else if (!build_types.empty()) {
 		// there is not a projected map: place the entire right chunk in the HT
-		ht.Build(lstate.join_keys, input);
+		ht.Build(lstate.append_state, lstate.join_keys, input);
 	} else {
 		// there are only keys: place an empty chunk in the payload
 		lstate.build_chunk.SetCardinality(input.size());
-		ht.Build(lstate.join_keys, lstate.build_chunk);
-	}
-
-	// swizzle if we reach memory limit
-	auto approx_ptr_table_size = ht.Count() * 3 * sizeof(data_ptr_t);
-	if (can_go_external && ht.SizeInBytes() + approx_ptr_table_size >= gstate.sink_memory_per_thread) {
-		lstate.hash_table->SwizzleBlocks();
-		gstate.external = true;
+		ht.Build(lstate.append_state, lstate.join_keys, lstate.build_chunk);
 	}
 
 	return SinkResultType::NEED_MORE_INPUT;
@@ -226,6 +215,7 @@ void PhysicalHashJoin::Combine(ExecutionContext &context, GlobalSinkState &gstat
 	auto &gstate = gstate_p.Cast<HashJoinGlobalSinkState>();
 	auto &lstate = lstate_p.Cast<HashJoinLocalSinkState>();
 	if (lstate.hash_table) {
+		lstate.hash_table->GetSinkCollection().FlushAppendState(lstate.append_state);
 		lock_guard<mutex> local_ht_lock(gstate.lock);
 		gstate.local_hash_tables.push_back(std::move(lstate.hash_table));
 	}
@@ -239,14 +229,14 @@ void PhysicalHashJoin::Combine(ExecutionContext &context, GlobalSinkState &gstat
 //===--------------------------------------------------------------------===//
 class HashJoinFinalizeTask : public ExecutorTask {
 public:
-	HashJoinFinalizeTask(shared_ptr<Event> event_p, ClientContext &context, HashJoinGlobalSinkState &sink,
-	                     idx_t block_idx_start, idx_t block_idx_end, bool parallel)
-	    : ExecutorTask(context), event(std::move(event_p)), sink(sink), block_idx_start(block_idx_start),
-	      block_idx_end(block_idx_end), parallel(parallel) {
+	HashJoinFinalizeTask(shared_ptr<Event> event_p, ClientContext &context, HashJoinGlobalSinkState &sink_p,
+	                     idx_t chunk_idx_from_p, idx_t chunk_idx_to_p, bool parallel_p)
+	    : ExecutorTask(context), event(std::move(event_p)), sink(sink_p), chunk_idx_from(chunk_idx_from_p),
+	      chunk_idx_to(chunk_idx_to_p), parallel(parallel_p) {
 	}
 
 	TaskExecutionResult ExecuteTask(TaskExecutionMode mode) override {
-		sink.hash_table->Finalize(block_idx_start, block_idx_end, parallel);
+		sink.hash_table->Finalize(chunk_idx_from, chunk_idx_to, parallel);
 		event->FinishTask();
 		return TaskExecutionResult::TASK_FINISHED;
 	}
@@ -254,8 +244,8 @@ public:
 private:
 	shared_ptr<Event> event;
 	HashJoinGlobalSinkState &sink;
-	idx_t block_idx_start;
-	idx_t block_idx_end;
+	idx_t chunk_idx_from;
+	idx_t chunk_idx_to;
 	bool parallel;
 };
 
@@ -273,26 +263,24 @@ public:
 
 		vector<unique_ptr<Task>> finalize_tasks;
 		auto &ht = *sink.hash_table;
-		const auto &block_collection = ht.GetBlockCollection();
-		const auto &blocks = block_collection.blocks;
-		const auto num_blocks = blocks.size();
-		if (block_collection.count < PARALLEL_CONSTRUCT_THRESHOLD && !context.config.verify_parallelism) {
+		const auto chunk_count = ht.GetDataCollection().ChunkCount();
+		const idx_t num_threads = TaskScheduler::GetScheduler(context).NumberOfThreads();
+		if (num_threads == 1 || (ht.Count() < PARALLEL_CONSTRUCT_THRESHOLD && !context.config.verify_parallelism)) {
 			// Single-threaded finalize
 			finalize_tasks.push_back(
-			    make_uniq<HashJoinFinalizeTask>(shared_from_this(), context, sink, 0, num_blocks, false));
+			    make_uniq<HashJoinFinalizeTask>(shared_from_this(), context, sink, 0, chunk_count, false));
 		} else {
 			// Parallel finalize
-			idx_t num_threads = TaskScheduler::GetScheduler(context).NumberOfThreads();
-			auto blocks_per_thread = MaxValue<idx_t>((num_blocks + num_threads - 1) / num_threads, 1);
+			auto chunks_per_thread = MaxValue<idx_t>((chunk_count + num_threads - 1) / num_threads, 1);
 
-			idx_t block_idx = 0;
+			idx_t chunk_idx = 0;
 			for (idx_t thread_idx = 0; thread_idx < num_threads; thread_idx++) {
-				auto block_idx_start = block_idx;
-				auto block_idx_end = MinValue<idx_t>(block_idx_start + blocks_per_thread, num_blocks);
+				auto chunk_idx_from = chunk_idx;
+				auto chunk_idx_to = MinValue<idx_t>(chunk_idx_from + chunks_per_thread, chunk_count);
 				finalize_tasks.push_back(make_uniq<HashJoinFinalizeTask>(shared_from_this(), context, sink,
-				                                                         block_idx_start, block_idx_end, true));
-				block_idx = block_idx_end;
-				if (block_idx == num_blocks) {
+				                                                         chunk_idx_from, chunk_idx_to, true));
+				chunk_idx = chunk_idx_to;
+				if (chunk_idx == chunk_count) {
 					break;
 				}
 			}
@@ -301,6 +289,7 @@ public:
 	}
 
 	void FinishEvent() override {
+		sink.hash_table->GetDataCollection().VerifyEverythingPinned();
 		sink.hash_table->finalized = true;
 	}
 
@@ -317,7 +306,7 @@ void HashJoinGlobalSinkState::ScheduleFinalize(Pipeline &pipeline, Event &event)
 	event.InsertEvent(std::move(new_event));
 }
 
-void HashJoinGlobalSinkState::InitializeProbeSpill(ClientContext &context) {
+void HashJoinGlobalSinkState::InitializeProbeSpill() {
 	lock_guard<mutex> guard(lock);
 	if (!probe_spill) {
 		probe_spill = make_uniq<JoinHashTable::ProbeSpill>(*hash_table, context, probe_types);
@@ -376,28 +365,37 @@ public:
 SinkFinalizeType PhysicalHashJoin::Finalize(Pipeline &pipeline, Event &event, ClientContext &context,
                                             GlobalSinkState &gstate) const {
 	auto &sink = gstate.Cast<HashJoinGlobalSinkState>();
+	auto &ht = *sink.hash_table;
 
+	sink.external = ht.RequiresExternalJoin(context.config, sink.local_hash_tables);
 	if (sink.external) {
-		D_ASSERT(can_go_external);
-		// External join - partition HT
 		sink.perfect_join_executor.reset();
-		sink.hash_table->ComputePartitionSizes(context.config, sink.local_hash_tables, sink.max_ht_size);
-		auto new_event = make_shared<HashJoinPartitionEvent>(pipeline, sink, sink.local_hash_tables);
-		event.InsertEvent(std::move(new_event));
+		if (ht.RequiresPartitioning(context.config, sink.local_hash_tables)) {
+			auto new_event = make_shared<HashJoinPartitionEvent>(pipeline, sink, sink.local_hash_tables);
+			event.InsertEvent(std::move(new_event));
+		} else {
+			for (auto &local_ht : sink.local_hash_tables) {
+				ht.Merge(*local_ht);
+			}
+			sink.local_hash_tables.clear();
+			sink.hash_table->PrepareExternalFinalize();
+			sink.ScheduleFinalize(pipeline, event);
+		}
 		sink.finalized = true;
 		return SinkFinalizeType::READY;
 	} else {
 		for (auto &local_ht : sink.local_hash_tables) {
-			sink.hash_table->Merge(*local_ht);
+			ht.Merge(*local_ht);
 		}
 		sink.local_hash_tables.clear();
+		ht.Unpartition();
 	}
 
 	// check for possible perfect hash table
 	auto use_perfect_hash = sink.perfect_join_executor->CanDoPerfectHashJoin();
 	if (use_perfect_hash) {
-		D_ASSERT(sink.hash_table->equality_types.size() == 1);
-		auto key_type = sink.hash_table->equality_types[0];
+		D_ASSERT(ht.equality_types.size() == 1);
+		auto key_type = ht.equality_types[0];
 		use_perfect_hash = sink.perfect_join_executor->BuildPerfectHashTable(key_type);
 	}
 	// In case of a large build side or duplicates, use regular hash join
@@ -406,7 +404,7 @@ SinkFinalizeType PhysicalHashJoin::Finalize(Pipeline &pipeline, Event &event, Cl
 		sink.ScheduleFinalize(pipeline, event);
 	}
 	sink.finalized = true;
-	if (sink.hash_table->Count() == 0 && EmptyResultIfRHSIsEmpty()) {
+	if (ht.Count() == 0 && EmptyResultIfRHSIsEmpty()) {
 		return SinkFinalizeType::NO_OUTPUT_POSSIBLE;
 	}
 	return SinkFinalizeType::READY;
@@ -450,7 +448,7 @@ unique_ptr<OperatorState> PhysicalHashJoin::GetOperatorState(ExecutionContext &c
 	}
 	if (sink.external) {
 		state->spill_chunk.Initialize(allocator, sink.probe_types);
-		sink.InitializeProbeSpill(context.client);
+		sink.InitializeProbeSpill();
 	}
 
 	return std::move(state);
@@ -466,7 +464,7 @@ OperatorResultType PhysicalHashJoin::ExecuteInternal(ExecutionContext &context,
 	// some initialization for external hash join
 	if (sink.external && !state.initialized) {
 		if (!sink.probe_spill) {
-			sink.InitializeProbeSpill(context.client);
+			sink.InitializeProbeSpill();
 		}
 		state.spill_state = sink.probe_spill->RegisterThread();
 		state.initialized = true;
@@ -524,12 +522,13 @@ public:
 	HashJoinGlobalSourceState(const PhysicalHashJoin &op, ClientContext &context);
 
 	//! Initialize this source state using the info in the sink
-	void Initialize(ClientContext &context, HashJoinGlobalSinkState &sink);
+	void Initialize(HashJoinGlobalSinkState &sink);
 	//! Try to prepare the next stage
 	void TryPrepareNextStage(HashJoinGlobalSinkState &sink);
-	//! Prepare the next build/probe stage for external hash join (must hold lock)
+	//! Prepare the next build/probe/scan_ht stage for external hash join (must hold lock)
 	void PrepareBuild(HashJoinGlobalSinkState &sink);
 	void PrepareProbe(HashJoinGlobalSinkState &sink);
+	void PrepareScanHT(HashJoinGlobalSinkState &sink);
 	//! Assigns a task to a local source state
 	bool AssignTask(HashJoinGlobalSinkState &sink, HashJoinLocalSourceState &lstate);
 
@@ -545,21 +544,24 @@ public:
 	mutex lock;
 
 	//! For HT build synchronization
-	idx_t build_block_idx;
-	idx_t build_block_count;
-	idx_t build_block_done;
-	idx_t build_blocks_per_thread;
+	idx_t build_chunk_idx;
+	idx_t build_chunk_count;
+	idx_t build_chunk_done;
+	idx_t build_chunks_per_thread;
 
 	//! For probe synchronization
 	idx_t probe_chunk_count;
 	idx_t probe_chunk_done;
 
-	//! For full/outer synchronization
-	JoinHTScanState full_outer_scan;
-
 	//! To determine the number of threads
 	idx_t probe_count;
 	idx_t parallel_scan_chunk_count;
+
+	//! For full/outer synchronization
+	idx_t full_outer_chunk_idx;
+	idx_t full_outer_chunk_count;
+	idx_t full_outer_chunk_done;
+	idx_t full_outer_chunks_per_thread;
 };
 
 class HashJoinLocalSourceState : public LocalSourceState {
@@ -575,18 +577,15 @@ public:
 	void ExternalProbe(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate, DataChunk &chunk);
 	void ExternalScanHT(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate, DataChunk &chunk);
 
-	//! Scans the HT for full/outer join
-	void ScanFullOuter(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate);
-
 public:
 	//! The stage that this thread was assigned work for
 	HashJoinSourceStage local_stage;
 	//! Vector with pointers here so we don't have to re-initialize
 	Vector addresses;
 
-	//! Blocks assigned to this thread for building the pointer table
-	idx_t build_block_idx_start;
-	idx_t build_block_idx_end;
+	//! Chunks assigned to this thread for building the pointer table
+	idx_t build_chunk_idx_from;
+	idx_t build_chunk_idx_to;
 
 	//! Local scan state for probe spill
 	ColumnDataConsumerScanState probe_local_scan;
@@ -599,10 +598,12 @@ public:
 	vector<idx_t> payload_indices;
 	//! Scan structure for the external probe
 	unique_ptr<JoinHashTable::ScanStructure> scan_structure;
+	bool empty_ht_probe_in_progress;
 
-	//! Current number of tuples from a full/outer scan that are 'in-flight'
-	idx_t full_outer_found_entries;
-	idx_t full_outer_in_progress;
+	//! Chunks assigned to this thread for a full/outer scan
+	idx_t full_outer_chunk_idx_from;
+	idx_t full_outer_chunk_idx_to;
+	unique_ptr<JoinHTScanState> full_outer_scan_state;
 };
 
 unique_ptr<GlobalSourceState> PhysicalHashJoin::GetGlobalSourceState(ClientContext &context) const {
@@ -615,36 +616,32 @@ unique_ptr<LocalSourceState> PhysicalHashJoin::GetLocalSourceState(ExecutionCont
 }
 
 HashJoinGlobalSourceState::HashJoinGlobalSourceState(const PhysicalHashJoin &op, ClientContext &context)
-    : op(op), global_stage(HashJoinSourceStage::INIT), probe_chunk_count(0), probe_chunk_done(0),
-      probe_count(op.children[0]->estimated_cardinality),
+    : op(op), global_stage(HashJoinSourceStage::INIT), build_chunk_count(0), build_chunk_done(0), probe_chunk_count(0),
+      probe_chunk_done(0), probe_count(op.children[0]->estimated_cardinality),
       parallel_scan_chunk_count(context.config.verify_parallelism ? 1 : 120) {
 }
 
-void HashJoinGlobalSourceState::Initialize(ClientContext &context, HashJoinGlobalSinkState &sink) {
+void HashJoinGlobalSourceState::Initialize(HashJoinGlobalSinkState &sink) {
 	lock_guard<mutex> init_lock(lock);
 	if (global_stage != HashJoinSourceStage::INIT) {
 		// Another thread initialized
 		return;
 	}
-	full_outer_scan.total = sink.hash_table->Count();
-
-	idx_t num_blocks = sink.hash_table->GetBlockCollection().blocks.size();
-	idx_t num_threads = TaskScheduler::GetScheduler(context).NumberOfThreads();
-	build_blocks_per_thread = MaxValue<idx_t>((num_blocks + num_threads - 1) / num_threads, 1);
 
-	// Finalize the probe spill too
+	// Finalize the probe spill
 	if (sink.probe_spill) {
 		sink.probe_spill->Finalize();
 	}
 
 	global_stage = HashJoinSourceStage::PROBE;
+	TryPrepareNextStage(sink);
 }
 
 void HashJoinGlobalSourceState::TryPrepareNextStage(HashJoinGlobalSinkState &sink) {
-	lock_guard<mutex> guard(lock);
 	switch (global_stage.load()) {
 	case HashJoinSourceStage::BUILD:
-		if (build_block_done == build_block_count) {
+		if (build_chunk_done == build_chunk_count) {
+			sink.hash_table->GetDataCollection().VerifyEverythingPinned();
 			sink.hash_table->finalized = true;
 			PrepareProbe(sink);
 		}
@@ -652,14 +649,14 @@ void HashJoinGlobalSourceState::TryPrepareNextStage(HashJoinGlobalSinkState &sin
 	case HashJoinSourceStage::PROBE:
 		if (probe_chunk_done == probe_chunk_count) {
 			if (IsRightOuterJoin(op.join_type)) {
-				global_stage = HashJoinSourceStage::SCAN_HT;
+				PrepareScanHT(sink);
 			} else {
 				PrepareBuild(sink);
 			}
 		}
 		break;
 	case HashJoinSourceStage::SCAN_HT:
-		if (full_outer_scan.scanned == full_outer_scan.total) {
+		if (full_outer_chunk_done == full_outer_chunk_count) {
 			PrepareBuild(sink);
 		}
 		break;
@@ -673,15 +670,24 @@ void HashJoinGlobalSourceState::PrepareBuild(HashJoinGlobalSinkState &sink) {
 	auto &ht = *sink.hash_table;
 
 	// Try to put the next partitions in the block collection of the HT
-	if (!ht.PrepareExternalFinalize()) {
+	if (!sink.external || !ht.PrepareExternalFinalize()) {
 		global_stage = HashJoinSourceStage::DONE;
 		return;
 	}
 
-	auto &block_collection = ht.GetBlockCollection();
-	build_block_idx = 0;
-	build_block_count = block_collection.blocks.size();
-	build_block_done = 0;
+	auto &data_collection = ht.GetDataCollection();
+	if (data_collection.Count() == 0 && op.EmptyResultIfRHSIsEmpty()) {
+		PrepareBuild(sink);
+		return;
+	}
+
+	build_chunk_idx = 0;
+	build_chunk_count = data_collection.ChunkCount();
+	build_chunk_done = 0;
+
+	auto num_threads = TaskScheduler::GetScheduler(sink.context).NumberOfThreads();
+	build_chunks_per_thread = MaxValue<idx_t>((build_chunk_count + num_threads - 1) / num_threads, 1);
+
 	ht.InitializePointerTable();
 
 	global_stage = HashJoinSourceStage::BUILD;
@@ -689,16 +695,31 @@ void HashJoinGlobalSourceState::PrepareBuild(HashJoinGlobalSinkState &sink) {
 
 void HashJoinGlobalSourceState::PrepareProbe(HashJoinGlobalSinkState &sink) {
 	sink.probe_spill->PrepareNextProbe();
+	const auto &consumer = *sink.probe_spill->consumer;
 
-	probe_chunk_count = sink.probe_spill->consumer->ChunkCount();
+	probe_chunk_count = consumer.Count() == 0 ? 0 : consumer.ChunkCount();
 	probe_chunk_done = 0;
 
-	if (IsRightOuterJoin(op.join_type)) {
-		full_outer_scan.Reset();
-		full_outer_scan.total = sink.hash_table->Count();
+	global_stage = HashJoinSourceStage::PROBE;
+	if (probe_chunk_count == 0) {
+		TryPrepareNextStage(sink);
+		return;
 	}
+}
 
-	global_stage = HashJoinSourceStage::PROBE;
+void HashJoinGlobalSourceState::PrepareScanHT(HashJoinGlobalSinkState &sink) {
+	D_ASSERT(global_stage != HashJoinSourceStage::SCAN_HT);
+	auto &ht = *sink.hash_table;
+
+	auto &data_collection = ht.GetDataCollection();
+	full_outer_chunk_idx = 0;
+	full_outer_chunk_count = data_collection.ChunkCount();
+	full_outer_chunk_done = 0;
+
+	auto num_threads = TaskScheduler::GetScheduler(sink.context).NumberOfThreads();
+	full_outer_chunks_per_thread = MaxValue<idx_t>((full_outer_chunk_count + num_threads - 1) / num_threads, 1);
+
+	global_stage = HashJoinSourceStage::SCAN_HT;
 }
 
 bool HashJoinGlobalSourceState::AssignTask(HashJoinGlobalSinkState &sink, HashJoinLocalSourceState &lstate) {
@@ -707,24 +728,28 @@ bool HashJoinGlobalSourceState::AssignTask(HashJoinGlobalSinkState &sink, HashJo
 	lock_guard<mutex> guard(lock);
 	switch (global_stage.load()) {
 	case HashJoinSourceStage::BUILD:
-		if (build_block_idx != build_block_count) {
+		if (build_chunk_idx != build_chunk_count) {
 			lstate.local_stage = global_stage;
-			lstate.build_block_idx_start = build_block_idx;
-			build_block_idx = MinValue<idx_t>(build_block_count, build_block_idx + build_blocks_per_thread);
-			lstate.build_block_idx_end = build_block_idx;
+			lstate.build_chunk_idx_from = build_chunk_idx;
+			build_chunk_idx = MinValue<idx_t>(build_chunk_count, build_chunk_idx + build_chunks_per_thread);
+			lstate.build_chunk_idx_to = build_chunk_idx;
 			return true;
 		}
 		break;
 	case HashJoinSourceStage::PROBE:
 		if (sink.probe_spill->consumer && sink.probe_spill->consumer->AssignChunk(lstate.probe_local_scan)) {
 			lstate.local_stage = global_stage;
+			lstate.empty_ht_probe_in_progress = false;
 			return true;
 		}
 		break;
 	case HashJoinSourceStage::SCAN_HT:
-		if (full_outer_scan.scan_index != full_outer_scan.total) {
+		if (full_outer_chunk_idx != full_outer_chunk_count) {
 			lstate.local_stage = global_stage;
-			lstate.ScanFullOuter(sink, *this);
+			lstate.full_outer_chunk_idx_from = full_outer_chunk_idx;
+			full_outer_chunk_idx =
+			    MinValue<idx_t>(full_outer_chunk_count, full_outer_chunk_idx + full_outer_chunks_per_thread);
+			lstate.full_outer_chunk_idx_to = full_outer_chunk_idx;
 			return true;
 		}
 		break;
@@ -779,9 +804,9 @@ bool HashJoinLocalSourceState::TaskFinished() {
 	case HashJoinSourceStage::BUILD:
 		return true;
 	case HashJoinSourceStage::PROBE:
-		return scan_structure == nullptr;
+		return scan_structure == nullptr && !empty_ht_probe_in_progress;
 	case HashJoinSourceStage::SCAN_HT:
-		return full_outer_in_progress == 0;
+		return full_outer_scan_state == nullptr;
 	default:
 		throw InternalException("Unexpected HashJoinSourceStage in TaskFinished!");
 	}
@@ -791,10 +816,10 @@ void HashJoinLocalSourceState::ExternalBuild(HashJoinGlobalSinkState &sink, Hash
 	D_ASSERT(local_stage == HashJoinSourceStage::BUILD);
 
 	auto &ht = *sink.hash_table;
-	ht.Finalize(build_block_idx_start, build_block_idx_end, true);
+	ht.Finalize(build_chunk_idx_from, build_chunk_idx_to, true);
 
 	lock_guard<mutex> guard(gstate.lock);
-	gstate.build_block_done += build_block_idx_end - build_block_idx_start;
+	gstate.build_chunk_done += build_chunk_idx_to - build_chunk_idx_from;
 }
 
 void HashJoinLocalSourceState::ExternalProbe(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate,
@@ -802,14 +827,20 @@ void HashJoinLocalSourceState::ExternalProbe(HashJoinGlobalSinkState &sink, Hash
 	D_ASSERT(local_stage == HashJoinSourceStage::PROBE && sink.hash_table->finalized);
 
 	if (scan_structure) {
-		// still have elements remaining (i.e. we got >STANDARD_VECTOR_SIZE elements in the previous probe)
+		// Still have elements remaining (i.e. we got >STANDARD_VECTOR_SIZE elements in the previous probe)
 		scan_structure->Next(join_keys, payload, chunk);
-		if (chunk.size() == 0) {
-			scan_structure = nullptr;
-			sink.probe_spill->consumer->FinishChunk(probe_local_scan);
-			lock_guard<mutex> lock(gstate.lock);
-			gstate.probe_chunk_done++;
+		if (chunk.size() != 0) {
+			return;
 		}
+	}
+
+	if (scan_structure || empty_ht_probe_in_progress) {
+		// Previous probe is done
+		scan_structure = nullptr;
+		empty_ht_probe_in_progress = false;
+		sink.probe_spill->consumer->FinishChunk(probe_local_scan);
+		lock_guard<mutex> lock(gstate.lock);
+		gstate.probe_chunk_done++;
 		return;
 	}
 
@@ -821,6 +852,12 @@ void HashJoinLocalSourceState::ExternalProbe(HashJoinGlobalSinkState &sink, Hash
 	payload.ReferenceColumns(probe_chunk, payload_indices);
 	auto precomputed_hashes = &probe_chunk.data.back();
 
+	if (sink.hash_table->Count() == 0 && !gstate.op.EmptyResultIfRHSIsEmpty()) {
+		gstate.op.ConstructEmptyJoinResult(sink.hash_table->join_type, sink.hash_table->has_null, payload, chunk);
+		empty_ht_probe_in_progress = true;
+		return;
+	}
+
 	// Perform the probe
 	scan_structure = sink.hash_table->Probe(join_keys, precomputed_hashes);
 	scan_structure->Next(join_keys, payload, chunk);
@@ -828,27 +865,19 @@ void HashJoinLocalSourceState::ExternalProbe(HashJoinGlobalSinkState &sink, Hash
 
 void HashJoinLocalSourceState::ExternalScanHT(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate,
                                               DataChunk &chunk) {
-	D_ASSERT(local_stage == HashJoinSourceStage::SCAN_HT && full_outer_in_progress != 0);
+	D_ASSERT(local_stage == HashJoinSourceStage::SCAN_HT);
 
-	if (full_outer_found_entries != 0) {
-		// Just did a scan, now gather
-		sink.hash_table->GatherFullOuter(chunk, addresses, full_outer_found_entries);
-		full_outer_found_entries = 0;
-		return;
+	if (!full_outer_scan_state) {
+		full_outer_scan_state = make_uniq<JoinHTScanState>(sink.hash_table->GetDataCollection(),
+		                                                   full_outer_chunk_idx_from, full_outer_chunk_idx_to);
 	}
+	sink.hash_table->ScanFullOuter(*full_outer_scan_state, addresses, chunk);
 
-	lock_guard<mutex> guard(gstate.lock);
-	auto &fo_ss = gstate.full_outer_scan;
-	fo_ss.scanned += full_outer_in_progress;
-	full_outer_in_progress = 0;
-}
-
-void HashJoinLocalSourceState::ScanFullOuter(HashJoinGlobalSinkState &sink, HashJoinGlobalSourceState &gstate) {
-	auto &fo_ss = gstate.full_outer_scan;
-	idx_t scan_index_before = fo_ss.scan_index;
-	full_outer_found_entries = sink.hash_table->ScanFullOuter(fo_ss, addresses);
-	idx_t scanned = fo_ss.scan_index - scan_index_before;
-	full_outer_in_progress = scanned;
+	if (chunk.size() == 0) {
+		full_outer_scan_state = nullptr;
+		lock_guard<mutex> guard(gstate.lock);
+		gstate.full_outer_chunk_done += full_outer_chunk_idx_to - full_outer_chunk_idx_from;
+	}
 }
 
 void PhysicalHashJoin::GetData(ExecutionContext &context, DataChunk &chunk, GlobalSourceState &gstate_p,
@@ -858,20 +887,12 @@ void PhysicalHashJoin::GetData(ExecutionContext &context, DataChunk &chunk, Glob
 	auto &lstate = lstate_p.Cast<HashJoinLocalSourceState>();
 	sink.scanned_data = true;
 
-	if (!sink.external) {
-		if (IsRightOuterJoin(join_type)) {
-			{
-				lock_guard<mutex> guard(gstate.lock);
-				lstate.ScanFullOuter(sink, gstate);
-			}
-			sink.hash_table->GatherFullOuter(chunk, lstate.addresses, lstate.full_outer_found_entries);
-		}
+	if (!sink.external && !IsRightOuterJoin(join_type)) {
 		return;
 	}
 
-	D_ASSERT(can_go_external);
 	if (gstate.global_stage == HashJoinSourceStage::INIT) {
-		gstate.Initialize(context.client, sink);
+		gstate.Initialize(sink);
 	}
 
 	// Any call to GetData must produce tuples, otherwise the pipeline executor thinks that we're done
@@ -880,6 +901,7 @@ void PhysicalHashJoin::GetData(ExecutionContext &context, DataChunk &chunk, Glob
 		if (!lstate.TaskFinished() || gstate.AssignTask(sink, lstate)) {
 			lstate.ExecuteTask(sink, gstate, chunk);
 		} else {
+			lock_guard<mutex> guard(gstate.lock);
 			gstate.TryPrepareNextStage(sink);
 		}
 	}