duckdb 0.6.2-dev1049.0 → 0.6.2-dev1060.0

package/package.json

@@ -2,7 +2,7 @@
   "name": "duckdb",
   "main": "./lib/duckdb.js",
   "types": "./lib/duckdb.d.ts",
-  "version": "0.6.2-dev1049.0",
+  "version": "0.6.2-dev1060.0",
   "description": "DuckDB node.js API",
   "gypfile": true,
   "dependencies": {

package/src/duckdb/src/common/sort/merge_sorter.cpp

@@ -364,18 +364,24 @@ void MergeSorter::MergeRadix(const idx_t &count, const bool left_smaller[]) {
 		const bool l_done = l.block_idx == l_blocks.size();
 		const bool r_done = r.block_idx == r_blocks.size();
 		// Pin the radix sortable blocks
+		idx_t l_count;
 		if (!l_done) {
 			l_block = l_blocks[l.block_idx].get();
 			left->PinRadix(l.block_idx);
 			l_ptr = l.RadixPtr();
+			l_count = l_block->count;
+		} else {
+			l_count = 0;
 		}
+		idx_t r_count;
 		if (!r_done) {
 			r_block = r_blocks[r.block_idx].get();
 			r.PinRadix(r.block_idx);
 			r_ptr = r.RadixPtr();
+			r_count = r_block->count;
+		} else {
+			r_count = 0;
 		}
-		const idx_t &l_count = !l_done ? l_block->count : 0;
-		const idx_t &r_count = !r_done ? r_block->count : 0;
 		// Copy using computed merge
 		if (!l_done && !r_done) {
 			// Both sides have data - merge
@@ -420,7 +426,7 @@ void MergeSorter::MergeData(SortedData &result_data, SortedData &l_data, SortedD
 	auto result_data_handle = buffer_manager.Pin(result_data_block->block);
 	data_ptr_t result_data_ptr = result_data_handle.Ptr() + result_data_block->count * row_width;
 	// Result heap to write to (if needed)
-	RowDataBlock *result_heap_block;
+	RowDataBlock *result_heap_block = nullptr;
 	BufferHandle result_heap_handle;
 	data_ptr_t result_heap_ptr;
 	if (!layout.AllConstant() && state.external) {

package/src/duckdb/src/common/types/hash.cpp

@@ -40,7 +40,7 @@ template <>
 hash_t Hash(float val) {
 	static_assert(sizeof(float) == sizeof(uint32_t), "");
 	FloatingPointEqualityTransform<float>::OP(val);
-	uint32_t uval = *((uint32_t *)&val);
+	uint32_t uval = Load<uint32_t>((const_data_ptr_t)&val);
 	return murmurhash64(uval);
 }
 
@@ -48,7 +48,7 @@ template <>
 hash_t Hash(double val) {
 	static_assert(sizeof(double) == sizeof(uint64_t), "");
 	FloatingPointEqualityTransform<double>::OP(val);
-	uint64_t uval = *((uint64_t *)&val);
+	uint64_t uval = Load<uint64_t>((const_data_ptr_t)&val);
 	return murmurhash64(uval);
 }
 

package/src/duckdb/src/execution/index/art/node.cpp

@@ -298,6 +298,8 @@ Node *Node::Deserialize(ART &art, idx_t block_id, idx_t offset) {
 		deserialized_node = (Node *)Node256::New();
 		break;
 	}
+	default:
+		throw InternalException("Unrecognized node type");
 	}
 	deserialized_node->DeserializeInternal(reader);
 	return deserialized_node;

package/src/duckdb/src/function/aggregate/distributive/approx_count.cpp

@@ -93,8 +93,8 @@ static void ApproxCountDistinctUpdateFunction(Vector inputs[], AggregateInputDat
 	state_vector.ToUnifiedFormat(count, sdata);
 	auto states = (ApproxDistinctCountState **)sdata.data;
 
-	uint64_t *indices;
-	uint8_t *counts;
+	uint64_t *indices = nullptr;
+	uint8_t *counts = nullptr;
 	for (idx_t i = 0; i < count; i++) {
 		auto agg_state = states[sdata.sel->get_index(i)];
 		if (!agg_state->log) {

package/src/duckdb/src/function/scalar/string/string_split.cpp

@@ -74,7 +74,7 @@ struct StringSplitter {
 		auto delim_size = delim.GetSize();
 		idx_t list_idx = 0;
 		while (input_size > 0) {
-			idx_t match_size;
+			idx_t match_size = 0;
 			auto pos = OP::Find(input_data, input_size, delim_data, delim_size, match_size, data);
 			if (pos > input_size) {
 				break;

package/src/duckdb/src/function/table/version/pragma_version.cpp

@@ -1,8 +1,8 @@
 #ifndef DUCKDB_VERSION
-#define DUCKDB_VERSION "0.6.2-dev1049"
+#define DUCKDB_VERSION "0.6.2-dev1060"
 #endif
 #ifndef DUCKDB_SOURCE_ID
-#define DUCKDB_SOURCE_ID "29229a04fc"
+#define DUCKDB_SOURCE_ID "b3f6a8f16d"
 #endif
 #include "duckdb/function/table/system_functions.hpp"
 #include "duckdb/main/database.hpp"

package/src/duckdb/src/include/duckdb/common/types/hugeint.hpp

@@ -26,9 +26,9 @@ public:
 
 	template <class T>
 	static T Cast(hugeint_t input) {
-		T value;
-		TryCast(input, value);
-		return value;
+		T result = 0;
+		TryCast(input, result);
+		return result;
 	}
 
 	template <class T>

package/src/duckdb/src/include/duckdb/storage/compression/chimp/chimp_compress.hpp

@@ -149,7 +149,7 @@ public:
 		current_segment->count++;
 
 		if (is_valid) {
-			T floating_point_value = *(T *)(&value);
+			T floating_point_value = Load<T>((const_data_ptr_t)&value);
 			NumericStatistics::Update<T>(current_segment->stats, floating_point_value);
 		} else {
 			//! FIXME: find a cheaper alternative to storing a NULL

package/src/duckdb/src/include/duckdb/storage/compression/patas/patas_analyze.hpp

@@ -102,7 +102,7 @@ struct EmptyPatasWriter {
 		using EXACT_TYPE = typename FloatingToExact<VALUE_TYPE>::type;
 
 		auto state_wrapper = (PatasAnalyzeState<VALUE_TYPE> *)state_p;
-		state_wrapper->WriteValue(*(EXACT_TYPE *)(&uncompressed_value), is_valid);
+		state_wrapper->WriteValue(Load<EXACT_TYPE>((const_data_ptr_t)&uncompressed_value), is_valid);
 	}
 };
 

package/src/duckdb/src/include/duckdb/storage/compression/patas/patas_compress.hpp

@@ -52,7 +52,7 @@ public:
 				NumericStatistics::Update<VALUE_TYPE>(state_wrapper->current_segment->stats, value);
 			}
 
-			state_wrapper->WriteValue(*(EXACT_TYPE *)(&value));
+			state_wrapper->WriteValue(Load<EXACT_TYPE>((const_data_ptr_t)&value));
 		}
 	};
 

package/src/duckdb/src/optimizer/deliminator.cpp

@@ -325,7 +325,7 @@ bool Deliminator::RemoveInequalityCandidate(unique_ptr<LogicalOperator> *plan, u
 	GetDelimJoins(**plan, delim_joins);
 
 	LogicalOperator *parent = nullptr;
-	idx_t parent_delim_get_side;
+	idx_t parent_delim_get_side = 0;
 	for (auto dj : delim_joins) {
 		D_ASSERT(dj->type == LogicalOperatorType::LOGICAL_DELIM_JOIN);
 		if (!HasChild(dj, &proj_or_agg, parent_delim_get_side)) {

package/src/duckdb/src/optimizer/filter_combiner.cpp

@@ -119,8 +119,10 @@ void FilterCombiner::GenerateFilters(const std::function<void(unique_ptr<Express
 				callback(std::move(comparison));
 			}
 			// for each entry also create a comparison with each constant
-			int lower_index = -1, upper_index = -1;
-			bool lower_inclusive, upper_inclusive;
+			int lower_index = -1;
+			int upper_index = -1;
+			bool lower_inclusive = false;
+			bool upper_inclusive = false;
 			for (idx_t k = 0; k < constant_list.size(); k++) {
 				auto &info = constant_list[k];
 				if (info.comparison_type == ExpressionType::COMPARE_GREATERTHAN ||

package/src/duckdb/src/storage/buffer_manager.cpp

@@ -720,9 +720,9 @@ private:
 		if (index_manager.RemoveIndex(index)) {
 			// the max_index that is currently in use has decreased
 			// as a result we can truncate the file
+#ifndef WIN32 // this ended up causing issues when sorting
 			auto max_index = index_manager.GetMaxIndex();
 			auto &fs = FileSystem::GetFileSystem(db);
-#ifndef WIN32 // this ended up causing issues when sorting
 			fs.Truncate(*handle, GetPositionInFile(max_index + 1));
 #endif
 		}

package/src/duckdb/third_party/libpg_query/src_backend_parser_scan.cpp

@@ -482,7 +482,7 @@ struct yy_buffer_state
 	/* Size of input buffer in bytes, not including room for EOB
 	 * characters.
 	 */
-	int yy_buf_size;
+	yy_size_t yy_buf_size;
 
 	/* Number of characters read into yy_ch_buf, not including EOB
 	 * characters.