duckdb 0.3.3-dev811.0 → 0.3.3-dev835.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "duckdb",
   "main": "./lib/duckdb.js",
-  "version": "0.3.3-dev811.0",
+  "version": "0.3.3-dev835.0",
   "description": "DuckDB node.js API",
   "gypfile": true,
   "dependencies": {

package/src/duckdb.cpp

@@ -4216,7 +4216,7 @@ static DefaultMacro internal_macros[] = {
 	{DEFAULT_SCHEMA, "list_prepend", {"e", "l", nullptr}, "list_concat(list_value(e), l)"},
 	{DEFAULT_SCHEMA, "array_prepend", {"el", "arr", nullptr}, "list_prepend(el, arr)"},
 	{DEFAULT_SCHEMA, "array_pop_back", {"arr", nullptr}, "arr[:LEN(arr)-1]"},
-	{DEFAULT_SCHEMA, "array_pop_front", {"arr", nullptr}, "arr[1:]"},
+	{DEFAULT_SCHEMA, "array_pop_front", {"arr", nullptr}, "arr[2:]"},
 	{DEFAULT_SCHEMA, "array_push_back", {"arr", "e", nullptr}, "list_concat(arr, list_value(e))"},
 	{DEFAULT_SCHEMA, "array_push_front", {"arr", "e", nullptr}, "list_concat(list_value(e), arr)"},
 	{DEFAULT_SCHEMA, "generate_subscripts", {"arr", "dim", nullptr}, "unnest(generate_series(1, array_length(arr, dim)))"},
@@ -15930,7 +15930,7 @@ bool LocalFileSystem::FileExists(const string &filename) {
 	const wchar_t *wpath = unicode_path.c_str();
 	if (_waccess(wpath, 0) == 0) {
 		struct _stat64i32 status;
-		_wstat(wpath, &status);
+		_wstat64i32(wpath, &status);
 		if (status.st_size > 0) {
 			return true;
 		}
@@ -15942,7 +15942,7 @@ bool LocalFileSystem::IsPipe(const string &filename) {
 	const wchar_t *wpath = unicode_path.c_str();
 	if (_waccess(wpath, 0) == 0) {
 		struct _stat64i32 status;
-		_wstat(wpath, &status);
+		_wstat64i32(wpath, &status);
 		if (status.st_size == 0) {
 			return true;
 		}
@@ -83851,7 +83851,7 @@ static void ExecuteSlice(Vector &result, Vector &s, Vector &b, Vector &e, const
 		auto edata = ConstantVector::GetData<INDEX_TYPE>(e);
 
 		auto sliced = sdata[0];
-		auto begin = bdata[0];
+		auto begin = (bdata[0] > 0) ? bdata[0] - 1 : bdata[0];
 		auto end = edata[0];
 
 		auto svalid = !ConstantVector::IsNull(s);
@@ -83883,6 +83883,8 @@ static void ExecuteSlice(Vector &result, Vector &s, Vector &b, Vector &e, const
 			auto begin = ((INDEX_TYPE *)bdata.data)[bidx];
 			auto end = ((INDEX_TYPE *)edata.data)[eidx];
 
+			begin = (begin > 0) ? begin - 1 : begin;
+
 			auto svalid = sdata.validity.RowIsValid(sidx);
 			auto bvalid = bdata.validity.RowIsValid(bidx);
 			auto evalid = edata.validity.RowIsValid(eidx);
@@ -84535,6 +84537,14 @@ void ListExtractTemplate(idx_t count, VectorData &list_data, VectorData &offsets
 		if (list_data.validity.RowIsValid(list_index) && offsets_data.validity.RowIsValid(offsets_index)) {
 			auto list_entry = ((list_entry_t *)list_data.data)[list_index];
 			auto offsets_entry = ((int64_t *)offsets_data.data)[offsets_index];
+
+			// 1-based indexing
+			if (offsets_entry == 0) {
+				result_mask.SetInvalid(i);
+				continue;
+			}
+			offsets_entry = (offsets_entry > 0) ? offsets_entry - 1 : offsets_entry;
+
 			idx_t child_offset;
 			if (offsets_entry < 0) {
 				if ((idx_t)-offsets_entry > list_entry.length) {
@@ -84649,7 +84659,7 @@ static void ExecuteListExtract(Vector &result, Vector &list, Vector &offsets, co
 static void ExecuteStringExtract(Vector &result, Vector &input_vector, Vector &subscript_vector, const idx_t count) {
 	BinaryExecutor::Execute<string_t, int32_t, string_t>(
 	    input_vector, subscript_vector, result, count, [&](string_t input_string, int32_t subscript) {
-		    return SubstringFun::SubstringScalarFunction(result, input_string, subscript + int32_t(subscript >= 0), 1);
+		    return SubstringFun::SubstringScalarFunction(result, input_string, subscript, 1);
 	    });
 }